diff mbox series

[1/2] ref-manual: Cleanup VOLATILE_LOG_DIR

Message ID 20241011144847.1332607-1-niko.mauno@vaisala.com
State Superseded
Headers show
Series [1/2] ref-manual: Cleanup VOLATILE_LOG_DIR | expand

Commit Message

Niko Mauno Oct. 11, 2024, 2:48 p.m. UTC
This variable was removed in
https://git.yoctoproject.org/poky/commit/?id=2f8806deb7655b37d6f8d12ff54680d6acf7a298
("bitbake.conf: drop VOLATILE_LOG_DIR, use FILESYSTEM_PERMS_TABLES instead")

Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
---
 documentation/ref-manual/features.rst  |  5 -----
 documentation/ref-manual/variables.rst | 10 +---------
 2 files changed, 1 insertion(+), 14 deletions(-)

Comments

Quentin Schulz Oct. 14, 2024, 10:48 a.m. UTC | #1
Hi Niko,

On 10/11/24 4:48 PM, Niko Mauno via lists.yoctoproject.org wrote:
> [You don't often get email from niko.mauno=vaisala.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> This variable was removed in
> https://git.yoctoproject.org/poky/commit/?id=2f8806deb7655b37d6f8d12ff54680d6acf7a298
> ("bitbake.conf: drop VOLATILE_LOG_DIR, use FILESYSTEM_PERMS_TABLES instead")
> 
> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
> ---
>   documentation/ref-manual/features.rst  |  5 -----
>   documentation/ref-manual/variables.rst | 10 +---------
>   2 files changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
> index b2ba731bb2..84ebfa81ae 100644
> --- a/documentation/ref-manual/features.rst
> +++ b/documentation/ref-manual/features.rst
> @@ -325,11 +325,6 @@ The image features available for all images are:
>      the ``/var/log/postinstall.log`` file on first boot of the image on
>      the target system.
> 
> -   .. note::
> -
> -      To make the ``/var/log`` directory on the target persistent, use the
> -      :term:`VOLATILE_LOG_DIR` variable by setting it to "no".
> -

Please keep this and update it to explain how to do this with the new 
variable now.

I believe one should remove files/fs-perms-volatile-log.txt from 
FILESYSTEM_PERMS_TABLES as explained in the commit log of the commit you 
just linked to?

Can you please update the migration manual to specify what the user 
needs to do to keep the same behavior?

Cheers,
Quentin
diff mbox series

Patch

diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
index b2ba731bb2..84ebfa81ae 100644
--- a/documentation/ref-manual/features.rst
+++ b/documentation/ref-manual/features.rst
@@ -325,11 +325,6 @@  The image features available for all images are:
    the ``/var/log/postinstall.log`` file on first boot of the image on
    the target system.
 
-   .. note::
-
-      To make the ``/var/log`` directory on the target persistent, use the
-      :term:`VOLATILE_LOG_DIR` variable by setting it to "no".
-
 -  *ptest-pkgs:* Installs ptest packages for all ptest-enabled recipes.
 
 -  *read-only-rootfs:* Creates an image whose root filesystem is
diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 32c9e7407d..71b3325c8f 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -13,7 +13,7 @@  system and gives an overview of their function and contents.
 :term:`K <KARCH>` :term:`L <LABELS>` :term:`M <MACHINE>`
 :term:`N <NATIVELSBSTRING>` :term:`O <OBJCOPY>` :term:`P`
 :term:`R <RANLIB>` :term:`S` :term:`T`
-:term:`U <UBOOT_CONFIG>` :term:`V <VOLATILE_LOG_DIR>`
+:term:`U <UBOOT_CONFIG>` :term:`V <VIRTUAL-RUNTIME>`
 :term:`W <WARN_QA>` :term:`X <XSERVER>`
 
 .. glossary::
@@ -9983,14 +9983,6 @@  system and gives an overview of their function and contents.
 
          PACKAGE_INSTALL = "${INITRAMFS_SCRIPTS} ${VIRTUAL-RUNTIME_base-utils} base-passwd"
 
-   :term:`VOLATILE_LOG_DIR`
-      Specifies the persistence of the target's ``/var/log`` directory,
-      which is used to house postinstall target log files.
-
-      By default, :term:`VOLATILE_LOG_DIR` is set to "yes", which means the
-      file is not persistent. You can override this setting by setting the
-      variable to "no" to make the log directory persistent.
-
    :term:`VOLATILE_TMP_DIR`
       Specifies the persistence of the target's ``/tmp`` directory.