| Message ID | 20241009104716.711424-1-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] bitbake.conf: don't force musl on mips to use classic sysv hashing | expand |
On Wed, Oct 9, 2024 at 3:47 AM Ross Burton <ross.burton@arm.com> wrote: > > This is no longer needed, qemumips with musl generates the expected > DT_MIPS_XHASH table as it already does with glibc: > > Dynamic Section: > NEEDED libc.so > SONAME libz.so.1 > DT_MIPS_XHASH 0x000001a8 > I am afraid we can not do this. xhash is supported by toolchain that's is correct but it also needs to be supported by dynamic linker and musl does not have this implemented > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/conf/bitbake.conf | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 3f583668f66..8000baba389 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -636,8 +636,6 @@ ASNEEDED ?= "-Wl,--as-needed" > > export LDFLAGS = "${TARGET_LDFLAGS}" > TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED} ${DEBUG_PREFIX_MAP}" > -# mips does not support GNU hash style therefore we override > -LINKER_HASH_STYLE:mipsarch:libc-musl = "sysv" > > # Pass parallel make options to the compile task > EXTRA_OEMAKE:prepend:task-compile = "${PARALLEL_MAKE} " > -- > 2.34.1 >
Khem has pointed out to me that whilst the binaries build successfully, musl doesn’t support MIPS_XHASH so it won’t _actually_ run. Ignore these, sorry for the noise. Ross > On 9 Oct 2024, at 11:47, Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > > This is no longer needed, qemumips with musl generates the expected > DT_MIPS_XHASH table as it already does with glibc: > > Dynamic Section: > NEEDED libc.so > SONAME libz.so.1 > DT_MIPS_XHASH 0x000001a8 > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/conf/bitbake.conf | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 3f583668f66..8000baba389 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -636,8 +636,6 @@ ASNEEDED ?= "-Wl,--as-needed" > > export LDFLAGS = "${TARGET_LDFLAGS}" > TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED} ${DEBUG_PREFIX_MAP}" > -# mips does not support GNU hash style therefore we override > -LINKER_HASH_STYLE:mipsarch:libc-musl = "sysv" > > # Pass parallel make options to the compile task > EXTRA_OEMAKE:prepend:task-compile = "${PARALLEL_MAKE} " > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#205346): https://lists.openembedded.org/g/openembedded-core/message/205346 > Mute This Topic: https://lists.openembedded.org/mt/108906501/6875888 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 3f583668f66..8000baba389 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -636,8 +636,6 @@ ASNEEDED ?= "-Wl,--as-needed" export LDFLAGS = "${TARGET_LDFLAGS}" TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED} ${DEBUG_PREFIX_MAP}" -# mips does not support GNU hash style therefore we override -LINKER_HASH_STYLE:mipsarch:libc-musl = "sysv" # Pass parallel make options to the compile task EXTRA_OEMAKE:prepend:task-compile = "${PARALLEL_MAKE} "
This is no longer needed, qemumips with musl generates the expected DT_MIPS_XHASH table as it already does with glibc: Dynamic Section: NEEDED libc.so SONAME libz.so.1 DT_MIPS_XHASH 0x000001a8 Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/conf/bitbake.conf | 2 -- 1 file changed, 2 deletions(-)