diff mbox series

[12/16] ref-manual: add missing variable PRSERVER_UPSTREAM

Message ID 20241009074120.866786-13-antonin.godard@bootlin.com
State Superseded
Headers show
Series Updates for styhead | expand

Commit Message

Antonin Godard Oct. 9, 2024, 7:41 a.m. UTC
From: Antonin Godard <antonin.godard@bootlin.com>

Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
---
 documentation/ref-manual/variables.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Michael Opdenacker Oct. 9, 2024, 2:28 p.m. UTC | #1
Hi Antonin

Thanks for the update!

On 10/9/24 09:41, Antonin Godard via lists.yoctoproject.org wrote:
> From: Antonin Godard <antonin.godard@bootlin.com>
>
> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
> ---
>   documentation/ref-manual/variables.rst | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 72781d93b..985fec5d6 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -6878,6 +6878,11 @@ system and gives an overview of their function and contents.
>         service <dev-manual/packages:working with a pr service>`. You can
>         set :term:`PRSERV_HOST` to other values to use a remote PR service.
>   
> +   :term:`PRSERVER_UPSTREAM`
> +      This variable can be used to specify an upstream PR server for the local
> +      PR server to connect to, in the form of ``host:port``.
> +
> +      This makes it possible to implement local fixes to an upstream package.


Actually, the right variable should be PRSERV_UPSTREAM (instead of 
PRSERVER_UPSTREAM), as used in the rest of the BitBake code.
I've submitted a patch last week to fix this in bin/bitbake-prserv, but 
it hasn't been merged yet.
https://lore.kernel.org/bitbake-devel/20241002150747.85513-1-michael.opdenacker@rootcommit.com/T/#u

Cheers
Michael.
Antonin Godard Oct. 9, 2024, 2:39 p.m. UTC | #2
Hi Michael,

On 09/10/2024 16:28, Michael Opdenacker wrote:
>> +   :term:`PRSERVER_UPSTREAM`
>> +      This variable can be used to specify an upstream PR server for 
>> the local
>> +      PR server to connect to, in the form of ``host:port``.
>> +
>> +      This makes it possible to implement local fixes to an upstream 
>> package.
> 
> 
> Actually, the right variable should be PRSERV_UPSTREAM (instead of 
> PRSERVER_UPSTREAM), as used in the rest of the BitBake code.
> I've submitted a patch last week to fix this in bin/bitbake-prserv, but 
> it hasn't been merged yet.
> https://lore.kernel.org/bitbake-devel/20241002150747.85513-1- 
> michael.opdenacker@rootcommit.com/T/#u

Thanks! I got tricked by grepping for PRSERVER_UPSTREAM actually.
Will update in v2.

Cheers,
Antonin
diff mbox series

Patch

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 72781d93b..985fec5d6 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -6878,6 +6878,11 @@  system and gives an overview of their function and contents.
       service <dev-manual/packages:working with a pr service>`. You can
       set :term:`PRSERV_HOST` to other values to use a remote PR service.
 
+   :term:`PRSERVER_UPSTREAM`
+      This variable can be used to specify an upstream PR server for the local
+      PR server to connect to, in the form of ``host:port``.
+
+      This makes it possible to implement local fixes to an upstream package.
 
    :term:`PSEUDO_IGNORE_PATHS`
       A comma-separated (without spaces) list of path prefixes that should be ignored