| Message ID | 20240928190942.2291734-1-radian.dc@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | meta-ti-bsp: ti-dm-fw: declare files installed in 'DEPLOYDIR' | expand |
NAK
This does not make any sense. The subject says DEPLOYDIR, then you add
INSTALL_DM_FW_DIR (that is ${nonarch_base_libdir}/firmware/${DM_FW_DIR})
to FILES, which has nothing to do with do_deploy, only do_install.
Moreover, ti-dm-fw.bb includes ti-linux-fw.inc, which already sets FILES
to include everything in ${nonarch_base_libdir}/firmware
On Sat, Sep 28, 2024 at 09:09:42PM +0200, Adrian DC wrote:
> Errors: ... is trying to install files into a shared area
> when those files already exist.
> Tests: Build clean, rebuild, rebuild clean with sstate
> ---
>
> Signed-off-by: Adrian DC <radian.dc@gmail.com>
> ---
> meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
> index 1ad236ce..39e0eb8c 100644
> --- a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
> +++ b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
> @@ -77,6 +77,8 @@ do_deploy() {
> done
> }
>
> +FILES:${PN} += "${INSTALL_DM_FW_DIR}"
> +
> # Set up names for the firmwares
> ALTERNATIVE:${PN}:am62xx = "am62-main-r5f0_0-fw"
> ALTERNATIVE:${PN}:am62pxx = "am62p-main-r5f0_0-fw"
> --
> 2.43.0
diff --git a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb index 1ad236ce..39e0eb8c 100644 --- a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb +++ b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb @@ -77,6 +77,8 @@ do_deploy() { done } +FILES:${PN} += "${INSTALL_DM_FW_DIR}" + # Set up names for the firmwares ALTERNATIVE:${PN}:am62xx = "am62-main-r5f0_0-fw" ALTERNATIVE:${PN}:am62pxx = "am62p-main-r5f0_0-fw"
Errors: ... is trying to install files into a shared area when those files already exist. Tests: Build clean, rebuild, rebuild clean with sstate --- Signed-off-by: Adrian DC <radian.dc@gmail.com> --- meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb | 2 ++ 1 file changed, 2 insertions(+)