Message ID | 6817b012763fc32cdcffe30163a304da3ed59ae1.1726971209.git.steve@sakoman.com |
---|---|
State | Accepted |
Delegated to: | Steve Sakoman |
Headers | show |
Series | [kirkstone,01/15] libpcap: Security fix for CVE-2023-7256 & CVE-2024-8006 | expand |
Hello, This patch has introduced an issue while building recipes without any files installed or packaged. Prime example for this is meta-toolchain [1]. As, previously the error was hidden in the for loop - an explicit failure is causing an issue while building meta-toolchain et al. I believe the fix is either to `inherit nopackages` for meta-toolchain like recipes or modify the previously submitted patch to not hard-fail. 1: https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/meta/meta-toolchain.bb Thanks, --Atharva
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass index 4345ffc693..b35508db27 100644 --- a/meta/classes/buildhistory.bbclass +++ b/meta/classes/buildhistory.bbclass @@ -597,15 +597,12 @@ buildhistory_list_files_no_owners() { buildhistory_list_pkg_files() { # Create individual files-in-package for each recipe's package - for pkgdir in $(find ${PKGDEST}/* -maxdepth 0 -type d); do + pkgdirlist=$(find ${PKGDEST}/* -maxdepth 0 -type d) + for pkgdir in $pkgdirlist; do pkgname=$(basename $pkgdir) outfolder="${BUILDHISTORY_DIR_PACKAGE}/$pkgname" outfile="$outfolder/files-in-package.txt" - # Make sure the output folder exists so we can create the file - if [ ! -d $outfolder ] ; then - bbdebug 2 "Folder $outfolder does not exist, file $outfile not created" - continue - fi + mkdir -p $outfolder buildhistory_list_files $pkgdir $outfile fakeroot done }