| Message ID | 20240925132017.3427438-5-yoann.congal@smile.fr |
|---|---|
| State | New |
| Headers | show |
| Series | Document my team's commits for 5.1 | expand |
Hi Yoann, On 9/25/24 3:20 PM, Yoann Congal via lists.yoctoproject.org wrote: > From: Yoann Congal <yoann.congal@smile.fr> > > This covers Poky's commits > 47ed8ac83a6 (spirv-tools: Fix git-describe related reproducibility, 2024-08-03) > a19bb8c1d51 (spirv-tools: Update merged patch to backport status, 2024-09-05) > > Signed-off-by: Yoann Congal <yoann.congal@smile.fr> > --- > documentation/migration-guides/release-notes-5.1.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/documentation/migration-guides/release-notes-5.1.rst b/documentation/migration-guides/release-notes-5.1.rst > index d6c72c5c4..8b51f5677 100644 > --- a/documentation/migration-guides/release-notes-5.1.rst > +++ b/documentation/migration-guides/release-notes-5.1.rst > @@ -50,6 +50,8 @@ New Features / Enhancements in 5.1 > > - Miscellaneous changes: > > + - spriv-tools is now repeatably reproducible > + Somehow my local dictionary doesn't highlight "repeatably" but my - non-native - brain is screaming it's incorrect. I can suggest "repeatedly" instead. Or even better... not have it at all? Doesn't "reproducible" mean the fact it can be reproduced, meaning "more than once", hence "repeatedly"? Or maybe we thought it was reproducible and we fixed it, in which case "really" could be a good replacement for "repeatably"/"repeatedly"? Cheers, Quentin
Le 26/09/2024 à 14:53, Quentin Schulz a écrit : > Hi Yoann, > > On 9/25/24 3:20 PM, Yoann Congal via lists.yoctoproject.org wrote: >> From: Yoann Congal <yoann.congal@smile.fr> >> >> This covers Poky's commits >> 47ed8ac83a6 (spirv-tools: Fix git-describe related reproducibility, 2024-08-03) >> a19bb8c1d51 (spirv-tools: Update merged patch to backport status, 2024-09-05) >> >> Signed-off-by: Yoann Congal <yoann.congal@smile.fr> >> --- >> documentation/migration-guides/release-notes-5.1.rst | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/documentation/migration-guides/release-notes-5.1.rst b/documentation/migration-guides/release-notes-5.1.rst >> index d6c72c5c4..8b51f5677 100644 >> --- a/documentation/migration-guides/release-notes-5.1.rst >> +++ b/documentation/migration-guides/release-notes-5.1.rst >> @@ -50,6 +50,8 @@ New Features / Enhancements in 5.1 >> - Miscellaneous changes: >> + - spriv-tools is now repeatably reproducible >> + > > Somehow my local dictionary doesn't highlight "repeatably" but my - non-native - brain is screaming it's incorrect. > > I can suggest "repeatedly" instead. > > Or even better... not have it at all? Doesn't "reproducible" mean the fact it can be reproduced, meaning "more than once", hence "repeatedly"? > > Or maybe we thought it was reproducible and we fixed it, in which case "really" could be a good replacement for "repeatably"/"repeatedly"? It was reproducible most of the time but not every time. Now, it is reproducible every time (famous last words ;) ). ... but now I think that this detail is not really interesting for the release note. I've sent a simpler "fix reproducibility" v2. Thanks! > > Cheers, > Quentin
diff --git a/documentation/migration-guides/release-notes-5.1.rst b/documentation/migration-guides/release-notes-5.1.rst index d6c72c5c4..8b51f5677 100644 --- a/documentation/migration-guides/release-notes-5.1.rst +++ b/documentation/migration-guides/release-notes-5.1.rst @@ -50,6 +50,8 @@ New Features / Enhancements in 5.1 - Miscellaneous changes: + - spriv-tools is now repeatably reproducible + Known Issues in 5.1 ~~~~~~~~~~~~~~~~~~~