| Message ID | 20240924063229.2309109-1-quic_raghuvar@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe,scarthgap,1/3] android-tools-adbd.service: Update ConditionPathExists to /etc | expand |
On Tue, 24 Sept 2024 at 08:36, Raghuvarya S <quic_raghuvar@quicinc.com> wrote: > > To ensure android-tools-adbd.service starts at boot, the path > for ConditionPathExists must be present at build time. /etc is > more suitable for build-time files than /var, which is for > runtime files. Changed ConditionPathExists from > /var/usb-debugging-enabled to /etc/usb-debugging-enabled > > Backport-of: 8106cfe769aa ("android-tools-adbd.service: Change /var to /etc in ConditionPathExists") > CC: Khem Raj <raj.khem@gmail.com> > CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com> > --- > .../android-tools/android-tools/android-tools-adbd.service | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For the series: Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, Sep 24, 2024 at 12:02:28PM +0530, Raghuvarya S wrote: > To ensure android-tools-adbd.service starts at boot, the path > for ConditionPathExists must be present at build time. /etc is > more suitable for build-time files than /var, which is for > runtime files. Changed ConditionPathExists from > /var/usb-debugging-enabled to /etc/usb-debugging-enabled > > Backport-of: 8106cfe769aa ("android-tools-adbd.service: Change /var to /etc in ConditionPathExists") > CC: Khem Raj <raj.khem@gmail.com> > CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com> > --- > .../android-tools/android-tools/android-tools-adbd.service | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Armin, Khem, what is the plan with respect to this backport request? Could you please clarify, is there anything remaining on the Qualcomm's side? Is it rejected for backporting to stable branches?
On Sun, Oct 6, 2024 at 8:19 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Tue, Sep 24, 2024 at 12:02:28PM +0530, Raghuvarya S wrote: > > To ensure android-tools-adbd.service starts at boot, the path > > for ConditionPathExists must be present at build time. /etc is > > more suitable for build-time files than /var, which is for > > runtime files. Changed ConditionPathExists from > > /var/usb-debugging-enabled to /etc/usb-debugging-enabled > > > > Backport-of: 8106cfe769aa ("android-tools-adbd.service: Change /var to /etc in ConditionPathExists") > > CC: Khem Raj <raj.khem@gmail.com> > > CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com> > > --- > > .../android-tools/android-tools/android-tools-adbd.service | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Armin, Khem, what is the plan with respect to this backport request? > Could you please clarify, is there anything remaining on the Qualcomm's > side? Is it rejected for backporting to stable branches? > It's staged in stable/scarthgap-nut so if nothing regresses it should be in next monthly release of scarthgap always check the nut branches if you want to see latest status of your backport requests. https://git.openembedded.org/meta-openembedded-contrib/log/?h=stable/scarthgap-nut > -- > With best wishes > Dmitry
diff --git a/meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service b/meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service index ddf8d7f74..b6661f2e3 100644 --- a/meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service +++ b/meta-oe/recipes-devtools/android-tools/android-tools/android-tools-adbd.service @@ -1,6 +1,6 @@ [Unit] Description=Android Debug Bridge -ConditionPathExists=/var/usb-debugging-enabled +ConditionPathExists=/etc/usb-debugging-enabled Before=android-system.service [Service]
To ensure android-tools-adbd.service starts at boot, the path for ConditionPathExists must be present at build time. /etc is more suitable for build-time files than /var, which is for runtime files. Changed ConditionPathExists from /var/usb-debugging-enabled to /etc/usb-debugging-enabled Backport-of: 8106cfe769aa ("android-tools-adbd.service: Change /var to /etc in ConditionPathExists") CC: Khem Raj <raj.khem@gmail.com> CC: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Raghuvarya S <quic_raghuvar@quicinc.com> --- .../android-tools/android-tools/android-tools-adbd.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)