Message ID | 20240922084128.9648-6-mikko.rapeli@linaro.org |
---|---|
State | New |
Headers | show |
Series | systemd uki support | expand |
On Sun, Sep 22, 2024 at 1:42 AM Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote: > > These work on all archs not just x86. > > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> > --- > meta/classes-recipe/image_types_wic.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/image_types_wic.bbclass b/meta/classes-recipe/image_types_wic.bbclass > index 86f40633eb..e02eb0b367 100644 > --- a/meta/classes-recipe/image_types_wic.bbclass > +++ b/meta/classes-recipe/image_types_wic.bbclass > @@ -110,7 +110,7 @@ WKS_FILE_DEPENDS_DEFAULT = '${@bb.utils.contains_any("BUILD_ARCH", [ 'x86_64', ' > WKS_FILE_DEPENDS_DEFAULT += "bmaptool-native cdrtools-native btrfs-tools-native squashfs-tools-native e2fsprogs-native erofs-utils-native" > # Unified kernel images need objcopy > WKS_FILE_DEPENDS_DEFAULT += "virtual/${TARGET_PREFIX}binutils" > -WKS_FILE_DEPENDS_BOOTLOADERS = "" > +WKS_FILE_DEPENDS_BOOTLOADERS ?= "systemd-boot os-release" systemd-boot is only built for arm/arm64/x86/x86_64 if I look into the systemd-boot recipe, so this will break wic image generation for other architectures. > WKS_FILE_DEPENDS_BOOTLOADERS:x86 = "syslinux grub-efi systemd-boot os-release" > WKS_FILE_DEPENDS_BOOTLOADERS:x86-64 = "syslinux grub-efi systemd-boot os-release" > WKS_FILE_DEPENDS_BOOTLOADERS:x86-x32 = "syslinux grub-efi" > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#204777): https://lists.openembedded.org/g/openembedded-core/message/204777 > Mute This Topic: https://lists.openembedded.org/mt/108587931/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi, On Mon, Sep 23, 2024 at 05:10:35PM -0700, Khem Raj wrote: > On Sun, Sep 22, 2024 at 1:42 AM Mikko Rapeli via > lists.openembedded.org > <mikko.rapeli=linaro.org@lists.openembedded.org> wrote: > > > > These work on all archs not just x86. > > > > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> > > --- > > meta/classes-recipe/image_types_wic.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes-recipe/image_types_wic.bbclass b/meta/classes-recipe/image_types_wic.bbclass > > index 86f40633eb..e02eb0b367 100644 > > --- a/meta/classes-recipe/image_types_wic.bbclass > > +++ b/meta/classes-recipe/image_types_wic.bbclass > > @@ -110,7 +110,7 @@ WKS_FILE_DEPENDS_DEFAULT = '${@bb.utils.contains_any("BUILD_ARCH", [ 'x86_64', ' > > WKS_FILE_DEPENDS_DEFAULT += "bmaptool-native cdrtools-native btrfs-tools-native squashfs-tools-native e2fsprogs-native erofs-utils-native" > > # Unified kernel images need objcopy > > WKS_FILE_DEPENDS_DEFAULT += "virtual/${TARGET_PREFIX}binutils" > > -WKS_FILE_DEPENDS_BOOTLOADERS = "" > > +WKS_FILE_DEPENDS_BOOTLOADERS ?= "systemd-boot os-release" > > systemd-boot is only built for arm/arm64/x86/x86_64 if I look into the > systemd-boot recipe, so this will break wic image > generation for other architectures. Ok, I can drop this change. It's a bit confusing how systemd-boot and grub-efi are used currently. Both don't work and end up using only grub-efi. If intention is to boot with systemd-boot, then grub-efi is not needed. Cheers, -Mikko > > > WKS_FILE_DEPENDS_BOOTLOADERS:x86 = "syslinux grub-efi systemd-boot os-release" > > WKS_FILE_DEPENDS_BOOTLOADERS:x86-64 = "syslinux grub-efi systemd-boot os-release" > > WKS_FILE_DEPENDS_BOOTLOADERS:x86-x32 = "syslinux grub-efi" > > -- > > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#204777): https://lists.openembedded.org/g/openembedded-core/message/204777 > > Mute This Topic: https://lists.openembedded.org/mt/108587931/1997914 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta/classes-recipe/image_types_wic.bbclass b/meta/classes-recipe/image_types_wic.bbclass index 86f40633eb..e02eb0b367 100644 --- a/meta/classes-recipe/image_types_wic.bbclass +++ b/meta/classes-recipe/image_types_wic.bbclass @@ -110,7 +110,7 @@ WKS_FILE_DEPENDS_DEFAULT = '${@bb.utils.contains_any("BUILD_ARCH", [ 'x86_64', ' WKS_FILE_DEPENDS_DEFAULT += "bmaptool-native cdrtools-native btrfs-tools-native squashfs-tools-native e2fsprogs-native erofs-utils-native" # Unified kernel images need objcopy WKS_FILE_DEPENDS_DEFAULT += "virtual/${TARGET_PREFIX}binutils" -WKS_FILE_DEPENDS_BOOTLOADERS = "" +WKS_FILE_DEPENDS_BOOTLOADERS ?= "systemd-boot os-release" WKS_FILE_DEPENDS_BOOTLOADERS:x86 = "syslinux grub-efi systemd-boot os-release" WKS_FILE_DEPENDS_BOOTLOADERS:x86-64 = "syslinux grub-efi systemd-boot os-release" WKS_FILE_DEPENDS_BOOTLOADERS:x86-x32 = "syslinux grub-efi"
These work on all archs not just x86. Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> --- meta/classes-recipe/image_types_wic.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)