diff mbox series

yavta: Update to kernel 6.8

Message ID 20240910124936.21220-1-tolvupostur@gmail.com
State Accepted
Headers show
Series yavta: Update to kernel 6.8 | expand

Commit Message

Einar Gunnarsson Sept. 10, 2024, 12:49 p.m. UTC
Additional changes:
Use https protocol for git fetch
Build with meson

Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
---
 .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

Comments

Ryan Eatmon Sept. 13, 2024, 1:25 p.m. UTC | #1
I'm seeing build failures on 32bit platforms with this new version.  Can 
anyone verify?


On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
> Additional changes:
> Use https protocol for git fetch
> Build with meson
> 
> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
> ---
>   .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
>   1 file changed, 3 insertions(+), 15 deletions(-)
> 
> diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> index c4f31c033..db00c67b1 100644
> --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
>   LICENSE = "GPL-2.0-only"
>   LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>   
> -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
> +SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
>             "
> -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
> +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
>   
>   PV = "0.0"
>   S = "${WORKDIR}/git"
> @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
>   # Upstream repo does not tag
>   UPSTREAM_CHECK_COMMITS = "1"
>   
> -EXTRA_OEMAKE = "-e MAKEFLAGS="
> -
> -# The yavta sources include copies of the headers required to build in the
> -# include directory.  The Makefile uses CFLAGS to include these, but since
> -# we override the CFLAGS then we need to add this include path back in.
> -CFLAGS += "-I${S}/include"
> -
> -do_install() {
> -    install -d ${D}${bindir}
> -    install -m 0755 yavta ${D}${bindir}
> -}
> -
> -
> +inherit meson
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#112229): https://lists.openembedded.org/g/openembedded-devel/message/112229
> Mute This Topic: https://lists.openembedded.org/mt/108374819/6551054
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Einar Gunnarsson Sept. 13, 2024, 5:25 p.m. UTC | #2
Ooops

On Fri, 13 Sept 2024 at 15:25, Ryan Eatmon <reatmon@ti.com> wrote:

>
> I'm seeing build failures on 32bit platforms with this new version.  Can
> anyone verify?
>

I can confirm that this does not build on 32-bit.
The problem seems to be switching to meson build - both the current SRCREV
and the updated one fail on time_t size with meson, but build with the old
mess of a code.

Sorry about that
Einar Jon


>
> On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
> > Additional changes:
> > Use https protocol for git fetch
> > Build with meson
> >
> > Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
> > ---
> >   .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
> >   1 file changed, 3 insertions(+), 15 deletions(-)
> >
> > diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > index c4f31c033..db00c67b1 100644
> > --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
> >   LICENSE = "GPL-2.0-only"
> >   LIC_FILES_CHKSUM =
> "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
> >
> > -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
> > +SRC_URI = "git://
> git.ideasonboard.org/yavta.git;branch=master;protocol=https \
> >             "
> > -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
> > +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
> >
> >   PV = "0.0"
> >   S = "${WORKDIR}/git"
> > @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
> >   # Upstream repo does not tag
> >   UPSTREAM_CHECK_COMMITS = "1"
> >
> > -EXTRA_OEMAKE = "-e MAKEFLAGS="
> > -
> > -# The yavta sources include copies of the headers required to build in
> the
> > -# include directory.  The Makefile uses CFLAGS to include these, but
> since
> > -# we override the CFLAGS then we need to add this include path back in.
> > -CFLAGS += "-I${S}/include"
> > -
> > -do_install() {
> > -    install -d ${D}${bindir}
> > -    install -m 0755 yavta ${D}${bindir}
> > -}
> > -
> > -
> > +inherit meson
> >
> >
> >
> > 
> >
>
> --
> Ryan Eatmon                reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc.  -  LCPD  -  MGTS
>
Khem Raj Sept. 13, 2024, 6:28 p.m. UTC | #3
On Fri, Sep 13, 2024 at 11:17 AM Einar Gunnarsson via
lists.openembedded.org <tolvupostur=gmail.com@lists.openembedded.org>
wrote:
>
> Ooops
>
> On Fri, 13 Sept 2024 at 15:25, Ryan Eatmon <reatmon@ti.com> wrote:
>>
>>
>> I'm seeing build failures on 32bit platforms with this new version.  Can
>> anyone verify?
>
>
> I can confirm that this does not build on 32-bit.
> The problem seems to be switching to meson build - both the current SRCREV
> and the updated one fail on time_t size with meson, but build with the old mess of a code.
>

My builds test 64 bit on AB, locally I test 32bit arm/x86 and its
using clang compiler and it works fine there too.
I do not have 32bit builds+musl combination, too many combos, not
enough compute power.

> Sorry about that
> Einar Jon
>
>>
>>
>> On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
>> > Additional changes:
>> > Use https protocol for git fetch
>> > Build with meson
>> >
>> > Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
>> > ---
>> >   .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
>> >   1 file changed, 3 insertions(+), 15 deletions(-)
>> >
>> > diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>> > index c4f31c033..db00c67b1 100644
>> > --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>> > +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>> > @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
>> >   LICENSE = "GPL-2.0-only"
>> >   LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>> >
>> > -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
>> > +SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
>> >             "
>> > -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
>> > +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
>> >
>> >   PV = "0.0"
>> >   S = "${WORKDIR}/git"
>> > @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
>> >   # Upstream repo does not tag
>> >   UPSTREAM_CHECK_COMMITS = "1"
>> >
>> > -EXTRA_OEMAKE = "-e MAKEFLAGS="
>> > -
>> > -# The yavta sources include copies of the headers required to build in the
>> > -# include directory.  The Makefile uses CFLAGS to include these, but since
>> > -# we override the CFLAGS then we need to add this include path back in.
>> > -CFLAGS += "-I${S}/include"
>> > -
>> > -do_install() {
>> > -    install -d ${D}${bindir}
>> > -    install -m 0755 yavta ${D}${bindir}
>> > -}
>> > -
>> > -
>> > +inherit meson
>> >
>> >
>> >
>> >
>> >
>>
>> --
>> Ryan Eatmon                reatmon@ti.com
>> -----------------------------------------
>> Texas Instruments, Inc.  -  LCPD  -  MGTS
>
>
>
> --
> Regards
> Einar Jón
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#112277): https://lists.openembedded.org/g/openembedded-devel/message/112277
> Mute This Topic: https://lists.openembedded.org/mt/108374819/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ryan Eatmon Sept. 13, 2024, 6:38 p.m. UTC | #4
On 9/13/2024 1:28 PM, Khem Raj wrote:
> On Fri, Sep 13, 2024 at 11:17 AM Einar Gunnarsson via
> lists.openembedded.org <tolvupostur=gmail.com@lists.openembedded.org>
> wrote:
>>
>> Ooops
>>
>> On Fri, 13 Sept 2024 at 15:25, Ryan Eatmon <reatmon@ti.com> wrote:
>>>
>>>
>>> I'm seeing build failures on 32bit platforms with this new version.  Can
>>> anyone verify?
>>
>>
>> I can confirm that this does not build on 32-bit.
>> The problem seems to be switching to meson build - both the current SRCREV
>> and the updated one fail on time_t size with meson, but build with the old mess of a code.
>>
> 
> My builds test 64 bit on AB, locally I test 32bit arm/x86 and its
> using clang compiler and it works fine there too.
> I do not have 32bit builds+musl combination, too many combos, not
> enough compute power.

I have a patch that I'm testing.  I've spoken to the upstream maintainer 
and will send the patch in to them once it's complete.  Then we can bump 
the SRCREV again once they accept it.



>> Sorry about that
>> Einar Jon
>>
>>>
>>>
>>> On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
>>>> Additional changes:
>>>> Use https protocol for git fetch
>>>> Build with meson
>>>>
>>>> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
>>>> ---
>>>>    .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
>>>>    1 file changed, 3 insertions(+), 15 deletions(-)
>>>>
>>>> diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>>>> index c4f31c033..db00c67b1 100644
>>>> --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>>>> +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
>>>> @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
>>>>    LICENSE = "GPL-2.0-only"
>>>>    LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
>>>>
>>>> -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
>>>> +SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
>>>>              "
>>>> -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
>>>> +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
>>>>
>>>>    PV = "0.0"
>>>>    S = "${WORKDIR}/git"
>>>> @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
>>>>    # Upstream repo does not tag
>>>>    UPSTREAM_CHECK_COMMITS = "1"
>>>>
>>>> -EXTRA_OEMAKE = "-e MAKEFLAGS="
>>>> -
>>>> -# The yavta sources include copies of the headers required to build in the
>>>> -# include directory.  The Makefile uses CFLAGS to include these, but since
>>>> -# we override the CFLAGS then we need to add this include path back in.
>>>> -CFLAGS += "-I${S}/include"
>>>> -
>>>> -do_install() {
>>>> -    install -d ${D}${bindir}
>>>> -    install -m 0755 yavta ${D}${bindir}
>>>> -}
>>>> -
>>>> -
>>>> +inherit meson
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>> --
>>> Ryan Eatmon                reatmon@ti.com
>>> -----------------------------------------
>>> Texas Instruments, Inc.  -  LCPD  -  MGTS
>>
>>
>>
>> --
>> Regards
>> Einar Jón
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#112277): https://lists.openembedded.org/g/openembedded-devel/message/112277
>> Mute This Topic: https://lists.openembedded.org/mt/108374819/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
Martin Jansa Sept. 14, 2024, 8:38 a.m. UTC | #5
Not sure which errors you were seeing, but I can confirm it fails to
build for 32-bit in my world builds with:

../git/yavta.c:2195:51: error: format '%ld' expects argument of type
'long int', but argument 8 has type '__time64_t' {aka 'long long int'}
[-Werror=format=]
 2195 |                 printf("%u (%u) [%c] %s %u %u B %ld.%06ld
%ld.%06ld %.3f fps ts %s/%s\n", i, buf.index,
      |                                                 ~~^
      |                                                   |
      |                                                   long int
      |                                                 %lld
......
 2199 |                         buf.timestamp.tv_sec, buf.timestamp.tv_usec,
      |                         ~~~~~~~~~~~~~~~~~~~~
      |                                      |
      |                                      __time64_t {aka long long int}

../git/yavta.c:2257:41: error: format '%lu' expects argument of type
'long unsigned int', but argument 3 has type '__time64_t' {aka 'long
long int'} [-Werror=format=]
 2257 |         printf("Captured %u frames in %lu.%06lu seconds (%f
fps, %f B/s).\n",
      |                                       ~~^
      |                                         |
      |                                         long unsigned int
      |                                       %llu
 2258 |                 i, ts.tv_sec, ts.tv_nsec/1000, fps, bps);
      |                    ~~~~~~~~~
      |                      |
      |                      __time64_t {aka long long int}

This one isn't hard to fix, but maybe you were seeing some other issues.

Regards,

On Fri, Sep 13, 2024 at 8:38 PM Ryan Eatmon via lists.openembedded.org
<reatmon=ti.com@lists.openembedded.org> wrote:
>
>
>
> On 9/13/2024 1:28 PM, Khem Raj wrote:
> > On Fri, Sep 13, 2024 at 11:17 AM Einar Gunnarsson via
> > lists.openembedded.org <tolvupostur=gmail.com@lists.openembedded.org>
> > wrote:
> >>
> >> Ooops
> >>
> >> On Fri, 13 Sept 2024 at 15:25, Ryan Eatmon <reatmon@ti.com> wrote:
> >>>
> >>>
> >>> I'm seeing build failures on 32bit platforms with this new version.  Can
> >>> anyone verify?
> >>
> >>
> >> I can confirm that this does not build on 32-bit.
> >> The problem seems to be switching to meson build - both the current SRCREV
> >> and the updated one fail on time_t size with meson, but build with the old mess of a code.
> >>
> >
> > My builds test 64 bit on AB, locally I test 32bit arm/x86 and its
> > using clang compiler and it works fine there too.
> > I do not have 32bit builds+musl combination, too many combos, not
> > enough compute power.
>
> I have a patch that I'm testing.  I've spoken to the upstream maintainer
> and will send the patch in to them once it's complete.  Then we can bump
> the SRCREV again once they accept it.
>
>
>
> >> Sorry about that
> >> Einar Jon
> >>
> >>>
> >>>
> >>> On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
> >>>> Additional changes:
> >>>> Use https protocol for git fetch
> >>>> Build with meson
> >>>>
> >>>> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
> >>>> ---
> >>>>    .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
> >>>>    1 file changed, 3 insertions(+), 15 deletions(-)
> >>>>
> >>>> diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> >>>> index c4f31c033..db00c67b1 100644
> >>>> --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> >>>> +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> >>>> @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
> >>>>    LICENSE = "GPL-2.0-only"
> >>>>    LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
> >>>>
> >>>> -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
> >>>> +SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
> >>>>              "
> >>>> -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
> >>>> +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
> >>>>
> >>>>    PV = "0.0"
> >>>>    S = "${WORKDIR}/git"
> >>>> @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
> >>>>    # Upstream repo does not tag
> >>>>    UPSTREAM_CHECK_COMMITS = "1"
> >>>>
> >>>> -EXTRA_OEMAKE = "-e MAKEFLAGS="
> >>>> -
> >>>> -# The yavta sources include copies of the headers required to build in the
> >>>> -# include directory.  The Makefile uses CFLAGS to include these, but since
> >>>> -# we override the CFLAGS then we need to add this include path back in.
> >>>> -CFLAGS += "-I${S}/include"
> >>>> -
> >>>> -do_install() {
> >>>> -    install -d ${D}${bindir}
> >>>> -    install -m 0755 yavta ${D}${bindir}
> >>>> -}
> >>>> -
> >>>> -
> >>>> +inherit meson
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>> --
> >>> Ryan Eatmon                reatmon@ti.com
> >>> -----------------------------------------
> >>> Texas Instruments, Inc.  -  LCPD  -  MGTS
> >>
> >>
> >>
> >> --
> >> Regards
> >> Einar Jón
> >>
> >>
> >>
>
> --
> Ryan Eatmon                reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc.  -  LCPD  -  MGTS
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#112280): https://lists.openembedded.org/g/openembedded-devel/message/112280
> Mute This Topic: https://lists.openembedded.org/mt/108374819/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Martin Jansa Sept. 14, 2024, 8:40 a.m. UTC | #6
https://git.ideasonboard.org/yavta.git/commit/?id=52c975e5542504ac10bed8b1d68df5c75951d202

On Sat, Sep 14, 2024 at 10:38 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Not sure which errors you were seeing, but I can confirm it fails to
> build for 32-bit in my world builds with:
>
> ../git/yavta.c:2195:51: error: format '%ld' expects argument of type
> 'long int', but argument 8 has type '__time64_t' {aka 'long long int'}
> [-Werror=format=]
>  2195 |                 printf("%u (%u) [%c] %s %u %u B %ld.%06ld
> %ld.%06ld %.3f fps ts %s/%s\n", i, buf.index,
>       |                                                 ~~^
>       |                                                   |
>       |                                                   long int
>       |                                                 %lld
> ......
>  2199 |                         buf.timestamp.tv_sec, buf.timestamp.tv_usec,
>       |                         ~~~~~~~~~~~~~~~~~~~~
>       |                                      |
>       |                                      __time64_t {aka long long int}
>
> ../git/yavta.c:2257:41: error: format '%lu' expects argument of type
> 'long unsigned int', but argument 3 has type '__time64_t' {aka 'long
> long int'} [-Werror=format=]
>  2257 |         printf("Captured %u frames in %lu.%06lu seconds (%f
> fps, %f B/s).\n",
>       |                                       ~~^
>       |                                         |
>       |                                         long unsigned int
>       |                                       %llu
>  2258 |                 i, ts.tv_sec, ts.tv_nsec/1000, fps, bps);
>       |                    ~~~~~~~~~
>       |                      |
>       |                      __time64_t {aka long long int}
>
> This one isn't hard to fix, but maybe you were seeing some other issues.
>
> Regards,
>
> On Fri, Sep 13, 2024 at 8:38 PM Ryan Eatmon via lists.openembedded.org
> <reatmon=ti.com@lists.openembedded.org> wrote:
> >
> >
> >
> > On 9/13/2024 1:28 PM, Khem Raj wrote:
> > > On Fri, Sep 13, 2024 at 11:17 AM Einar Gunnarsson via
> > > lists.openembedded.org <tolvupostur=gmail.com@lists.openembedded.org>
> > > wrote:
> > >>
> > >> Ooops
> > >>
> > >> On Fri, 13 Sept 2024 at 15:25, Ryan Eatmon <reatmon@ti.com> wrote:
> > >>>
> > >>>
> > >>> I'm seeing build failures on 32bit platforms with this new version.  Can
> > >>> anyone verify?
> > >>
> > >>
> > >> I can confirm that this does not build on 32-bit.
> > >> The problem seems to be switching to meson build - both the current SRCREV
> > >> and the updated one fail on time_t size with meson, but build with the old mess of a code.
> > >>
> > >
> > > My builds test 64 bit on AB, locally I test 32bit arm/x86 and its
> > > using clang compiler and it works fine there too.
> > > I do not have 32bit builds+musl combination, too many combos, not
> > > enough compute power.
> >
> > I have a patch that I'm testing.  I've spoken to the upstream maintainer
> > and will send the patch in to them once it's complete.  Then we can bump
> > the SRCREV again once they accept it.
> >
> >
> >
> > >> Sorry about that
> > >> Einar Jon
> > >>
> > >>>
> > >>>
> > >>> On 9/10/2024 7:49 AM, Einar Gunnarsson wrote:
> > >>>> Additional changes:
> > >>>> Use https protocol for git fetch
> > >>>> Build with meson
> > >>>>
> > >>>> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
> > >>>> ---
> > >>>>    .../recipes-multimedia/v4l2apps/yavta_git.bb   | 18 +++---------------
> > >>>>    1 file changed, 3 insertions(+), 15 deletions(-)
> > >>>>
> > >>>> diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > >>>> index c4f31c033..db00c67b1 100644
> > >>>> --- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > >>>> +++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
> > >>>> @@ -2,9 +2,9 @@ SUMMARY = "Yet Another V4L2 Test Application"
> > >>>>    LICENSE = "GPL-2.0-only"
> > >>>>    LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
> > >>>>
> > >>>> -SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
> > >>>> +SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
> > >>>>              "
> > >>>> -SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
> > >>>> +SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
> > >>>>
> > >>>>    PV = "0.0"
> > >>>>    S = "${WORKDIR}/git"
> > >>>> @@ -12,16 +12,4 @@ S = "${WORKDIR}/git"
> > >>>>    # Upstream repo does not tag
> > >>>>    UPSTREAM_CHECK_COMMITS = "1"
> > >>>>
> > >>>> -EXTRA_OEMAKE = "-e MAKEFLAGS="
> > >>>> -
> > >>>> -# The yavta sources include copies of the headers required to build in the
> > >>>> -# include directory.  The Makefile uses CFLAGS to include these, but since
> > >>>> -# we override the CFLAGS then we need to add this include path back in.
> > >>>> -CFLAGS += "-I${S}/include"
> > >>>> -
> > >>>> -do_install() {
> > >>>> -    install -d ${D}${bindir}
> > >>>> -    install -m 0755 yavta ${D}${bindir}
> > >>>> -}
> > >>>> -
> > >>>> -
> > >>>> +inherit meson
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>
> > >>> --
> > >>> Ryan Eatmon                reatmon@ti.com
> > >>> -----------------------------------------
> > >>> Texas Instruments, Inc.  -  LCPD  -  MGTS
> > >>
> > >>
> > >>
> > >> --
> > >> Regards
> > >> Einar Jón
> > >>
> > >>
> > >>
> >
> > --
> > Ryan Eatmon                reatmon@ti.com
> > -----------------------------------------
> > Texas Instruments, Inc.  -  LCPD  -  MGTS
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#112280): https://lists.openembedded.org/g/openembedded-devel/message/112280
> > Mute This Topic: https://lists.openembedded.org/mt/108374819/3617156
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
index c4f31c033..db00c67b1 100644
--- a/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
+++ b/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb
@@ -2,9 +2,9 @@  SUMMARY = "Yet Another V4L2 Test Application"
 LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING.GPL;md5=751419260aa954499f7abaabaa882bbe"
 
-SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master \
+SRC_URI = "git://git.ideasonboard.org/yavta.git;branch=master;protocol=https \
           "
-SRCREV = "65f740aa1758531fd810339bc1b7d1d33666e28a"
+SRCREV = "323facd1d5bd6251eec70dd5c1484a12ce01202a"
 
 PV = "0.0"
 S = "${WORKDIR}/git"
@@ -12,16 +12,4 @@  S = "${WORKDIR}/git"
 # Upstream repo does not tag
 UPSTREAM_CHECK_COMMITS = "1"
 
-EXTRA_OEMAKE = "-e MAKEFLAGS="
-
-# The yavta sources include copies of the headers required to build in the
-# include directory.  The Makefile uses CFLAGS to include these, but since
-# we override the CFLAGS then we need to add this include path back in.
-CFLAGS += "-I${S}/include"
-
-do_install() {
-    install -d ${D}${bindir}
-    install -m 0755 yavta ${D}${bindir}
-}
-
-
+inherit meson