diff mbox series

[meta-oe] nmap: depend on libpcre2 not libpcre

Message ID 20240910145244.1238276-1-martin.jansa@gmail.com
State Accepted
Headers show
Series [meta-oe] nmap: depend on libpcre2 not libpcre | expand

Commit Message

Martin Jansa Sept. 10, 2024, 2:52 p.m. UTC
* switched to libpcre2 in:
  https://github.com/nmap/nmap/commit/828ab48764b82d0226e860c73c5dac5b11f77385

* in builds hwere libpcre2 isn't pulled by some other dependency it was failing with:
| service_scan.h:74:10: fatal error: pcre2.h: No such file or directory                                                                                                                                                                       |    74 | #include <pcre2.h>                                                                                                                                                                                                                  |       |          ^~~~~~~~~|

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
---
 meta-oe/recipes-security/nmap/nmap_7.95.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Sept. 13, 2024, 5:46 p.m. UTC | #1
this exposes an issue, when linking with lld linker ends up with

riscv64-yoe-linux-ld.lld: error: unable to find library -lpcre2-8

On Tue, Sep 10, 2024 at 7:52 AM Martin Jansa via
lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
wrote:
>
> * switched to libpcre2 in:
>   https://github.com/nmap/nmap/commit/828ab48764b82d0226e860c73c5dac5b11f77385
>
> * in builds hwere libpcre2 isn't pulled by some other dependency it was failing with:
> | service_scan.h:74:10: fatal error: pcre2.h: No such file or directory                                                                                                                                                                       |    74 | #include <pcre2.h>                                                                                                                                                                                                                  |       |          ^~~~~~~~~|
>
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> ---
>  meta-oe/recipes-security/nmap/nmap_7.95.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-security/nmap/nmap_7.95.bb b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> index d3273dc4e9..79c28e71f0 100644
> --- a/meta-oe/recipes-security/nmap/nmap_7.95.bb
> +++ b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> @@ -17,7 +17,7 @@ inherit autotools-brokensep pkgconfig python3native
>  PACKAGECONFIG ?= "pcre ncat nping pcap"
>
>  PACKAGECONFIG[pcap] = "--with-pcap=linux, --without-pcap, libpcap, libpcap"
> -PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre"
> +PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre2"
>  PACKAGECONFIG[ssl] = "--with-openssl=${STAGING_LIBDIR}/.., --without-openssl, openssl, openssl"
>  PACKAGECONFIG[ssh2] = "--with-openssh2=${STAGING_LIBDIR}/.., --without-openssh2, libssh2, libssh2"
>  PACKAGECONFIG[libz] = "--with-libz=${STAGING_LIBDIR}/.., --without-libz, zlib, zlib"
> --
> 2.46.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#112233): https://lists.openembedded.org/g/openembedded-devel/message/112233
> Mute This Topic: https://lists.openembedded.org/mt/108376191/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Martin Jansa Sept. 13, 2024, 6:04 p.m. UTC | #2
Interesting, I was building it fine with lld, will check what libpcre2
it has in RSS and on cmdline.

On Fri, Sep 13, 2024 at 7:46 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> this exposes an issue, when linking with lld linker ends up with
>
> riscv64-yoe-linux-ld.lld: error: unable to find library -lpcre2-8
>
> On Tue, Sep 10, 2024 at 7:52 AM Martin Jansa via
> lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
> wrote:
> >
> > * switched to libpcre2 in:
> >   https://github.com/nmap/nmap/commit/828ab48764b82d0226e860c73c5dac5b11f77385
> >
> > * in builds hwere libpcre2 isn't pulled by some other dependency it was failing with:
> > | service_scan.h:74:10: fatal error: pcre2.h: No such file or directory                                                                                                                                                                       |    74 | #include <pcre2.h>                                                                                                                                                                                                                  |       |          ^~~~~~~~~|
> >
> > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > ---
> >  meta-oe/recipes-security/nmap/nmap_7.95.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-security/nmap/nmap_7.95.bb b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > index d3273dc4e9..79c28e71f0 100644
> > --- a/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > +++ b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > @@ -17,7 +17,7 @@ inherit autotools-brokensep pkgconfig python3native
> >  PACKAGECONFIG ?= "pcre ncat nping pcap"
> >
> >  PACKAGECONFIG[pcap] = "--with-pcap=linux, --without-pcap, libpcap, libpcap"
> > -PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre"
> > +PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre2"
> >  PACKAGECONFIG[ssl] = "--with-openssl=${STAGING_LIBDIR}/.., --without-openssl, openssl, openssl"
> >  PACKAGECONFIG[ssh2] = "--with-openssh2=${STAGING_LIBDIR}/.., --without-openssh2, libssh2, libssh2"
> >  PACKAGECONFIG[libz] = "--with-libz=${STAGING_LIBDIR}/.., --without-libz, zlib, zlib"
> > --
> > 2.46.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#112233): https://lists.openembedded.org/g/openembedded-devel/message/112233
> > Mute This Topic: https://lists.openembedded.org/mt/108376191/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
Khem Raj Sept. 13, 2024, 6:17 p.m. UTC | #3
its on riscv64/clang19, this combo could be interesting

On Fri, Sep 13, 2024 at 11:04 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Interesting, I was building it fine with lld, will check what libpcre2
> it has in RSS and on cmdline.
>
> On Fri, Sep 13, 2024 at 7:46 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > this exposes an issue, when linking with lld linker ends up with
> >
> > riscv64-yoe-linux-ld.lld: error: unable to find library -lpcre2-8
> >
> > On Tue, Sep 10, 2024 at 7:52 AM Martin Jansa via
> > lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
> > wrote:
> > >
> > > * switched to libpcre2 in:
> > >   https://github.com/nmap/nmap/commit/828ab48764b82d0226e860c73c5dac5b11f77385
> > >
> > > * in builds hwere libpcre2 isn't pulled by some other dependency it was failing with:
> > > | service_scan.h:74:10: fatal error: pcre2.h: No such file or directory                                                                                                                                                                       |    74 | #include <pcre2.h>                                                                                                                                                                                                                  |       |          ^~~~~~~~~|
> > >
> > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > > ---
> > >  meta-oe/recipes-security/nmap/nmap_7.95.bb | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/recipes-security/nmap/nmap_7.95.bb b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > > index d3273dc4e9..79c28e71f0 100644
> > > --- a/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > > +++ b/meta-oe/recipes-security/nmap/nmap_7.95.bb
> > > @@ -17,7 +17,7 @@ inherit autotools-brokensep pkgconfig python3native
> > >  PACKAGECONFIG ?= "pcre ncat nping pcap"
> > >
> > >  PACKAGECONFIG[pcap] = "--with-pcap=linux, --without-pcap, libpcap, libpcap"
> > > -PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre"
> > > +PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre2"
> > >  PACKAGECONFIG[ssl] = "--with-openssl=${STAGING_LIBDIR}/.., --without-openssl, openssl, openssl"
> > >  PACKAGECONFIG[ssh2] = "--with-openssh2=${STAGING_LIBDIR}/.., --without-openssh2, libssh2, libssh2"
> > >  PACKAGECONFIG[libz] = "--with-libz=${STAGING_LIBDIR}/.., --without-libz, zlib, zlib"
> > > --
> > > 2.46.0
> > >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#112233): https://lists.openembedded.org/g/openembedded-devel/message/112233
> > > Mute This Topic: https://lists.openembedded.org/mt/108376191/1997914
> > > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
diff mbox series

Patch

diff --git a/meta-oe/recipes-security/nmap/nmap_7.95.bb b/meta-oe/recipes-security/nmap/nmap_7.95.bb
index d3273dc4e9..79c28e71f0 100644
--- a/meta-oe/recipes-security/nmap/nmap_7.95.bb
+++ b/meta-oe/recipes-security/nmap/nmap_7.95.bb
@@ -17,7 +17,7 @@  inherit autotools-brokensep pkgconfig python3native
 PACKAGECONFIG ?= "pcre ncat nping pcap"
 
 PACKAGECONFIG[pcap] = "--with-pcap=linux, --without-pcap, libpcap, libpcap"
-PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre"
+PACKAGECONFIG[pcre] = "--with-libpcre=${STAGING_LIBDIR}/.., --with-libpcre=included, libpcre2"
 PACKAGECONFIG[ssl] = "--with-openssl=${STAGING_LIBDIR}/.., --without-openssl, openssl, openssl"
 PACKAGECONFIG[ssh2] = "--with-openssh2=${STAGING_LIBDIR}/.., --without-openssh2, libssh2, libssh2"
 PACKAGECONFIG[libz] = "--with-libz=${STAGING_LIBDIR}/.., --without-libz, zlib, zlib"