| Message ID | 20240907083446.80928-1-f_l_k@t-online.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-oe] iwd: use internal ell | expand |
On Sat, Sep 7, 2024 at 1:33 AM Markus Volk via lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org> wrote: > > iwd and ell need to be updated in sync. This is regularly neglected. > Also the fact that they reside in different layers compicates the update process. > yes this has happened in past as well. > Beside iwd, there are not a lot of consumers for ell. > if this is the case then, I would like to suggest that either iwd moves to core or ell moves out of core into meta-oe next to iwd. I think ideally it can be deleted but there might be other consumers of ell outside of meta-openembedded layers and core > Building with internal ell makes iwd updates easier > Building with internal ell is fine if its not generating duplicate copies of ell artifacts. Can you confirm what happens when switching between internal and external ell ? > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > meta-oe/recipes-connectivity/iwd/iwd_2.20.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > index ffdab0260..16d900ddc 100644 > --- a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > +++ b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > @@ -3,7 +3,7 @@ HOMEPAGE = "https://iwd.wiki.kernel.org/" > LICENSE = "LGPL-2.1-only" > LIC_FILES_CHKSUM = "file://COPYING;md5=fb504b67c50331fc78734fed90fb0e09" > > -DEPENDS = "ell" > +DEPENDS = "dbus" > > SRC_URI = "https://www.kernel.org/pub/linux/network/wireless/${BP}.tar.xz \ > file://0001-build-Use-abs_top_srcdir-instead-of-abs_srcdir-for-e.patch \ > @@ -24,8 +24,6 @@ PACKAGECONFIG[wired] = "--enable-wired,--disable-wired" > PACKAGECONFIG[ofono] = "--enable-ofono,--disable-ofono" > PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd-service,systemd" > > -EXTRA_OECONF = "--enable-external-ell" > - > SYSTEMD_SERVICE:${PN} = " \ > iwd.service \ > ${@bb.utils.contains('PACKAGECONFIG', 'wired', 'ead.service', '', d)} \ > -- > 2.46.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#112113): https://lists.openembedded.org/g/openembedded-devel/message/112113 > Mute This Topic: https://lists.openembedded.org/mt/108319324/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
At least ofono in oe-core is using ell by default https://git.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/ofono/ofono_2.10.bb explicitly the external on (from oe-core) since https://git.openembedded.org/openembedded-core/commit/meta/recipes-connectivity/ofono?id=3683f524dc60325b3f3b1bc3a32e70a41064ae03 On Sat, Sep 7, 2024 at 5:24 PM Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > On Sat, Sep 7, 2024 at 1:33 AM Markus Volk via lists.openembedded.org > <f_l_k=t-online.de@lists.openembedded.org> wrote: > > > > iwd and ell need to be updated in sync. This is regularly neglected. > > Also the fact that they reside in different layers compicates the update process. > > > > yes this has happened in past as well. > > > Beside iwd, there are not a lot of consumers for ell. > > > > if this is the case then, I would like to suggest that either iwd moves to core > or ell moves out of core into meta-oe next to iwd. I think ideally it > can be deleted > but there might be other consumers of ell outside of meta-openembedded > layers and core > > > Building with internal ell makes iwd updates easier > > > > Building with internal ell is fine if its not generating duplicate > copies of ell artifacts. Can you confirm what happens when > switching between internal and external ell ? > > > Signed-off-by: Markus Volk <f_l_k@t-online.de> > > --- > > meta-oe/recipes-connectivity/iwd/iwd_2.20.bb | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > > index ffdab0260..16d900ddc 100644 > > --- a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > > +++ b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb > > @@ -3,7 +3,7 @@ HOMEPAGE = "https://iwd.wiki.kernel.org/" > > LICENSE = "LGPL-2.1-only" > > LIC_FILES_CHKSUM = "file://COPYING;md5=fb504b67c50331fc78734fed90fb0e09" > > > > -DEPENDS = "ell" > > +DEPENDS = "dbus" > > > > SRC_URI = "https://www.kernel.org/pub/linux/network/wireless/${BP}.tar.xz \ > > file://0001-build-Use-abs_top_srcdir-instead-of-abs_srcdir-for-e.patch \ > > @@ -24,8 +24,6 @@ PACKAGECONFIG[wired] = "--enable-wired,--disable-wired" > > PACKAGECONFIG[ofono] = "--enable-ofono,--disable-ofono" > > PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd-service,systemd" > > > > -EXTRA_OECONF = "--enable-external-ell" > > - > > SYSTEMD_SERVICE:${PN} = " \ > > iwd.service \ > > ${@bb.utils.contains('PACKAGECONFIG', 'wired', 'ead.service', '', d)} \ > > -- > > 2.46.0 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#112114): https://lists.openembedded.org/g/openembedded-devel/message/112114 > Mute This Topic: https://lists.openembedded.org/mt/108319324/3617156 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Sat, Sep 7 2024 at 05:44:19 PM +02:00:00, Martin Jansa <martin.jansa@gmail.com> wrote: > explicitly the external on (from oe-core) since > <https://git.openembedded.org/openembedded-core/commit/meta/recipes-connectivity/ofono?id=3683f524dc60325b3f3b1bc3a32e70a41064ae03> Understand. I also know that bluez5 uses ell when PACKAGECONFIG is enabled for either mesh or btpclient. But that's not the default. So for consistency, maybe it would be good to keep it external for all three? I'm not sure about this change either, but wanted to bring it up for discussion because it always feels a bit like groundhog day with iwd/ell. I'm not that familiar with investigating sstate cache reuse issues. I'm willing to learn more about it, but right now I don't know what exact files I would need to compare, or is there something like a tool that can be used for this purpose?
On Sat, Sep 7, 2024 at 11:22 AM Markus Volk <f_l_k@t-online.de> wrote: > > On Sat, Sep 7 2024 at 05:44:19 PM +02:00:00, Martin Jansa <martin.jansa@gmail.com> wrote: > > explicitly the external on (from oe-core) since https://git.openembedded.org/openembedded-core/commit/meta/recipes-connectivity/ofono?id=3683f524dc60325b3f3b1bc3a32e70a41064ae03 > > > Understand. I also know that bluez5 uses ell when PACKAGECONFIG is enabled for either mesh or btpclient. But that's not the default. So for consistency, maybe it would be good to keep it external for all three? > > I'm not sure about this change either, but wanted to bring it up for discussion because it always feels a bit like groundhog day with iwd/ell. > > I'm not that familiar with investigating sstate cache reuse issues. I'm willing to learn more about it, but right now I don't know what exact files I would need to compare, or is there something like a tool that can be used for this purpose? I think ell is in core layer therefore it binds us to the compatible versions we can use for packages which uses ell. It also depends upon how upstream is expecting distros to consume it. If they think that it should be vendored in apps then thats what we should do
On Sat, Sep 7 2024 at 12:56:04 PM -07:00:00, Khem Raj <raj.khem@gmail.com> wrote: > If they think that > it should be vendored in apps then thats what we should do By default, all three known recipes that use ell are probably vendored by default. The --enable-external-ell option is set in the recipe for all of them.
diff --git a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb index ffdab0260..16d900ddc 100644 --- a/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb +++ b/meta-oe/recipes-connectivity/iwd/iwd_2.20.bb @@ -3,7 +3,7 @@ HOMEPAGE = "https://iwd.wiki.kernel.org/" LICENSE = "LGPL-2.1-only" LIC_FILES_CHKSUM = "file://COPYING;md5=fb504b67c50331fc78734fed90fb0e09" -DEPENDS = "ell" +DEPENDS = "dbus" SRC_URI = "https://www.kernel.org/pub/linux/network/wireless/${BP}.tar.xz \ file://0001-build-Use-abs_top_srcdir-instead-of-abs_srcdir-for-e.patch \ @@ -24,8 +24,6 @@ PACKAGECONFIG[wired] = "--enable-wired,--disable-wired" PACKAGECONFIG[ofono] = "--enable-ofono,--disable-ofono" PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd-service,systemd" -EXTRA_OECONF = "--enable-external-ell" - SYSTEMD_SERVICE:${PN} = " \ iwd.service \ ${@bb.utils.contains('PACKAGECONFIG', 'wired', 'ead.service', '', d)} \
iwd and ell need to be updated in sync. This is regularly neglected. Also the fact that they reside in different layers compicates the update process. Beside iwd, there are not a lot of consumers for ell. Building with internal ell makes iwd updates easier Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta-oe/recipes-connectivity/iwd/iwd_2.20.bb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)