diff mbox series

[kirkstone] glib-2.0: Remove gvariant byteswap test

Message ID 20240903133828.3762-1-mail2szahir@gmail.com
State Changes Requested
Headers show
Series [kirkstone] glib-2.0: Remove gvariant byteswap test | expand

Commit Message

aszh07 Sept. 3, 2024, 1:38 p.m. UTC
As byteswap has some issue sporadically, remove the byteswap
completely from gvariant. When run in QEMU, could see the
below failure sporadically

Executing: glib/gvariant.test
Executing: glib/gvariant.test
Test timed out after 300 seconds
FAIL: glib/gvariant.test (Child process killed by signal 9)

Until issue is fixed removing byteswap test
from gvariant to increase stability.

Signed-off-by: Zahir Hussain <mail2szahir@gmail.com>
---
 ...ib-2.0-Remove-gvariant-byteswap-test.patch | 45 +++++++++++++++++++
 meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb |  1 +
 2 files changed, 46 insertions(+)
 create mode 100644 meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch

Comments

patchtest@automation.yoctoproject.org Sept. 3, 2024, 1:48 p.m. UTC | #1
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/kirkstone-glib-2.0-Remove-gvariant-byteswap-test.patch

FAIL: test Upstream-Status presence: Added patch file is missing Upstream-Status: <Valid status> in the commit message (test_patch.TestPatch.test_upstream_status_presence_format)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!
Alexander Kanavin Sept. 3, 2024, 2:10 p.m. UTC | #2
Is this seen on the yocto autobuilder, or only in your private testing?

Also, how would we know that the issue is fixed, and this patch can be removed?

Alex

On Tue, 3 Sept 2024 at 15:38, aszh07 via lists.openembedded.org
<mail2szahir=gmail.com@lists.openembedded.org> wrote:
>
> As byteswap has some issue sporadically, remove the byteswap
> completely from gvariant. When run in QEMU, could see the
> below failure sporadically
>
> Executing: glib/gvariant.test
> Executing: glib/gvariant.test
> Test timed out after 300 seconds
> FAIL: glib/gvariant.test (Child process killed by signal 9)
>
> Until issue is fixed removing byteswap test
> from gvariant to increase stability.
>
> Signed-off-by: Zahir Hussain <mail2szahir@gmail.com>
> ---
>  ...ib-2.0-Remove-gvariant-byteswap-test.patch | 45 +++++++++++++++++++
>  meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb |  1 +
>  2 files changed, 46 insertions(+)
>  create mode 100644 meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch b/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch
> new file mode 100644
> index 0000000000..4cefd2e522
> --- /dev/null
> +++ b/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch
> @@ -0,0 +1,45 @@
> +From f4c529805aed5ee92b8d7d729cfa501be5835d7e Mon Sep 17 00:00:00 2001
> +From: aszh07 <mail2szahir@gmail.com>
> +Date: Mon, 29 Jul 2024 16:19:10 +0530
> +Subject: [PATCH] glib-2.0: Remove gvariant byteswap test
> +
> +As byteswap has some issue sporadically, remove the byteswap
> +completely from gvariant. When run in QEMU, could see the
> +below failure sporadically,
> +
> +Executing: glib/gvariant.test
> +Executing: glib/gvariant.test
> +Test timed out after 300 seconds
> +FAIL: glib/gvariant.test (Child process killed by signal 9)
> +
> +Until issue is fixed removing byteswap test
> +from gvariant to increase stability.
> +
> +Signed-off-by: Zahir Hussain <mail2szahir@gmail.com>
> +---
> + glib/tests/gvariant.c | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/glib/tests/gvariant.c b/glib/tests/gvariant.c
> +index 939f073..a25a4a4 100644
> +--- a/glib/tests/gvariant.c
> ++++ b/glib/tests/gvariant.c
> +@@ -5656,7 +5656,6 @@ main (int argc, char **argv)
> +   g_test_add_func ("/gvariant/serialiser/tuple", test_tuples);
> +   g_test_add_func ("/gvariant/serialiser/variant", test_variants);
> +   g_test_add_func ("/gvariant/serialiser/strings", test_strings);
> +-  g_test_add_func ("/gvariant/serialiser/byteswap", test_byteswaps);
> +   g_test_add_func ("/gvariant/serialiser/children", test_serialiser_children);
> +
> +   for (i = 1; i <= 20; i += 4)
> +@@ -5679,7 +5678,6 @@ main (int argc, char **argv)
> +   g_test_add_func ("/gvariant/valist", test_valist);
> +   g_test_add_func ("/gvariant/builder-memory", test_builder_memory);
> +   g_test_add_func ("/gvariant/hashing", test_hashing);
> +-  g_test_add_func ("/gvariant/byteswap", test_gv_byteswap);
> +   g_test_add_func ("/gvariant/byteswap/non-normal-non-aligned", test_gv_byteswap_non_normal_non_aligned);
> +   g_test_add_func ("/gvariant/parser", test_parses);
> +   g_test_add_func ("/gvariant/parser/integer-bounds", test_parser_integer_bounds);
> +--
> +2.17.1
> +
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
> index 35b51a3ec9..3beb324383 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
> @@ -49,6 +49,7 @@ SRC_URI = "${GNOME_MIRROR}/glib/${SHRT_VER}/glib-${PV}.tar.xz \
>             file://CVE-2024-34397_16.patch \
>             file://CVE-2024-34397_17.patch \
>             file://CVE-2024-34397_18.patch \
> +           file://0001-glib-2.0-Remove-gvariant-byteswap-test.patch \
>             "
>  SRC_URI:append:class-native = " file://relocate-modules.patch"
>
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#204163): https://lists.openembedded.org/g/openembedded-core/message/204163
> Mute This Topic: https://lists.openembedded.org/mt/108244763/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch b/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch
new file mode 100644
index 0000000000..4cefd2e522
--- /dev/null
+++ b/meta/recipes-core/glib-2.0/glib-2.0/0001-glib-2.0-Remove-gvariant-byteswap-test.patch
@@ -0,0 +1,45 @@ 
+From f4c529805aed5ee92b8d7d729cfa501be5835d7e Mon Sep 17 00:00:00 2001
+From: aszh07 <mail2szahir@gmail.com>
+Date: Mon, 29 Jul 2024 16:19:10 +0530
+Subject: [PATCH] glib-2.0: Remove gvariant byteswap test
+
+As byteswap has some issue sporadically, remove the byteswap
+completely from gvariant. When run in QEMU, could see the
+below failure sporadically,
+
+Executing: glib/gvariant.test
+Executing: glib/gvariant.test
+Test timed out after 300 seconds
+FAIL: glib/gvariant.test (Child process killed by signal 9)
+
+Until issue is fixed removing byteswap test 
+from gvariant to increase stability.
+
+Signed-off-by: Zahir Hussain <mail2szahir@gmail.com>
+---
+ glib/tests/gvariant.c | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/glib/tests/gvariant.c b/glib/tests/gvariant.c
+index 939f073..a25a4a4 100644
+--- a/glib/tests/gvariant.c
++++ b/glib/tests/gvariant.c
+@@ -5656,7 +5656,6 @@ main (int argc, char **argv)
+   g_test_add_func ("/gvariant/serialiser/tuple", test_tuples);
+   g_test_add_func ("/gvariant/serialiser/variant", test_variants);
+   g_test_add_func ("/gvariant/serialiser/strings", test_strings);
+-  g_test_add_func ("/gvariant/serialiser/byteswap", test_byteswaps);
+   g_test_add_func ("/gvariant/serialiser/children", test_serialiser_children);
+ 
+   for (i = 1; i <= 20; i += 4)
+@@ -5679,7 +5678,6 @@ main (int argc, char **argv)
+   g_test_add_func ("/gvariant/valist", test_valist);
+   g_test_add_func ("/gvariant/builder-memory", test_builder_memory);
+   g_test_add_func ("/gvariant/hashing", test_hashing);
+-  g_test_add_func ("/gvariant/byteswap", test_gv_byteswap);
+   g_test_add_func ("/gvariant/byteswap/non-normal-non-aligned", test_gv_byteswap_non_normal_non_aligned);
+   g_test_add_func ("/gvariant/parser", test_parses);
+   g_test_add_func ("/gvariant/parser/integer-bounds", test_parser_integer_bounds);
+-- 
+2.17.1
+
diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
index 35b51a3ec9..3beb324383 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
+++ b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
@@ -49,6 +49,7 @@  SRC_URI = "${GNOME_MIRROR}/glib/${SHRT_VER}/glib-${PV}.tar.xz \
            file://CVE-2024-34397_16.patch \
            file://CVE-2024-34397_17.patch \
            file://CVE-2024-34397_18.patch \
+           file://0001-glib-2.0-Remove-gvariant-byteswap-test.patch \
            "
 SRC_URI:append:class-native = " file://relocate-modules.patch"