| Message ID | 20240831130113.34867-1-niko.mauno@vaisala.com |
|---|---|
| State | New |
| Headers | show |
| Series | icu: Fix 'buildpaths' QA error | expand |
On Sat, 2024-08-31 at 16:01 +0300, Niko Mauno via lists.openembedded.org wrote: > Add stripping of STAGING_DIR_NATIVE during target/nativesdk specific > do_install, which mitigates following BitBake failure: > > ERROR: icu-75-1-r0 do_package_qa: QA Issue: File > /usr/lib/icu/75.1/pkgdata.inc in package icu-dev contains reference > to TMPDIR [buildpaths] > ERROR: icu-75-1-r0 do_package_qa: Fatal QA errors were found, > failing task. > > While doing so, we also drop HOSTTOOLS_DIR stripping, as it's value > does not appear in the content of either file that are manipulated > here. > > Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> > --- > meta/recipes-support/icu/icu_75-1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why aren't we seeing this issue in automated test? Cheers, Richard
On 9/1/24 13:55, Richard Purdie wrote: > On Sat, 2024-08-31 at 16:01 +0300, Niko Mauno via > lists.openembedded.org wrote: >> Add stripping of STAGING_DIR_NATIVE during target/nativesdk specific >> do_install, which mitigates following BitBake failure: >> >> ERROR: icu-75-1-r0 do_package_qa: QA Issue: File >> /usr/lib/icu/75.1/pkgdata.inc in package icu-dev contains reference >> to TMPDIR [buildpaths] >> ERROR: icu-75-1-r0 do_package_qa: Fatal QA errors were found, >> failing task. >> >> While doing so, we also drop HOSTTOOLS_DIR stripping, as it's value >> does not appear in the content of either file that are manipulated >> here. >> >> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> >> --- >> meta/recipes-support/icu/icu_75-1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Why aren't we seeing this issue in automated test? I should have known better, in a new workspace I was unable to reproduce to issue. Apologies for the noise. -Niko
diff --git a/meta/recipes-support/icu/icu_75-1.bb b/meta/recipes-support/icu/icu_75-1.bb index 8f7f5e6cc7..9922469672 100644 --- a/meta/recipes-support/icu/icu_75-1.bb +++ b/meta/recipes-support/icu/icu_75-1.bb @@ -60,7 +60,7 @@ remove_build_host_references() { sed -i \ -e 's,--sysroot=${STAGING_DIR_TARGET},,g' \ -e 's|${DEBUG_PREFIX_MAP}||g' \ - -e 's:${HOSTTOOLS_DIR}/::g' \ + -e 's:${STAGING_DIR_NATIVE}::g' \ ${D}/${libdir}/${BPN}/${@icu_install_folder(d)}/Makefile.inc \ ${D}/${libdir}/${BPN}/${@icu_install_folder(d)}/pkgdata.inc }
Add stripping of STAGING_DIR_NATIVE during target/nativesdk specific do_install, which mitigates following BitBake failure: ERROR: icu-75-1-r0 do_package_qa: QA Issue: File /usr/lib/icu/75.1/pkgdata.inc in package icu-dev contains reference to TMPDIR [buildpaths] ERROR: icu-75-1-r0 do_package_qa: Fatal QA errors were found, failing task. While doing so, we also drop HOSTTOOLS_DIR stripping, as it's value does not appear in the content of either file that are manipulated here. Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> --- meta/recipes-support/icu/icu_75-1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)