diff mbox series

[v2,14/14] qemuarm64-secureboot.yml: Set branch to scarthgap

Message ID 20240819190429.2897888-15-javier.tia@linaro.org
State New
Headers show
Series qemuarm64-secureboot: Add UEFI Secure Boot | expand

Commit Message

Javier Tia Aug. 19, 2024, 7:04 p.m. UTC
UEFI Secure Boot is broken in master. Set to the latest stable OE
branch.

Signed-off-by: Javier Tia <javier.tia@linaro.org>
---
 ci/qemuarm64-secureboot.yml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mikko Rapeli Aug. 21, 2024, 7:02 a.m. UTC | #1
Hi,

On Mon, Aug 19, 2024 at 01:04:29PM -0600, Javier Tia wrote:
> UEFI Secure Boot is broken in master. Set to the latest stable OE
> branch.

What exactly is broken on master? On my build with this series
everything worked with master commits:

poky 39de8c65492a8b84494abc3f890744f89af70a36
meta-arm c965cf722f684acfbefa5a6509d36c0478a7a48f
meta-openembedded ec936d6893b95a6c191c324ff2448444ac56d6dc
meta-secure-core ae48c2372a346eee842e94e0a230944977bc5293

$ kas build ci/qemuarm64-secureboot.yml:ci/sstate-mirror.yml:ci/testimage.yml
...
2024-08-21 07:45:38 - INFO     - RESULTS:
2024-08-21 07:45:38 - INFO     - RESULTS - ftpm.FtpmTestSuite.test_ftpm: PASSED (65.68s)
2024-08-21 07:45:38 - INFO     - RESULTS - optee.OpteeTestSuite.test_opteetest_xtest: PASSED (458.00s)
2024-08-21 07:45:38 - INFO     - RESULTS - uefi_secure_boot.UEFI_SB_TestSuite.test_uefi_secure_boot: PASSED (0.78s)
2024-08-21 07:45:38 - INFO     - RESULTS - date.DateTest.test_date: PASSED (11.95s)
2024-08-21 07:45:38 - INFO     - RESULTS - df.DfTest.test_df: PASSED (0.78s)
2024-08-21 07:45:38 - INFO     - RESULTS - oe_syslog.SyslogTest.test_syslog_running: PASSED (0.81s)
2024-08-21 07:45:38 - INFO     - RESULTS - oe_syslog.SyslogTestConfig.test_syslog_logger: PASSED (2.37s)
2024-08-21 07:45:38 - INFO     - RESULTS - oe_syslog.SyslogTestConfig.test_syslog_restart: PASSED (1.50s)
2024-08-21 07:45:38 - INFO     - RESULTS - parselogs.ParseLogsTest.test_get_context: PASSED (0.00s)
2024-08-21 07:45:38 - INFO     - RESULTS - parselogs.ParseLogsTest.test_parselogs: PASSED (4.23s)
2024-08-21 07:45:38 - INFO     - RESULTS - ping.PingTest.test_ping: PASSED (0.05s)
2024-08-21 07:45:38 - INFO     - RESULTS - scp.ScpTest.test_scp_file: PASSED (1.88s)
2024-08-21 07:45:38 - INFO     - RESULTS - ssh.SSHTest.test_ssh: PASSED (0.73s)
2024-08-21 07:45:38 - INFO     - RESULTS - systemd.SystemdBasicTests.test_systemd_basic: PASSED (0.72s)
2024-08-21 07:45:38 - INFO     - RESULTS - systemd.SystemdBasicTests.test_systemd_failed: PASSED (1.64s)
2024-08-21 07:45:38 - INFO     - RESULTS - systemd.SystemdBasicTests.test_systemd_list: PASSED (5.84s)
2024-08-21 07:45:38 - INFO     - RESULTS - systemd.SystemdJournalTests.test_systemd_boot_time: PASSED (0.81s)
2024-08-21 07:45:38 - INFO     - RESULTS - systemd.SystemdJournalTests.test_systemd_journal: PASSED (0.97s)
2024-08-21 07:45:38 - INFO     - RESULTS - apt.AptRepoTest.test_apt_install_from_repo: SKIPPED (0.00s)
...
2024-08-21 07:45:38 - INFO     - SUMMARY:
2024-08-21 07:45:38 - INFO     - core-image-base () - Ran 75 tests in 561.638s
2024-08-21 07:45:38 - INFO     - core-image-base - OK - All required tests passed (successes=18, skipped=57, failures=0, errors=0)
2024-08-21 07:45:38 - INFO     - NOTE: recipe core-image-base-1.0-r0: task do_testimage: Succeeded

Cheers,

-Mikko
Jon Mason Aug. 21, 2024, 2:35 p.m. UTC | #2
On Mon, Aug 19, 2024 at 01:04:29PM -0600, Javier Tia wrote:
> UEFI Secure Boot is broken in master. Set to the latest stable OE
> branch.
> 
> Signed-off-by: Javier Tia <javier.tia@linaro.org>
> ---
>  ci/qemuarm64-secureboot.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/ci/qemuarm64-secureboot.yml b/ci/qemuarm64-secureboot.yml
> index 02341934..cadbe874 100644
> --- a/ci/qemuarm64-secureboot.yml
> +++ b/ci/qemuarm64-secureboot.yml
> @@ -1,5 +1,9 @@
>  # yaml-language-server: $schema=https://raw.githubusercontent.com/siemens/kas/master/kas/schema-kas.json
>  
> +defaults:
> + repos:
> +    branch: scarthgap

Please don't do this.  If it's broken in edk2 then hold back the
version for qemuarm64-secureboot in a bbappend.  And if this was the
right thing to do (which it isn't), it needs a comment saying why it's
being done here.  Lastly, this fails CI majorly (in every instance of
qemuarm64-secureboot).  One example,
https://gitlab.com/jonmason00/meta-arm/-/jobs/7627395767

Thanks,
Jon

> +
>  header:
>    version: 14
>    includes:
> -- 
> 2.46.0
> 
>
Javier Tia Aug. 22, 2024, 1:43 a.m. UTC | #3
On 8/21/24 1:02 AM, Mikko Rapeli wrote:
> Hi,
> 
> On Mon, Aug 19, 2024 at 01:04:29PM -0600, Javier Tia wrote:
>> UEFI Secure Boot is broken in master. Set to the latest stable OE 
>> branch.
> 
> What exactly is broken on master? On my build with this series 
> everything worked with master commits:

Every time I tried to boot the kernel, I was getting an authentication error. However, after clearing out all repos and cloning them, that is no longer the case. Perhaps there was an upstream problem that was resolved.

$ kas build ci/qemuarm64-secureboot.yml:ci/sstate-mirror.yml:ci/testimage.yml
...
2024-08-21 19:24:11 - INFO     - Repository poky checked out to 94993b0ef4d670cbfee517b703e356de461078a9
2024-08-21 19:24:11 - INFO     - Repository meta-openembedded checked out to fc0264f0fd424e18c364d18cbce69eae386c8995
2024-08-21 19:24:11 - INFO     - Repository meta-secure-core checked out to ae48c2372a346eee842e94e0a230944977bc5293
...
SUMMARY:
core-image-base () - Ran 73 tests in 21.193s
core-image-base - OK - All required tests passed (successes=16, skipped=57, failures=0, errors=0)
NOTE: Tasks Summary: Attempted 4266 tasks of which 3983 didn't need to be rerun and all succeeded.


Thanks,

» Javier Tia 
Javier Tia Aug. 22, 2024, 1:43 a.m. UTC | #4
On 8/21/24 8:35 AM, Jon Mason wrote:
> On Mon, Aug 19, 2024 at 01:04:29PM -0600, Javier Tia wrote:
>> diff --git a/ci/qemuarm64-secureboot.yml b/ci/qemuarm64-secureboot.yml
>> index 02341934..cadbe874 100644
>> --- a/ci/qemuarm64-secureboot.yml
>> +++ b/ci/qemuarm64-secureboot.yml
>> @@ -1,5 +1,9 @@
>>   # yaml-language-server: $schema=https://raw.githubusercontent.com/siemens/kas/master/kas/schema-kas.json
>>   
>> +defaults:
>> + repos:
>> +    branch: scarthgap
> 
> Please don't do this.  If it's broken in edk2 then hold back the
> version for qemuarm64-secureboot in a bbappend.  And if this was the
> right thing to do (which it isn't), it needs a comment saying why it's
> being done here.  Lastly, this fails CI majorly (in every instance of
> qemuarm64-secureboot).  One example,
> https://gitlab.com/jonmason00/meta-arm/-/jobs/7627395767
> 

Sure, I have removed the last commit hard-coding the branch. It's using master by default and passing the tests. Sending patch series v3.

Thanks,

» Javier Tia 
diff mbox series

Patch

diff --git a/ci/qemuarm64-secureboot.yml b/ci/qemuarm64-secureboot.yml
index 02341934..cadbe874 100644
--- a/ci/qemuarm64-secureboot.yml
+++ b/ci/qemuarm64-secureboot.yml
@@ -1,5 +1,9 @@ 
 # yaml-language-server: $schema=https://raw.githubusercontent.com/siemens/kas/master/kas/schema-kas.json
 
+defaults:
+ repos:
+    branch: scarthgap
+
 header:
   version: 14
   includes: