diff mbox series

Util-linux: Adding missing ptest dependencies

Message ID 20240819145140.582935-1-aoifepowerIris@gmail.com
State New
Headers show
Series Util-linux: Adding missing ptest dependencies | expand

Commit Message

Aoife Power Aug. 19, 2024, 2:51 p.m. UTC
Missing adduser and eudev to RDEPENDS dependencies for ptest

Signed-off-by: Aoife Power <aoifepowerIris@gmail.com>
---
 meta/recipes-core/util-linux/util-linux_2.40.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aoife Power Aug. 19, 2024, 2:54 p.m. UTC | #1
Note: with ptests the adduser package is only avaliable in the
meta-openembedded/meta-perl layer.
Does this need to be included elsewhere for the ptest use case?  Should it
be added to the core layer to allow the ptests to work correctly?
Thanks,
Aoife

On Mon, Aug 19, 2024 at 4:52 PM Aoife Power <aoifepoweriris@gmail.com>
wrote:

> Missing adduser and eudev to RDEPENDS dependencies for ptest
>
> Signed-off-by: Aoife Power <aoifepowerIris@gmail.com>
> ---
>  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> index a1aab94055..f1c200c28b 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> @@ -139,7 +139,7 @@ RDEPENDS:${PN}-dev += " util-linux-libuuid-dev"
>  RPROVIDES:${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev"
>
>  RDEPENDS:${PN}-bash-completion += "${PN}-lsblk"
> -RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs
> findutils grep iproute2 kmod procps sed socat which xz diffutils"
> +RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs
> findutils grep iproute2 kmod procps sed socat which xz diffutils adduser
> eudev"
>  RRECOMMENDS:${PN}-ptest += "kernel-module-scsi-debug kernel-module-sd-mod
> kernel-module-loop kernel-module-algif-hash"
>  RDEPENDS:${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff"
>  ALLOW_EMPTY:${PN}-swaponoff = "1"
> --
> 2.46.0
>
>
Alexander Kanavin Aug. 19, 2024, 3:34 p.m. UTC | #2
What the failures you are seeing actually are? We do run util-linux
ptest on the autobuilder, and it isn't failing. Is it different for
you?

Alex

On Mon, 19 Aug 2024 at 16:55, Aoife Power via lists.openembedded.org
<aoifepowerIris=gmail.com@lists.openembedded.org> wrote:
>
> Note: with ptests the adduser package is only avaliable in the meta-openembedded/meta-perl layer.
> Does this need to be included elsewhere for the ptest use case?  Should it be added to the core layer to allow the ptests to work correctly?
> Thanks,
> Aoife
>
> On Mon, Aug 19, 2024 at 4:52 PM Aoife Power <aoifepoweriris@gmail.com> wrote:
>>
>> Missing adduser and eudev to RDEPENDS dependencies for ptest
>>
>> Signed-off-by: Aoife Power <aoifepowerIris@gmail.com>
>> ---
>>  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>> index a1aab94055..f1c200c28b 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>> @@ -139,7 +139,7 @@ RDEPENDS:${PN}-dev += " util-linux-libuuid-dev"
>>  RPROVIDES:${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev"
>>
>>  RDEPENDS:${PN}-bash-completion += "${PN}-lsblk"
>> -RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils"
>> +RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils adduser eudev"
>>  RRECOMMENDS:${PN}-ptest += "kernel-module-scsi-debug kernel-module-sd-mod kernel-module-loop kernel-module-algif-hash"
>>  RDEPENDS:${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff"
>>  ALLOW_EMPTY:${PN}-swaponoff = "1"
>> --
>> 2.46.0
>>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#203509): https://lists.openembedded.org/g/openembedded-core/message/203509
> Mute This Topic: https://lists.openembedded.org/mt/107982088/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jasper Orschulko Aug. 20, 2024, 12:39 p.m. UTC | #3
Hi Alex,

please ignore the previous patch. There is still stuff that we need to figure out internally, due to miscommunication. We will submit a v2 of the patch if required. Thanks and sorry for the inconvenience. :)

Cheers,
Jasper

On 19 August 2024 17:34:00 CEST, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
>What the failures you are seeing actually are? We do run util-linux
>ptest on the autobuilder, and it isn't failing. Is it different for
>you?
>
>Alex
>
>On Mon, 19 Aug 2024 at 16:55, Aoife Power via lists.openembedded.org
><aoifepowerIris=gmail.com@lists.openembedded.org> wrote:
>>
>> Note: with ptests the adduser package is only avaliable in the meta-openembedded/meta-perl layer.
>> Does this need to be included elsewhere for the ptest use case?  Should it be added to the core layer to allow the ptests to work correctly?
>> Thanks,
>> Aoife
>>
>> On Mon, Aug 19, 2024 at 4:52 PM Aoife Power <aoifepoweriris@gmail.com> wrote:
>>>
>>> Missing adduser and eudev to RDEPENDS dependencies for ptest
>>>
>>> Signed-off-by: Aoife Power <aoifepowerIris@gmail.com>
>>> ---
>>>  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>>> index a1aab94055..f1c200c28b 100644
>>> --- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>>> +++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
>>> @@ -139,7 +139,7 @@ RDEPENDS:${PN}-dev += " util-linux-libuuid-dev"
>>>  RPROVIDES:${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev"
>>>
>>>  RDEPENDS:${PN}-bash-completion += "${PN}-lsblk"
>>> -RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils"
>>> +RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils adduser eudev"
>>>  RRECOMMENDS:${PN}-ptest += "kernel-module-scsi-debug kernel-module-sd-mod kernel-module-loop kernel-module-algif-hash"
>>>  RDEPENDS:${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff"
>>>  ALLOW_EMPTY:${PN}-swaponoff = "1"
>>> --
>>> 2.46.0
>>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#203509): https://lists.openembedded.org/g/openembedded-core/message/203509
>> Mute This Topic: https://lists.openembedded.org/mt/107982088/1686489
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
index a1aab94055..f1c200c28b 100644
--- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
@@ -139,7 +139,7 @@  RDEPENDS:${PN}-dev += " util-linux-libuuid-dev"
 RPROVIDES:${PN}-dev = "${PN}-libblkid-dev ${PN}-libmount-dev"
 
 RDEPENDS:${PN}-bash-completion += "${PN}-lsblk"
-RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils"
+RDEPENDS:${PN}-ptest += "bash bc btrfs-tools coreutils e2fsprogs findutils grep iproute2 kmod procps sed socat which xz diffutils adduser eudev"
 RRECOMMENDS:${PN}-ptest += "kernel-module-scsi-debug kernel-module-sd-mod kernel-module-loop kernel-module-algif-hash"
 RDEPENDS:${PN}-swaponoff = "${PN}-swapon ${PN}-swapoff"
 ALLOW_EMPTY:${PN}-swaponoff = "1"