diff mbox series

[meta-networking,2/5] fwknop: Specify target locations of gpg and wget

Message ID 20240818225620.2226473-2-raj.khem@gmail.com
State New
Headers show
Series [meta-networking,1/5] fwknop: Upgrade to 2.6.11 | expand

Commit Message

Khem Raj Aug. 18, 2024, 10:56 p.m. UTC
This fixes emitting buildpaths into binary and also
fixes the issue where these tools wont exist on
the paths they were found on build machine

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Peter Kjellerstedt Aug. 19, 2024, 3:33 p.m. UTC | #1
> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Khem Raj
> Sent: den 19 augusti 2024 00:56
> To: openembedded-devel@lists.openembedded.org
> Cc: Khem Raj <raj.khem@gmail.com>
> Subject: [oe] [meta-networking][PATCH 2/5] fwknop: Specify target locations of gpg and wget
> 
> This fixes emitting buildpaths into binary and also
> fixes the issue where these tools wont exist on
> the paths they were found on build machine
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> index c9f9596eb4..0e7998b6dc 100644
> --- a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> +++ b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> @@ -12,7 +12,9 @@ SRC_URI[sha256sum] = "a4ec7c22dd90dd684f9f7b96d3a901c4131ec8c7a3b9db26d0428513f6
> 
>  DEPENDS = "libpcap gpgme"
> 
> -EXTRA_OECONF = " --with-iptables=${sbindir}/iptables"
> +EXTRA_OECONF = "--with-iptables=${sbindir}/iptables \
> +				--with-gpg=${bindir}/gpg \
> +				--with-wget=${base_bindir}/wget"

Do you happen to have tabs configured to be four spaces wide?
Please use spaces instead for alignment since the above looks 
weird with 8-character tabs.

> 
>  do_configure:prepend () {
>  	install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess ${S}/config

//Peter
Khem Raj Aug. 19, 2024, 3:36 p.m. UTC | #2
On Mon, Aug 19, 2024 at 8:33 AM Peter Kjellerstedt <
peter.kjellerstedt@axis.com> wrote:

> > -----Original Message-----
> > From: openembedded-devel@lists.openembedded.org <
> openembedded-devel@lists.openembedded.org> On Behalf Of Khem Raj
> > Sent: den 19 augusti 2024 00:56
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Khem Raj <raj.khem@gmail.com>
> > Subject: [oe] [meta-networking][PATCH 2/5] fwknop: Specify target
> locations of gpg and wget
> >
> > This fixes emitting buildpaths into binary and also
> > fixes the issue where these tools wont exist on
> > the paths they were found on build machine
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> > index c9f9596eb4..0e7998b6dc 100644
> > --- a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> > +++ b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
> > @@ -12,7 +12,9 @@ SRC_URI[sha256sum] =
> "a4ec7c22dd90dd684f9f7b96d3a901c4131ec8c7a3b9db26d0428513f6
> >
> >  DEPENDS = "libpcap gpgme"
> >
> > -EXTRA_OECONF = " --with-iptables=${sbindir}/iptables"
> > +EXTRA_OECONF = "--with-iptables=${sbindir}/iptables \
> > +                             --with-gpg=${bindir}/gpg \
> > +                             --with-wget=${base_bindir}/wget"
>
> Do you happen to have tabs configured to be four spaces wide?
> Please use spaces instead for alignment since the above looks
> weird with 8-character tabs.


It was a different editor than usual thanks for noting


>
> >
> >  do_configure:prepend () {
> >       install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess
> ${S}/config
>
> //Peter
>
>
diff mbox series

Patch

diff --git a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
index c9f9596eb4..0e7998b6dc 100644
--- a/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
+++ b/meta-networking/recipes-support/fwknop/fwknop_2.6.11.bb
@@ -12,7 +12,9 @@  SRC_URI[sha256sum] = "a4ec7c22dd90dd684f9f7b96d3a901c4131ec8c7a3b9db26d0428513f6
 
 DEPENDS = "libpcap gpgme"
 
-EXTRA_OECONF = " --with-iptables=${sbindir}/iptables"
+EXTRA_OECONF = "--with-iptables=${sbindir}/iptables \
+				--with-gpg=${bindir}/gpg \
+				--with-wget=${base_bindir}/wget"
 
 do_configure:prepend () {
 	install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess ${S}/config