diff mbox series

[meta-networking] blueman: Fix do_package QA issue

Message ID 20240808191119.158166-1-alperyasinak1@gmail.com
State Accepted
Headers show
Series [meta-networking] blueman: Fix do_package QA issue | expand

Commit Message

alperak Aug. 8, 2024, 7:11 p.m. UTC
ERROR: blueman-2.4.3-r0 do_package: QA Issue: blueman: Files/directories were installed but not shipped in any package:
  /usr/lib/systemd/system
  /usr/lib/systemd/system/blueman-mechanism.service
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
blueman: 2 installed and not shipped files. [installed-vs-shipped]
ERROR: blueman-2.4.3-r0 do_package: Fatal QA errors were found, failing task.

Signed-off-by: alperak <alperyasinak1@gmail.com>
---
 meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Jansa Aug. 19, 2024, 11:14 a.m. UTC | #1
Doesn't this just hide the issue that the systemd service file is
installed in wrong directory?

with current master I'm seeing:
ERROR: Didn't find service unit 'blueman-mechanism.service', specified
in SYSTEMD_SERVICE:blueman.

On Thu, Aug 8, 2024 at 9:11 PM Alper Ak via lists.openembedded.org
<alperyasinak1=gmail.com@lists.openembedded.org> wrote:
>
> ERROR: blueman-2.4.3-r0 do_package: QA Issue: blueman: Files/directories were installed but not shipped in any package:
>   /usr/lib/systemd/system
>   /usr/lib/systemd/system/blueman-mechanism.service
> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> blueman: 2 installed and not shipped files. [installed-vs-shipped]
> ERROR: blueman-2.4.3-r0 do_package: Fatal QA errors were found, failing task.
>
> Signed-off-by: alperak <alperyasinak1@gmail.com>
> ---
>  meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> index 5aa3b2bd5..df2a226f0 100644
> --- a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> +++ b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> @@ -40,6 +40,7 @@ FILES:${PN} += " \
>      ${datadir} \
>      ${systemd_user_unitdir} \
>      ${PYTHON_SITEPACKAGES_DIR} \
> +    ${prefix}${systemd_system_unitdir} \
>  "
>
>  # In code, path to python is a variable that is replaced with path to native version of it
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111682): https://lists.openembedded.org/g/openembedded-devel/message/111682
> Mute This Topic: https://lists.openembedded.org/mt/107795994/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj Aug. 19, 2024, 5:51 p.m. UTC | #2
On Mon, Aug 19, 2024 at 4:14 AM Martin Jansa via
lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
wrote:
>
> Doesn't this just hide the issue that the systemd service file is
> installed in wrong directory?
>

yes infact it does sadly.

> with current master I'm seeing:
> ERROR: Didn't find service unit 'blueman-mechanism.service', specified
> in SYSTEMD_SERVICE:blueman.
>
> On Thu, Aug 8, 2024 at 9:11 PM Alper Ak via lists.openembedded.org
> <alperyasinak1=gmail.com@lists.openembedded.org> wrote:
> >
> > ERROR: blueman-2.4.3-r0 do_package: QA Issue: blueman: Files/directories were installed but not shipped in any package:
> >   /usr/lib/systemd/system
> >   /usr/lib/systemd/system/blueman-mechanism.service
> > Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> > blueman: 2 installed and not shipped files. [installed-vs-shipped]
> > ERROR: blueman-2.4.3-r0 do_package: Fatal QA errors were found, failing task.
> >
> > Signed-off-by: alperak <alperyasinak1@gmail.com>
> > ---
> >  meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > index 5aa3b2bd5..df2a226f0 100644
> > --- a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > +++ b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > @@ -40,6 +40,7 @@ FILES:${PN} += " \
> >      ${datadir} \
> >      ${systemd_user_unitdir} \
> >      ${PYTHON_SITEPACKAGES_DIR} \
> > +    ${prefix}${systemd_system_unitdir} \
> >  "
> >
> >  # In code, path to python is a variable that is replaced with path to native version of it
> > --
> > 2.25.1
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111848): https://lists.openembedded.org/g/openembedded-devel/message/111848
> Mute This Topic: https://lists.openembedded.org/mt/107795994/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Martin Jansa Aug. 19, 2024, 5:52 p.m. UTC | #3
I've sent fix for that earlier today.

Cheers,

On Mon, Aug 19, 2024 at 7:52 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Aug 19, 2024 at 4:14 AM Martin Jansa via
> lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
> wrote:
> >
> > Doesn't this just hide the issue that the systemd service file is
> > installed in wrong directory?
> >
>
> yes infact it does sadly.
>
> > with current master I'm seeing:
> > ERROR: Didn't find service unit 'blueman-mechanism.service', specified
> > in SYSTEMD_SERVICE:blueman.
> >
> > On Thu, Aug 8, 2024 at 9:11 PM Alper Ak via lists.openembedded.org
> > <alperyasinak1=gmail.com@lists.openembedded.org> wrote:
> > >
> > > ERROR: blueman-2.4.3-r0 do_package: QA Issue: blueman: Files/directories were installed but not shipped in any package:
> > >   /usr/lib/systemd/system
> > >   /usr/lib/systemd/system/blueman-mechanism.service
> > > Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
> > > blueman: 2 installed and not shipped files. [installed-vs-shipped]
> > > ERROR: blueman-2.4.3-r0 do_package: Fatal QA errors were found, failing task.
> > >
> > > Signed-off-by: alperak <alperyasinak1@gmail.com>
> > > ---
> > >  meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > > index 5aa3b2bd5..df2a226f0 100644
> > > --- a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > > +++ b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
> > > @@ -40,6 +40,7 @@ FILES:${PN} += " \
> > >      ${datadir} \
> > >      ${systemd_user_unitdir} \
> > >      ${PYTHON_SITEPACKAGES_DIR} \
> > > +    ${prefix}${systemd_system_unitdir} \
> > >  "
> > >
> > >  # In code, path to python is a variable that is replaced with path to native version of it
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#111848): https://lists.openembedded.org/g/openembedded-devel/message/111848
> > Mute This Topic: https://lists.openembedded.org/mt/107795994/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
index 5aa3b2bd5..df2a226f0 100644
--- a/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
+++ b/meta-networking/recipes-connectivity/blueman/blueman_2.4.3.bb
@@ -40,6 +40,7 @@  FILES:${PN} += " \
     ${datadir} \
     ${systemd_user_unitdir} \
     ${PYTHON_SITEPACKAGES_DIR} \
+    ${prefix}${systemd_system_unitdir} \
 "
 
 # In code, path to python is a variable that is replaced with path to native version of it