diff mbox series

[meta-python] python3-daemon: switch to PEP-517 build backend

Message ID 20240807124748.126211-1-alperyasinak1@gmail.com
State Under Review
Headers show
Series [meta-python] python3-daemon: switch to PEP-517 build backend | expand

Commit Message

alperak Aug. 7, 2024, 12:47 p.m. UTC
The project has a proper pyproject.toml which declares the setuptools.build.meta PEP-517 backend.

Fix:

WARNING: python3-daemon-3.0.1-r0 do_check_backend: QA Issue: inherits setuptools3 but has pyproject.toml with setuptools.build_meta, use the correct class [pep517-backend]

Signed-off-by: alperak <alperyasinak1@gmail.com>
---
 .../python/python3-daemon_3.0.1.bb             | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Khem Raj Aug. 9, 2024, 4:08 p.m. UTC | #1
it fails to compile see

https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/4025/steps/15/logs/stdio

On Wed, Aug 7, 2024 at 5:47 AM Alper Ak via lists.openembedded.org
<alperyasinak1=gmail.com@lists.openembedded.org> wrote:
>
> The project has a proper pyproject.toml which declares the setuptools.build.meta PEP-517 backend.
>
> Fix:
>
> WARNING: python3-daemon-3.0.1-r0 do_check_backend: QA Issue: inherits setuptools3 but has pyproject.toml with setuptools.build_meta, use the correct class [pep517-backend]
>
> Signed-off-by: alperak <alperyasinak1@gmail.com>
> ---
>  .../python/python3-daemon_3.0.1.bb             | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> index 715d3bf12..4cdbff0ee 100644
> --- a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> +++ b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> @@ -1,18 +1,18 @@
>  DESCRIPTION = "Library to implement a well-behaved Unix daemon process"
>  HOMEPAGE = "https://pagure.io/python-daemon/"
>  SECTION = "devel/python"
> -
> -DEPENDS += "python3-docutils-native"
> -RDEPENDS:${PN} = "python3-docutils \
> -                  python3-lockfile (>= 0.10) \
> -                  python3-resource \
> -"
> -
>  LICENSE = "Apache-2.0 & GPL-3.0-only"
>  LIC_FILES_CHKSUM = "file://README;md5=a3a94c615dc969a70525f1eebbacf235"
>
> -inherit pypi setuptools3
> +PYPI_PACKAGE = "python-daemon"
> +
> +inherit pypi python_setuptools_build_meta
>
>  SRC_URI[sha256sum] = "6c57452372f7eaff40934a1c03ad1826bf5e793558e87fef49131e6464b4dae5"
>
> -PYPI_PACKAGE = "python-daemon"
> +DEPENDS += "python3-docutils-native"
> +
> +RDEPENDS:${PN} = "python3-docutils \
> +                  python3-lockfile (>= 0.10) \
> +                  python3-resource \
> +"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111629): https://lists.openembedded.org/g/openembedded-devel/message/111629
> Mute This Topic: https://lists.openembedded.org/mt/107768088/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj Aug. 9, 2024, 9:42 p.m. UTC | #2
here is link to error for just this recipe -
https://errors.yoctoproject.org/Errors/Details/797752/

On Fri, Aug 9, 2024 at 9:08 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> it fails to compile see
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/4025/steps/15/logs/stdio
>
> On Wed, Aug 7, 2024 at 5:47 AM Alper Ak via lists.openembedded.org
> <alperyasinak1=gmail.com@lists.openembedded.org> wrote:
> >
> > The project has a proper pyproject.toml which declares the setuptools.build.meta PEP-517 backend.
> >
> > Fix:
> >
> > WARNING: python3-daemon-3.0.1-r0 do_check_backend: QA Issue: inherits setuptools3 but has pyproject.toml with setuptools.build_meta, use the correct class [pep517-backend]
> >
> > Signed-off-by: alperak <alperyasinak1@gmail.com>
> > ---
> >  .../python/python3-daemon_3.0.1.bb             | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> > index 715d3bf12..4cdbff0ee 100644
> > --- a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> > +++ b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> > @@ -1,18 +1,18 @@
> >  DESCRIPTION = "Library to implement a well-behaved Unix daemon process"
> >  HOMEPAGE = "https://pagure.io/python-daemon/"
> >  SECTION = "devel/python"
> > -
> > -DEPENDS += "python3-docutils-native"
> > -RDEPENDS:${PN} = "python3-docutils \
> > -                  python3-lockfile (>= 0.10) \
> > -                  python3-resource \
> > -"
> > -
> >  LICENSE = "Apache-2.0 & GPL-3.0-only"
> >  LIC_FILES_CHKSUM = "file://README;md5=a3a94c615dc969a70525f1eebbacf235"
> >
> > -inherit pypi setuptools3
> > +PYPI_PACKAGE = "python-daemon"
> > +
> > +inherit pypi python_setuptools_build_meta
> >
> >  SRC_URI[sha256sum] = "6c57452372f7eaff40934a1c03ad1826bf5e793558e87fef49131e6464b4dae5"
> >
> > -PYPI_PACKAGE = "python-daemon"
> > +DEPENDS += "python3-docutils-native"
> > +
> > +RDEPENDS:${PN} = "python3-docutils \
> > +                  python3-lockfile (>= 0.10) \
> > +                  python3-resource \
> > +"
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#111629): https://lists.openembedded.org/g/openembedded-devel/message/111629
> > Mute This Topic: https://lists.openembedded.org/mt/107768088/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
Tim Orling Aug. 9, 2024, 9:52 p.m. UTC | #3
On Fri, Aug 9, 2024 at 2:42 PM Khem Raj via lists.openembedded.org
<raj.khem=gmail.com@lists.openembedded.org> wrote:

> here is link to error for just this recipe -
> https://errors.yoctoproject.org/Errors/Details/797752/


The key to that backtrace is:
ModuleNotFoundError: No module named 'setuptools.extern'

Where to go from there is less obvious.

>
>
> On Fri, Aug 9, 2024 at 9:08 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > it fails to compile see
> >
> >
> https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/4025/steps/15/logs/stdio
> >
> > On Wed, Aug 7, 2024 at 5:47 AM Alper Ak via lists.openembedded.org
> > <alperyasinak1=gmail.com@lists.openembedded.org> wrote:
> > >
> > > The project has a proper pyproject.toml which declares the
> setuptools.build.meta PEP-517 backend.
> > >
> > > Fix:
> > >
> > > WARNING: python3-daemon-3.0.1-r0 do_check_backend: QA Issue: inherits
> setuptools3 but has pyproject.toml with setuptools.build_meta, use the
> correct class [pep517-backend]
> > >
> > > Signed-off-by: alperak <alperyasinak1@gmail.com>
> > > ---
> > >  .../python/python3-daemon_3.0.1.bb             | 18
> +++++++++---------
> > >  1 file changed, 9 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/meta-python/recipes-devtools/python/
> python3-daemon_3.0.1.bb b/meta-python/recipes-devtools/python/
> python3-daemon_3.0.1.bb
> > > index 715d3bf12..4cdbff0ee 100644
> > > --- a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> > > +++ b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
> > > @@ -1,18 +1,18 @@
> > >  DESCRIPTION = "Library to implement a well-behaved Unix daemon
> process"
> > >  HOMEPAGE = "https://pagure.io/python-daemon/"
> > >  SECTION = "devel/python"
> > > -
> > > -DEPENDS += "python3-docutils-native"
> > > -RDEPENDS:${PN} = "python3-docutils \
> > > -                  python3-lockfile (>= 0.10) \
> > > -                  python3-resource \
> > > -"
> > > -
> > >  LICENSE = "Apache-2.0 & GPL-3.0-only"
> > >  LIC_FILES_CHKSUM =
> "file://README;md5=a3a94c615dc969a70525f1eebbacf235"
> > >
> > > -inherit pypi setuptools3
> > > +PYPI_PACKAGE = "python-daemon"
> > > +
> > > +inherit pypi python_setuptools_build_meta
> > >
> > >  SRC_URI[sha256sum] =
> "6c57452372f7eaff40934a1c03ad1826bf5e793558e87fef49131e6464b4dae5"
> > >
> > > -PYPI_PACKAGE = "python-daemon"
> > > +DEPENDS += "python3-docutils-native"
> > > +
> > > +RDEPENDS:${PN} = "python3-docutils \
> > > +                  python3-lockfile (>= 0.10) \
> > > +                  python3-resource \
> > > +"
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111730):
> https://lists.openembedded.org/g/openembedded-devel/message/111730
> Mute This Topic: https://lists.openembedded.org/mt/107768088/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
index 715d3bf12..4cdbff0ee 100644
--- a/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
+++ b/meta-python/recipes-devtools/python/python3-daemon_3.0.1.bb
@@ -1,18 +1,18 @@ 
 DESCRIPTION = "Library to implement a well-behaved Unix daemon process"
 HOMEPAGE = "https://pagure.io/python-daemon/"
 SECTION = "devel/python"
-
-DEPENDS += "python3-docutils-native"
-RDEPENDS:${PN} = "python3-docutils \
-                  python3-lockfile (>= 0.10) \
-                  python3-resource \
-"
-
 LICENSE = "Apache-2.0 & GPL-3.0-only"
 LIC_FILES_CHKSUM = "file://README;md5=a3a94c615dc969a70525f1eebbacf235"
 
-inherit pypi setuptools3
+PYPI_PACKAGE = "python-daemon"
+
+inherit pypi python_setuptools_build_meta
 
 SRC_URI[sha256sum] = "6c57452372f7eaff40934a1c03ad1826bf5e793558e87fef49131e6464b4dae5"
 
-PYPI_PACKAGE = "python-daemon"
+DEPENDS += "python3-docutils-native"
+
+RDEPENDS:${PN} = "python3-docutils \
+                  python3-lockfile (>= 0.10) \
+                  python3-resource \
+"