| Message ID | 20240711112749.1212183-1-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | e42abd3b82c7bac93541b2cf87b553c1a31346cd |
| Headers | show |
| Series | [v2] python3: Drop generating a static libpython | expand |
Hi, I tried adding this in my Scarthgap project and this change reduced disk memory usage by ~177MB, very nice find :) Any chance to have this backported? Best regards, Gudni
You are welcome to send such a backport, but it has to preserve existing behaviour by default. Alex On Wed, 17 Jul 2024 at 11:17, Guðni Már Gilbert via lists.openembedded.org <gudni.m.g=gmail.com@lists.openembedded.org> wrote: > > Hi, I tried adding this in my Scarthgap project and this change reduced disk memory usage by ~177MB, very nice find :) > > Any chance to have this backported? > > Best regards, > Gudni > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#202147): https://lists.openembedded.org/g/openembedded-core/message/202147 > Mute This Topic: https://lists.openembedded.org/mt/107160591/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Wed, Jul 17, 2024 at 09:21 AM, Alexander Kanavin wrote: > > You are welcome to send such a backport, but it has to preserve > existing behaviour by default. > > Alex I see, then to backport this specific change we would need to add 'staticlibpython' to PACKAGECONFIG.
On Wed, 2024-07-17 at 11:20 +0200, Alexander Kanavin via lists.openembedded.org wrote: > You are welcome to send such a backport, but it has to preserve > existing behaviour by default. Given I found no users of it, I suspect if we wait a week or two and hear no complaints, this one might be ok but it would need a little more careful review/testing/TSC acks. Cheers, Richard
diff --git a/meta/recipes-devtools/python/python3_3.12.4.bb b/meta/recipes-devtools/python/python3_3.12.4.bb index 77bbfaa069e..743ba0b1f1f 100644 --- a/meta/recipes-devtools/python/python3_3.12.4.bb +++ b/meta/recipes-devtools/python/python3_3.12.4.bb @@ -107,6 +107,7 @@ PACKAGECONFIG[tk] = ",,tk" PACKAGECONFIG[tcl] = ",,tcl" PACKAGECONFIG[gdbm] = ",,gdbm" PACKAGECONFIG[lto] = "--with-lto,--without-lto" +PACKAGECONFIG[staticlibpython] = "--with-static-libpython,--without-static-libpython" do_configure:prepend () { mkdir -p ${B}/Modules
This currently puts a 60MB binary into the recipe sysroots in the native case as well as the implications for the target. Since as far as I know, we don't need/use this, stop generating it by adding a PACKAGECONFIG. It can be enabled by anyone who does actually need to use it. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- meta/recipes-devtools/python/python3_3.12.4.bb | 1 + 1 file changed, 1 insertion(+)