Message ID | 20240709120209.65344-1-niko.mauno@vaisala.com |
---|---|
State | Accepted, archived |
Commit | fcd340ec53ff8352b8cae0eb351810072b025a08 |
Headers | show |
Series | Fix missing leading whitespace with ':append' | expand |
Hello, Can you submit one patch per recipe? On 09/07/2024 15:02:09+0300, Niko Mauno via lists.openembedded.org wrote: > From: Niko Mauno <niko.mauno@vaisala.com> > > Mitigate occurrences where ':append' operator is used and leading > whitespace character is obviously missing, risking inadvertent > string concatenation. > > Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> > --- > meta/recipes-devtools/dnf/dnf_4.20.0.bb | 2 +- > meta/recipes-graphics/mesa/mesa.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-devtools/dnf/dnf_4.20.0.bb b/meta/recipes-devtools/dnf/dnf_4.20.0.bb > index 4757346cbf..98edab0614 100644 > --- a/meta/recipes-devtools/dnf/dnf_4.20.0.bb > +++ b/meta/recipes-devtools/dnf/dnf_4.20.0.bb > @@ -18,7 +18,7 @@ SRC_URI = "git://github.com/rpm-software-management/dnf.git;branch=master;protoc > file://0001-lock.py-fix-Exception-handling.patch \ > " > > -SRC_URI:append:class-native = "file://0001-dnf-write-the-log-lock-to-root.patch" > +SRC_URI:append:class-native = " file://0001-dnf-write-the-log-lock-to-root.patch" > > SRCREV = "e3cb438c0fd08c79676c0f3276aa7d75cd8557c6" > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)" > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc > index 272d57c749..d56def2916 100644 > --- a/meta/recipes-graphics/mesa/mesa.inc > +++ b/meta/recipes-graphics/mesa/mesa.inc > @@ -91,7 +91,7 @@ PACKAGECONFIG = " \ > ${@bb.utils.contains('DISTRO_FEATURES', 'vulkan', 'zink', '', d)} \ > " > > -PACKAGECONFIG:append:class-native = "gallium-llvm r600" > +PACKAGECONFIG:append:class-native = " gallium-llvm r600" > > # "gbm" requires "opengl" > PACKAGECONFIG[gbm] = "-Dgbm=enabled,-Dgbm=disabled" > -- > 2.39.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#201655): https://lists.openembedded.org/g/openembedded-core/message/201655 > Mute This Topic: https://lists.openembedded.org/mt/107121031/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, 2024-07-09 at 16:10 +0200, Alexandre Belloni via lists.openembedded.org wrote: > Hello, > > Can you submit one patch per recipe? FWIW I tweaked the shortlog prefix in master-next to mesa/dnf: which resolves this case. Cheers, Richard
On 7/9/24 18:43, Richard Purdie wrote: > On Tue, 2024-07-09 at 16:10 +0200, Alexandre Belloni via > lists.openembedded.org wrote: >> Hello, >> >> Can you submit one patch per recipe? > > FWIW I tweaked the shortlog prefix in master-next to mesa/dnf: which > resolves this case. > > Cheers, > > Richard Apologies, I failed to realize this before submitting a v2 of the commit as a series of two separate patches. Please ignore it. - Niko
diff --git a/meta/recipes-devtools/dnf/dnf_4.20.0.bb b/meta/recipes-devtools/dnf/dnf_4.20.0.bb index 4757346cbf..98edab0614 100644 --- a/meta/recipes-devtools/dnf/dnf_4.20.0.bb +++ b/meta/recipes-devtools/dnf/dnf_4.20.0.bb @@ -18,7 +18,7 @@ SRC_URI = "git://github.com/rpm-software-management/dnf.git;branch=master;protoc file://0001-lock.py-fix-Exception-handling.patch \ " -SRC_URI:append:class-native = "file://0001-dnf-write-the-log-lock-to-root.patch" +SRC_URI:append:class-native = " file://0001-dnf-write-the-log-lock-to-root.patch" SRCREV = "e3cb438c0fd08c79676c0f3276aa7d75cd8557c6" UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+(\.\d+)+)" diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc index 272d57c749..d56def2916 100644 --- a/meta/recipes-graphics/mesa/mesa.inc +++ b/meta/recipes-graphics/mesa/mesa.inc @@ -91,7 +91,7 @@ PACKAGECONFIG = " \ ${@bb.utils.contains('DISTRO_FEATURES', 'vulkan', 'zink', '', d)} \ " -PACKAGECONFIG:append:class-native = "gallium-llvm r600" +PACKAGECONFIG:append:class-native = " gallium-llvm r600" # "gbm" requires "opengl" PACKAGECONFIG[gbm] = "-Dgbm=enabled,-Dgbm=disabled"