Message ID | 20240527134416.10699-1-jaekyu.lee@lge.com |
---|---|
State | Rejected |
Delegated to: | Steve Sakoman |
Headers | show |
Series | [scarthgap] rust: remove unnecessary git signature | expand |
Hello, there are lots of patches in oe-core with git signatures at the end, why does it need to be removed from here in particular? Alex On Mon, 27 May 2024 at 16:25, Jaekyu Lee via lists.openembedded.org <jaekyu.lee=lge.com@lists.openembedded.org> wrote: > > From: "jaekyu.lee" <jaekyu.lee@lge.com> > > Remove useless git signature > > Signed-off-by: jaekyu.lee <jaekyu.lee@lge.com> > --- > .../0001-Handle-vendored-sources-when-remapping-paths.patch | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > index a46ee14402..10ca1c2530 100644 > --- a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > +++ b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > @@ -41,6 +41,4 @@ index cd276674dee6..48fdb2c7f7b7 100644 > } > cargo.env("RUSTC_CARGO_REGISTRY_SRC_TO_REMAP", env_var); > } > --- > -2.39.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#199902): https://lists.openembedded.org/g/openembedded-core/message/199902 > Mute This Topic: https://lists.openembedded.org/mt/106323318/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Thank you for reply. I don't think we need to remove it specifically for this patch. If possible, I will update patch to remove it from all patches. Do you agree that information ( git version information) is unnecessary? On Mon, May 27, 2024 at 11:40 PM Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > Hello, > > there are lots of patches in oe-core with git signatures at the end, > why does it need to be removed from here in particular? > > Alex > > On Mon, 27 May 2024 at 16:25, Jaekyu Lee via lists.openembedded.org > <jaekyu.lee=lge.com@lists.openembedded.org> wrote: > > > > From: "jaekyu.lee" <jaekyu.lee@lge.com> > > > > Remove useless git signature > > > > Signed-off-by: jaekyu.lee <jaekyu.lee@lge.com> > > --- > > .../0001-Handle-vendored-sources-when-remapping-paths.patch | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git > a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > > index a46ee14402..10ca1c2530 100644 > > --- > a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > > +++ > b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch > > @@ -41,6 +41,4 @@ index cd276674dee6..48fdb2c7f7b7 100644 > > } > > cargo.env("RUSTC_CARGO_REGISTRY_SRC_TO_REMAP", env_var); > > } > > --- > > -2.39.0 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#199903): > https://lists.openembedded.org/g/openembedded-core/message/199903 > Mute This Topic: https://lists.openembedded.org/mt/106323318/7530085 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > jkbestfamily@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Mon, 27 May 2024 at 18:41, 이재규 <jkbestfamily@gmail.com> wrote: > > Thank you for reply. > > I don't think we need to remove it specifically for this patch. > If possible, I will update patch to remove it from all patches. Do you agree that information ( git version information) is unnecessary? It might be unnecessary, but I do not think there is a need to remove it. If 'git format-patch' adds that when it writes a patch file to disk, then we shouldn't fight with that: people will keep sending patch files that have it. Alex
> -----Original Message----- > From: openembedded-core@lists.openembedded.org <openembedded- > core@lists.openembedded.org> On Behalf Of Alexander Kanavin > Sent: den 27 maj 2024 18:46 > To: 이재규 <jkbestfamily@gmail.com> > Cc: jaekyu.lee@lge.com; openembedded-core@lists.openembedded.org > Subject: Re: [PATCH] [OE-core][scarthgap] rust: remove unnecessary git > signature > > On Mon, 27 May 2024 at 18:41, 이재규 <jkbestfamily@gmail.com> wrote: > > > > Thank you for reply. > > > > I don't think we need to remove it specifically for this patch. > > If possible, I will update patch to remove it from all patches. Do you > > agree that information ( git version information) is unnecessary? > > It might be unnecessary, but I do not think there is a need to remove > it. If 'git format-patch' adds that when it writes a patch file to > disk, then we shouldn't fight with that: people will keep sending > patch files that have it. > > Alex For the record, patches generated/updated by devtool will be created with `git format-patch --no-signature --no-numbered ...` and thus lack the git version at the end. Personally, I have the following in my .gitconfig to avoid having `git format-name ...` generate the signature: [format] signature = But as Alex says, some will generate patches with the Git signature, and some will generate them without it. So unless someone adds some check for their non-existence, e.g., to patchcheck, they will come and go depending on who generates the patches. //Peter
On Tue, 2024-05-28 at 00:38 +0000, Peter Kjellerstedt via lists.openembedded.org wrote: > > For the record, patches generated/updated by devtool will be created with > `git format-patch --no-signature --no-numbered ...` and thus lack the git > version at the end. > > Personally, I have the following in my .gitconfig to avoid having > `git format-name ...` generate the signature: > > [format] > signature = > > But as Alex says, some will generate patches with the Git signature, and > some will generate them without it. So unless someone adds some check for > their non-existence, e.g., to patchcheck, they will come and go depending > on who generates the patches. I think it may be worth documenting this config and recommending it to people, just so we can avoid a bit more noise. Cheers, Richard
diff --git a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch index a46ee14402..10ca1c2530 100644 --- a/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch +++ b/meta/recipes-devtools/rust/files/0001-Handle-vendored-sources-when-remapping-paths.patch @@ -41,6 +41,4 @@ index cd276674dee6..48fdb2c7f7b7 100644 } cargo.env("RUSTC_CARGO_REGISTRY_SRC_TO_REMAP", env_var); } --- -2.39.0