Message ID | 20240524151838.2450718-1-richard.purdie@linuxfoundation.org |
---|---|
State | Accepted, archived |
Commit | 002a2a9d977ed5b86138333c567d25616d38c60b |
Headers | show |
Series | layer.conf: Add os-release to SIGGEN_EXCLUDERECIPES_ABISAFE | expand |
Richard Purdie via lists.openembedded.org <richard.purdie= linuxfoundation.org@lists.openembedded.org> escreveu (sexta, 24/05/2024 à(s) 16:18): > This rebuilds whenever DISTRO_VERSION changes (i.e. any commit is made) > and systemd depends upon it so lots of things end up rebuilding which > isn't necessary, > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > meta/conf/layer.conf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf > index f2bca0aa5ba..65eb657fd93 100644 > --- a/meta/conf/layer.conf > +++ b/meta/conf/layer.conf > @@ -45,6 +45,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \ > ca-certificates \ > shared-mime-info \ > desktop-file-utils \ > + os-release \ > Acked-by: Jose Quaresma <j <martin.jansa@gmail.com>ose.quaresma@foundries.io > I've had this on the Linux microPlatform distro for a while now but I forgot to submit https://github.com/foundriesio/meta-lmp/blob/efe9acade717181a5b9d3c520d90aa53049abb27/meta-lmp-base/conf/layer.conf#L37 Jose " > > SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \ > -- > 2.40.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#199852): > https://lists.openembedded.org/g/openembedded-core/message/199852 > Mute This Topic: https://lists.openembedded.org/mt/106283450/5052612 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > quaresma.jose@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
>> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf >> index f2bca0aa5ba..65eb657fd93 100644 >> --- a/meta/conf/layer.conf >> +++ b/meta/conf/layer.conf >> @@ -45,6 +45,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \ >> ca-certificates \ >> shared-mime-info \ >> desktop-file-utils \ >> + os-release \ > > > Acked-by: Jose Quaresma <jose.quaresma@foundries.io> > > I've had this on the Linux microPlatform distro for a while now but I forgot to submit > https://github.com/foundriesio/meta-lmp/blob/efe9acade717181a5b9d3c520d90aa53049abb27/meta-lmp-base/conf/layer.conf#L37 You can drop few lines from SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS there as well :).
Martin Jansa <martin.jansa@gmail.com> escreveu (sexta, 24/05/2024 à(s) 17:22): > >> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf > >> index f2bca0aa5ba..65eb657fd93 100644 > >> --- a/meta/conf/layer.conf > >> +++ b/meta/conf/layer.conf > >> @@ -45,6 +45,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \ > >> ca-certificates \ > >> shared-mime-info \ > >> desktop-file-utils \ > >> + os-release \ > > > > > > Acked-by: Jose Quaresma <jose.quaresma@foundries.io> > > > > I've had this on the Linux microPlatform distro for a while now but I > forgot to submit > > > https://github.com/foundriesio/meta-lmp/blob/efe9acade717181a5b9d3c520d90aa53049abb27/meta-lmp-base/conf/layer.conf#L37 > > You can drop few lines from SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS there as well > :). > I can try to see if I still need to have it, this one was to store and re-use the initramfs on the sstate-cache. Without that I sometimes need to rebuild the kernel when this would not be necessary. All of that was validated on the kirkstone branch. Anyway, I will take a look. Thanks for the tip.
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS is weaker version of SIGGEN_EXCLUDERECIPES_ABISAFE to mark it ABI safe only for some recipes. As you mark it ABI safe globally then the os-release entries in SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS shouldn't be needed, they don't harm except few more cpu cycles, I've just noticed it's strange. On Fri, May 24, 2024 at 6:31 PM Jose Quaresma <quaresma.jose@gmail.com> wrote: > > > > Martin Jansa <martin.jansa@gmail.com> escreveu (sexta, 24/05/2024 à(s) 17:22): >> >> >> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf >> >> index f2bca0aa5ba..65eb657fd93 100644 >> >> --- a/meta/conf/layer.conf >> >> +++ b/meta/conf/layer.conf >> >> @@ -45,6 +45,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \ >> >> ca-certificates \ >> >> shared-mime-info \ >> >> desktop-file-utils \ >> >> + os-release \ >> > >> > >> > Acked-by: Jose Quaresma <jose.quaresma@foundries.io> >> > >> > I've had this on the Linux microPlatform distro for a while now but I forgot to submit >> > https://github.com/foundriesio/meta-lmp/blob/efe9acade717181a5b9d3c520d90aa53049abb27/meta-lmp-base/conf/layer.conf#L37 >> >> You can drop few lines from SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS there as well :). > > > I can try to see if I still need to have it, this one was to store and re-use the initramfs on the sstate-cache. > Without that I sometimes need to rebuild the kernel when this would not be necessary. > All of that was validated on the kirkstone branch. > > Anyway, I will take a look. > > Thanks for the tip. > > -- > Best regards, > > José Quaresma
diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf index f2bca0aa5ba..65eb657fd93 100644 --- a/meta/conf/layer.conf +++ b/meta/conf/layer.conf @@ -45,6 +45,7 @@ SIGGEN_EXCLUDERECIPES_ABISAFE += " \ ca-certificates \ shared-mime-info \ desktop-file-utils \ + os-release \ " SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
This rebuilds whenever DISTRO_VERSION changes (i.e. any commit is made) and systemd depends upon it so lots of things end up rebuilding which isn't necessary, Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- meta/conf/layer.conf | 1 + 1 file changed, 1 insertion(+)