| Message ID | 20220119115759.1390792-1-andrej.valek@siemens.com |
|---|---|
| State | New |
| Headers | show |
| Series | kernel: add missing path to search for debug files | expand |
On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote: > Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has > been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE > options. For ex. when the variable "debug-file-directory" package search > path has to be set explicitly, otherwise it will not find any files. > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com> > --- > meta/classes/kernel.bbclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index 473e28be47..9ea201c936 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = "" > FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build" > FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}" > FILES:${KERNEL_PACKAGE_NAME}-modules = "" > +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug" This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the very least we need a bugzilla entry for creating some... Cheers, Richard
On 1/19/22 5:48 PM, Richard Purdie wrote: > On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote: >> Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has >> been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE >> options. For ex. when the variable "debug-file-directory" package search >> path has to be set explicitly, otherwise it will not find any files. >> >> Signed-off-by: Andrej Valek <andrej.valek@siemens.com> >> --- >> meta/classes/kernel.bbclass | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index 473e28be47..9ea201c936 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = "" >> FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build" >> FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}" >> FILES:${KERNEL_PACKAGE_NAME}-modules = "" >> +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug" > This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the > very least we need a bugzilla entry for creating some... Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700 Cheers Michael
Hello Richard, Fine, that we have it, but are you going to take a look on the patch :) ? Regards, Andrej On Fri, 2022-01-21 at 10:18 +0100, Michael Opdenacker wrote: > > On 1/19/22 5:48 PM, Richard Purdie wrote: > > On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote: > > > Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}- > > > dbg has > > > been added to kernel, it has to cover all > > > PACKAGE_DEBUG_SPLIT_STYLE > > > options. For ex. when the variable "debug-file-directory" package > > > search > > > path has to be set explicitly, otherwise it will not find any > > > files. > > > > > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com> > > > --- > > > meta/classes/kernel.bbclass | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/meta/classes/kernel.bbclass > > > b/meta/classes/kernel.bbclass > > > index 473e28be47..9ea201c936 100644 > > > --- a/meta/classes/kernel.bbclass > > > +++ b/meta/classes/kernel.bbclass > > > @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = "" > > > FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* > > > /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} > > > ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build" > > > FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux- > > > ${KERNEL_VERSION_NAME}" > > > FILES:${KERNEL_PACKAGE_NAME}-modules = "" > > > +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug > > > /usr/src/debug" > > This seems to highlight that we have no tests for > > KERNEL_PACKAGE_NAME. At the > > very least we need a bugzilla entry for creating some... > > > Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700 > Cheers > Michael >
ping On Mon, 2022-01-24 at 08:19 +0000, Andrej Valek via lists.openembedded.org wrote: > Hello Richard, > > Fine, that we have it, but are you going to take a look on the patch > :) > ? > > Regards, > Andrej > > On Fri, 2022-01-21 at 10:18 +0100, Michael Opdenacker wrote: > > > > On 1/19/22 5:48 PM, Richard Purdie wrote: > > > On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote: > > > > Since explicit debug package creation via > > > > ${KERNEL_PACKAGE_NAME}- > > > > dbg has > > > > been added to kernel, it has to cover all > > > > PACKAGE_DEBUG_SPLIT_STYLE > > > > options. For ex. when the variable "debug-file-directory" > > > > package > > > > search > > > > path has to be set explicitly, otherwise it will not find any > > > > files. > > > > > > > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com> > > > > --- > > > > meta/classes/kernel.bbclass | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/meta/classes/kernel.bbclass > > > > b/meta/classes/kernel.bbclass > > > > index 473e28be47..9ea201c936 100644 > > > > --- a/meta/classes/kernel.bbclass > > > > +++ b/meta/classes/kernel.bbclass > > > > @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = "" > > > > FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* > > > > /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} > > > > ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build" > > > > FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux- > > > > ${KERNEL_VERSION_NAME}" > > > > FILES:${KERNEL_PACKAGE_NAME}-modules = "" > > > > +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug > > > > /usr/src/debug" > > > This seems to highlight that we have no tests for > > > KERNEL_PACKAGE_NAME. At the > > > very least we need a bugzilla entry for creating some... > > > > > > Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700 > > Cheers > > Michael > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#160872): > https://lists.openembedded.org/g/openembedded-core/message/160872 > Mute This Topic: https://lists.openembedded.org/mt/88532225/3619876 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: > https://lists.openembedded.org/g/openembedded-core/unsub [ > andrej.valek@siemens.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 473e28be47..9ea201c936 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = "" FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build" FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}" FILES:${KERNEL_PACKAGE_NAME}-modules = "" +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug" RDEPENDS:${KERNEL_PACKAGE_NAME} = "${KERNEL_PACKAGE_NAME}-base (= ${EXTENDPKGV})" # Allow machines to override this dependency if kernel image files are # not wanted in images as standard
Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE options. For ex. when the variable "debug-file-directory" package search path has to be set explicitly, otherwise it will not find any files. Signed-off-by: Andrej Valek <andrej.valek@siemens.com> --- meta/classes/kernel.bbclass | 1 + 1 file changed, 1 insertion(+)