diff mbox series

[v2] glibc: correct license

Message ID 20240506074548.16296-1-peter.marko@siemens.com
State Accepted, archived
Commit b7ad15a59d048ca7561a03cb0fc8e2c24680ce5c
Headers show
Series [v2] glibc: correct license | expand

Commit Message

Peter Marko May 6, 2024, 7:45 a.m. UTC
From: Peter Marko <peter.marko@siemens.com>

The license per [1] is LGPL-2.1-or-later and
[2] converted last LGPL-2.1-only references.

License-Update: corrected from LGPL-2.1-only to LGPL-2.1-or-later based on [1] and [2]

[1] https://www.gnu.org/software/libc/
[2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=273a835fe7c685cc54266bb8b502787bad5e9bae

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta/recipes-core/glibc/glibc-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Jansa May 16, 2024, 5:29 a.m. UTC | #1
Hi Peter,

what about BSD-4-Clause-UC, BSD-3-Clause, ISC licenses included in glibc.

I've suggested to add them long time ago in:
https://lists.openembedded.org/g/openembedded-core/topic/91285771#msg166005
which resulted in:
https://sourceware.org/bugzilla/show_bug.cgi?id=28007
https://sourceware.org/pipermail/libc-alpha/2022-May/139167.html
but the discussion upstream stopped shortly after and the oe-core
change was never merged because of that. Maybe it's time to re-check
and ping upstream again after 2 years.

Cheers,

On Mon, May 6, 2024 at 9:46 AM Peter Marko via lists.openembedded.org
<peter.marko=siemens.com@lists.openembedded.org> wrote:
>
> From: Peter Marko <peter.marko@siemens.com>
>
> The license per [1] is LGPL-2.1-or-later and
> [2] converted last LGPL-2.1-only references.
>
> License-Update: corrected from LGPL-2.1-only to LGPL-2.1-or-later based on [1] and [2]
>
> [1] https://www.gnu.org/software/libc/
> [2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=273a835fe7c685cc54266bb8b502787bad5e9bae
>
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta/recipes-core/glibc/glibc-common.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glibc/glibc-common.inc b/meta/recipes-core/glibc/glibc-common.inc
> index b9516e77f0..91a3f5bcd5 100644
> --- a/meta/recipes-core/glibc/glibc-common.inc
> +++ b/meta/recipes-core/glibc/glibc-common.inc
> @@ -2,7 +2,7 @@ SUMMARY = "GLIBC (GNU C Library)"
>  DESCRIPTION = "The GNU C Library is used as the system C library in most systems with the Linux kernel."
>  HOMEPAGE = "http://www.gnu.org/software/libc/libc.html"
>  SECTION = "libs"
> -LICENSE = "GPL-2.0-only & LGPL-2.1-only"
> +LICENSE = "GPL-2.0-only & LGPL-2.1-or-later"
>
>  LIC_FILES_CHKSUM ?= "file://LICENSES;md5=f77e878d320e99e94ae9a4aea7f491d1 \
>        file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#199036): https://lists.openembedded.org/g/openembedded-core/message/199036
> Mute This Topic: https://lists.openembedded.org/mt/105935723/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Peter Marko May 16, 2024, 7:53 p.m. UTC | #2
Hi Martin,

license handling is a very complicated topic, especially for historical projects like glibc with ton of files with diverse origin.
License scanning programs will find 15+ different licenses here and some of them may not be even available in yocto license list.
I submitted this particular commit because I was responsible for an update with commit which was asking for it.

The discussion you linked about adding SPDX identifiers is something which would really help.
It would enable license discovery without need of big data software and allow to accurately set the LICENSE field also by SW developers.

Peter

-----Original Message-----
From: Martin Jansa <martin.jansa@gmail.com> 
Sent: Thursday, May 16, 2024 7:30
To: Marko, Peter (ADV D EU SK BFS1) <Peter.Marko@siemens.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH v2] glibc: correct license

> Hi Peter,
>
> what about BSD-4-Clause-UC, BSD-3-Clause, ISC licenses included in glibc.
>
> I've suggested to add them long time ago in:
> https://lists.openembedded.org/g/openembedded-core/topic/91285771#msg166005
> which resulted in:
> https://sourceware.org/bugzilla/show_bug.cgi?id=28007
> https://sourceware.org/pipermail/libc-alpha/2022-May/139167.html
> but the discussion upstream stopped shortly after and the oe-core change was never merged because of that. Maybe it's time to re-check and ping upstream again after 2 years.
>
> Cheers,
>
> On Mon, May 6, 2024 at 9:46 AM Peter Marko via lists.openembedded.org <peter.marko=siemens.com@lists.openembedded.org> wrote:
> ...
Khem Raj May 16, 2024, 8:05 p.m. UTC | #3
On Wed, May 15, 2024 at 10:29 PM Martin Jansa via
lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
wrote:
>
> Hi Peter,
>
> what about BSD-4-Clause-UC, BSD-3-Clause, ISC licenses included in glibc.
>
> I've suggested to add them long time ago in:
> https://lists.openembedded.org/g/openembedded-core/topic/91285771#msg166005
> which resulted in:
> https://sourceware.org/bugzilla/show_bug.cgi?id=28007
> https://sourceware.org/pipermail/libc-alpha/2022-May/139167.html
> but the discussion upstream stopped shortly after and the oe-core
> change was never merged because of that. Maybe it's time to re-check
> and ping upstream again after 2 years.

Perhaps yes.

On a tangent here, but I also think we should use
https://github.com/nexB/scancode-toolkit
to extract the license information from source code itself to update
the LICENSE field
in the recipes.

>
> Cheers,
>
> On Mon, May 6, 2024 at 9:46 AM Peter Marko via lists.openembedded.org
> <peter.marko=siemens.com@lists.openembedded.org> wrote:
> >
> > From: Peter Marko <peter.marko@siemens.com>
> >
> > The license per [1] is LGPL-2.1-or-later and
> > [2] converted last LGPL-2.1-only references.
> >
> > License-Update: corrected from LGPL-2.1-only to LGPL-2.1-or-later based on [1] and [2]
> >
> > [1] https://www.gnu.org/software/libc/
> > [2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=273a835fe7c685cc54266bb8b502787bad5e9bae
> >
> > Signed-off-by: Peter Marko <peter.marko@siemens.com>
> > ---
> >  meta/recipes-core/glibc/glibc-common.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/glibc/glibc-common.inc b/meta/recipes-core/glibc/glibc-common.inc
> > index b9516e77f0..91a3f5bcd5 100644
> > --- a/meta/recipes-core/glibc/glibc-common.inc
> > +++ b/meta/recipes-core/glibc/glibc-common.inc
> > @@ -2,7 +2,7 @@ SUMMARY = "GLIBC (GNU C Library)"
> >  DESCRIPTION = "The GNU C Library is used as the system C library in most systems with the Linux kernel."
> >  HOMEPAGE = "http://www.gnu.org/software/libc/libc.html"
> >  SECTION = "libs"
> > -LICENSE = "GPL-2.0-only & LGPL-2.1-only"
> > +LICENSE = "GPL-2.0-only & LGPL-2.1-or-later"
> >
> >  LIC_FILES_CHKSUM ?= "file://LICENSES;md5=f77e878d320e99e94ae9a4aea7f491d1 \
> >        file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> > --
> > 2.30.2
> >
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#199437): https://lists.openembedded.org/g/openembedded-core/message/199437
> Mute This Topic: https://lists.openembedded.org/mt/105935723/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Martin Jansa May 16, 2024, 8:18 p.m. UTC | #4
On Thu, May 16, 2024 at 10:05 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Wed, May 15, 2024 at 10:29 PM Martin Jansa via
> lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
> wrote:
> >
> > Hi Peter,
> >
> > what about BSD-4-Clause-UC, BSD-3-Clause, ISC licenses included in glibc.
> >
> > I've suggested to add them long time ago in:
> > https://lists.openembedded.org/g/openembedded-core/topic/91285771#msg166005
> > which resulted in:
> > https://sourceware.org/bugzilla/show_bug.cgi?id=28007
> > https://sourceware.org/pipermail/libc-alpha/2022-May/139167.html
> > but the discussion upstream stopped shortly after and the oe-core
> > change was never merged because of that. Maybe it's time to re-check
> > and ping upstream again after 2 years.
>
> Perhaps yes.
>
> On a tangent here, but I also think we should use
> https://github.com/nexB/scancode-toolkit
> to extract the license information from source code itself to update
> the LICENSE field
> in the recipes.

Yeah, we've added it 10+ years ago, because Blackduck or something was
complaining about missing license identifiers in:
https://github.com/openwebos/meta-webos/commit/8eb313e4303defbe495cf7f91974799046975fca
then I've dropped this 2 years ago in:
https://github.com/webosose/meta-webosose/commit/95d7c2798d6f0a7a227db9631775eff7a2928596
after failed attempt to upstream this to oe-core and upstream glibc reaction.

The LICENSE information in the recipe isn't complete and as Peter
wanted to fix "or later" part I though he might be interested in other
licenses as well.

There weren't many changes in:
https://sourceware.org/git/?p=glibc.git;a=history;f=LICENSES;h=530893b1dc9ea00755603c68fb36bd4fc38a7be8;hb=HEAD
but the last commit looks interesting.

Cheers,
diff mbox series

Patch

diff --git a/meta/recipes-core/glibc/glibc-common.inc b/meta/recipes-core/glibc/glibc-common.inc
index b9516e77f0..91a3f5bcd5 100644
--- a/meta/recipes-core/glibc/glibc-common.inc
+++ b/meta/recipes-core/glibc/glibc-common.inc
@@ -2,7 +2,7 @@  SUMMARY = "GLIBC (GNU C Library)"
 DESCRIPTION = "The GNU C Library is used as the system C library in most systems with the Linux kernel."
 HOMEPAGE = "http://www.gnu.org/software/libc/libc.html"
 SECTION = "libs"
-LICENSE = "GPL-2.0-only & LGPL-2.1-only"
+LICENSE = "GPL-2.0-only & LGPL-2.1-or-later"
 
 LIC_FILES_CHKSUM ?= "file://LICENSES;md5=f77e878d320e99e94ae9a4aea7f491d1 \
       file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \