From patchwork Thu Jun 23 16:43:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niko Mauno X-Patchwork-Id: 9548 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA039C433EF for ; Thu, 23 Jun 2022 16:44:16 +0000 (UTC) Received: from sinikuusama2.dnainternet.net (sinikuusama2.dnainternet.net [83.102.40.152]) by mx.groups.io with SMTP id smtpd.web11.64.1656002651917430432 for ; Thu, 23 Jun 2022 09:44:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 spf.protection.outlook.com}: parse error for token &{10 18 spfd.protection.outlook.com}: limit exceeded (domain: vaisala.com, ip: 83.102.40.152, mailfrom: niko.mauno@vaisala.com) Received: from localhost (localhost [127.0.0.1]) by sinikuusama2.dnainternet.net (Postfix) with ESMTP id ED09A1620F; Thu, 23 Jun 2022 19:44:08 +0300 (EEST) X-Virus-Scanned: DNA Internet at dnainternet.net Received: from sinikuusama2.dnainternet.net ([83.102.40.152]) by localhost (sinikuusama2.dnainternet.net [127.0.0.1]) (DNA Internet, port 10041) with ESMTP id 0kLJXwKaVUXe; Thu, 23 Jun 2022 19:44:08 +0300 (EEST) Received: from kirsikkapuu2.dnainternet.net (kirsikkapuu2.dnainternet.net [83.102.40.52]) by sinikuusama2.dnainternet.net (Postfix) with ESMTP id 9B3DB163B5; Thu, 23 Jun 2022 19:44:08 +0300 (EEST) Received: from gasmonkey.vaisala.com (82-181-110-188.bb.dnainternet.fi [82.181.110.188]) by kirsikkapuu2.dnainternet.net (Postfix) with ESMTP id 693843BAF; Thu, 23 Jun 2022 19:44:05 +0300 (EEST) From: Niko Mauno To: openembedded-core@lists.openembedded.org Cc: luca.ceresoli@bootlin.com, Niko Mauno Subject: [PATCHv2 1/3] ptest.bbclass: Honor PARALLEL_MAKE, PARALLEL_MAKEINST Date: Thu, 23 Jun 2022 19:43:54 +0300 Message-Id: <20220623164356.3239-1-niko.mauno@vaisala.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 23 Jun 2022 16:44:16 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/167277 Since oe_runmake wrapper doesn't by default involve PARALLEL_MAKE outside do_compile() nor PARALLEL_MAKEINST outside do_install(), enable parallellized make by default when oe_runmake is invoked from do_compile_ptest() or do_install_ptest() by declaring wrapper task specific EXTRA_OEMAKE overrides in fashion similar to do_compile and do_install overrides in meta/conf/bitbake.conf. Parallel make can still be disabled by resetting bbclass specific PTEST_PARALLEL_MAKE and PTEST_PARALLEL_MAKEINST variables in recipe e.g. if a race issue needs to be avoided without modifying source code. Tested by issuing following command sequence on a 32-core build host: $ bitbake -c clean util-linux && bitbake --skip-setscene -c compile util-linux && time bitbake --skip-setscene -c compile_ptest_base util-linux and found that before this change the result was real 0m34.684s user 0m0.753s sys 0m0.131s and after this change real 0m9.868s user 0m0.749s sys 0m0.150s Signed-off-by: Niko Mauno --- meta/classes/ptest.bbclass | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta/classes/ptest.bbclass b/meta/classes/ptest.bbclass index 1ec23c0923..c162f5d934 100644 --- a/meta/classes/ptest.bbclass +++ b/meta/classes/ptest.bbclass @@ -5,6 +5,10 @@ This package contains a test directory ${PTEST_PATH} for package test purposes." PTEST_PATH ?= "${libdir}/${BPN}/ptest" PTEST_BUILD_HOST_FILES ?= "Makefile" PTEST_BUILD_HOST_PATTERN ?= "" +PTEST_PARALLEL_MAKE ?= "${PARALLEL_MAKE}" +PTEST_PARALLEL_MAKEINST ?= "${PARALLEL_MAKEINST}" +EXTRA_OEMAKE:prepend:task-compile-ptest-base = "${PTEST_PARALLEL_MAKE} " +EXTRA_OEMAKE:prepend:task-install-ptest-base = "${PTEST_PARALLEL_MAKEINST} " FILES:${PN}-ptest += "${PTEST_PATH}" SECTION:${PN}-ptest = "devel" From patchwork Thu Jun 23 16:43:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niko Mauno X-Patchwork-Id: 9549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCA9CCA47C for ; Thu, 23 Jun 2022 16:44:26 +0000 (UTC) Received: from tulikuusama2.dnainternet.net (tulikuusama2.dnainternet.net [83.102.40.151]) by mx.groups.io with SMTP id smtpd.web08.69.1656002659115599281 for ; Thu, 23 Jun 2022 09:44:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 spf.protection.outlook.com}: parse error for token &{10 18 spfd.protection.outlook.com}: limit exceeded (domain: vaisala.com, ip: 83.102.40.151, mailfrom: niko.mauno@vaisala.com) Received: from localhost (localhost [127.0.0.1]) by tulikuusama2.dnainternet.net (Postfix) with ESMTP id 85C9F42357; Thu, 23 Jun 2022 19:44:17 +0300 (EEST) X-Virus-Scanned: DNA Internet at dnainternet.net Received: from tulikuusama2.dnainternet.net ([83.102.40.151]) by localhost (tulikuusama2.dnainternet.net [127.0.0.1]) (DNA Internet, port 10041) with ESMTP id A5v-ha-pQ84u; Thu, 23 Jun 2022 19:44:16 +0300 (EEST) Received: from kirsikkapuu2.dnainternet.net (kirsikkapuu2.dnainternet.net [83.102.40.52]) by tulikuusama2.dnainternet.net (Postfix) with ESMTP id 98E0042307; Thu, 23 Jun 2022 19:44:16 +0300 (EEST) Received: from gasmonkey.vaisala.com (82-181-110-188.bb.dnainternet.fi [82.181.110.188]) by kirsikkapuu2.dnainternet.net (Postfix) with ESMTP id 5EDDE7E; Thu, 23 Jun 2022 19:44:12 +0300 (EEST) From: Niko Mauno To: openembedded-core@lists.openembedded.org Cc: luca.ceresoli@bootlin.com, Niko Mauno Subject: [PATCHv2 2/3] strace: Drop redundant oe_runmake parameter Date: Thu, 23 Jun 2022 19:43:55 +0300 Message-Id: <20220623164356.3239-2-niko.mauno@vaisala.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220623164356.3239-1-niko.mauno@vaisala.com> References: <20220623164356.3239-1-niko.mauno@vaisala.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 23 Jun 2022 16:44:26 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/167278 PARALLEL_MAKE is now honored in ptest.bbclass, so drop redundant parameter from oe_runmake call. Signed-off-by: Niko Mauno --- meta/recipes-devtools/strace/strace_5.18.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/strace/strace_5.18.bb b/meta/recipes-devtools/strace/strace_5.18.bb index 3164ebca51..08f0f1d27e 100644 --- a/meta/recipes-devtools/strace/strace_5.18.bb +++ b/meta/recipes-devtools/strace/strace_5.18.bb @@ -33,7 +33,7 @@ TESTDIR = "tests" PTEST_BUILD_HOST_PATTERN = "^(DEB_CHANGELOGTIME|RPM_CHANGELOGTIME|WARN_CFLAGS_FOR_BUILD|LDFLAGS_FOR_BUILD)" do_compile_ptest() { - oe_runmake ${PARALLEL_MAKE} -C ${TESTDIR} buildtest-TESTS + oe_runmake -C ${TESTDIR} buildtest-TESTS } do_install_ptest() { From patchwork Thu Jun 23 16:43:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niko Mauno X-Patchwork-Id: 9550 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE431C43334 for ; Thu, 23 Jun 2022 16:44:26 +0000 (UTC) Received: from sypressi2.dnainternet.net (sypressi2.dnainternet.net [83.102.40.154]) by mx.groups.io with SMTP id smtpd.web11.68.1656002664400159221 for ; Thu, 23 Jun 2022 09:44:24 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 spf.protection.outlook.com}: parse error for token &{10 18 spfd.protection.outlook.com}: limit exceeded (domain: vaisala.com, ip: 83.102.40.154, mailfrom: niko.mauno@vaisala.com) Received: from localhost (localhost [127.0.0.1]) by sypressi2.dnainternet.net (Postfix) with ESMTP id 81912179F1; Thu, 23 Jun 2022 19:44:22 +0300 (EEST) X-Virus-Scanned: DNA Internet at dnainternet.net Received: from sypressi2.dnainternet.net ([83.102.40.154]) by localhost (sypressi2.dnainternet.net [127.0.0.1]) (DNA Internet, port 10041) with ESMTP id gaBFhs5Eo-MC; Thu, 23 Jun 2022 19:44:22 +0300 (EEST) Received: from kirsikkapuu2.dnainternet.net (kirsikkapuu2.dnainternet.net [83.102.40.52]) by sypressi2.dnainternet.net (Postfix) with ESMTP id 54FF6179EF; Thu, 23 Jun 2022 19:44:22 +0300 (EEST) Received: from gasmonkey.vaisala.com (82-181-110-188.bb.dnainternet.fi [82.181.110.188]) by kirsikkapuu2.dnainternet.net (Postfix) with ESMTP id 1B19F7E; Thu, 23 Jun 2022 19:44:18 +0300 (EEST) From: Niko Mauno To: openembedded-core@lists.openembedded.org Cc: luca.ceresoli@bootlin.com, Niko Mauno Subject: [PATCHv2 3/3] valgrind: Drop redundant oe_runmake parameter Date: Thu, 23 Jun 2022 19:43:56 +0300 Message-Id: <20220623164356.3239-3-niko.mauno@vaisala.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220623164356.3239-1-niko.mauno@vaisala.com> References: <20220623164356.3239-1-niko.mauno@vaisala.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 23 Jun 2022 16:44:26 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/167279 PARALLEL_MAKE is now honored in ptest.bbclass, so drop redundant parameter from oe_runmake call. Signed-off-by: Niko Mauno --- meta/recipes-devtools/valgrind/valgrind_3.19.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/valgrind/valgrind_3.19.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.19.0.bb index 6e3234be6b..69915de505 100644 --- a/meta/recipes-devtools/valgrind/valgrind_3.19.0.bb +++ b/meta/recipes-devtools/valgrind/valgrind_3.19.0.bb @@ -141,7 +141,7 @@ SKIP_FILEDEPS:${PN}-ptest = '1' INSANE_SKIP:${PN}-ptest = "debug-deps" do_compile_ptest() { - oe_runmake ${PARALLEL_MAKE} check + oe_runmake check }