From patchwork Fri Apr 10 10:05:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85810 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BB5E99071 for ; Fri, 10 Apr 2026 10:06:01 +0000 (UTC) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.153077.1775815556931988179 for ; Fri, 10 Apr 2026 03:05:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=DL1BxkH1; spf=pass (domain: gmail.com, ip: 209.85.128.43, mailfrom: martin.jansa@gmail.com) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a041eae5so13061065e9.1 for ; Fri, 10 Apr 2026 03:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815555; x=1776420355; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NlGttw3TXrUId9V3UKJdgAjDUj2rc8ZFMBl6e4Yigxg=; b=DL1BxkH1yKC3zGAm1/tVW9h/Oygr+ddzi/5VChHcOS1jWiIQ7/rHZdF/KdNhHOn/Lr pFfAwr94UBO4ZIwm2RuQX+enovf5QylL9PE2L1xYY9QULPER0q0M5fg4Golf0Rx2AeT+ w5XFCj/yJfQbexcxBW8WdQXrJ5DVP8XnZepNIQM8ufi4WgKbcg8Gl3ZoWkvUAdzZ9LcX kb52pEGL3VkWd7y9Dqekm4/Op88hwvnK+bcjk8Jg5DNIsOuljO/NyuYaVQRfB8lw3pmQ 5pm+WJTGskV7CE7v+yiDscLOBkhWG548vEVgepaMXMSuhZCO4C1ZtreVRBXD6pAR/LkQ buQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815555; x=1776420355; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NlGttw3TXrUId9V3UKJdgAjDUj2rc8ZFMBl6e4Yigxg=; b=Swsu47F6R60RSJx1RAa69C8lsU/Lzz69mE5olLn3O6Fsgs5oK3iYpd8/iDVAmBJp+N OO3bvcVerpgk9bKRZRl0uBvbm9r/AirIzE38/dY5PKk87OxTB8MLNyWySZ5aubX38LWX gHkDbFzrnuM/NROL3Y/IxC7zx0CjOEQ/EQfx4oMzeVJ7VplisjeZclV7S2QiAbwFIMuh PPX1T7bqftN9dkuN8Xm13RWvRJdeP65PyjwuRNOgsT59ZbfptKMibqJcLSWEDIS8W7bz tWPuuCcUT6VEANebxCuK2RzG8qE/jwyw+BdhqY9T26s+LtHX92GtoULPjhdWBgV2tfV1 CRNw== X-Gm-Message-State: AOJu0Yx0OTVxKDZ4aAlMZbR4luF/pZeC5QCttDxAv0SxzHA5dWHzdr5X Ieyu44g4/8XrLaySMgcihD+E+ab3BgmZqVVbfypK1xEx/mU4BhUOMJAt5TLnmQ== X-Gm-Gg: AeBDiesCk+WYirYS4Sn5TT3o/XemR4qbmj1iE8Ut49mhUpAMKxv+fpBpHjChUAZ/TiM WZi6kTIDraDf7C86ZQfl4M2r5HRTNdYmSAUxpU58uNd9PCeJRnw7Ot/dB3Px67sqjkbEyPyXHRV QtK2RgP+VWJEB9cDIMdSjVNwQyEQK3mELbOr3eXXPH51IQ0g8tOaZaqoqpd4YnTVovab9z6W8WO WkFVHplUcPW+BJILTZdvoId0hofNjs2vz+bg+BIqvcoCZ4SgYFX/VVd/zvXU0p+bp5SjA1H5UkK dFydD03UXjovNQ6BEXByJvKdZ+6hjTUKdgjB30CroL1uaOXAGHxJCCr8TsX/Y5S0pNTRKV3Ddy4 b/N2RZ+581yR6BfcEAUgaFpoJe8CAZVr591sVvOn5rfkijs7mLonCWPDoBOum7WCvC0SDvdhOZz lCnhpzU/Wubal+wvoPvwvPaAwAHEQQAyzcm9LtzUL8Zm0bz6GTtD/JxgnzzUL9UOYEExoKfXybU geV79KhUg== X-Received: by 2002:a05:600c:8b6b:b0:488:be21:54b9 with SMTP id 5b1f17b1804b1-488d67ce792mr31132355e9.8.1775815555086; Fri, 10 Apr 2026 03:05:55 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d538c39bsm58426235e9.14.2026.04.10.03.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:54 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Martin Jansa , Mathieu Dubois-Briand , Richard Purdie Subject: [scarthgap][PATCH 1/4] gcc: backport a fix for building with gcc-16 Date: Fri, 10 Apr 2026 12:05:45 +0200 Message-ID: <20260410100548.3944487-1-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:06:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235007 From: Martin Jansa Fixes: https://errors.yoctoproject.org/Errors/Details/905192/ when building on host with gcc-16 Compared to 15.2 used in whinlatter this needs 2 additional backports. Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie Signed-off-by: Martin Jansa --- meta/recipes-devtools/gcc/gcc-13.4.inc | 3 + ...dy-Make-it-buildable-by-C-11-to-C-26.patch | 257 ++++++++++++++++++ ...build-Remove-INCLUDE_MEMORY-PR117737.patch | 46 ++++ ...am-include-above-safe-ctype.h-PR1177.patch | 54 ++++ 4 files changed, 360 insertions(+) create mode 100644 meta/recipes-devtools/gcc/gcc/0028-libcody-Make-it-buildable-by-C-11-to-C-26.patch create mode 100644 meta/recipes-devtools/gcc/gcc/0029-build-Remove-INCLUDE_MEMORY-PR117737.patch create mode 100644 meta/recipes-devtools/gcc/gcc/0030-build-Move-sstream-include-above-safe-ctype.h-PR1177.patch diff --git a/meta/recipes-devtools/gcc/gcc-13.4.inc b/meta/recipes-devtools/gcc/gcc-13.4.inc index eefae13530..2017c44498 100644 --- a/meta/recipes-devtools/gcc/gcc-13.4.inc +++ b/meta/recipes-devtools/gcc/gcc-13.4.inc @@ -66,6 +66,9 @@ SRC_URI = "${BASEURI} \ file://0024-Avoid-hardcoded-build-paths-into-ppc-libgcc.patch \ file://0025-gcc-testsuite-tweaks-for-mips-OE.patch \ file://0027-Fix-gcc-vect-module-testcases.patch \ + file://0028-libcody-Make-it-buildable-by-C-11-to-C-26.patch \ + file://0029-build-Remove-INCLUDE_MEMORY-PR117737.patch \ + file://0030-build-Move-sstream-include-above-safe-ctype.h-PR1177.patch \ " SRC_URI[sha256sum] = "9c4ce6dbb040568fdc545588ac03c5cbc95a8dbf0c7aa490170843afb59ca8f5" diff --git a/meta/recipes-devtools/gcc/gcc/0028-libcody-Make-it-buildable-by-C-11-to-C-26.patch b/meta/recipes-devtools/gcc/gcc/0028-libcody-Make-it-buildable-by-C-11-to-C-26.patch new file mode 100644 index 0000000000..431facb011 --- /dev/null +++ b/meta/recipes-devtools/gcc/gcc/0028-libcody-Make-it-buildable-by-C-11-to-C-26.patch @@ -0,0 +1,257 @@ +From 0ffe3c9af4e5d5468df742512b6e930fe7039230 Mon Sep 17 00:00:00 2001 +From: Jakub Jelinek +Date: Fri, 21 Nov 2025 16:25:58 +0100 +Subject: [PATCH] libcody: Make it buildable by C++11 to C++26 + +The following builds with -std=c++11 and c++14 and c++17 and c++20 and c++23 +and c++26. + +I see the u8 string literals are mixed e.g. with strerror, so in +-fexec-charset=IBM1047 there will still be garbage, so am not 100% sure if +the u8 literals everywhere are worth it either. + +2025-11-21 Jakub Jelinek + + * cody.hh (S2C): For __cpp_char8_t >= 201811 use char8_t instead of + char in argument type. + (MessageBuffer::Space): Revert 2025-11-15 change. + (MessageBuffer::Append): For __cpp_char8_t >= 201811 add overload + with char8_t const * type of first argument. + (Packet::Packet): Similarly for first argument. + * client.cc (CommunicationError, Client::ProcessResponse, + Client::Connect, ConnectResponse, PathnameResponse, OKResponse, + IncludeTranslateResponse): Cast u8 string literals to (const char *) + where needed. + * server.cc (Server::ProcessRequests, ConnectRequest): Likewise. + +Signed-off-by: Martin Jansa +Upstream-Status: Backport [07a767c7a50d1daae8ef7d4aba73fe53ad40c0b7] +--- + libcody/client.cc | 36 +++++++++++++++++++----------------- + libcody/cody.hh | 22 ++++++++++++++++++++++ + libcody/server.cc | 28 ++++++++++++++-------------- + 3 files changed, 55 insertions(+), 31 deletions(-) + +diff --git a/libcody/client.cc b/libcody/client.cc +index ae69d190cb77..147fecdbe500 100644 +--- a/libcody/client.cc ++++ b/libcody/client.cc +@@ -97,7 +97,7 @@ int Client::CommunicateWithServer () + + static Packet CommunicationError (int err) + { +- std::string e {u8"communication error:"}; ++ std::string e {(const char *) u8"communication error:"}; + e.append (strerror (err)); + + return Packet (Client::PC_ERROR, std::move (e)); +@@ -110,33 +110,34 @@ Packet Client::ProcessResponse (std::vector &words, + { + if (e == EINVAL) + { +- std::string msg (u8"malformed string '"); ++ std::string msg ((const char *) u8"malformed string '"); + msg.append (words[0]); +- msg.append (u8"'"); ++ msg.append ((const char *) u8"'"); + return Packet (Client::PC_ERROR, std::move (msg)); + } + else +- return Packet (Client::PC_ERROR, u8"missing response"); ++ return Packet (Client::PC_ERROR, (const char *) u8"missing response"); + } + + Assert (!words.empty ()); +- if (words[0] == u8"ERROR") ++ if (words[0] == (const char *) u8"ERROR") + return Packet (Client::PC_ERROR, +- words.size () == 2 ? words[1]: u8"malformed error response"); ++ words.size () == 2 ? words[1] ++ : (const char *) u8"malformed error response"); + + if (isLast && !read.IsAtEnd ()) + return Packet (Client::PC_ERROR, +- std::string (u8"unexpected extra response")); ++ std::string ((const char *) u8"unexpected extra response")); + + Assert (code < Detail::RC_HWM); + Packet result (responseTable[code] (words)); + result.SetRequest (code); + if (result.GetCode () == Client::PC_ERROR && result.GetString ().empty ()) + { +- std::string msg {u8"malformed response '"}; ++ std::string msg {(const char *) u8"malformed response '"}; + + read.LexedLine (msg); +- msg.append (u8"'"); ++ msg.append ((const char *) u8"'"); + result.GetString () = std::move (msg); + } + else if (result.GetCode () == Client::PC_CONNECT) +@@ -199,7 +200,7 @@ Packet Client::Connect (char const *agent, char const *ident, + size_t alen, size_t ilen) + { + write.BeginLine (); +- write.AppendWord (u8"HELLO"); ++ write.AppendWord ((const char *) u8"HELLO"); + write.AppendInteger (Version); + write.AppendWord (agent, true, alen); + write.AppendWord (ident, true, ilen); +@@ -211,7 +212,8 @@ Packet Client::Connect (char const *agent, char const *ident, + // HELLO $version $agent [$flags] + Packet ConnectResponse (std::vector &words) + { +- if (words[0] == u8"HELLO" && (words.size () == 3 || words.size () == 4)) ++ if (words[0] == (const char *) u8"HELLO" ++ && (words.size () == 3 || words.size () == 4)) + { + char *eptr; + unsigned long val = strtoul (words[1].c_str (), &eptr, 10); +@@ -247,7 +249,7 @@ Packet Client::ModuleRepo () + // PATHNAME $dir | ERROR + Packet PathnameResponse (std::vector &words) + { +- if (words[0] == u8"PATHNAME" && words.size () == 2) ++ if (words[0] == (const char *) u8"PATHNAME" && words.size () == 2) + return Packet (Client::PC_PATHNAME, std::move (words[1])); + + return Packet (Client::PC_ERROR, u8""); +@@ -256,7 +258,7 @@ Packet PathnameResponse (std::vector &words) + // OK or ERROR + Packet OKResponse (std::vector &words) + { +- if (words[0] == u8"OK") ++ if (words[0] == (const char *) u8"OK") + return Packet (Client::PC_OK); + else + return Packet (Client::PC_ERROR, +@@ -319,11 +321,11 @@ Packet Client::IncludeTranslate (char const *include, Flags flags, size_t ilen) + // PATHNAME $cmifile + Packet IncludeTranslateResponse (std::vector &words) + { +- if (words[0] == u8"BOOL" && words.size () == 2) ++ if (words[0] == (const char *) u8"BOOL" && words.size () == 2) + { +- if (words[1] == u8"FALSE") +- return Packet (Client::PC_BOOL, 0); +- else if (words[1] == u8"TRUE") ++ if (words[1] == (const char *) u8"FALSE") ++ return Packet (Client::PC_BOOL); ++ else if (words[1] == (const char *) u8"TRUE") + return Packet (Client::PC_BOOL, 1); + else + return Packet (Client::PC_ERROR, u8""); +diff --git a/libcody/cody.hh b/libcody/cody.hh +index 789ce9e70b75..93bce93aa94d 100644 +--- a/libcody/cody.hh ++++ b/libcody/cody.hh +@@ -47,12 +47,21 @@ namespace Detail { + + // C++11 doesn't have utf8 character literals :( + ++#if __cpp_char8_t >= 201811 ++template ++constexpr char S2C (char8_t const (&s)[I]) ++{ ++ static_assert (I == 2, "only single octet strings may be converted"); ++ return s[0]; ++} ++#else + template + constexpr char S2C (char const (&s)[I]) + { + static_assert (I == 2, "only single octet strings may be converted"); + return s[0]; + } ++#endif + + /// Internal buffering class. Used to concatenate outgoing messages + /// and Lex incoming ones. +@@ -123,6 +132,13 @@ public: + Space (); + Append (str, maybe_quote, len); + } ++#if __cpp_char8_t >= 201811 ++ void AppendWord (char8_t const *str, bool maybe_quote = false, ++ size_t len = ~size_t (0)) ++ { ++ AppendWord ((const char *) str, maybe_quote, len); ++ } ++#endif + /// Add a word as with AppendWord + /// @param str the string to append + /// @param maybe_quote string might need quoting, as for Append +@@ -264,6 +280,12 @@ public: + : string (s), cat (STRING), code (c) + { + } ++#if __cpp_char8_t >= 201811 ++ Packet (unsigned c, const char8_t *s) ++ : string ((const char *) s), cat (STRING), code (c) ++ { ++ } ++#endif + Packet (unsigned c, std::vector &&v) + : vector (std::move (v)), cat (VECTOR), code (c) + { +diff --git a/libcody/server.cc b/libcody/server.cc +index e2fa069bb933..c18469fae843 100644 +--- a/libcody/server.cc ++++ b/libcody/server.cc +@@ -36,12 +36,12 @@ static RequestPair + const requestTable[Detail::RC_HWM] = + { + // Same order as enum RequestCode +- RequestPair {u8"HELLO", nullptr}, +- RequestPair {u8"MODULE-REPO", ModuleRepoRequest}, +- RequestPair {u8"MODULE-EXPORT", ModuleExportRequest}, +- RequestPair {u8"MODULE-IMPORT", ModuleImportRequest}, +- RequestPair {u8"MODULE-COMPILED", ModuleCompiledRequest}, +- RequestPair {u8"INCLUDE-TRANSLATE", IncludeTranslateRequest}, ++ RequestPair {(const char *) u8"HELLO", nullptr}, ++ RequestPair {(const char *) u8"MODULE-REPO", ModuleRepoRequest}, ++ RequestPair {(const char *) u8"MODULE-EXPORT", ModuleExportRequest}, ++ RequestPair {(const char *) u8"MODULE-IMPORT", ModuleImportRequest}, ++ RequestPair {(const char *) u8"MODULE-COMPILED", ModuleCompiledRequest}, ++ RequestPair {(const char *) u8"INCLUDE-TRANSLATE", IncludeTranslateRequest}, + }; + } + +@@ -135,21 +135,21 @@ void Server::ProcessRequests (void) + std::string msg; + + if (err > 0) +- msg = u8"error processing '"; ++ msg = (const char *) u8"error processing '"; + else if (ix >= Detail::RC_HWM) +- msg = u8"unrecognized '"; ++ msg = (const char *) u8"unrecognized '"; + else if (IsConnected () && ix == Detail::RC_CONNECT) +- msg = u8"already connected '"; ++ msg = (const char *) u8"already connected '"; + else if (!IsConnected () && ix != Detail::RC_CONNECT) +- msg = u8"not connected '"; ++ msg = (const char *) u8"not connected '"; + else +- msg = u8"malformed '"; ++ msg = (const char *) u8"malformed '"; + + read.LexedLine (msg); +- msg.append (u8"'"); ++ msg.append ((const char *) u8"'"); + if (err > 0) + { +- msg.append (u8" "); ++ msg.append ((const char *) u8" "); + msg.append (strerror (err)); + } + resolver->ErrorResponse (this, std::move (msg)); +@@ -176,7 +176,7 @@ Resolver *ConnectRequest (Server *s, Resolver *r, + return nullptr; + + if (words.size () == 3) +- words.emplace_back (u8""); ++ words.emplace_back ((const char *) u8""); + unsigned version = ParseUnsigned (words[1]); + if (version == ~0u) + return nullptr; diff --git a/meta/recipes-devtools/gcc/gcc/0029-build-Remove-INCLUDE_MEMORY-PR117737.patch b/meta/recipes-devtools/gcc/gcc/0029-build-Remove-INCLUDE_MEMORY-PR117737.patch new file mode 100644 index 0000000000..d784edefd7 --- /dev/null +++ b/meta/recipes-devtools/gcc/gcc/0029-build-Remove-INCLUDE_MEMORY-PR117737.patch @@ -0,0 +1,46 @@ +From b3f1b9e2aa079f8ec73e3cb48143a16645c49566 Mon Sep 17 00:00:00 2001 +From: Andrew Pinski +Date: Fri, 22 Nov 2024 09:31:44 -0800 +Subject: [PATCH] build: Remove INCLUDE_MEMORY [PR117737] + +Since diagnostic.h is included in over half of the sources, requiring to `#define INCLUDE_MEMORY` +does not make sense. Instead lets unconditionally include memory in system.h. + +The majority of this patch is just removing `#define INCLUDE_MEMORY` from the sources which currently +have it. + +This should also fix the mingw build issue but I have not tried it. + +Signed-off-by: Andrew Pinski +Signed-off-by: Martin Jansa +Upstream-Status: Backport [gcc-15.1.0 b3f1b9e2aa07 partial, only the gcc/system.h change] +--- + gcc/system.h | 8 +------- + 1 file changed, 1 insertion(+), 7 deletions(-) + +diff --git a/gcc/system.h b/gcc/system.h +index c18c7c5ec58d..c209871df72d 100644 +--- a/gcc/system.h ++++ b/gcc/system.h +@@ -222,6 +222,7 @@ extern int fprintf_unlocked (FILE *, const char *, ...); + #ifdef INCLUDE_FUNCTIONAL + # include + #endif ++# include + # include + # include + # include +@@ -758,13 +759,6 @@ private: + #define LIKELY(x) (__builtin_expect ((x), 1)) + #define UNLIKELY(x) (__builtin_expect ((x), 0)) + +-/* Some of the headers included by can use "abort" within a +- namespace, e.g. "_VSTD::abort();", which fails after we use the +- preprocessor to redefine "abort" as "fancy_abort" below. */ +- +-#ifdef INCLUDE_MEMORY +-# include +-#endif + + #ifdef INCLUDE_MUTEX + # include diff --git a/meta/recipes-devtools/gcc/gcc/0030-build-Move-sstream-include-above-safe-ctype.h-PR1177.patch b/meta/recipes-devtools/gcc/gcc/0030-build-Move-sstream-include-above-safe-ctype.h-PR1177.patch new file mode 100644 index 0000000000..270c91c345 --- /dev/null +++ b/meta/recipes-devtools/gcc/gcc/0030-build-Move-sstream-include-above-safe-ctype.h-PR1177.patch @@ -0,0 +1,54 @@ +From ac90b5c413c1565fb37cf79b92f6859b3852254a Mon Sep 17 00:00:00 2001 +From: Andrew Pinski +Date: Mon, 25 Nov 2024 14:03:27 -0800 +Subject: [PATCH] build: Move sstream include above safe-ctype.h {PR117771] + +sstream in some versions of libstdc++ include locale which might not have been +included yet. safe-ctype.h defines the toupper, tolower, etc. as macros so the +c++ header files needed to be included before hand as comment in system.h says: +/* Include C++ standard headers before "safe-ctype.h" to avoid GCC + poisoning the ctype macros through safe-ctype.h */ + +I don't understand how it was working before when memory was included after +safe-ctype.h rather than before. But this makes sstream consistent with the +other C++ headers. + +Pushed as obvious after a build for riscv64-elf. + +gcc/ChangeLog: + + PR target/117771 + * system.h: Move the include of sstream above safe-ctype.h. + +Signed-off-by: Andrew Pinski +Signed-off-by: Martin Jansa +Upstream-Status: Backport [gcc-15.1.0 f6e00226a4ca63e76e3e0b3a09a4ce6223980981] +--- + gcc/system.h | 7 +++---- + 1 file changed, 3 insertions(+), 4 deletions(-) + +diff --git a/gcc/system.h b/gcc/system.h +index 33245e76a986..ff983986153c 100644 +--- a/gcc/system.h ++++ b/gcc/system.h +@@ -222,6 +222,9 @@ extern int fprintf_unlocked (FILE *, const char *, ...); + #ifdef INCLUDE_FUNCTIONAL + # include + #endif ++#ifdef INCLUDE_SSTREAM ++# include ++#endif + # include + # include + # include +@@ -742,10 +745,6 @@ extern int vsnprintf (char *, size_t, const char *, va_list); + # include + #endif + +-#ifdef INCLUDE_SSTREAM +-# include +-#endif +- + #ifdef INCLUDE_MALLOC_H + #if defined(HAVE_MALLINFO) || defined(HAVE_MALLINFO2) + #include From patchwork Fri Apr 10 10:05:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C90E99076 for ; Fri, 10 Apr 2026 10:06:01 +0000 (UTC) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.152788.1775815557760045095 for ; Fri, 10 Apr 2026 03:05:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=D7TlV9rc; spf=pass (domain: gmail.com, ip: 209.85.128.47, mailfrom: martin.jansa@gmail.com) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483487335c2so20216315e9.2 for ; Fri, 10 Apr 2026 03:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815556; x=1776420356; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hEgByVqts7D4zu+V3hq/yxQSzwcDJhl1D1IhZ0fwTuI=; b=D7TlV9rcrIToKBALrJEXiA+7hYaTLv5LRE38QiPMRJ7X4D1P1IrCNluRV493FnRZ/p DfwQzPPm4HW8HQ12bOwcge6Ag6pHrromepp8k9rjCt2khlETuZmclG508YmXYaIp0DIT uB5cQjoJmP6pEJt+n4OCehj7Qxma1UhrMjxVBYeQJ6WWqwFIgPOkhbdgrcn8s1TxSoDg HTUWeS4LP53YiacUf4sG857uievQ5LoHPoY/KcaL0eOOb9GscbgdpdMjTdN/LTmklwLg gIwt48cltXFH/3LPU8q6Gk+3BeSX9ZlBILUar21oFHaAkzFgyQCvfV7aZEip3M1FkgEj FvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815556; x=1776420356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hEgByVqts7D4zu+V3hq/yxQSzwcDJhl1D1IhZ0fwTuI=; b=sqoSlESQWj2oVkEcF8HBYhRYskJ9KyIdLlF+d2awxzjPJytrXMh+jdVsTNOvAASILO BjkN5YNHohNeMtxMsec53S6p87KbtHG0FgyyEz2h3OefOd1tUbcN0cF0keeejktDUGgy TWRA7VWcPjNWlQqL3xfEESpkp0MuRDPL5/tAQLmY/bLpyBcZpKj7h022jmX+c7eon0NR RyW0Nbb/f5UoFvmGeSIDABUc1sWMBMzXAgIJZj1GMGkpuiQPOxh4SBVdneeGwFNFgT3W AVuuQ9FQBm/je+qxDrNfiiCJS/1nyoZmowh3VgGAoYyuWPJ5DmkY/kKSIBLgcOvfFkng 1jBw== X-Gm-Message-State: AOJu0YxO4YO3QrfxDJL7YxbrG6K7OZ5/IidUphIsw4h/IaDu4PcxO1b4 Cza5w72+5C3OItZD6kuwsgikHgBfyBO1XDyrE6ayUrMVGnx3/OTITcA6jFlyQQ== X-Gm-Gg: AeBDietGZFl0rEu0kfYB0EfrvqsTd+9WS/lxrD2NT/bIWe9bAhLBMWpFnJ8OtKEJTxe PMA1KuRhW1ycSjt9TuUus7pVCiJ3Z3VZxCNW5NRfb58nqzb3G7+RqWoOU4K7BWEL6oX5S6NanK1 V8MvUTkS5LdJ60eY5g7kJP2LpPh/PfRNIWYiMjb3M+nsGGgd1gCt/AqGKLVSphmbIChZdtknQbt R4OCWGo5F5I6rv/vgNFmnkjQHBQKOrpZUWmUxXB2SNNDOtdjDw7BCooOQwkyON0ElGpwkIE5bxI dVisQLHgOBN+B71YcrP0IikUuJXG7jnqP+jJsVnEuJimoHSmntlFkl5pn1pns83l0FhbOLGAziG Gm0dJstzd6BvHyWOC0xy9fFxbgwah7AQCsz4TIQPvNKPzq2J9rZLkSSsDX+dnIN9t+wIzKC9wQJ EK7POglHfzerbdqrEtWi6MDl6Q+TnEvQkE21Zkb7umF82PgcTHyYN1HOyDSq20t5bDKPXAa7J6u N5yxmWaqw== X-Received: by 2002:a05:600c:64cf:b0:485:b6dd:5066 with SMTP id 5b1f17b1804b1-488d67ce664mr28345645e9.7.1775815555909; Fri, 10 Apr 2026 03:05:55 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d525c931sm61633405e9.0.2026.04.10.03.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:55 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Hemanth Kumar M D , Richard Purdie Subject: [scarthgap][PATCH 2/4] libxcrypt: avoid discarded-qualifiers build failure with glibc 2.43 Date: Fri, 10 Apr 2026 12:05:46 +0200 Message-ID: <20260410100548.3944487-2-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410100548.3944487-1-martin.jansa@gmail.com> References: <20260410100548.3944487-1-martin.jansa@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:06:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235008 From: Hemanth Kumar M D With the glibc 2.43 upgrade, building nativesdk-libxcrypt triggers a -Wdiscarded-qualifiers warning in crypt-gost-yescrypt.c and crypt-sm3-yescrypt.c which becomes a build failure due to -Werror. Signed-off-by: Hemanth Kumar M D Signed-off-by: Richard Purdie --- meta/recipes-core/libxcrypt/libxcrypt.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index ee6875aa05..11ec87c14e 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -23,6 +23,7 @@ S = "${WORKDIR}/git" BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir} -Wno-error" CPPFLAGS:append:class-nativesdk = " -Wno-error" +CFLAGS:append:class-nativesdk = " -Wno-error=discarded-qualifiers" API = "--disable-obsolete-api" EXTRA_OECONF += "${API}" From patchwork Fri Apr 10 10:05:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1918DE99074 for ; Fri, 10 Apr 2026 10:06:01 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.153079.1775815558497168169 for ; Fri, 10 Apr 2026 03:05:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=LH6b/qYc; spf=pass (domain: gmail.com, ip: 209.85.128.46, mailfrom: martin.jansa@gmail.com) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48374014a77so25387725e9.3 for ; Fri, 10 Apr 2026 03:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815557; x=1776420357; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1fyyTVq8e8XuYXA844yDoJEYeGMSVdIMZTOmgyhTbIY=; b=LH6b/qYcscgIKtcp8yrrHX+U6OpTEFcXzmnjLHuxu6jgkcd/Kn0R6OqPig4iUeh50b 8SNlTnmjaleL/sVLTYqCrksu9xWVgeQpjzFnzOgxhNl6DcSWugy9otiernZUeM0c35Sh TSX0/kuhz+p78xspYvP4XX0GQLj/M36rh2jypnQQnGOIkONH3Ab4A3HSq9tj174O8Prw BjLoDzrL7E9TBaHjL1C/8S9ymvzbDQ7acS6+0gegTNjWPUEaO0srFud8DjUG/tmhUgzQ TwqrULCWixBuwvNR2XZr3gKWucAvMoJH1H4ukQlTlLzWAi6raNq0cbD1N6HeqkOVC3uh 57+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815557; x=1776420357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1fyyTVq8e8XuYXA844yDoJEYeGMSVdIMZTOmgyhTbIY=; b=nBlZqWPCeFMfngWvudrubwKuz0NkdzHIu1HHsOVizjYQp9Vp0ykcriEvUhR967NedD dXNUypFHs+ni6mBBWdSQ4O0nkzrtkmJ2rT4J3V5dgnT0AF13BvDJQ1WDi6tBeKcKwrIN q8idg1RO8mIF5XxFU7UmukI/lkqtYOMfX5cOaWJrXDKA9/zeJHz9QDExIeACIpE2RTBe 8/x3SZI3Od5Xk5ihfiVuJZtVf3BVmlT4VWu7oFYUv2wmgcHTZ992xrIJ+HLVp6bRjgWw C7qcqXf5bFyjnAbwb/DMd3w3vzwugY/3ND1MjKKkO1exuxtqxvjZt8PmDA9uIQoxomJG VhHQ== X-Gm-Message-State: AOJu0Ywd8d/KL1rbttGEDksyBKl4h66g9TkQKuDi2kC4/BMftzTpJsgb MFNr2GADEHbTw+SrKCQEEW5hkcFRWxloV52blVUcpAnXLcJZ5+DfiW+u0oKEjg== X-Gm-Gg: AeBDieurQ7cY/IUYNGVgRbCIlgLJOwB8TEjOKEpcauFJ/AeL5XTlZ4UEymgto1odzYg Xx4JAlidBkn4o8s27mBOnvGPaf7GYPEVQZjN6huLDQ5JnFrhQuGBC+SPC3MMXOTb/ye31viUjq5 Oioc0FDiy4/kOvV8xSVlxXyQvXz5lItewjfhDo3quTga4ClPMllbsWclIiAhwhus9r52jzVGD7J GQNTpEdygxdmzqFvgwdlPPAriOlyEzmfqhBI3do4kRvvBZnqiUh4M0dXpeAVc/+uADKCDegF/RK x28z1o1toKYgiN7PG+tq29qc1v9sfMoJpv3H8oi5RFqCBNOF9DslR8nyz0zPITZYR6Y7mu7K9jW LwTZekXZrxG/rccF1xK0bDiN+LfTA6cqlLFvaj+YCmtsvjmLslnHkuzuKMtGC/LYYBM6f1aZDfI veXT6x4evBboYejt49O0LS6h8Mg052QXmgKjI6fSmcw4/1qwasmJ48dCQrXk8iNeBtJDCXGggG0 8CcTGAxNg== X-Received: by 2002:a05:600c:a010:b0:487:300:d9ca with SMTP id 5b1f17b1804b1-488d68af201mr32899895e9.31.1775815556741; Fri, 10 Apr 2026 03:05:56 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d531f1f9sm77551285e9.1.2026.04.10.03.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:56 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Khem Raj , Khem Raj , Richard Purdie Subject: [scarthgap][PATCH 3/4] libxcrypt: Fix build wrt C23 support Date: Fri, 10 Apr 2026 12:05:47 +0200 Message-ID: <20260410100548.3944487-3-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410100548.3944487-1-martin.jansa@gmail.com> References: <20260410100548.3944487-1-martin.jansa@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:06:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235009 From: Khem Raj latest glibc has better C23 support and exposes this problem Fixes following errors seen in nativesdk-libxcrypt | ../sources/libxcrypt-4.5.2/lib/crypt-sm3-yescrypt.c:139:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] | 139 | char *hptr = strchr ((const char *) intbuf->retval + 3, '$'); | | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | 6 errors generated. Compared to wrynose remove lib/crypt-sm3-yescrypt.c change, because the file doesn't exist in the version used in scarthgap, it was failing only in lib/crypt-gost-yescrypt.c Signed-off-by: Khem Raj Signed-off-by: Richard Purdie --- ...24d6e87aeae631bc0a7bb1ba983cf8def4de.patch | 29 +++++++++++++++++++ meta/recipes-core/libxcrypt/libxcrypt.inc | 4 ++- 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch diff --git a/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch b/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch new file mode 100644 index 0000000000..456788e585 --- /dev/null +++ b/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch @@ -0,0 +1,29 @@ +From 174c24d6e87aeae631bc0a7bb1ba983cf8def4de Mon Sep 17 00:00:00 2001 +From: Stanislav Zidek +Date: Wed, 10 Dec 2025 14:03:54 +0100 +Subject: [PATCH] fix -Werror=discarded-qualifiers + +On Fedora rawhide (to be Fedora 44), gcc became more strict +wrt. const-ness. + +Upstream-Status: Backport [https://github.com/besser82/libxcrypt/pull/220 without lib/crypt-sm3-yescrypt.c] +Signed-off-by: Khem Raj + +--- + lib/crypt-gost-yescrypt.c | 2 +- + lib/crypt-sm3-yescrypt.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/lib/crypt-gost-yescrypt.c b/lib/crypt-gost-yescrypt.c +index 190ae94b..e9dc7e80 100644 +--- a/lib/crypt-gost-yescrypt.c ++++ b/lib/crypt-gost-yescrypt.c +@@ -131,7 +131,7 @@ crypt_gost_yescrypt_rn (const char *phrase, size_t phr_size, + intbuf->outbuf[1] = 'g'; + + /* extract yescrypt output from "$y$param$salt$output" */ +- char *hptr = strchr ((const char *) intbuf->retval + 3, '$'); ++ char *hptr = strchr ((char *) intbuf->retval + 3, '$'); + if (!hptr) + { + errno = EINVAL; diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index 11ec87c14e..4e240f4d14 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -9,7 +9,9 @@ LIC_FILES_CHKSUM = "file://LICENSING;md5=c0a30e2b1502c55a7f37e412cd6c6a4b \ inherit autotools pkgconfig -SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH};protocol=https" +SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH};protocol=https \ + file://174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch \ +" SRCREV = "f531a36aa916a22ef2ce7d270ba381e264250cbf" SRCBRANCH ?= "master" From patchwork Fri Apr 10 10:05:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A18BE99079 for ; Fri, 10 Apr 2026 10:06:01 +0000 (UTC) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.152789.1775815559331755199 for ; Fri, 10 Apr 2026 03:05:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=rNJ+XWyy; spf=pass (domain: gmail.com, ip: 209.85.128.44, mailfrom: martin.jansa@gmail.com) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso21366405e9.2 for ; Fri, 10 Apr 2026 03:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815558; x=1776420358; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n4mFJU2HtVnzfIqJWLtaALRDMxIR5J59x1n90ESHOBg=; b=rNJ+XWyyb6kHZCYJIKygFFwZlCpySmN/p/tJT12yVElD1YNiLsUDoDhMg7wntakw3n 8cntnjpRMGd8NS4sM3tTQRtslxrhQDpUiV57aV6SHLcwQpKViaLGC93hzZIcEpT54AfH z/M5t3ahqYtgDEpCySt6assPv2euucBx0bl5hQoQpTJ3/yxs/HbPKiue8Dg/NhcHP9Ci dKxvhIP/9pcsabafyNeWteMLAV/RVuLJWA8hD6RR65nuUnj8nX0snvSXnIeEI9gfMjE6 s+XQfKHXXVS6ibm7yjeJdxDrFGxh4Z7wxg2HsG/ulhPAH7TwbtUKuTwjf8glJhe7/oxy IrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815558; x=1776420358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n4mFJU2HtVnzfIqJWLtaALRDMxIR5J59x1n90ESHOBg=; b=X0v2sCsgS1RlOaki5bqiftb7o/EwnHhwEabYHLd7yZKCbeGYsCFkXMbF6ZyQBnbJJz ncSmCeaFcJHjF3ETZRbxIB8FPf4sPKD329NsMYkeV7VcKrwEEFC6cApGS8TxHEZTZ+sv M+T/zov0+Qs2QqeEK2DNrK39ACyHpXalxWaV+ggeiwWBV6UFtvHCnhvcSikBE2OAbqks QQ15Masi4CNlK4GGglhuTh4KhZILktFV7pehKvbLSNS33t3f9fgRV0l3BMk5wnUeCyqs qdGohVn0C/1jmORl73X8I7oqo2AyY0xbuvw67qNWo+oacnjKJ/pAEHdbshuoTnOufZ+I 308g== X-Gm-Message-State: AOJu0Yzo3Ccm+zTzvtnE7t9hen2D6kQ8XVFS4mho/NMvTg8bRX5eawL/ pENZG6VCTiCHWS/9aI6WIBLdo/9CgyDKxbIqc2Ha89uksTT0+HPzbThOymc2sw== X-Gm-Gg: AeBDievqV3y//t96wuNNrfjm52YszyS1cFKyNCkSNfs8BiPlCBjclk0Pn4zcetLg166 lWcJ8i4jHrKQC90zFHrNFF/Hw5weu8AG2UISOsePEVtKMKzAPHuCHUCsgFYJFe4OpMDjRiEjn7i Pa85mV2JEkaZjIYk0NcKsprpd7sgvSlugKxH2u19cIT9r+joZ4ATzBBq/2cNkBaPhrsOXZuNh1A rGHmQrhYvppn3ohsphr9ZicZZokDO91kaYEGH2jfHZVPNAQfbg0jfOaGd/P5qcMMRF6avsdjg7O EtGLWb+RaL5x+sHQOjdRw56fGpfNZQFGZQDs/qHiP+HgKdZIQ/TFEiE0gXXk8Y1ucwL4BvjFxDM qx+WysnfmH4Xj3x8ruvMKpNKOkL0WGjB0nrNLw8qFHDyCGMmKvpdEuwSajERheR3VtWBD8kgFfx TtJ/9OBD94dtZ3+f+78/E/IPNKbZYYMGcZ+HE10os37vAksA77CPSHDS4+ooZiTgWl8Jrp+EFru a07C3S+Tw== X-Received: by 2002:a05:600c:45c9:b0:480:4a8f:2d5c with SMTP id 5b1f17b1804b1-488d689cf9emr26974795e9.29.1775815557602; Fri, 10 Apr 2026 03:05:57 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e462fdsm5921719f8f.22.2026.04.10.03.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:57 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Khem Raj , Khem Raj , Richard Purdie Subject: [scarthgap][PATCH 4/4] libxcrypt: Use configure knob to disable warnings as errors Date: Fri, 10 Apr 2026 12:05:48 +0200 Message-ID: <20260410100548.3944487-4-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410100548.3944487-1-martin.jansa@gmail.com> References: <20260410100548.3944487-1-martin.jansa@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:06:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235010 From: Khem Raj Passing Wno-error via environment flags for target and nativesdk is intended but is not effective due to command line ordering and as a result some patches have been added to disable particular kind of warning as error. Given the scenario, warnings as errors should be disabled for all builds, this makes it portable across hosts and across compilers ( gcc, clang ) and glibc versions. Signed-off-by: Khem Raj Signed-off-by: Richard Purdie --- meta/recipes-core/libxcrypt/libxcrypt.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index 4e240f4d14..25c4fde813 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -23,9 +23,9 @@ PROVIDES = "virtual/crypt" S = "${WORKDIR}/git" BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" -TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir} -Wno-error" -CPPFLAGS:append:class-nativesdk = " -Wno-error" -CFLAGS:append:class-nativesdk = " -Wno-error=discarded-qualifiers" +TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}" + +EXTRA_OECONF += "--disable-werror" API = "--disable-obsolete-api" EXTRA_OECONF += "${API}"