From patchwork Fri Apr 10 10:05:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE55BE9906F for ; Fri, 10 Apr 2026 10:05:30 +0000 (UTC) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.153072.1775815523091127868 for ; Fri, 10 Apr 2026 03:05:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=F+WoS8J0; spf=pass (domain: gmail.com, ip: 209.85.128.42, mailfrom: martin.jansa@gmail.com) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so17575815e9.0 for ; Fri, 10 Apr 2026 03:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815521; x=1776420321; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MgbXVlkW+k2nQWLosNO3RU4U5oMGprrZublJaA5dCME=; b=F+WoS8J0xJLXXB3+Bndp8e2K9UdipbVH4GOMB/grS3mCG+MO7svIlnDypw7DTvm+KN AoOcF+SA+DfWf2Gm/pdBYgABTalh2EfFO+BlXrZSlBH0Z3g+ZpBjORDC3AWJreEvP0xB wCLsynzU2YktAOQoJEXhuukN/34DTxvpH4LB/ItFwOdiifd1KObYm1DmoJvW5lVPk83m u6KxgTsvsnKlac/LBsnCTw+FdHGGO1TveDMai85kwKfLpqTSZoByQoxFc94sJ6lvJVuv XCwu+8mNZv5SxkZMPVvvmQLMFCPPztpZypxkN3M5X14BFSfX8lYLF6uHfCo90NOo8vAN 2zXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815521; x=1776420321; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MgbXVlkW+k2nQWLosNO3RU4U5oMGprrZublJaA5dCME=; b=n1NsOpEjm6u0r83azatOfqUZePhc51mRL1GVpMW3pNm0Nxo0IUpgdFbF+lXHfwrXiN 6gv81CTZn9g9L2Wt6qcwANeuBGv0rRp1AJIhLQBGrXomJc6V4eeRBUHyukemF+MxZgnp vaMOf56MJ08mOGipYBvzhxDMlzGNGXWDGkCGF5akzHsQPnG0a8XbibodGSo3tQVTnkvt Jbh1j9Xtv5Uqr7Gc1pyh2poTKDfdNw8J/D7kVnAMz0qKi/VhmfildskhxtW0DXFebBbl qzroCV5+GQE38xNfoIW8vor+jVaEiTTYGdalBfCkSJWnHmMjqrsVPY5O9JGDgBEgxzic XHzQ== X-Gm-Message-State: AOJu0Yx6kN/oHXopGl2SzqRxgtnMgjUhgT+0QQ99QTxEnnB6jpobuAKO a2fPUtSUg3Z4te1AwfUrMozka20/upZO0EZVF197RnYrxCGFWVk5ultCbwNa4Q== X-Gm-Gg: AeBDietPQNMGc5mqUZ58v89ettdP+NCEDryo70jvMEbKMzitsOQF+GzV5AbwUEnKWat 4WHX9imhMBzQwYLOJGrkjz3QybugvE/aPjLMzamHvO0E9he0zwkJBS7tLAjJSh/vlUnjCMqvp8z OJODXg8gbdOmCs6IOTskq2F6shCeVTq76rjBW0L8psPk/winIIuRlV0cr7xgOVg5c6QOQeRftHt odKiaW4JvFHsZB3fFxfsaHBswyMvawGlHTpYqK8dFLCtxo0J+rTwNsbv800yC+vSySivYSJjSVv Frsr+rIfVLTRDH0ynaugj+AryQXddDbqgIj+BD8J9CY8zRJBpZZ6L/hvpiiiyX0FAHUYDPBJpN/ kqfzEX88Zb2rIkKCxTJXGgEDezw2gzi/OkDtpTcGfyI+kVQoks4GLWG8kXUvXnXBp3+MyL6PpeB OXrjZ5Bup7JyHFc7YMv30rZ37LlWgMHqe7fx/jIBES9LiNFMyyje+LcvK4XyzUgh/PtScLJpM64 Kl8yJIKOA== X-Received: by 2002:a05:600c:314b:b0:488:b241:2c5f with SMTP id 5b1f17b1804b1-488d687c076mr24756495e9.26.1775815521392; Fri, 10 Apr 2026 03:05:21 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd10b1dbsm93862315e9.2.2026.04.10.03.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:20 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Hemanth Kumar M D , Richard Purdie Subject: [whinlatter][PATCH 1/3] libxcrypt: avoid discarded-qualifiers build failure with glibc 2.43 Date: Fri, 10 Apr 2026 12:05:14 +0200 Message-ID: <20260410100516.3923530-1-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:05:30 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235004 From: Hemanth Kumar M D With the glibc 2.43 upgrade, building nativesdk-libxcrypt triggers a -Wdiscarded-qualifiers warning in crypt-gost-yescrypt.c and crypt-sm3-yescrypt.c which becomes a build failure due to -Werror. Signed-off-by: Hemanth Kumar M D Signed-off-by: Richard Purdie --- meta/recipes-core/libxcrypt/libxcrypt.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index da515d1927..1292f4288b 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -19,6 +19,7 @@ PROVIDES = "virtual/crypt" BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir} -Wno-error" CPPFLAGS:append:class-nativesdk = " -Wno-error" +CFLAGS:append:class-nativesdk = " -Wno-error=discarded-qualifiers" API = "--disable-obsolete-api" EXTRA_OECONF += "${API}" From patchwork Fri Apr 10 10:05:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85808 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18B2E99073 for ; Fri, 10 Apr 2026 10:05:30 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.152779.1775815524081172527 for ; Fri, 10 Apr 2026 03:05:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=lyto1PFx; spf=pass (domain: gmail.com, ip: 209.85.221.49, mailfrom: martin.jansa@gmail.com) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfd96354aso1147234f8f.1 for ; Fri, 10 Apr 2026 03:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815522; x=1776420322; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vk5G1KDkU4a8uYmSA8XiYTz/zaU1i7kxIjXcZpaSWkQ=; b=lyto1PFxNbZJlayii+DaM8HbK3UX8YZW34rVR31hNrxou6pLvZm2EUyYHin1Mj/xpX toDjuD/QRFwW4w1UtphIaF9Bf8gS7Iz1yyh//EmTrOKLm7pQpE5TS/VIDPp1Pnt7Mtc6 2rqdragPTbcLAbTcHvWe7ME/DDTAP/wscCoTy6BTjCMvNd1A/tz2FaQVBD+B5B9FnzkT bqgAlJXqpOz6f5bkANCCvVcXSvrfjjkqKECqVlD3SFoV+CosSHP/sGZCU8SGmzGg2QdO 36t7HYkNkkmCIWuG+IZ0T0Hff2caa/0cmab+cEPOqb3PAhRFuhczLecrlBwtEjp72ti9 0aOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815522; x=1776420322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Vk5G1KDkU4a8uYmSA8XiYTz/zaU1i7kxIjXcZpaSWkQ=; b=UFcpWX42eG6feqWSbHmyxG2W5FPXvN2xPU7LcVe20WaLVDUnL7OPtk9pQeCHUsc+80 TBm6qqU57tI7UBlPTElk7zlqC97eKV+U9FF0hfUyAlRvBDpF/KfLaHhNZ8iPF5WucRga cm/d2jrF2yiYyiI5uGNOJyUEnryUXAOSNXvL3Uxc+cCJmxlvOJc6S2mame48uK7FG2lq GbZbhHO8bKGxt52zzuMyNiWYRbR1pP+ca5BGJGzuN2xCSJFs/Niw2DHO2c3UraZfqjXx MZPOQgZPAfRHzXG2GAHTSohoiKAltcN0ONGbpO7sAQAcqou75hMECMgO9n8AO8/dvUrp JDeA== X-Gm-Message-State: AOJu0Yw/BU8jGuh9lq9htRGZDMuTYUom2YvmYycoBs/R5p3fezuhen1I oWfDhXzmzqpl0MkzYd5iUye3zwMuLAauWWV4oZ3x288bbnU6JTnLCR+hQAtGeQ== X-Gm-Gg: AeBDievARvxpGB9BjehAmd0DlPousvLDwzudpkYpkGPLaW3HizeS74WSro0ZaYMtGvT UfwOZMjfXf5WNX4v6oOz5AAWNVC28vuFx3zuqUkQ1RDNR9AmA+HepT953AAssI0xcgi0XDLBJu/ A8CmvTsGXT1cb/gxveWriZztjfSYVLgQLkPuz9omN6fREUMvNVqVPsqastY4ZUJTpt6soSHkP1L vmHnDbAl0nqXuYYEsP6IlR4AekoRnq/AZwpSFudlidSDGwrFTF2hQKTsOM9GqNzxg94QZexMbhH kVWWpXVS80usqkpgwTVUR8TI+YmtHF7IaGQDZT6HIvs3H9EMjcReyTQi8CErRopNJ/gH03En61J uGYRqtfVwpLdkFNW3M3iGCk6e3XwFLQicsZEnZDwD/Owv8QSLxqOxAqH+Wgl1H0D5D3wv1dvzVC zIzQDTtcVv7Ue7EbTfcb3sotxlrKfgpIq/9jXcQw5fCZyWiUeNqSYw9P7/0fatv2bxfjvsUgh4Z bMwzresc9JGpHeg1y0S X-Received: by 2002:a05:600c:8706:b0:488:b9c6:11ba with SMTP id 5b1f17b1804b1-488d6890cf9mr31341495e9.28.1775815522248; Fri, 10 Apr 2026 03:05:22 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5344e28sm67447075e9.7.2026.04.10.03.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:21 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Khem Raj , Khem Raj , Richard Purdie Subject: [whinlatter][PATCH 2/3] libxcrypt: Fix build wrt C23 support Date: Fri, 10 Apr 2026 12:05:15 +0200 Message-ID: <20260410100516.3923530-2-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410100516.3923530-1-martin.jansa@gmail.com> References: <20260410100516.3923530-1-martin.jansa@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:05:30 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235005 From: Khem Raj latest glibc has better C23 support and exposes this problem Fixes following errors seen in nativesdk-libxcrypt | ../sources/libxcrypt-4.5.2/lib/crypt-sm3-yescrypt.c:139:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] | 139 | char *hptr = strchr ((const char *) intbuf->retval + 3, '$'); | | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | 6 errors generated. Compared to wrynose remove lib/crypt-sm3-yescrypt.c change, because the file doesn't exist in the version used in whinlatter, it was failing only in lib/crypt-gost-yescrypt.c Signed-off-by: Khem Raj Signed-off-by: Richard Purdie --- ...24d6e87aeae631bc0a7bb1ba983cf8def4de.patch | 29 +++++++++++++++++++ meta/recipes-core/libxcrypt/libxcrypt.inc | 1 + 2 files changed, 30 insertions(+) create mode 100644 meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch diff --git a/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch b/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch new file mode 100644 index 0000000000..456788e585 --- /dev/null +++ b/meta/recipes-core/libxcrypt/files/174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch @@ -0,0 +1,29 @@ +From 174c24d6e87aeae631bc0a7bb1ba983cf8def4de Mon Sep 17 00:00:00 2001 +From: Stanislav Zidek +Date: Wed, 10 Dec 2025 14:03:54 +0100 +Subject: [PATCH] fix -Werror=discarded-qualifiers + +On Fedora rawhide (to be Fedora 44), gcc became more strict +wrt. const-ness. + +Upstream-Status: Backport [https://github.com/besser82/libxcrypt/pull/220 without lib/crypt-sm3-yescrypt.c] +Signed-off-by: Khem Raj + +--- + lib/crypt-gost-yescrypt.c | 2 +- + lib/crypt-sm3-yescrypt.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/lib/crypt-gost-yescrypt.c b/lib/crypt-gost-yescrypt.c +index 190ae94b..e9dc7e80 100644 +--- a/lib/crypt-gost-yescrypt.c ++++ b/lib/crypt-gost-yescrypt.c +@@ -131,7 +131,7 @@ crypt_gost_yescrypt_rn (const char *phrase, size_t phr_size, + intbuf->outbuf[1] = 'g'; + + /* extract yescrypt output from "$y$param$salt$output" */ +- char *hptr = strchr ((const char *) intbuf->retval + 3, '$'); ++ char *hptr = strchr ((char *) intbuf->retval + 3, '$'); + if (!hptr) + { + errno = EINVAL; diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index 1292f4288b..d84cbc9db3 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://LICENSING;md5=c0a30e2b1502c55a7f37e412cd6c6a4b \ inherit autotools pkgconfig SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH};protocol=https \ + file://174c24d6e87aeae631bc0a7bb1ba983cf8def4de.patch \ " SRCREV = "55ea777e8d567e5e86ffac917c28815ac54cc341" SRCBRANCH ?= "master" From patchwork Fri Apr 10 10:05:16 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jansa X-Patchwork-Id: 85807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDE1E99069 for ; Fri, 10 Apr 2026 10:05:30 +0000 (UTC) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.152780.1775815524867376888 for ; Fri, 10 Apr 2026 03:05:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20251104 header.b=iXGClCor; spf=pass (domain: gmail.com, ip: 209.85.221.54, mailfrom: martin.jansa@gmail.com) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43d43e09de5so983843f8f.1 for ; Fri, 10 Apr 2026 03:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775815523; x=1776420323; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uF2vghswLiIVTlSWaE92Maltcg2c4oidfyDjVrc0B6w=; b=iXGClCorHETlSUo1n22lfmrUYJ3Q9As3eV2tll+1k2GN5fHUbcYwTCUPDiT+KJfXf9 IKWvLZuUIgqOL9LWWn4HaUGtZIgHL+14ceaOAg9t9ZvxIqkrBMRuz22yJs+0CBbaqcZr 1bd5h04w3sn22x2kOXGxvA6J6J3mM2Y1223o4apa3sO3icRZQ5XAXM2t1cWkFc9/Dtsy EyHwaIPQTc81yB1qKDUVwvh0Zk+NhT2ciZUqRh1hjFJERbQvjNqGrps/CW4aLW2/A9u1 qz8ekQq6UNQgAeAJICVNHYBHxPMyRu+TOUH0iv+N5IeRCq4H6V0b5/BxV5ZBu50XW3ru XIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775815523; x=1776420323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uF2vghswLiIVTlSWaE92Maltcg2c4oidfyDjVrc0B6w=; b=qgRfhNMP8Da/YFhsYxfocXUSkvkbZhEEWkShl8zO9dtUTBGhN7mbtYuEUPKMh9/bGT U9WHsISsx91UqMG164PXYpn83xPaLUlIgEub2BbHrshoX/UEr2I+QwHzzEESSGQBeGEV 6Y7l1HDb3TUudIY1NJMTw3zAaRXF1hLeak3AsgCxoCogfvWq3hwwex+bDCuOr6bST7zd nv/fPH5W/k3I804Tz5uJ15VJwCOQXGRGu83AIQsoPLAGdqfpc5lauc1yPzy0jXu382mj 4N5JpdRWWj0AiVkVFY/OvcqtavJ3K9ch2cs66b5PIGlEwHDDYYCfX1fkaT5ug5IC7KxJ fgNg== X-Gm-Message-State: AOJu0YyZG1LshyDf3AGjGMh1ZPtUxJr1YjS8rjjtAUfh6JTjbcR/PlDn bhACvDzu70fJT3oDks8uufpyVU8SkRA3C2ocKvyO4sSdpC9DpCOkx4jLcXkqnQ== X-Gm-Gg: AeBDievRq54/DVkj/KeRIfZdYdBe/AOfr3jCPobmyo8Wa4wVXU1QKq/8lq/6aImbrQ5 sReG8kOKZDJh6NKbNm0CfzsN/VBmwe3t305Hu+cJQGcWwH7WnuQO+zpq8oD00k0PPfuTT7EX1ai 7LYzw5Erq36UyOm5UxuDkcWxDMcJhffxSKCkgeByx+5kBsaBuDSQYNeKPVgUvF+r4K8L8DGdmua W9dimDTC/55AymLMxH/I0jL00Q5hL2QJ6/AfJZm022AZkF2NZxDaZD6alm7xs3QJaUQ2dzoWUte CWg04vQAkmzPJePZh55ut5kmq3vfkGpDOSIpYgIeE2EzchGSTBDb6DoFbEFWi2yauPZe6HdS3Kx TnHhboSnV285azXR4MsXYTdW4dGjWf+eMYZReV7JLJPcpf/ylwroFZp2hNNM+C2F9JXJ6qk13xC rJ2ov9mGlu7u8n6vk5rHtdDU5w2Gk6YS+wO/DEvmsXK6skdHTBbtzhzGBgURm3fLx0jzk40o7V2 2fLoMnrLw== X-Received: by 2002:a05:6000:401e:b0:43d:4a43:53e1 with SMTP id ffacd0b85a97d-43d642cbb41mr3663457f8f.43.1775815523072; Fri, 10 Apr 2026 03:05:23 -0700 (PDT) Received: from localhost ([109.238.218.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5062fsm5840037f8f.31.2026.04.10.03.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 03:05:22 -0700 (PDT) From: martin.jansa@gmail.com To: openembedded-core@lists.openembedded.org Cc: Khem Raj , Khem Raj , Richard Purdie Subject: [whinlatter][PATCH 3/3] libxcrypt: Use configure knob to disable warnings as errors Date: Fri, 10 Apr 2026 12:05:16 +0200 Message-ID: <20260410100516.3923530-3-martin.jansa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410100516.3923530-1-martin.jansa@gmail.com> References: <20260410100516.3923530-1-martin.jansa@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 10 Apr 2026 10:05:30 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/235006 From: Khem Raj Passing Wno-error via environment flags for target and nativesdk is intended but is not effective due to command line ordering and as a result some patches have been added to disable particular kind of warning as error. Given the scenario, warnings as errors should be disabled for all builds, this makes it portable across hosts and across compilers ( gcc, clang ) and glibc versions. Signed-off-by: Khem Raj Signed-off-by: Richard Purdie --- meta/recipes-core/libxcrypt/libxcrypt.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc index d84cbc9db3..25cb7f6178 100644 --- a/meta/recipes-core/libxcrypt/libxcrypt.inc +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc @@ -18,9 +18,9 @@ SRCBRANCH ?= "master" PROVIDES = "virtual/crypt" BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}" -TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir} -Wno-error" -CPPFLAGS:append:class-nativesdk = " -Wno-error" -CFLAGS:append:class-nativesdk = " -Wno-error=discarded-qualifiers" +TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${includedir}" + +EXTRA_OECONF += "--disable-werror" API = "--disable-obsolete-api" EXTRA_OECONF += "${API}"