From patchwork Wed Mar 4 10:43:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Guillevic X-Patchwork-Id: 82442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A517EB7EC8 for ; Wed, 4 Mar 2026 10:43:54 +0000 (UTC) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.15141.1772621032665906561 for ; Wed, 04 Mar 2026 02:43:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile.fr header.s=google header.b=oRt9wzX6; spf=pass (domain: smile.fr, ip: 209.85.128.50, mailfrom: corentin.guillevic@smile.fr) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4806f3fc50bso71247435e9.0 for ; Wed, 04 Mar 2026 02:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1772621031; x=1773225831; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nyBvMxL0Vnvq2XVy6q/9AyepAl1O4rjs176S/KpMPls=; b=oRt9wzX61PMqqlyx7b3q0nsyTjAUf3fBwtQpd86tpC4aAq0Vz70KqmBrPFDNhcciJt PkqvIA+rgWWzKCsSAoKuqPKSsVSw1E/qLTCIWxWgQcbIXOOB5Fk+GI+lO67j9+V+xaI3 5BPOq+K0buGsTIvQh3ZuNF5eDXq6TWtaPxJPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772621031; x=1773225831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nyBvMxL0Vnvq2XVy6q/9AyepAl1O4rjs176S/KpMPls=; b=INoDvhD2ArwqLKvK4NCEgMurS29axqMPF0to+QIjVLbRhlsiLcUcQ5izHD99sibGLZ A1C0iDK1NnstgklLRjMdjRjDahB7UKRa4V0dYJbPu1OoeIcljff0BCynWZPZmyF96Wgf bIiwfgCiROpnFxFyEwvFmomx+wDQmFxKoyUJDsh/96XwtvXG0r8sNPkK//DY4Jq/+WSU kGWYZCJatnSMk0fAkZlmWcEq2I+Bcr6BUwsKIAsZiojdiBB322zEe987Cj5tc+AGTfN8 4PzZxQz0RWFiE1y1l7jVWY/Vr/FntHgnSQZmAmhGYp/1d1b4RwmDt0FSYhls/cnp7y9B jKCw== X-Gm-Message-State: AOJu0YwGLMxm0Ph35BUq6+pPPmSJufPlov6kcCxt2zUhPjUJzzcynpPs /C+NyOpZfahuvVAoNtzKil2RYyGs1P6B1r8bCbmR7lvfU7nXE/5Oa+sPsAU9uAqYZ2LdCorVZ9B AhzLYqMs= X-Gm-Gg: ATEYQzyD94zZcok4FwatjHWIszIRPH9nd3aDPfJQDdEujvNUJYuwmP4mrwuQ49t8nu8 /X6D5oAvone8Fx8EN2HtKuYj2P0lZVdpPt0Pwp35z0UmJP1MmYN38CBn6XqXa9xC4zHITh8fWnm BVGuVBnh3h+YAbuMKVE3PEz+se/yCYPkwonf9f1DWz9s4CujF3trn6ylKBuKrgeie/r/jM3tV+z etbHN1S22JuDjCF9PlaGD0aqGDh6UiPGcTvQC1krvCwn+OZyBC+K42hipjYZ8UO/1WkbPOEwKSO g7mAW+8vLFVIbCrPSgoiE5N6oc4xvLbNSLmGVYwe47rj0KTNeLyzdegI4yiWC4247bWjif9NTWf AwEmbrC2sfIx2QkCaCEEwxgFm36MwmrSk4L/7BzWtRvisOgotCgvIYurG7SR1qPvPWt7cvm+DUO y1b0Ac/2CXzHLJ3yy804DETKukDlBe12jSFuQlpxn38eQr3KRdWDUu+P7l8hbn247Mo5SQdwns1 GkZMORT3L7+tyBue1+Bk3+uXDu7PF0c X-Received: by 2002:a05:600c:4e16:b0:47e:e946:3a72 with SMTP id 5b1f17b1804b1-485198992eemr23961985e9.27.1772621031007; Wed, 04 Mar 2026 02:43:51 -0800 (PST) Received: from heaven.idf.intranet (static-css-ccs-204145.business.bouyguestelecom.com. [176.157.204.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b34b6252sm25638168f8f.10.2026.03.04.02.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 02:43:50 -0800 (PST) From: Corentin Guillevic To: openembedded-core@lists.openembedded.org Cc: Corentin Guillevic Subject: [RFC PATCH 1/4] insane.bbclass: check revision for every git URI Date: Wed, 4 Mar 2026 11:43:39 +0100 Message-ID: <20260304104342.869457-2-corentin.guillevic@smile.fr> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304104342.869457-1-corentin.guillevic@smile.fr> References: <20260304104342.869457-1-corentin.guillevic@smile.fr> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 04 Mar 2026 10:43:54 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/232370 Every git URI into SRC_URI variable should have a revision. However, if the revision is missing (SRCREV), BitBake will perform a query on the remote repository every time it parses a recipe. This check will raise an error if a git URI is not provided alongside a revision. Signed-off-by: Corentin Guillevic --- meta/classes-global/insane.bbclass | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index aeffee7983..349da3a65d 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1493,7 +1493,34 @@ python do_recipe_qa() { error_msg = "%s: invalid PACKAGECONFIG(s): %s" % (pn, " ".join(sorted(invalid_pkgconfigs))) oe.qa.handle_error("invalid-packageconfig", error_msg, d) + def test_git_missing_srcrev(pn, d): + sha1_re = re.compile(r'^[0-9a-f]{40}$') + for uri in d.getVar('SRC_URI').split(): + # Get tokens for the current URI + params = bb.fetch2.decodeurl(uri) + + if params[0] != 'git': + continue + + name = params[5].get('name', '') + rev = params[5].get('rev', '') + + # Revision is provided as a 'rev' parameter + if rev: + # Prevent any revision that doesn't look like a SHA-1 + if not sha1_re.match(rev or ''): + oe.qa.handle_error("missing-srcrev", "%s: ;rev=%s URL parameter doesn't look like a SHA-1" % (pn, rev), d) + # git URI has a "name" parameter + elif name: + rev = d.getVar('SRCREV_' + name) + if not rev: + oe.qa.handle_error("missing-srcrev", "%s: no revision (%s) defined for URI %s" % (pn, 'SRCREV_' + name, uri), d) + else: + if d.getVar('SRCREV') == "INVALID": + oe.qa.handle_error("missing-srcrev", "%s: no revision (SRCREV) defined for URI %s" % (pn, uri), d) + pn = d.getVar('PN') + test_git_missing_srcrev(pn, d) test_naming(pn, d) test_missing_metadata(pn, d) test_missing_maintainer(pn, d) From patchwork Wed Mar 4 10:43:40 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Guillevic X-Patchwork-Id: 82443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B946EB7EC9 for ; Wed, 4 Mar 2026 10:43:54 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.15038.1772621033748849336 for ; Wed, 04 Mar 2026 02:43:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile.fr header.s=google header.b=PCqZfu1H; spf=pass (domain: smile.fr, ip: 209.85.128.46, mailfrom: corentin.guillevic@smile.fr) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48374014a77so81320525e9.3 for ; Wed, 04 Mar 2026 02:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1772621032; x=1773225832; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SFUXLSzwiy/UnmW/n5AFF2pewH8CYf/u9tCOcT3PXQI=; b=PCqZfu1H/yxyTmHbe6CK/Ka5Yj7jynnCbiqvQwLCR03kWW48FhKJ9Gp1bZRPT2Q2DJ WYrMBxI2jwfPAqGkT2327RioKbmzaAAR6aVDwQTbtPwW7QFvvtioPcvNhKLfNaFaMAsq J9MxYfhg1GcJTD3lA4448Qz8rCQchGrTfSRVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772621032; x=1773225832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SFUXLSzwiy/UnmW/n5AFF2pewH8CYf/u9tCOcT3PXQI=; b=BQAJ9GQfjnZqd+pOnNhTcDLdTD+n5pgjW2tJCcKdAzQbOkVcPOXqh5lvAOv6IgivpG QyO7ZqXomnvGTK+C0TzFxPAD/wJ7N8Z4EDpl3lNNOndAN4GaAxdG/0NyzfJnAkWuVq8g PnUkxHcSsWWk52A47bqfY09OwMQlLIwZuKCG//U2XwEbxAx2yT7xedeLN2MUSjnoF+IX I69QPyEVRUO3m1Lb7djrrBh1fxMkf1dGQY3oOgH7uYuO0UpUUHs2bftyTKR0AqKoObIO Z/N8IbjmFHr+JOtw3FAp3mLTL4NsI5KBaYlyuTsFBkDcJCt4rX9i2W+Z4OZNL3RsXuNY ZyiA== X-Gm-Message-State: AOJu0YwR7HdN3Th4ZgdQUoEyPHlqDu+gpkAq9pXjJPZe0DGD3Rqw+PVN yFVLoCPtkFq5C7FaZEcWgvfSivPZfEcT8Yoxio6mqly+K+zGMiCBV/Dqhy+uyqRpegpNwkQxzkl v6+wPgnk= X-Gm-Gg: ATEYQzxpoYdzAXVOAA18ElATL4/o3hfi5Kg+nPsb5JoDZ4ut27tKRZhEr22lIwbL507 +6lgJJiV7ZxFEGExJIxZ5u6TSjcTbDfi3FIwVOGVvLLzYbclVONbkcPOLeZA1e4BLQey/6RbOow CAwCCNuKSkGQ81cIdGl9rQtYosb6tQiv37FaqmKsfZzsL0A0H53RfVuvpPihdC3AsqTb77rdjER zKkC+hbTfRBDIf/sPggymmlpa32FY3gXuk7DLBXEKMNVIjITe6ZfDsTVh//VsUIqktGWsI7CFAw Vqzz38YQuoV7g9BmR9fV1cT2KTJS9PaDXmfP4nBVcruso5pufrVoJmhtcH8RAv/B29K3mNBQ8oP qTS+OSCdMJVxo62Zi6D9B5oMsJDBulKqOkJbJwA+Musec0K445/41DJsHJhr6XhAstwOje9iMGt eCSdnUonBddX/K71dVC+GBcOpWr3PXYNrZ0XdT58YlQ7GwlVtUzh9E1/550ZFPAX7r91rzaSD9j SolDBaR7ueIFMjHIbk30LyBn8VI6ISc X-Received: by 2002:a05:600c:1d26:b0:47d:5e02:14e5 with SMTP id 5b1f17b1804b1-485198310e2mr27012875e9.5.1772621032159; Wed, 04 Mar 2026 02:43:52 -0800 (PST) Received: from heaven.idf.intranet (static-css-ccs-204145.business.bouyguestelecom.com. [176.157.204.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b34b6252sm25638168f8f.10.2026.03.04.02.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 02:43:51 -0800 (PST) From: Corentin Guillevic To: openembedded-core@lists.openembedded.org Cc: Corentin Guillevic Subject: [RFC PATCH 2/4] layer.conf: enable test for revision alongside a git URI Date: Wed, 4 Mar 2026 11:43:40 +0100 Message-ID: <20260304104342.869457-3-corentin.guillevic@smile.fr> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304104342.869457-1-corentin.guillevic@smile.fr> References: <20260304104342.869457-1-corentin.guillevic@smile.fr> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 04 Mar 2026 10:43:54 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/232371 As meta is the main layer, its recipes should fully comply with revisions for git URIs. Enable the check for this layer only. Signed-off-by: Corentin Guillevic --- meta/conf/layer.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf index ba25ca3029..1f95867165 100644 --- a/meta/conf/layer.conf +++ b/meta/conf/layer.conf @@ -19,6 +19,9 @@ BBLAYERS_LAYERINDEX_NAME_core = "openembedded-core" # Set a variable to get to the top of the metadata location COREBASE = '${@os.path.normpath("${LAYERDIR}/../")}' +# Raise an error if no revision is provided with a git URI +ERROR_QA:append:layer-core = " missing-srcrev" + # opkg-utils is for update-alternatives :( SIGGEN_EXCLUDERECIPES_ABISAFE += " \ sysvinit-inittab \ From patchwork Wed Mar 4 10:43:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Guillevic X-Patchwork-Id: 82444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A1EEB7EC9 for ; Wed, 4 Mar 2026 10:44:04 +0000 (UTC) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.15040.1772621034952904851 for ; Wed, 04 Mar 2026 02:43:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile.fr header.s=google header.b=h0EFhMdV; spf=pass (domain: smile.fr, ip: 209.85.221.46, mailfrom: corentin.guillevic@smile.fr) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439b790af67so1874230f8f.0 for ; Wed, 04 Mar 2026 02:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1772621033; x=1773225833; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEx9wT6aKhFf/XOt5xGAQ0dFDlJsXHX32c3svX6JUTI=; b=h0EFhMdVzVmozqo9FnXBe0O+johrwNFaTI8fRHBYMNASKi/fJEkjuQ9kZPhFIEjIrw dSFx8dr+EhYghM4VIuruMSpYOsspC6VF8tEpN6+KeYBuWiU4YwOnDY3+Pzr+lrkCyOht IcHWFqdwHOcivUqqK5ypH4aDlndPRzsmuCPnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772621033; x=1773225833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HEx9wT6aKhFf/XOt5xGAQ0dFDlJsXHX32c3svX6JUTI=; b=GbtjQJFycRt+MMVztddqcvpmgJCOBmeZtiJRD9srMs+x8pScCQKmIr66TYr/E4ahL5 /hUAwnZw38qbtLKjjofPWFZhA5sWyoJSmDLXB96P8gw4czLsN9XVWi/nrpjNCHQyj2YU U2K7IsZCmoFYbrDTg7IrUF5bN0lYb6Gsv0sza2tluEvPRv/TyTxubSreVRRiOge9b+3r DlhWL2AQKGigThu50glO6O9yMi0yuBvXvw1yAmuBrp1QiQfsWPpJwXLFft/F4vtBES6J BCKrUO903vEXSHIivSJ94s+k6kLVK4qw+21D4Kog2SowSmq73wukng00GXyvFXQ2jDPV xHwQ== X-Gm-Message-State: AOJu0YybKgkJPgoiNm3fD2oje9PtXrZbmqTMy7U7jd/3zZIDEUMl99ym YUKV9ZRlLCjqrhRMYS/aPaozfodDK7FKTVjDVNic90SrWQVIQBGEpLsp/gogHS2m3/78Q4GMsnz qVyLg6Mw= X-Gm-Gg: ATEYQzxu226hLv0FU6tGGDHDeLFHYXyVmT5hSot3/e3jMiisUKrurjrGsbkve1L30A8 zXaFgQWVSoXp/RAhfcAtQKYObVhCzHnQwHazExLTLdP/M4hzPJAF3GqysQERtv/WL2P5XUagosv Z5YVsJghd3rRhCO4XWbYGhzhwCk2Q4ffxDQZs2YGC2SfDjZgztbDHXN19AiDZzekC4aDwouoSoP BopPoguM+MfpHXfPek7bGvETg7nPbmRVLhZ4+Yw9iR7RsVQpUjZTpWCcB/sKQ2NLyv/4nCdQlM5 HRVYMX1+ebLqDund1Uw6FWv/yB40+3G0w8jMiUIDxE2S3yE36lqhg5PUFiwRda/JoLVhnwWdLE7 mVc/eKm/ySWdqr0Gdh8BvKvIydtlWJoHjymmwHUso9d9YbMZix/SNghUnLHicngVUFZMjcRjgKz AKxNpKkxKalnMoCI/3sJdGi7Ylp4qH3SD0fBXkQ8v5v9wGpg3JDfjPUh8OmKcYf/I1N1mTIaNkZ 2bJLeY5ux5jkOdKvM5yonVFHW2DWyrrdjwEI0Ea7uw= X-Received: by 2002:a05:6000:220e:b0:439:ac8b:4106 with SMTP id ffacd0b85a97d-439c8a8e07cmr2734016f8f.15.1772621033302; Wed, 04 Mar 2026 02:43:53 -0800 (PST) Received: from heaven.idf.intranet (static-css-ccs-204145.business.bouyguestelecom.com. [176.157.204.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b34b6252sm25638168f8f.10.2026.03.04.02.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 02:43:52 -0800 (PST) From: Corentin Guillevic To: openembedded-core@lists.openembedded.org Cc: Corentin Guillevic Subject: [RFC PATCH 3/4] recipetool: create: use default AUTOREV only for SCM URI Date: Wed, 4 Mar 2026 11:43:41 +0100 Message-ID: <20260304104342.869457-4-corentin.guillevic@smile.fr> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304104342.869457-1-corentin.guillevic@smile.fr> References: <20260304104342.869457-1-corentin.guillevic@smile.fr> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 04 Mar 2026 10:44:04 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/232372 AUTOREV shoud only be used for SCM URIs (Git, SVN...). However, the default revision is set to AUTOREV regardless of the URI scheme. To fix this, set AUTOREV as the default value only if the source URI supports SRCREV. Signed-off-by: Corentin Guillevic --- scripts/lib/recipetool/create.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py index ef0ba974a9..d785f042ee 100644 --- a/scripts/lib/recipetool/create.py +++ b/scripts/lib/recipetool/create.py @@ -419,7 +419,7 @@ def create_recipe(args): tempsrc = '' source = args.source srcsubdir = '' - srcrev = '${AUTOREV}' + srcrev = '' srcbranch = '' scheme = '' storeTagName = '' @@ -470,6 +470,11 @@ def create_recipe(args): # so we need to extract to a subdirectory fetchuri += ';subdir=${BPN}' srcuri = fetchuri + + # Define AUTOREV as default value only if the source URI supports SRCREV + if srcuri and srcuri.startswith(('gitsm://', 'git://', 'hg://', 'svn://')): + srcrev = '${AUTOREV}' + rev_re = re.compile(';rev=([^;]+)') res = rev_re.search(srcuri) if res: From patchwork Wed Mar 4 10:43:42 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Guillevic X-Patchwork-Id: 82445 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559F6EB7ECA for ; Wed, 4 Mar 2026 10:44:04 +0000 (UTC) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.15142.1772621035873990082 for ; Wed, 04 Mar 2026 02:43:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile.fr header.s=google header.b=eSFCww7c; spf=pass (domain: smile.fr, ip: 209.85.221.53, mailfrom: corentin.guillevic@smile.fr) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-439b6d9c981so2140086f8f.1 for ; Wed, 04 Mar 2026 02:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1772621034; x=1773225834; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=csm1ZwZwWh3bnb3Pv2NbbdKHkS/F/gKbUQkABmsSf5E=; b=eSFCww7cerJNgq0iWVZJRJX5e3Wtya3wzG2r6eOZGxVdw3nY/RSgBojaL36TzP8Xcs twedbPGxv72GvHfsvd31Hes6RCzNrJYwbd3Qy9nrWyfcZQTu3PQTfb3p2b9M/1Hp59MN aHluwBbwrCGnYQ7p2x8SZgG46Lr8iGG4hV5Yc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772621034; x=1773225834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=csm1ZwZwWh3bnb3Pv2NbbdKHkS/F/gKbUQkABmsSf5E=; b=gBvojs8N7asqyJG1Dd/bMXnB2xR1HtvYdu6GVn8b2SWsluzLtkZtdIh4tCagFt4tl4 8iy11+XfCUsPhvcG9Q3hI+5e9vJ6lTAYZoQ5Lx7MNxz4E3rIuTzyCkTa8gA8mJkds8Qa kXpLUnlPIPRzPBER/UKjSU+gX2aBfXZDVAIQ1C0ZasA2djz/Z7qbf8PC8afJPXJ9VM9a oF/zU5QL5nHQ226I2UoHMl3HZhQxiQsBD14RVk7uzcuaCzFjfSrHi7Y/nSp4pwu3OGwW hBDOXIzkjxsqTlBDnIu0Fx0wDS+IUklpVaXphdirD8/XcW5NvUoWXHRPnpnfwg54aVm+ NR3Q== X-Gm-Message-State: AOJu0YyqqjMM0qZnbKdzDafkqm4o+qE8yeJU2APi1RBW0Qh7rAKFMHw5 nm2IWiqAN10K77oGUz+x+bW8eomS57CueAAOzY+LFJs8P2DqWUt4gP17HjWPx2PQ2UtetmrY3F7 McnbDyig= X-Gm-Gg: ATEYQzyLO1K6BVg6BKy+yuUc2wThHFXtwzYq+DT/z9ypa5L1R/MPCi83q4rIntd9RfP qZV37AyiqFEO8moECMXSSZfkFYSixjKgMAYNAi6m35YM7YfG8t2aj0Ox+3NsMgpcTF1DPrk/03+ 7J3w/xxRsgV1gDcaKEcaBdYmtnumRarE+6Xg3r0ldIaDd0ecrO3G143iqJrhuSUejF50rw5Ztd7 29b+KkygQNgangBNEYJmQQ3MllTAG264QLXR8fmdkV9OvrMI/jVU2vE0VpqGxTvB7nmfrwInUKJ LgB+Vqhd5AB8snyBwKPpLUrio15EP8VbMMA/IaRHoTrn5JDrKmnUxE55Sho4V2VHqHWkoO7y6r3 HTx52cW+rs/2GEyL96rHYoF9ohnTKR6NhmwTxfqgFOp04bK3iNjgJV4VxblK20MqGaNzFS8kvbW c8hOL7U6F8PmcFqqiGQzL1cJb9x2Jzo7NQ6GjlSKhNzoV8qUt5vCq28zexnwmE8esjj2O5luIBn uA2VtW3eKlK0yiw4sGGJpVQYbJmIFo4b0ZNcMX6qeM= X-Received: by 2002:a5d:64c6:0:b0:439:a95b:3c47 with SMTP id ffacd0b85a97d-439c10a8fa3mr11035540f8f.10.1772621034263; Wed, 04 Mar 2026 02:43:54 -0800 (PST) Received: from heaven.idf.intranet (static-css-ccs-204145.business.bouyguestelecom.com. [176.157.204.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b34b6252sm25638168f8f.10.2026.03.04.02.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 02:43:54 -0800 (PST) From: Corentin Guillevic To: openembedded-core@lists.openembedded.org Cc: Corentin Guillevic Subject: [RFC PATCH 4/4] devtool: use default AUTOREV only for SCM URI Date: Wed, 4 Mar 2026 11:43:42 +0100 Message-ID: <20260304104342.869457-5-corentin.guillevic@smile.fr> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304104342.869457-1-corentin.guillevic@smile.fr> References: <20260304104342.869457-1-corentin.guillevic@smile.fr> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 04 Mar 2026 10:44:04 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/232374 Same than recipetool, the default revision is set to AUTOREV regardless of the URI scheme. AUTOREV is now the default value only if the source URI supports SRCREV. Signed-off-by: Corentin Guillevic --- scripts/lib/devtool/upgrade.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/lib/devtool/upgrade.py b/scripts/lib/devtool/upgrade.py index 8930fde5d6..34e23c2c45 100644 --- a/scripts/lib/devtool/upgrade.py +++ b/scripts/lib/devtool/upgrade.py @@ -157,7 +157,12 @@ def _get_uri(rd): break if not srcuri: raise DevtoolError('Unable to find non-local entry in SRC_URI') - srcrev = '${AUTOREV}' + + if srcuri and srcuri.startswith(('gitsm://', 'git://', 'hg://', 'svn://')): + srcrev = '${AUTOREV}' + else: + srcrev = None + if '://' in srcuri: # Fetch a URL rev_re = re.compile(';rev=([^;]+)')