From patchwork Thu Nov 20 08:33:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 75069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67DFCF855B for ; Thu, 20 Nov 2025 08:33:54 +0000 (UTC) Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.30135.1763627628308467570 for ; Thu, 20 Nov 2025 00:33:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LaLwsNYd; spf=pass (domain: gmail.com, ip: 74.125.82.50, mailfrom: raj.khem@gmail.com) Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-11beb0a7bd6so1256401c88.1 for ; Thu, 20 Nov 2025 00:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763627627; x=1764232427; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=68xQJ4MiGxtMEFGUXVIR4Z9Bec+HbgPqGuUQ5kfkGUI=; b=LaLwsNYdA+TaTeDadiHpd/KyhyAvuK/O6i4JREVOLguiPop0BPDOOKBTbZxwzvRd2F Nu2hKjLgmxsj94fAooNQPXtAgfMCoyak7pcnHQbr90yUJ20S6bdyUtbkXae1zOAJT2N1 F5ckcqgP+O3yt1PhRFtiIjl3X5OAN3TeG6lAyMocxDud9p9Um13LBmH4b2e+2bLdRzmf +dX6Zs4aSMP/MaoXOUjomJbxJpNMwpaQs1gmtILD/MiMTwPrpZxUKUgmdW5/YwaEMP3j IQMhtH/KbFOsiqv88yrgspWUfL6hEUA8x3uo49t7tuQY1sBccwXSHtgnEZdHLm9NqQqe /oQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763627627; x=1764232427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=68xQJ4MiGxtMEFGUXVIR4Z9Bec+HbgPqGuUQ5kfkGUI=; b=dyGkGMNeq6PSmhle6/qbegj6r8+hQk403Igo2Rcl3gAksr/BqKbboy/QzTAEfuu8xc 3WHfuuGr1anmsfTWCp0WB1Tbb0zbiFxW/gBSg+GLXiVU7L4MclKM6JeMQkT5X5DgRlzr JT/ix7LV1FwW9YyAkOTNlyFZQ3dUVD90F7itPp0cGMcaOu4a2g8m0Ebqlf4X/Aq3Z6Nu vqlS7X7TWb28uBp6h4ZCxcndIswYFPB5Pz3KZ2xeU1bfVzlKyktzfXL0FJuzBxbtkUCn 2Kn4zTZXXVWPpSKhR0LjwgMX1CqDKZYQZTjzvcoWM3HTG7ixTW9q7uDp1Ag8X25gZeB/ FJaQ== X-Gm-Message-State: AOJu0Yxo6mQkoKZkaPEBylYGQykDQZLp0a/vOyDdiQrTc0E+QWkpJs0X pz9AbmOFzrJuhjSMXbZi86fHVP29h5yhVXyk/s4Hwuk7Y3vJmzttA1RtIjBNvM6CL0g= X-Gm-Gg: ASbGnctJ6KWudxijUVyAjrW6Md35GSWJKJeV7aMkThOFTpinZXXPbFQ/p0HlTMKiyhE jx8McooZxQcfhvJYE2Fs2SMmrMRh8Iv/DWh/7KpZLmHfg8Of1EIySOUQdCLU6Am7jG93OvQA+r7 bh4uKMn6edd9ZqgT8EO555AlgXOGSJ8kiX0zleAubXv+sBidfVO/GsT/XpXayrq5C8q/mzO/CMH 7PB9bxtmecpL1LMu+a8X6Zg3eh8cqLPbithopNSsx2+fG64PQ775pwovGJyULHRxRNmj14gEfuI mdkwm+wB3R9VZlD2NeY3u46kfzbj/ez+WTNffsX0J3LA1HCX6hwqh59TfdmeOz0ZGSN9aN248cl ctXWZOVpkSZq/hCKyt9a522T359xQqnhK6tZ9S3CjiouHIeV1Nvw7tTgP9brNPYJYB4sHdRU1UM s8ubLUhTH5VVulSr6VOpg0QOzhQr856k624lgYQiav9ll/Yj4VpkUglAgeNJqvArJs+gIallR/B GAXYyPv9LO2qUNmIOIsTW+DZc0F+vp7 X-Google-Smtp-Source: AGHT+IEivUA5lsLfAAyYIZlvq8wGbsi8DMuZvUM+S43bb44Y8u4niHv7wpLYzhe3H2t9hvWfqFqCgg== X-Received: by 2002:a05:7022:6290:b0:11b:b471:dc8d with SMTP id a92af1059eb24-11c94aefcf7mr612494c88.2.1763627627168; Thu, 20 Nov 2025 00:33:47 -0800 (PST) Received: from apollo.tail3ccdd3.ts.net ([2601:646:8201:fd20::888a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a6fc3d0bb6sm9754310eec.2.2025.11.20.00.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 00:33:46 -0800 (PST) From: Khem Raj To: openembedded-devel@lists.openembedded.org Cc: Khem Raj Subject: [meta-networking][PATCH] python-scapy: Ignore failing ptests Date: Thu, 20 Nov 2025 00:33:44 -0800 Message-ID: <20251120083344.884831-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 20 Nov 2025 08:33:54 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/121931 These tests fail in OE qemu environment and is sensitive to ISP provider Signed-off-by: Khem Raj --- ...-skip-ICMP-regression-tests-in-ptest.patch | 50 +++++++++++++++++++ .../python/python3-scapy/run-ptest | 2 +- .../python/python3-scapy_2.6.1.bb | 1 + 3 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 meta-networking/recipes-devtools/python/python3-scapy/0001-python3-scapy-skip-ICMP-regression-tests-in-ptest.patch diff --git a/meta-networking/recipes-devtools/python/python3-scapy/0001-python3-scapy-skip-ICMP-regression-tests-in-ptest.patch b/meta-networking/recipes-devtools/python/python3-scapy/0001-python3-scapy-skip-ICMP-regression-tests-in-ptest.patch new file mode 100644 index 0000000000..68e5cf5b45 --- /dev/null +++ b/meta-networking/recipes-devtools/python/python3-scapy/0001-python3-scapy-skip-ICMP-regression-tests-in-ptest.patch @@ -0,0 +1,50 @@ +From 511d965d6dd440fc0ae6b702feff06cb6718140e Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Thu, 20 Nov 2025 00:05:55 -0800 +Subject: [PATCH] python3-scapy: skip ICMP regression tests in ptest + +The UTScapy regression campaign contains two ICMP-based tests: + + - "Latency check: localhost ICMP" + - "Sending and receiving an ICMPv6EchoRequest" + +Both rely on raw ICMP sockets and/or external IPv6 connectivity +(www.google.com), which are not guaranteed to be available in the +ptest environment. As a result they systematically fail and cause +the whole ptest run to be reported as failed. + +Tag these tests with the "skipped_ptest" keyword so they can be +filtered out by the ptest runner via `-K skipped_ptest`. Additionally, +mark the ICMPv6 test with `@pytest.mark.skip` to avoid running it +under pytest-based harnesses that import regression.uts. + +This keeps ptest results stable while still allowing developers to +run these tests manually in a properly networked environment. + +Upstream-Status: Inappropriate [OE-specific] + +Signed-off-by: Khem Raj +--- + test/regression.uts | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +--- a/test/regression.uts ++++ b/test/regression.uts +@@ -1732,7 +1732,7 @@ def _test(): + retry_test(_test) + + = Latency check: localhost ICMP +-~ netaccess needs_root linux latency ++~ netaccess needs_root linux latency skipped_ptest + + # Note: still needs to enforce L3RawSocket as this won't work otherwise with libpcap + sock = conf.L3socket +@@ -1840,7 +1840,7 @@ finally: + sck.close() + + = Sending and receiving an ICMPv6EchoRequest +-~ netaccess ipv6 ++~ netaccess ipv6 skipped_ptest + def _test(): + with no_debug_dissector(): + x = sr1(IPv6(dst="www.google.com")/ICMPv6EchoRequest(),timeout=3) diff --git a/meta-networking/recipes-devtools/python/python3-scapy/run-ptest b/meta-networking/recipes-devtools/python/python3-scapy/run-ptest index 5c166b7ba0..79e435a5ac 100644 --- a/meta-networking/recipes-devtools/python/python3-scapy/run-ptest +++ b/meta-networking/recipes-devtools/python/python3-scapy/run-ptest @@ -6,6 +6,6 @@ if ! nslookup example.com; then trap "mv /etc/resolv.conf.bak /etc/resolv.conf" INT EXIT fi -python3 UTscapy.py -t regression.uts -f text -l -C \ +python3 UTscapy.py -t regression.uts -f text -l -C -K skipped_ptest \ -o @PTEST_PATH@/scapy_ptest_$(date +%Y%m%d-%H%M%S).log \ 2>&1 | sed -e 's/^passed None/PASS:/' -e 's/^failed None/FAIL:/' diff --git a/meta-networking/recipes-devtools/python/python3-scapy_2.6.1.bb b/meta-networking/recipes-devtools/python/python3-scapy_2.6.1.bb index 5f09fd852a..faafeecfaf 100644 --- a/meta-networking/recipes-devtools/python/python3-scapy_2.6.1.bb +++ b/meta-networking/recipes-devtools/python/python3-scapy_2.6.1.bb @@ -18,6 +18,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=b234ee4d69f5fce4486a80fdaf4a4263" # SRCREV = "8e08cbf759de6709a5b4af6bea3655d293129bb4" SRC_URI = "git://github.com/secdev/scapy.git;branch=master;protocol=https;tag=v${PV} \ + file://0001-python3-scapy-skip-ICMP-regression-tests-in-ptest.patch \ file://run-ptest" UPSTREAM_CHECK_COMMITS = "1"