From patchwork Sun Oct 26 20:51:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 73048 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558D5CCF9E5 for ; Sun, 26 Oct 2025 20:51:28 +0000 (UTC) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.groups.io with SMTP id smtpd.web10.18230.1761511881878454992 for ; Sun, 26 Oct 2025 13:51:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=FRXWzviJ; spf=pass (domain: gmail.com, ip: 209.85.221.44, mailfrom: skandigraun@gmail.com) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3ecde0be34eso3191121f8f.1 for ; Sun, 26 Oct 2025 13:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761511880; x=1762116680; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=5yGmMK5RMKTWD5GgCCsQcwAnF+qX1St2qF6YfQ7EhIE=; b=FRXWzviJQLR7hLT12SH0jJpmDyjEkHoblvUXeyQJ40fy+KO6XYx74VJ+xStRsxp6NL ub63Ocb9TqIl55x9I5lFeyUiu9RhbaYHRcazwa+inmkxT6oYWzLSVmeJFBrwjq+1yYQn PJVs4+EWi4/r+LR7lLzuNvNzGk+Kf69D6UJ8w0OMDU/WdeTBNiIbrHd4x+daJ/O/2qbD uoTE290/MNhtugoliWxb7sFrYJSiVdUEUYgNHcylJ2aMmfQ7CBqGgRChmzJaVczjOXsL f58NDJqULFeY7d3ifhYh29E7Ma+SSAFiTDlfAWBYjmWylN9S85yoc0OvGkksY+ZCA3e8 J8hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761511880; x=1762116680; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5yGmMK5RMKTWD5GgCCsQcwAnF+qX1St2qF6YfQ7EhIE=; b=oESjaLZMBSoE5IduIT5t9J7C4MNW2MY7ZWbIScuQPshohxKgb6yVw/i6Kn5qCuidzv mkCQ1uL27V+5WW19ZFMZjAN+GJlV3xIlsMgtS6jsZi4VWpJd/I/nVeVRAg1jfMNmY3Ng ZWT3/+r5YQGDhqkL9RscjugTgRFJ81PtUxtSxz5O4xM4UKZgAUQfmSV8KwIXu/gfN2jg wgNApU1fHrB2v1ZZjjnbXJQLVJYaJhKHJqwT15BLNvHU//vJT15KU1DVB3RftgFCH36r /reaa/gMXbaamUdzpZfbw9SRkI4zrQ4fGgxgFEBq3hXbgcHooKvf9EY0PVPrpXBSC6+s qnZQ== X-Gm-Message-State: AOJu0Yxj5pWR3LCWkpm9Ymsr/7VjZZM1d+YZxV/LA2VnB/B+kqW+DIig UBMVYW4dcertprRiswHQa1KvLCVGmXjFEzjLGMQz+GmI2SQg2gALHmNXE8L3+g== X-Gm-Gg: ASbGncsyqH6vg3m55hX+JLUugCBqAY8vQMz+59sjTN4qvajyNeMuFUMYqKt5j4MAx+b ZjKszLeKb81/NRMa//TwczIFF4qFYfuyvKlUaH12+hriAMhf1fn0koDfTUpoaRXpeI9rnRMGjVB V32y+L1bOcCQV9LeDCny4rBoCJeKaiXUy66l0wgx482ngEXe9L3+wqbO4uVCdCDL+N15Itk0Nrl KYmZrUwylA6fjx7A+wQf0OokLZ7yDyxQTnz9i8vudJXTtPdCOEm8N98nR/Pedcu7NqG6zJf599h 2PeFG6uwsatEizsrEQHSew9yutdhYpekX8LPtieZYan7O37zhCKHlRFAFzWFyVKnkrcHF0Kz+BR IQfuhC4HdWsxjqWiYiWDTpW4IPMlFjZ1cf1LyJElevDe08J4mcv3VOxHqgpbyJX5E9dqrr1upZr bsV5rcNcfP X-Google-Smtp-Source: AGHT+IEYmLAs6ki5tTWcijRCCn549CKNxSM1wdnn6XVEzzf/vlS6/s/pMOEnHj4ACd01xdBSbV0njQ== X-Received: by 2002:a5d:5f88:0:b0:427:537:39e0 with SMTP id ffacd0b85a97d-4298f5825cfmr7863098f8f.14.1761511879891; Sun, 26 Oct 2025 13:51:19 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952da12dsm10484113f8f.29.2025.10.26.13.51.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Oct 2025 13:51:19 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-networking][PATCH 1/3] lksctp-tools: move ptest from problem-list to slow-list Date: Sun, 26 Oct 2025 21:51:16 +0100 Message-ID: <20251026205118.2439308-1-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 26 Oct 2025 20:51:28 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/121015 The tests execute and pass successfully - I managed to run them successfully, without a change on x86-64 and aarch64. Signed-off-by: Gyorgy Sarvari --- .../conf/include/ptest-packagelists-meta-networking.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-networking/conf/include/ptest-packagelists-meta-networking.inc b/meta-networking/conf/include/ptest-packagelists-meta-networking.inc index 1cdb6d1811..408b559da2 100644 --- a/meta-networking/conf/include/ptest-packagelists-meta-networking.inc +++ b/meta-networking/conf/include/ptest-packagelists-meta-networking.inc @@ -34,12 +34,12 @@ PTESTS_FAST_META_NETWORKING:remove:libc-musl = "\ # firewalld currently hangs forever so disable it for now # firewalld PTESTS_SLOW_META_NETWORKING = "\ + lksctp-tools \ net-snmp \ openvpn \ " PTESTS_PROBLEMS_META_NETWORKING = "\ - lksctp-tools \ nftables \ python3-scapy \ " From patchwork Sun Oct 26 20:51:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 73047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FD1CCF9E9 for ; Sun, 26 Oct 2025 20:51:28 +0000 (UTC) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web11.18157.1761511882201214309 for ; Sun, 26 Oct 2025 13:51:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=jNFXtt98; spf=pass (domain: gmail.com, ip: 209.85.221.45, mailfrom: skandigraun@gmail.com) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3f0ae439bc3so2539949f8f.1 for ; Sun, 26 Oct 2025 13:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761511880; x=1762116680; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=j3o+3BaPJMEPoWwdy43C6jzzsUiY6fTQI6Osh3u+hn4=; b=jNFXtt984kWm48gVJ/d2jpO3hHxndyUKttamtp+htKukTx2QnOm1LnyM2oRwrb3sho MIc0HFzxzjxU+XABxuO6NVkJlfYnAwY0nhh7RXx0TH6lz5/SZ3z2LipzKG64+mxsaj09 VDyUTdfRfDW3ENqIjJoyH9qATXc401LX/SrsA2uN3wZTKNicJUp9742+/ol3w/3cYYvU jep8a4TGIxCna2SCrOz++INgzUy8tyXVyEt+gngRKO8tLJw4fHv+iKG0uNe0EITIMjAa kT+Lo47zdLx2itlaLsaXrDhjmIPYHImHkHDmAOR1VkrlDR4TBl5mhT6KmmKwoVc22gEO 61Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761511880; x=1762116680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j3o+3BaPJMEPoWwdy43C6jzzsUiY6fTQI6Osh3u+hn4=; b=TEAxD6UGxf/QtzkYcjXXJY+LYSSewxOt+xQT3E42EXxKtCDaoPP68xbY8wkkDEu9hF lA7AF9kumb9MIj7nKubP88C09BIg7Naj+VVThTCuVhaHxCKMXdQgDiMCRKfEgQpWs7Dz k8H+DyNA9XCfwlkOfGOchQjsQ8QpsgH8/xh7rIPddURLxo6a10rKt7X63NoEpm3FNXgV wwc43ST8fVpSQAbjdcbaNM5lLCSUnMmOTuBRDCc7hPJAeZ9JbnlrYi4ymmXPWgbvMPqw IPEtQzGB10vcW7zRaTP1001aLcYvhTOPl6PRfT83EID8zyLid6t43Z53MyFeDpcHG7DJ /Ecg== X-Gm-Message-State: AOJu0YxOQZio04Euf/NZgm4v6WUfWZUnd32ytnUBxkrJlqcllF/WYLcV ZN93AH+xuxw5ZiAhqnzguAFjvoPu90Mf6ORmcCvteeN77lH46RE9mcmbuiFjEw== X-Gm-Gg: ASbGncs8Y5eRatjG8vRXHHfnXkzaL3w3suZIqvT21/Foz53QLEfFK8vexXLsIm1cTmX 7yNHTIjSlxwTRzhIFh1OJOKzVxqcaA+UD1/hwEJyJEfwmWwxzMVLX/aYngppHWttLPsYEUA/+HE r04RjL6PygyofsDXCrtLX1DheBwT8ICXkn1Iqzou9IjaupTzBsROR7aELeKBwLfz6A0DtDj1R/U KbPoeWhKLzS9pgWaPZG2lmL+vHEaR6hhDwyxOg1W69xK5FDvvow+Old9K8VEArI9d+maiQDMWHp y/wqsw5RowikKbXmGd+5lXEZjKtcF9iHQac27jETfAa8Lo8kMtN4orNIxzAsAEsAJjoVJHkHNLh 9+zt2UQicevzuAusCNXHv7YbpnXWqY/Ck+w3zXmPECzGABughGiFTd5ZAZXfequbwa/eUMe7E4A == X-Google-Smtp-Source: AGHT+IGH/0MYnFqgBov20F1Qzf2UVdiXh53DiGGcWSq3uyR9XKoLiHjZ/o9tcqL/6PheIkf79cioxg== X-Received: by 2002:a05:6000:4201:b0:429:8c4e:b0c8 with SMTP id ffacd0b85a97d-42990712215mr8725587f8f.27.1761511880507; Sun, 26 Oct 2025 13:51:20 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952da12dsm10484113f8f.29.2025.10.26.13.51.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Oct 2025 13:51:20 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-networking][PATCH 2/3] python3-scapy: fix ptests Date: Sun, 26 Oct 2025 21:51:17 +0100 Message-ID: <20251026205118.2439308-2-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026205118.2439308-1-skandigraun@gmail.com> References: <20251026205118.2439308-1-skandigraun@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 26 Oct 2025 20:51:28 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/121016 1. Install missing test files 2. Enable network access by setting a nameserver in resolv.conf because some tests require this 3. One test tries to ping Google through IPv6 - this test requires ipv6 DISTRO_FEATURE. In case ipv6 is not enabled, skip this test from the run-ptest script. NB: the last mentioned test to work also requires IPv6 support from your ISP. My ISP is IPv4-only, and I couldn't try it out. The above comes from my reading of the testcode. Signed-off-by: Gyorgy Sarvari --- .../include/ptest-packagelists-meta-networking.inc | 2 +- .../recipes-devtools/python/python3-scapy/run-ptest | 7 +++++++ .../recipes-devtools/python/python3-scapy_2.6.0.bb | 12 ++++++++++++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/meta-networking/conf/include/ptest-packagelists-meta-networking.inc b/meta-networking/conf/include/ptest-packagelists-meta-networking.inc index 408b559da2..838aee94d3 100644 --- a/meta-networking/conf/include/ptest-packagelists-meta-networking.inc +++ b/meta-networking/conf/include/ptest-packagelists-meta-networking.inc @@ -20,6 +20,7 @@ PTESTS_FAST_META_NETWORKING = "\ mbedtls \ openhpi \ openl2tp \ + python3-scapy \ squid \ tcpdump \ wolfssl \ @@ -41,7 +42,6 @@ PTESTS_SLOW_META_NETWORKING = "\ PTESTS_PROBLEMS_META_NETWORKING = "\ nftables \ - python3-scapy \ " PTESTS_PROBLEMS_META_NETWORKING:append:libc-musl = "\ libtalloc \ diff --git a/meta-networking/recipes-devtools/python/python3-scapy/run-ptest b/meta-networking/recipes-devtools/python/python3-scapy/run-ptest index 417e21053c..5c166b7ba0 100644 --- a/meta-networking/recipes-devtools/python/python3-scapy/run-ptest +++ b/meta-networking/recipes-devtools/python/python3-scapy/run-ptest @@ -1,4 +1,11 @@ #!/bin/sh + +if ! nslookup example.com; then + mv /etc/resolv.conf /etc/resolv.conf.bak + echo "nameserver 8.8.8.8" > /etc/resolv.conf + trap "mv /etc/resolv.conf.bak /etc/resolv.conf" INT EXIT +fi + python3 UTscapy.py -t regression.uts -f text -l -C \ -o @PTEST_PATH@/scapy_ptest_$(date +%Y%m%d-%H%M%S).log \ 2>&1 | sed -e 's/^passed None/PASS:/' -e 's/^failed None/FAIL:/' diff --git a/meta-networking/recipes-devtools/python/python3-scapy_2.6.0.bb b/meta-networking/recipes-devtools/python/python3-scapy_2.6.0.bb index fdef5473ef..2086b018d6 100644 --- a/meta-networking/recipes-devtools/python/python3-scapy_2.6.0.bb +++ b/meta-networking/recipes-devtools/python/python3-scapy_2.6.0.bb @@ -30,9 +30,19 @@ do_install:append() { } do_install_ptest() { + install -d ${D}${libdir}/test/pcaps install -m 0644 ${S}/scapy/tools/UTscapy.py ${D}${PTEST_PATH} install -m 0644 ${S}/test/regression.uts ${D}${PTEST_PATH} + install -m 0644 ${S}/test/pcaps/bad_rsn_parsing_overrides_ssid.pcap ${D}${libdir}/test/pcaps/ + install -m 0644 ${S}/test/pcaps/macos.pcapng.gz ${D}${libdir}/test/pcaps/ sed -i 's,@PTEST_PATH@,${PTEST_PATH},' ${D}${PTEST_PATH}/run-ptest + + # note1: if ipv6 isn't enabled, skip the related test (add '-K ipv6' argument) + # note2: to make this test work, your ISP also must support ipv6 - the test is trying + # to ping google.com through ipv6. + if [ "${@oe.utils.all_distro_features(d, 'ipv6', 'true', 'false')}" = "false" ]; then + sed -i 's/UTscapy.py/UTscapy.py -K ipv6/g' ${D}${PTEST_PATH}/run-ptest + fi } RDEPENDS:${PN} = "tcpdump python3-compression python3-cryptography python3-netclient \ @@ -41,3 +51,5 @@ RDEPENDS:${PN} = "tcpdump python3-compression python3-cryptography python3-netcl python3-difflib" RDEPENDS:${PN}-ptest += "python3-json python3-mock python3-multiprocessing \ iproute2 tshark" + +FILES:${PN}-ptest += "${libdir}/test/" From patchwork Sun Oct 26 20:51:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 73049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581E6CCF9ED for ; Sun, 26 Oct 2025 20:51:28 +0000 (UTC) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web11.18159.1761511883884723066 for ; Sun, 26 Oct 2025 13:51:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=NALc9qtI; spf=pass (domain: gmail.com, ip: 209.85.221.50, mailfrom: skandigraun@gmail.com) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3ece0e4c5faso3578894f8f.1 for ; Sun, 26 Oct 2025 13:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761511882; x=1762116682; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0I46qut/pEpEgcaG/IAS0x4XLDBvEc6VpJ5gK983XDI=; b=NALc9qtIUnbfq4j+P8KhXqFBUKeX39sTomw6UzyzfEtEYnO1yKI8hKmT1ReVz+athK gVLYxoQ+aLNrd18N8airU53ZqyW6FTkfl05RDJfnjDqB12cAO8AJ3QcGWrtdm7iqyFZ5 lo3FUz08/SvdiacBgcoA+1a2DcVg+5uIcRNE/6zNAAXYHsjylXJ1Xz1PQeLsaf7kpj3S zJDqnQ95G0PLok4FmZVDoYeqIixGSRz49yBZDc2XHmOxColnljBtRnvHI3YblNNTg1wn IEBOVV3JGhYTQQE0haP3cwLM+8rTVPbeZagkI3DjSVlJX/5Q1fg1m2WTl6v/o2PFWSVX gRAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761511882; x=1762116682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0I46qut/pEpEgcaG/IAS0x4XLDBvEc6VpJ5gK983XDI=; b=YUZgMD1WSfflzGOWLN2uxHCw59sEZf6sBKMq+vxKL++xDeAJf4ah8xmk8SsJWE7Bsp GYbFA6IASnOzhsVNZ6gbBMwcLpvCvMK0xWh4dhjkAEol8ydiT259o+jsOKjirt0jveXv XQ6Pk0jsCPnLRRn5bTZ4lb++i3st19H11w0tqJJmkB/yVxJ2pBH85OlKrz2sODlOgoK6 ZJiaG4kLLzonptQg14zKy16HoTUjav1azYsv8sNydg5sMLSS2eKVotEyFIO3N+iN0Y+I X4R+sFV+5Y/RN3hyUOYOawnd4lOtsYGHAsJcKprZVih3kNhMkJADImXSaKA1znLUGAH5 JwrQ== X-Gm-Message-State: AOJu0YyoFE949Iw5GSy+NXKST7Pozn6l62/mtJwz/sLzmFfRUB/spCdU g8sn8NnLEpG2laoSdjkCcNFSPnlvlPJvsHVYp+opl2CMsFm0U+adMohCER6kvg== X-Gm-Gg: ASbGncsO4bRqhSZ0Fr1fNGaQruwKygEDym40zeuviAkOEdln+psI0Y9G5E2Ow8eJCBi 8xKqoC7PHz/IZOrNgPU78JZdY/GvJq4o08H09BvpP3Rp705wqkOnU3bVNkVsPEExcVMacxzvgHJ GNtQnfdIjPYN8d+cOs5OOYaTrVkrTVK75ZeX9Vje59JcsCS1UL/2sKRU09Os2SNt4muLgpHzNqA XAV0U8AIgk/PiG+6gTlFxLOS2QFmGBXxmaAjXDRh3xV3tKx//9nBkLT1x2esfcpQKLL7Y89oqXf jEQf+Gl0NSSltPLpbatswHDY/eqpAqLpiCvz5EUkAurDVxsgggP4CmuuZd+uaKDaTFj/l0pK8T8 GqZF/vxo7Pfz8ZjRc78uW5eH2xjYl4ohMhkREQUEGD+uwgyO2y3iGnjeEAz36/dt3GBrsQ/BdcA == X-Google-Smtp-Source: AGHT+IHhfnDTF677LOh4PmvBFDXsvWAtEOlvM0jMkf1hlU9Hb8unbbIwLFxpYaDJbQfD8qDcFY5Srg== X-Received: by 2002:a05:6000:4024:b0:429:91ca:70f1 with SMTP id ffacd0b85a97d-42991ca720fmr6002111f8f.57.1761511882091; Sun, 26 Oct 2025 13:51:22 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952da12dsm10484113f8f.29.2025.10.26.13.51.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Oct 2025 13:51:21 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-networking][PATCH 3/3] nftables: fix ptests Date: Sun, 26 Oct 2025 21:51:18 +0100 Message-ID: <20251026205118.2439308-3-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251026205118.2439308-1-skandigraun@gmail.com> References: <20251026205118.2439308-1-skandigraun@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 26 Oct 2025 20:51:28 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/121017 Add missing kernel module dependencies, fix a script that is trying to run python instead of python3, and add a patch that fixes a test (submitted upstream). There are 2 notes: 1. For the tests to succeed the kernel must be compiled with CONFIG_NFT_TPROXY 2. There is 1 testcase that seems to be flaky: 0002-persist testcase randomly fails. When it is comparing the test output with the expected output, sometimes there is a comment present, and sometimes there isn't. Couldn't get to the bottom of this. The second point is the reason why the recipe remains on the PTESTS_PROBLEMS_META_NETWORKING list. Signed-off-by: Gyorgy Sarvari --- .../0001-fix-typo-in-test-script.patch | 35 +++++++++++++++++++ .../recipes-filter/nftables/nftables_1.1.5.bb | 7 +++- 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 meta-networking/recipes-filter/nftables/nftables/0001-fix-typo-in-test-script.patch diff --git a/meta-networking/recipes-filter/nftables/nftables/0001-fix-typo-in-test-script.patch b/meta-networking/recipes-filter/nftables/nftables/0001-fix-typo-in-test-script.patch new file mode 100644 index 0000000000..c0d1e33b5e --- /dev/null +++ b/meta-networking/recipes-filter/nftables/nftables/0001-fix-typo-in-test-script.patch @@ -0,0 +1,35 @@ +From 956e7d89865b497f889483c90bc7fed9bec4e030 Mon Sep 17 00:00:00 2001 +From: Gyorgy Sarvari +Date: Sun, 26 Oct 2025 18:55:06 +0100 +Subject: [PATCH 1/2] fix typo in test script + +While executing the test suite from tests/shell/testcases folder, a lot of errors +are displayed: + +tests/shell/testcases/maps/vmap_timeout: line 48: [: : integer expected + +Looking at the script, a non-existing variable (expires) is tested instead of +the existing one (expire). + +This change corrects this. + +Upstream-Status: Submitted [https://lore.kernel.org/netfilter-devel/20251026204107.2438565-1-skandigraun@gmail.com/T/#u] + +Signed-off-by: Gyorgy Sarvari +--- + tests/shell/testcases/maps/vmap_timeout | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/shell/testcases/maps/vmap_timeout b/tests/shell/testcases/maps/vmap_timeout +index 8ac7e8e7..55d1c1b9 100755 +--- a/tests/shell/testcases/maps/vmap_timeout ++++ b/tests/shell/testcases/maps/vmap_timeout +@@ -45,7 +45,7 @@ for i in $(seq 1 100) ; do + expire=$((RANDOM%utimeout)) + + expire_str="" +- if [ "$expires" -gt 0 ]; then ++ if [ "$expire" -gt 0 ]; then + expire_str="expires ${expire}s" + fi + diff --git a/meta-networking/recipes-filter/nftables/nftables_1.1.5.bb b/meta-networking/recipes-filter/nftables/nftables_1.1.5.bb index a1954c0814..a2c6ce0e23 100644 --- a/meta-networking/recipes-filter/nftables/nftables_1.1.5.bb +++ b/meta-networking/recipes-filter/nftables/nftables_1.1.5.bb @@ -12,6 +12,7 @@ DEPENDS = "libmnl libnftnl bison-native \ ${@bb.utils.contains('PACKAGECONFIG', 'mini-gmp', '', 'gmp', d)}" SRC_URI = "http://www.netfilter.org/projects/nftables/files/${BP}.tar.xz \ + file://0001-fix-typo-in-test-script.patch \ file://run-ptest \ " SRC_URI[sha256sum] = "1daf10f322e14fd90a017538aaf2c034d7cc1eb1cc418ded47445d714ea168d4" @@ -67,6 +68,9 @@ do_install() { RDEPENDS:${PN}-ptest += " ${PN}-python bash coreutils make iproute2 iputils-ping procps python3-core python3-ctypes python3-json python3-misc sed util-linux" + +# For ptests compile the kernel with CONFIG_NFT_TPROXY + RRECOMMENDS:${PN}-ptest += "\ kernel-module-nft-chain-nat kernel-module-nft-queue \ kernel-module-nft-compat kernel-module-nft-quota \ @@ -79,7 +83,7 @@ kernel-module-nft-log kernel-module-nft-socket \ kernel-module-nft-masq kernel-module-nft-synproxy \ kernel-module-nft-nat kernel-module-nft-tunnel \ kernel-module-nft-numgen kernel-module-nft-xfrm \ -kernel-module-nft-osf \ +kernel-module-nft-osf kernel-module-nft-tproxy \ kernel-module-nf-flow-table \ kernel-module-nf-flow-table-inet \ kernel-module-nf-nat \ @@ -102,6 +106,7 @@ do_install_ptest() { cp -rf ${S}/${TESTDIR} ${D}${PTEST_PATH}/${TESTDIR} sed -i 's#/usr/bin/python#/usr/bin/python3#' ${D}${PTEST_PATH}/${TESTDIR}/json_echo/run-test.py sed -i 's#/usr/bin/env python#/usr/bin/env python3#' ${D}${PTEST_PATH}/${TESTDIR}/py/nft-test.py + sed -i 's#exec python -c#exec python3 -c#' ${D}${PTEST_PATH}/${TESTDIR}/shell/helpers/json-pretty.sh # handle multilib sed -i s:@libdir@:${libdir}:g ${D}${PTEST_PATH}/run-ptest }