From patchwork Thu Oct 16 09:29:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 72484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA241CCD194 for ; Thu, 16 Oct 2025 09:29:21 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web10.3911.1760606960169463958 for ; Thu, 16 Oct 2025 02:29:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=FsNfaMyM; spf=pass (domain: gmail.com, ip: 209.85.128.54, mailfrom: skandigraun@gmail.com) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-46fcf9f63b6so2503325e9.2 for ; Thu, 16 Oct 2025 02:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760606958; x=1761211758; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=x5ofIk0ltGzXdf3N/iNuy/7e5TnAqKnf5oscRMyTvQM=; b=FsNfaMyMGJRuVYoeF+L/IL97Uga7Uc/l7dl+y9VHeAPRYTrJebG/UaXWhL9HIFzVAQ SuiIm576gC+SMJT5QOTacX3e8r0fKc+42lwblB/xH2wNan6rAYktIxF4uP8ZAl5Jn6FX jGAsD0b2iuPw247Wv4Cb9kZMQiKNkI530YP4I/I3xJFxsn3BZRNEA9U/7IDvNpCjZ+V9 DGWwYSYBRu5Ig3DvUg4p1JqBqDe2PnY1rv9/DIv7g6o7pEJfGa3+5RS3plYQX8lrWxpm jYAFtjSJHNTz8hrgRW8Vz1VosM3NVu36MvEvWLeiV7mtWR/t+wFiGstvEpbRw6bnVs3Y GjRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760606958; x=1761211758; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x5ofIk0ltGzXdf3N/iNuy/7e5TnAqKnf5oscRMyTvQM=; b=DmO+fb0yr2xrGWoyG87ZB5RK2nSrjC+wkV5uPyfOkFUkqaKBmY+rCGWJUiyTu7kADO wclAFo6gxwOwKbKUKpwcYEI6CY37ZAnKVgKs/1s8qC7cFnCHy2BqYSj91lbGvu1Yii9Z 6S7UirmPwSjaa2YLEAD8b74B37emiBYOkueZjWSoZguQ/RK0Vt3LS3ySPKTGFP3erCTD GNjxx3zYZVot8mWxrbD13QRy3v4PN53ru5//Exg7X4cdg+oqtfTaSQdRuWu480QfoigQ P9P1R3HkvlvlCc2/+NO3SGU9uu1L7XndaTqXhlfHDIevIgBTrAWZieqs9qi52k1c3vCx pFWw== X-Gm-Message-State: AOJu0YyLFLfgLBmUZbU57lLf2tiVmlYPLJU8B/PQAXQnFO5iWofcu3p7 8MC2PjORHG9tZSCBNtrrtyAC31KourJ92moDFDVbhSE96wItylM+WPjQCAmy4Q== X-Gm-Gg: ASbGncv1lXZWsUApCee0kB2wDpjQamHyr43/gClRAJrvADgH4yrYDQNIpokaqnA81N9 1e7PeGo/Ro2I8MGJtq4//5tHE3fPYAaMumh5c/dstK6oV5JDy9uqFSwucYpPD50C/4ozUugz1mw zGPBSMLLAHIkM5CFHHKo40vqAFlJ1Mq5qZb4kUINnykomObvwDxlEMHqBn7QV1jkecKO3ctLWxP uBV6WDVIhSgv/2R5Htx7etOrNtaYyEf7oFDKlQyQ+88N7huXnIWdzdD8043DjNTdkdfdqH4s6+V XH9AYG3abMKDVqMVdc9rcV5j1XkqLiNncZCkfa5n0hA/Ura/Kzi1eklcKUnc5RaKRF3Vrd3UvDH bzq1+eUNzSmiOiKyAtdZJUjshnf9dJBljTL2pajE6Uerh6qPUdYA/v8WB6rBpOUZirGln9RNAMp t9MWrOPcyd X-Google-Smtp-Source: AGHT+IGZzeOzi23OYTKCGH5EB8CIlxKHolo8V2TIyAvMMR46Owjwt+yxui9MXbf9xPeUhjIy99AKmA== X-Received: by 2002:a05:600c:8288:b0:471:6f4:601f with SMTP id 5b1f17b1804b1-47106f460f6mr39938395e9.19.1760606958367; Thu, 16 Oct 2025 02:29:18 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ed9e7d7sm16819345e9.3.2025.10.16.02.29.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 02:29:18 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-oe][kirkstone][PATCH 1/4] faad2: patch CVE-221-32272 Date: Thu, 16 Oct 2025 11:29:14 +0200 Message-ID: <20251016092917.1946972-1-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Oct 2025 09:29:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/120723 Details: https://nvd.nist.gov/vuln/detail/CVE-2021-32272 Pick the patch that is mentioned in the ncv report. Signed-off-by: Gyorgy Sarvari --- ...ix-heap-buffer-overflow-in-mp4read.c.patch | 37 +++++++++++++++++++ .../recipes-multimedia/faad2/faad2_2.8.8.bb | 4 +- 2 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 meta-oe/recipes-multimedia/faad2/faad2/0001-fix-heap-buffer-overflow-in-mp4read.c.patch diff --git a/meta-oe/recipes-multimedia/faad2/faad2/0001-fix-heap-buffer-overflow-in-mp4read.c.patch b/meta-oe/recipes-multimedia/faad2/faad2/0001-fix-heap-buffer-overflow-in-mp4read.c.patch new file mode 100644 index 0000000000..c739e82fb0 --- /dev/null +++ b/meta-oe/recipes-multimedia/faad2/faad2/0001-fix-heap-buffer-overflow-in-mp4read.c.patch @@ -0,0 +1,37 @@ +From 57850acf9d40fc2898ded492b9ce942110d0c426 Mon Sep 17 00:00:00 2001 +From: Fabian Greffrath +Date: Mon, 31 Aug 2020 10:00:37 +0200 +Subject: [PATCH] fix heap-buffer-overflow in mp4read.c + +This originated from an integer overflow: If mp4config.frame.ents +would be read-in with a value of (uint32t)(-1), it would overflow to 0 +in the size calculation for the allocation in the next line. The +malloc() function would then successfully return a pointer to a memory +region of size 0, which will cause a segfault when written to. + +Fixes #57. + +CVE: CVE-2021-32272 +Upstream-Status: Backport [https://github.com/knik0/faad2/commit/1b71a6ba963d131375f5e489b3b25e36f19f3f24] + +Signed-off-by: Gyorgy Sarvari +--- + frontend/mp4read.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/frontend/mp4read.c b/frontend/mp4read.c +index 9767383..5dc36b7 100644 +--- a/frontend/mp4read.c ++++ b/frontend/mp4read.c +@@ -340,7 +340,10 @@ static int stszin(int size) + // Number of entries + mp4config.frame.ents = u32in(); + // fixme error checking +- // fixme: check atom size ++ ++ if (!(mp4config.frame.ents + 1)) ++ return ERR_FAIL; ++ + mp4config.frame.data = malloc(sizeof(*mp4config.frame.data) + * (mp4config.frame.ents + 1)); + ofs = 0; diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb index 56d5e1201e..d70c18f43d 100644 --- a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb @@ -7,7 +7,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=381c8cbe277a7bc1ee2ae6083a04c958" LICENSE_FLAGS = "commercial" -SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-2.8.0/${BP}.tar.gz" +SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-2.8.0/${BP}.tar.gz \ + file://0001-fix-heap-buffer-overflow-in-mp4read.c.patch \ + " SRC_URI[md5sum] = "28f6116efdbe9378269f8a6221767d1f" SRC_URI[sha256sum] = "985c3fadb9789d2815e50f4ff714511c79c2710ac27a4aaaf5c0c2662141426d" From patchwork Thu Oct 16 09:29:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 72483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA31CCD19A for ; Thu, 16 Oct 2025 09:29:21 +0000 (UTC) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web10.3912.1760606960825219536 for ; Thu, 16 Oct 2025 02:29:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=l9wtC3ly; spf=pass (domain: gmail.com, ip: 209.85.128.42, mailfrom: skandigraun@gmail.com) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-46e5980471eso4151365e9.2 for ; Thu, 16 Oct 2025 02:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760606959; x=1761211759; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=TPKdhY4LLmFE1YJg5Fbf5oifohWnaqh4DhwCZsNl9eo=; b=l9wtC3lyxPqJQ2KnPtRQXCSa3JEPJTi+hovkA3PZxCPyv7cAUpCrWqMxhFyinX/Z0w hgQGK0yGUlXk1WGZFE2L0ncQm1rBfh1pPpDKsvsoV6e2PWQrlhjnLMuOMwdrt1uv3j+W tMRd6slYLsPBc0mi/414dUxOFEypNTMG5JH1IUDIlFIFhJhwh1za5Y6qkMXBdkXrfnlz pPoTyK/OasQjVLHOdk19Y2vghIR7XAnx6ooMBWMFDvJ34kfhqrGNNIvNhbBBOTdu97Lt /Gmbkn3DmaCb0izdzYHwC/mQBAYNtV5qycPT0VzyZ0GY5i3IDdAlK6bwnFf4RHIqRqdK gPrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760606959; x=1761211759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TPKdhY4LLmFE1YJg5Fbf5oifohWnaqh4DhwCZsNl9eo=; b=qJBhsiKgM9ahzWQXZUj/iEbVfyu2eY/r+yCrGjXsEi569VH9l6ijDnejqdnEdpv5NL WMxXZoGAZjdDl+UHIXwIFMXRHib520FK7WaI74aXI3ai8r+WCawPNys7afrHLpycOZ/4 /DX7ZOmmYSzvpWTrKTYVrYQEu/hMh1O721Sfuiik1dkZxw5gAUOaO2nQKNTvgQE3IXjK X4Eb0EPRxDX/zrpWSEBBf4qUycgdnrsfdLRk75bv3Cvd8BRNPn/pxSUWxY7v74bswG3v LvN4CbXMu/M4sgi0OiuMm0836A0onKGBcuhuYZL5erFURe68DRY2xqMV9jvd1zzhBFi5 rk+A== X-Gm-Message-State: AOJu0YxOniSzqrXlsItZ4KRQudzr7/h1jOOZmCvMzJWsVtT8lM2waJOx iwTVGGzaFEyjnDy6EjP8QACZuSkuILhG4R5W3zvu3A9nJyQOa19+j8A1Fp0nhQ== X-Gm-Gg: ASbGnctQVyww5es2R3StnPo6A4TdP+LIMKK111ElsLSHZ5spRx7ZrcClMotcryfo0o8 fM4lcQW6FUrUTixBoywUSiDHrb8+mO7irfbka2OIyyiI+fZ89IwMZw/Fku8KJcpDfScnqOUwZgV QSxhiLeDN2mL2lQDLmWFVo6YXAq/uLr4b8omtWtSi0+LTE0sKKJ6IAc3PKw1ARjC7BeCfhwwIsD P5a8DYzpLSmUHQ/a9VxZp2APkQ/Zr8yAmwcsm9wFs0nEiw1b1c7LiTIRaya1ppyIpgFBCJQKfC1 HSv11Xp5tA6dFbyaro/sVPmUCCJVrup4E6woAdspFYJnMz7GRjI+4tg+hprAjwcmqlwsPzFKizG 7lW1t7vXyTA3a3dO5nflQFvWoyzSnW49dXqYCofTguPZJGhmFSOIPUKjWku1pBf5VNFcKGUzILA == X-Google-Smtp-Source: AGHT+IGUyWXg1o20W1qRrIG1wC6mWqJb1RyFmL9Chrc/cXi8XzQnpHFW0GJ96/o4T97yStZfswo7kw== X-Received: by 2002:a05:600c:8206:b0:46e:19f8:88d3 with SMTP id 5b1f17b1804b1-46fa9af313bmr222917555e9.22.1760606959080; Thu, 16 Oct 2025 02:29:19 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ed9e7d7sm16819345e9.3.2025.10.16.02.29.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 02:29:18 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-oe][kirkstone][PATCH 2/4] faad2: patch CVE-2021-32273 Date: Thu, 16 Oct 2025 11:29:15 +0200 Message-ID: <20251016092917.1946972-2-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251016092917.1946972-1-skandigraun@gmail.com> References: <20251016092917.1946972-1-skandigraun@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Oct 2025 09:29:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/120724 Details: https://nvd.nist.gov/vuln/detail/CVE-2021-32273 Pick the patch that resolved the issue linked in the nvd report. Signed-off-by: Gyorgy Sarvari --- ...ack-buffer-overflow-in-stringin-ftyp.patch | 28 +++++++++++++++++++ .../recipes-multimedia/faad2/faad2_2.8.8.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644 meta-oe/recipes-multimedia/faad2/faad2/0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch diff --git a/meta-oe/recipes-multimedia/faad2/faad2/0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch b/meta-oe/recipes-multimedia/faad2/faad2/0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch new file mode 100644 index 0000000000..3925cde545 --- /dev/null +++ b/meta-oe/recipes-multimedia/faad2/faad2/0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch @@ -0,0 +1,28 @@ +From a58cf881b820bfb4544995192fe5992ae010f1d7 Mon Sep 17 00:00:00 2001 +From: Fabian Greffrath +Date: Mon, 17 Aug 2020 07:37:09 +0200 +Subject: [PATCH] mp4read.c: fix stack-buffer-overflow in stringin()/ftypin() + +Terminate the string read into the stack buffer, +fixes #56. + +CVE: CVE-2021-32273 +Upstream-Status: Backport [https://github.com/knik0/faad2/commit/1073aeef823cafd844704389e9a497c257768e2f] + +Signed-off-by: Gyorgy Sarvari +--- + frontend/mp4read.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/frontend/mp4read.c b/frontend/mp4read.c +index 5dc36b7..a978e62 100644 +--- a/frontend/mp4read.c ++++ b/frontend/mp4read.c +@@ -91,6 +91,7 @@ static int stringin(char *txt, int sizemax) + if (!txt[size]) + break; + } ++ txt[sizemax-1] = '\0'; + + return size; + } diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb index d70c18f43d..6ac09c19ce 100644 --- a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb @@ -9,6 +9,7 @@ LICENSE_FLAGS = "commercial" SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-2.8.0/${BP}.tar.gz \ file://0001-fix-heap-buffer-overflow-in-mp4read.c.patch \ + file://0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch \ " SRC_URI[md5sum] = "28f6116efdbe9378269f8a6221767d1f" SRC_URI[sha256sum] = "985c3fadb9789d2815e50f4ff714511c79c2710ac27a4aaaf5c0c2662141426d" From patchwork Thu Oct 16 09:29:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 72486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA0CCCD183 for ; Thu, 16 Oct 2025 09:29:31 +0000 (UTC) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web10.3913.1760606961572606602 for ; Thu, 16 Oct 2025 02:29:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cx1o6csH; spf=pass (domain: gmail.com, ip: 209.85.128.53, mailfrom: skandigraun@gmail.com) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-46fc5e54cceso3468465e9.0 for ; Thu, 16 Oct 2025 02:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760606960; x=1761211760; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I8t47QPwtAYkeI1PYffgaKnUrAxtHvduowkPEb/fw5s=; b=cx1o6csHCVJfBhj3xIzAcrIwk+yEbTqcVvuwTHS2muPUr4Hj6LpZ1GLaHR66WQ+ksO R5LMUtgzGAUjhxNBRdDOp7Tz2oRj7LwSF8JkV47jzTraTxoJ52gnG30PMZNsGSJfNK0R vfUIirZSjNNi0P3iHTqlYpfPHQVfmptSsk4QpHGJyDz+Tk7/AV8iEYxsofg8ooX0ENY3 twQWvVQc6CPp/H32uvxKOycNFUDtKpYupeVVrRx1RSbjHuYGtz4Y+KIusDzhMeojaM9t Eb7o7BeY9H1MQiKi8tz+HNxcoRpc3AKPoEWrhduazqCxUSMZ2Ll7F5NC1OZj4Jo852/n l2wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760606960; x=1761211760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I8t47QPwtAYkeI1PYffgaKnUrAxtHvduowkPEb/fw5s=; b=P6a5vAnYa4M8X7XS6mzx7l9fzIPWa1ODi6hbo8d2f78L/92NjGXINBxjVpK9s7V0L/ 1Kxsa7JzBORWWTqaNZHbifTM+Qw9sWZMSZPo3CPaH2HuC4c8crtyAICO+OeWhadWg/wJ mcwVu3V2j9jqvTz+LjvjkOX3AwZXEdPZhzWPJc7+rXfVuPTKe4FiXXhvsvyKc9LLSguN e0H/mm+XedaPNsgOWGvjYk/1XOP9BlZnZC6Z4/2hwyAoTq5qugNL96sJsgP2Lq8LPVxu eYg2yeUOiWrdykr2pYwkecB59+HGROpNuIixVlvJDdVzczv74j0R9Msi/GVh6KBEpjNJ BETQ== X-Gm-Message-State: AOJu0YwZ7RILdXbHv49tzsyDDYofYFZdedBQfdqWsiGltS9lx1eewj55 aeuy76JM+CwKKr9ZbH8pqLLzMPFVec9/1fDCbeRFDhxgbWtxdTlO6eAJof8ndQ== X-Gm-Gg: ASbGncumUgUkwnc+wxyRpHUqF0H30uf2oWzvN66G33utcXzQt0nFMAgedtHyK07xXPU 2DHM63SR60x0m3/hYFrXsUW9sMYugVSywDlbmP0/VTFLKyJtDxg7vns8Dacr8GL4l2RQEztT+ob 8zkHFg2PQMxZPzKS5ITSNBuIxcbEViD0z3faStjj59y3kmSgm0lhfILAo2pIS+8oeJfmv2QjFXw tLuXsrCuupZNJ3pPCy5Ve7RtcDY94viH7zLJWk/K3vxlCzLnn41XG9m4id6GhGDWEPaF68VbPHd uuUsGCndjRswmgKcetVBzhiXIMMLvjqvrPvUzVRyP9uxWiyZ2Zp3pWDVrMGGrwpvRe2/pdpAVDH 9fBkUu1AAHjmZcmqflrvigchdV15QCVJ0vllrABO/W8KsSTpAGWji+DF8/jPRR9HMuuFVRPaGZg EQHe4neGdo X-Google-Smtp-Source: AGHT+IHlkADVczC5vVGJtHfRwDPmauHS3znJd2Jml5WMDx/gx8NtRpuEjmosrYFYR8vBDpPT2qe/jg== X-Received: by 2002:a05:600c:1395:b0:46e:27fb:17f0 with SMTP id 5b1f17b1804b1-46fa9aa204cmr214665125e9.9.1760606959805; Thu, 16 Oct 2025 02:29:19 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ed9e7d7sm16819345e9.3.2025.10.16.02.29.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 02:29:19 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-oe][kirkstone][PATCH 3/4] faad2: patch CVE-2021-32274 and CVE-2021-32277 Date: Thu, 16 Oct 2025 11:29:16 +0200 Message-ID: <20251016092917.1946972-3-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251016092917.1946972-1-skandigraun@gmail.com> References: <20251016092917.1946972-1-skandigraun@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Oct 2025 09:29:31 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/120725 Details: https://nvd.nist.gov/vuln/detail/CVE-2021-32274 https://nvd.nist.gov/vuln/detail/CVE-2021-32277 Pick the patch that resolved the issues linked in the nvd reports (same patch fixes both vulnerabilities). Signed-off-by: Gyorgy Sarvari merge to CVE-2021-32274 --- ...frame-length-to-960-and-1024-samples.patch | 87 +++++++++++++++++++ .../recipes-multimedia/faad2/faad2_2.8.8.bb | 1 + 2 files changed, 88 insertions(+) create mode 100644 meta-oe/recipes-multimedia/faad2/faad2/0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch diff --git a/meta-oe/recipes-multimedia/faad2/faad2/0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch b/meta-oe/recipes-multimedia/faad2/faad2/0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch new file mode 100644 index 0000000000..f1d5c63437 --- /dev/null +++ b/meta-oe/recipes-multimedia/faad2/faad2/0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch @@ -0,0 +1,87 @@ +From 9f7515c9571d5c72f6ec2dd6199650093628730b Mon Sep 17 00:00:00 2001 +From: Andrew Wesie +Date: Mon, 5 Oct 2020 05:47:59 -0500 +Subject: [PATCH] Restrict SBR frame length to 960 and 1024 samples. + +Fixes #59 and #60. + +CVE: CVE-2021-32274 CVE-2021-32277 +Upstream-Status: Backport [https://github.com/knik0/faad2/commit/c78251b2b5d41ea840fd61ab9502b3d3036bd747] + +Signed-off-by: Gyorgy Sarvari +--- + libfaad/sbr_dec.c | 9 ++++++++- + libfaad/specrec.c | 4 ++++ + libfaad/syntax.c | 7 +++++++ + 3 files changed, 19 insertions(+), 1 deletion(-) + +diff --git a/libfaad/sbr_dec.c b/libfaad/sbr_dec.c +index 0705ddd..1a541ef 100644 +--- a/libfaad/sbr_dec.c ++++ b/libfaad/sbr_dec.c +@@ -97,10 +97,17 @@ sbr_info *sbrDecodeInit(uint16_t framelength, uint8_t id_aac, + { + sbr->numTimeSlotsRate = RATE * NO_TIME_SLOTS_960; + sbr->numTimeSlots = NO_TIME_SLOTS_960; +- } else { ++ } ++ else if (framelength == 1024) ++ { + sbr->numTimeSlotsRate = RATE * NO_TIME_SLOTS; + sbr->numTimeSlots = NO_TIME_SLOTS; + } ++ else ++ { ++ faad_free(sbr); ++ return NULL; ++ } + + sbr->GQ_ringbuf_index[0] = 0; + sbr->GQ_ringbuf_index[1] = 0; +diff --git a/libfaad/specrec.c b/libfaad/specrec.c +index 9797d6e..d539bbe 100644 +--- a/libfaad/specrec.c ++++ b/libfaad/specrec.c +@@ -1053,6 +1053,8 @@ uint8_t reconstruct_single_channel(NeAACDecStruct *hDecoder, ic_stream *ics, + #endif + ); + } ++ if (!hDecoder->sbr[ele]) ++ return 19; + + if (sce->ics1.window_sequence == EIGHT_SHORT_SEQUENCE) + hDecoder->sbr[ele]->maxAACLine = 8*min(sce->ics1.swb_offset[max(sce->ics1.max_sfb-1, 0)], sce->ics1.swb_offset_max); +@@ -1305,6 +1307,8 @@ uint8_t reconstruct_channel_pair(NeAACDecStruct *hDecoder, ic_stream *ics1, ic_s + #endif + ); + } ++ if (!hDecoder->sbr[ele]) ++ return 19; + + if (cpe->ics1.window_sequence == EIGHT_SHORT_SEQUENCE) + hDecoder->sbr[ele]->maxAACLine = 8*min(cpe->ics1.swb_offset[max(cpe->ics1.max_sfb-1, 0)], cpe->ics1.swb_offset_max); +diff --git a/libfaad/syntax.c b/libfaad/syntax.c +index f8e808c..462ba9e 100644 +--- a/libfaad/syntax.c ++++ b/libfaad/syntax.c +@@ -1079,6 +1079,8 @@ static uint8_t fill_element(NeAACDecStruct *hDecoder, bitfile *ld, drc_info *drc + #endif + ); + } ++ if (!hDecoder->sbr[sbr_ele]) ++ return 19; + + hDecoder->sbr_present_flag = 1; + +@@ -1348,6 +1350,11 @@ void DRM_aac_scalable_main_element(NeAACDecStruct *hDecoder, NeAACDecFrameInfo * + hDecoder->sbr[0] = sbrDecodeInit(hDecoder->frameLength, hDecoder->element_id[0], + 2*get_sample_rate(hDecoder->sf_index), 0 /* ds SBR */, 1); + } ++ if (!hDecoder->sbr[0]) ++ { ++ hInfo->error = 19; ++ return; ++ } + + /* Reverse bit reading of SBR data in DRM audio frame */ + revbuffer = (uint8_t*)faad_malloc(buffer_size*sizeof(uint8_t)); diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb index 6ac09c19ce..731600205a 100644 --- a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb @@ -10,6 +10,7 @@ LICENSE_FLAGS = "commercial" SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-2.8.0/${BP}.tar.gz \ file://0001-fix-heap-buffer-overflow-in-mp4read.c.patch \ file://0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch \ + file://0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch \ " SRC_URI[md5sum] = "28f6116efdbe9378269f8a6221767d1f" SRC_URI[sha256sum] = "985c3fadb9789d2815e50f4ff714511c79c2710ac27a4aaaf5c0c2662141426d" From patchwork Thu Oct 16 09:29:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 72485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0661CCD194 for ; Thu, 16 Oct 2025 09:29:31 +0000 (UTC) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.groups.io with SMTP id smtpd.web11.4055.1760606962273282179 for ; Thu, 16 Oct 2025 02:29:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PWgh9asn; spf=pass (domain: gmail.com, ip: 209.85.128.51, mailfrom: skandigraun@gmail.com) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47114a40161so2819935e9.3 for ; Thu, 16 Oct 2025 02:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760606961; x=1761211761; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Trhv4x+ol06BIXVkNSzZMUCUVQ830dP7CDsUujlzym8=; b=PWgh9asnVJ9QbQBeaBsGQdutAxipYH3xyVJDM8pG75ejz0wE3olvp4PINpVHrItJ+p 8nt77Xdeak+j04pgukV1MsOkVVAtWdjKETZbQdTsw5Uha1zvV+N3f564xR03vMXLiAfI lOG8SvnCXd1+elVWvb1CaVhh5pHAGlqX4AcVn5jRxuyf7TwhwyV3rELQJgJbaX92gv+L n9sfC9gn6G8BcirCN0BW2YVZPNkWpyGN1oRVAZfKrsw0ZbFlbqHlP1HU+tlIsmRzXCJ5 xcCqXFvlFSaV3fRQsOIN0gFJAfogC/w0BF6jkwS/5KtrHeo3+7hJ7z1kFwUjip19fwHN fBXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760606961; x=1761211761; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Trhv4x+ol06BIXVkNSzZMUCUVQ830dP7CDsUujlzym8=; b=FuooKpW/0cOkjPh+fbZ0QFEp458EK6qDRJ5n2YUVGy7vInxIEp9B20w0QXVREntnR9 euugZPBXF9EwLV8Q4RR+s5L5O5kNSbGN3tMrQe0VNz3WB3F3jpG68wbplzGtl6GvzyML Z56uezdmPcVP+SbJjyjHsb8yDx2edcKquLM0oBcsADpGrbLU7QSmqxnKZSEc4f0r2lP5 AEbCCiTIHgvn1B8E21fucJgEVRROVVN/DKKxF6Ldw9IG2q23vN9DjFspQfmyu5JkqWCh 8WLMMkMLR4mjISeF5n8vtuLKsj+VBl+bLpO0AcBMvMWIL4Gneb10DgkiYd3IZaIQ1MLg MMDQ== X-Gm-Message-State: AOJu0YwCWh6SvrAYL2R70kWbC/4je4ydBdTCc0yheMwXy4wr9GgJMzaQ 4AWkmG28NdF6UyHhfvl04T2hoIj0I24hfbrFY+coF563IEkzs/jFEAiLYt+wxQ== X-Gm-Gg: ASbGncs2fH3j3bF11D9qHc3Gl6R1nqG78Yp/mIpgYplHhrsj4qkVCcw5sOxie5yyZI+ JHd79CGczRw8+L09IimOIICbGu/uYlatLSgSxbk4A7zAoOMVNKDDjJKOqFq/+z4W+o/XzDBX9wm MCVHZve9Os9H5ycxWI9LEAtjboIwXlK5BGi28BJaPL2KUYcIJAfPuc6jsFBC/rlM4OLgMj+5CDF d0S6oPkgLzMrraEy9bV/dZmJP4ZLYnAKfUp5k5ofUL+SvQLBfEt8KQs28McOgWe5BT8Mv9bSrkV kEu9giIXIia5HRAq9RjUF91WVMSVMAkZqrEX5oPlLC2FwYgWZQ8lVef5RnNdlDZ7Qs9MXxeA9qO 6aLBxR98NrpbvMGetYsJ87rCSjTede2JWw4+3qUG2qCxfBlNpTIpgrOZpJfNaoLD2l60WpneZuW qVcaTwpvdGCcyH2yTaeyA= X-Google-Smtp-Source: AGHT+IEbADxOoDirg/VkBWoSdIf03WjNLCe3dk4kx0SXiyyqTxBpvqu9BDgN7n/2fxtPw0Nt8IlgJA== X-Received: by 2002:a05:600c:354f:b0:471:12c2:2025 with SMTP id 5b1f17b1804b1-47112c22146mr13453565e9.32.1760606960561; Thu, 16 Oct 2025 02:29:20 -0700 (PDT) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ed9e7d7sm16819345e9.3.2025.10.16.02.29.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 02:29:20 -0700 (PDT) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-oe][kirkstone][PATCH 4/4] faad2: patch CVE-2021-32278 Date: Thu, 16 Oct 2025 11:29:17 +0200 Message-ID: <20251016092917.1946972-4-skandigraun@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251016092917.1946972-1-skandigraun@gmail.com> References: <20251016092917.1946972-1-skandigraun@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Oct 2025 09:29:31 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/120726 Details: https://nvd.nist.gov/vuln/detail/CVE-2021-32278 Pick the patch that is marked to revolve the issue linked in the nvd report. Signed-off-by: Gyorgy Sarvari --- .../0001-Check-return-value-of-ltp_data.patch | 31 +++++++++++++++++++ .../recipes-multimedia/faad2/faad2_2.8.8.bb | 1 + 2 files changed, 32 insertions(+) create mode 100644 meta-oe/recipes-multimedia/faad2/faad2/0001-Check-return-value-of-ltp_data.patch diff --git a/meta-oe/recipes-multimedia/faad2/faad2/0001-Check-return-value-of-ltp_data.patch b/meta-oe/recipes-multimedia/faad2/faad2/0001-Check-return-value-of-ltp_data.patch new file mode 100644 index 0000000000..3cd72baf79 --- /dev/null +++ b/meta-oe/recipes-multimedia/faad2/faad2/0001-Check-return-value-of-ltp_data.patch @@ -0,0 +1,31 @@ +From 4f8a793807d57d6a28aac3ab73ba0992efd5d828 Mon Sep 17 00:00:00 2001 +From: Andrew Wesie +Date: Mon, 5 Oct 2020 00:33:44 -0500 +Subject: [PATCH] Check return value of ltp_data. + +Fixes #62. + +CVE: CVE-2021-32278 +Upstream-Status: Backport [https://github.com/knik0/faad2/commit/e19a5e491354e0e4664d02b796dacee28fb2521e] + +Signed-off-by: Gyorgy Sarvari +--- + libfaad/syntax.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/libfaad/syntax.c b/libfaad/syntax.c +index 462ba9e..4e57efd 100644 +--- a/libfaad/syntax.c ++++ b/libfaad/syntax.c +@@ -872,7 +872,10 @@ static uint8_t ics_info(NeAACDecStruct *hDecoder, ic_stream *ics, bitfile *ld, + if ((ics->ltp.data_present = faad_get1bit(ld + DEBUGVAR(1,50,"ics_info(): ltp.data_present"))) & 1) + { +- ltp_data(hDecoder, ics, &(ics->ltp), ld); ++ if ((retval = ltp_data(hDecoder, ics, &(ics->ltp), ld)) > 0) ++ { ++ return retval; ++ } + } + } + #endif diff --git a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb index 731600205a..f354c99d33 100644 --- a/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb +++ b/meta-oe/recipes-multimedia/faad2/faad2_2.8.8.bb @@ -11,6 +11,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/faac/faad2-src/faad2-2.8.0/${BP}.tar.gz \ file://0001-fix-heap-buffer-overflow-in-mp4read.c.patch \ file://0001-mp4read.c-fix-stack-buffer-overflow-in-stringin-ftyp.patch \ file://0001-Restrict-SBR-frame-length-to-960-and-1024-samples.patch \ + file://0001-Check-return-value-of-ltp_data.patch \ " SRC_URI[md5sum] = "28f6116efdbe9378269f8a6221767d1f" SRC_URI[sha256sum] = "985c3fadb9789d2815e50f4ff714511c79c2710ac27a4aaaf5c0c2662141426d"