From patchwork Thu Sep 18 11:15:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?QsO2c3rDtnJtw6lueWkgWm9sdMOhbg==?= X-Patchwork-Id: 70496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB3CCAC59A for ; Thu, 18 Sep 2025 11:16:02 +0000 (UTC) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mx.groups.io with SMTP id smtpd.web11.11516.1758194153046985304 for ; Thu, 18 Sep 2025 04:15:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bp0n6SyX; spf=pass (domain: gmail.com, ip: 209.85.214.172, mailfrom: zboszor@gmail.com) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-24cde6c65d1so7831025ad.3 for ; Thu, 18 Sep 2025 04:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758194152; x=1758798952; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hsylM9gZXoVQn5JETdg59ncizLKpXtUHyfJXo41J/AM=; b=bp0n6SyXyxYJWoTBl7bq5IwF+t72kRmIIWCKpgLFTzeWlfqDaxAMrLFD9NG2AroBdB +ME0Kv+aTwkGmF5QRD7MQ3pHO89RuvkA8g06Qeqwhy2ShXxNF1MATuUQLhoNTZ/DL6Ju 9/4rCr06PktgfgMTH3eRYQF4Kp9OhhwNWrIDK8NQ8fK22O38wFg76XGsXOGVZeR3xJH1 H1lq3Q8ZP0dbGbu9NEgM7R1ex2/tXTz7dsKpvnflroWOVfTjw7UcBnmTbIQ0OBmGZITu 4Kx0LpGIK7tuI+SO6XK9to4g18ES3PqbTvAaxCON21tWRsr24CzQ2GnkJN7NNBmQw+QX TW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758194152; x=1758798952; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hsylM9gZXoVQn5JETdg59ncizLKpXtUHyfJXo41J/AM=; b=neKw/zd13sQW8YuZR6Z2VYSS/grSmC9xj01zeQsfmDojYTn/6tuUt/j3h0x0tW17cb ETTJgl1miriCG+sw0Z2H3uIJPybGVx6azuuag5UGQOAQk6EftKA2pi9Ys0E5kBoUv2Ea /yRElqYn8G9qYB5pfZl3wY3GRoUAA2hQIANtrn56BqlIimhhcBRxBpacQmUqEJ7FD+C2 U6lDzGaxZuCeueQ4YB43KM5Iknx9hbaeYxDL5dgd0B2GTAPKCopCYQ43fi6LgIV9Xno1 vHzJip4fP5OmZ+jarmRoitBO0XK10a1/oSC3cwAotcDko+Ons2k6tZbxI9fk+2ZdqMBO Xeag== X-Gm-Message-State: AOJu0YyF0VWlvmFmV+74fRjZsv/pMk8tgPw+RZ8CFc/+9Uz2R8H0plmF /HYrqHZHB9Qvyua0E/RhT91fMULyo3bPx79ylyWQGeHSzzKD7zDSff2Znp0R+g== X-Gm-Gg: ASbGncuKCARWiiBfThVpg4ZRTVBoaxyhN9NR+HrYk2QuN+mHPkz8PEO/XwpG98wAJO7 9cMl+yZmt3Y1WSHb0iBE7yIuRl497ZuCigQ8nX3FkKUS6lhBWKdaeX1zM8I710PzsXSSh+VKZrq wlaOsEEZVK5HxBkv6fXzj9I0hrQqGaWPW0LPtvxWumdkRKcdnlwPJvobe4UmCOlocugTkHavS1E VuBrZusAhPwSqO778JSfqG2kopzXE9ypcRzWCZsdH11JH+5GUTFkTzb1VNmLiuLr6YsZ0cEo0CN 5iy9sEZ9r5KjcBk8QOt0XmXLBz+2Ul+Zs1QOUogSXaEN8NiFD/urvWN5vaXhZAoyfsg2/Mn3Sn1 zlauntXzU8P15btkenJKPKkG7yPQya3LuHT7BJURIRmFaLoimJ2OP5IZlB0v6xYc= X-Google-Smtp-Source: AGHT+IEj1WX0j+vmAfm9mL2Mur6FVmhlTscTKnVBPVzeIGICQcM3NXc8nW8IRf6XolwlvDQc6xzkRg== X-Received: by 2002:a17:902:eccf:b0:24e:81d2:cfda with SMTP id d9443c01a7336-26810ddadc0mr76827695ad.0.1758194152011; Thu, 18 Sep 2025 04:15:52 -0700 (PDT) Received: from fedora (dsl51B7D2F9.fixip.t-online.hu. [81.183.210.249]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3303ffe611csm4070220a91.9.2025.09.18.04.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 04:15:51 -0700 (PDT) From: =?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ==?= To: openembedded-devel@lists.openembedded.org Cc: Armin Kuster , Ankur Tyagi , Yoann Congal , Khem Raj Subject: [meta-oe][walnascar][PATCH 1/2] gutenprint: fix a build race-condition Date: Thu, 18 Sep 2025 13:15:41 +0200 Message-ID: <20250918111542.717014-1-zboszor@gmail.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 18 Sep 2025 11:16:02 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/119558 From: Yoann Congal Gutenprint install hooks run in parallel but depend on each other. This is a race condition and might trigger a build failure (e.g on AB [0]): | chmod 700 $WORKDIR/image/usr/libexec/cups/backend/backend_gutenprint | chmod: cannot access '$WORKDIR/image/usr/libexec/cups/backend/backend_gutenprint': Not a directory | make[5]: *** [Makefile:2166: install-exec-hook] Error 1 Fixes this by adding an explicit dependency between the dependent targets. [0]: https://autobuilder.yoctoproject.org/valkyrie/#/builders/87/builds/46/steps/33/logs/stdio Signed-off-by: Yoann Congal Signed-off-by: Khem Raj --- ...-race-condition-around-empty-directo.patch | 60 +++++++++++++++++++ .../gutenprint/gutenprint_5.3.4.bb | 4 +- 2 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 meta-oe/recipes-printing/gutenprint/gutenprint/0001-cups-fix-a-build-race-condition-around-empty-directo.patch diff --git a/meta-oe/recipes-printing/gutenprint/gutenprint/0001-cups-fix-a-build-race-condition-around-empty-directo.patch b/meta-oe/recipes-printing/gutenprint/gutenprint/0001-cups-fix-a-build-race-condition-around-empty-directo.patch new file mode 100644 index 0000000000..758acfe6be --- /dev/null +++ b/meta-oe/recipes-printing/gutenprint/gutenprint/0001-cups-fix-a-build-race-condition-around-empty-directo.patch @@ -0,0 +1,60 @@ +From e3b0952fe936f90cfda9cbed368fae2143b72089 Mon Sep 17 00:00:00 2001 +From: Yoann Congal +Date: Thu, 3 Jul 2025 15:27:04 +0200 +Subject: [PATCH] cups: fix a build race-condition around empty directories + removal + +In automake, install-exec and install-data happen in parallel. +install-exec installs executables and install-data finishes with +install-data-hook that removes empty directories. If install-data-hook +happen before install-exec finishes, it might remove a directory while +it is used by the install process and make it fail. + +Fix this by adding an explicit dependency between install-data-hook and +install-exec. + +For example, here is the log of such a failure: +| make install-data-hook +| hosttools/mkdir -p 'image/usr/libexec/cups/backend' +| make[5]: Entering directory '$WORKDIR/build/src/cups' +| Expect a number of "rmdir: Directory not empty" warnings +| /bin/bash ../../libtool --mode=install $HOSTTOOLS/install -c backend_gutenprint '$WORKDIR/image/usr/libexec/cups/backend' + # Start of the install process (from install-exec) +| These messages are harmless and should be ignored. +... +| rmdir $WORKDIR/image/usr/libexec/cups/backend + # empty /usr/libexec/cups/backend is removed (from install-data-hook) +... +| libtool: install: $HOSTTOOLS/install -c backend_gutenprint $WORKDIR/image/usr/libexec/cups/backend + # install in a non-existing directory: backend_gutenprint is installed + # as /usr/libexec/cups/backend (this is now a file instead of a + # directory) +| make install-exec-hook +| make[5]: Entering directory '$WORKDIR/build/src/cups' +| chmod 700 $WORKDIR/image/usr/libexec/cups/backend/backend_gutenprint +| chmod: cannot access '$WORKDIR/image/usr/libexec/cups/backend/backend_gutenprint': Not a directory + # chmod fails because /usr/libexec/cups/backend is a file and not a + # directory +| make[5]: *** [Makefile:2166: install-exec-hook] Error 1 + +Signed-off-by: Yoann Congal +Upstream-Status: Submitted [https://sourceforge.net/p/gimp-print/mailman/gimp-print-devel/thread/20250703164244.1120340-1-yoann.congal%40smile.fr/#msg59202153] +--- + src/cups/Makefile.am | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/cups/Makefile.am b/src/cups/Makefile.am +index 7928ee3..fe45c92 100644 +--- a/src/cups/Makefile.am ++++ b/src/cups/Makefile.am +@@ -206,8 +206,9 @@ uninstall-local: $(INSTALL_DATA_LOCAL_DEPS) $(INSTALL_BLACKLIST) + $(RM) -f "$(DESTDIR)$(cupsdata_blacklistdir)/net.sf.gimp-print.usb-quirks" + $(RM) -f "$(DESTDIR)$(pkglibdir)/backend/gutenprint$(GUTENPRINT_MAJOR_VERSION)$(GUTENPRINT_MINOR_VERSION)+usb" + +-install-data-hook: ++install-data-hook: install-exec + # Remove unused directories in install tree ++# Note: it removes "exec" directories, so it must happen after install-exec. + -@echo 'Expect a number of "rmdir: Directory not empty" warnings' + -@echo 'These messages are harmless and should be ignored.' + -rmdir $(DESTDIR)$(cups_modeldir) diff --git a/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb b/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb index 5263890239..f90a123293 100644 --- a/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb +++ b/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb @@ -14,7 +14,9 @@ HOMEPAGE = "http://gimp-print.sourceforge.net/" LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" -SRC_URI = "https://downloads.sourceforge.net/gimp-print/${BP}.tar.xz" +SRC_URI = "https://downloads.sourceforge.net/gimp-print/${BP}.tar.xz \ + file://0001-cups-fix-a-build-race-condition-around-empty-directo.patch \ + " SRC_URI[sha256sum] = "db44a701d2b8e6a8931c83cec06c91226be266d23e5c189d20a39dd175f2023b" inherit autotools gettext pkgconfig From patchwork Thu Sep 18 11:15:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?QsO2c3rDtnJtw6lueWkgWm9sdMOhbg==?= X-Patchwork-Id: 70497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB77CAC5A9 for ; Thu, 18 Sep 2025 11:16:02 +0000 (UTC) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mx.groups.io with SMTP id smtpd.web10.11319.1758194156828718606 for ; Thu, 18 Sep 2025 04:15:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OmqAWrsl; spf=pass (domain: gmail.com, ip: 209.85.210.179, mailfrom: zboszor@gmail.com) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-772301f8a4cso1225569b3a.3 for ; Thu, 18 Sep 2025 04:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758194156; x=1758798956; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YetxR6FPul53Tq51hRHMzkeJOUr4I0//WRTs5Txpgr8=; b=OmqAWrsl2ifgfLhDhb7LcMzM9W0XBc/epqxv4o0SqJ7BR72brpHFMR1uqAoJ12jBLv RNJsbHL2Z06FZzBNhk2FMPSF1FGlTw7ATHqR8S8Iio2BNBqAh19ouRkgeokLLd5tNfsU 6dfGqm6s0JZ1ZEO4hSigomandDIQtlYXAIdqvHdv0qySbckkkfN0ojVImQdTxqvkssf3 8S4x7ourdiuw8P60uqem81rIWG8a+tATNom6bwhaMlA5wmVOKRy9uBmRg7LswwWp813M nUJ5sUdIZPsBGLoRhjQyR0MP7LGFRhGri0YaaTHzNrmQAukgC46WXUPcwJIpLv32/CeS HJSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758194156; x=1758798956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YetxR6FPul53Tq51hRHMzkeJOUr4I0//WRTs5Txpgr8=; b=ZCz4bePgV41AYBOG2DifjeXM12Be85jIg3ormMuHy5JSHHAXVoDgRiV6s9hLu3SEVX 1rJR1yWfY2MR90BX21HqedqnRR+TKMR77VGnwgQNmiMnMl4SWqd82S1gB+7zDonpR5Mb 5ZdLN1Cy/xI2P6gxSj4h9IT8RLz3a16UX/jcezja6faQWT8ZNJrR4bX58fuhd1lnGGbI O8QHYrO9c+dAT6wE7XYtFkWpkNA0j2T043I/urW3z+VBxFRsoxxLlWA6Ik8/FnBDRDgP W8Oyced7oFHdLvdyoQyrQ/uqfpC3a6V0LZNHVueUtreFqbDQrgs5qkEGObqhMJr2J3ip h+bg== X-Gm-Message-State: AOJu0Yz7ryxYBS2YVMEnUj598yRTnKf1TPwFTM6HvVdp9ShV/SD05JRY RFlHWZCy9T8jO5bqV/WWk1GA9yUmsYa3rsbO2AIyCadZhsbyLHazZHr89KUh/w== X-Gm-Gg: ASbGncvLQPgyWzpG4FobCxrOZiOLmh0NS1gBiTNsvccUqe+spbYb6I7/yx87tcnhPpR k/3BWNCQdV5ZWRRHkLgMZkSJIJ28jfiScUdgQOUPMoPULo7ToIX5XQT+2txvYyobeFZcqoF7gSF 782HhejnEOo8mdvHffegwMUwRnA4ewrdc6nqkAUeVmmlrEjIofybP4KMfWG7w36Cv+8T6vtQsFS p5iH0jzaIsK/Kwpk/pFiMJMT8pJt3w9bElEeakeYVNpUCptOiYO5UittmKBVKE7tYHkTmEWJT6R pz8Fn/Tm4KycKD+3QEC4MhF28G20x78VJynU9fLBBpVQ26+vD0K+RVmFN/nQCVHrZt4g8/OiLsG +Jo7Y6eILPurKQLfb8QyuAu5ZQgSIkN3UGONYTucFy3OMfuM+0wTLoClBZHLIdHp0LuOjiy+B9A == X-Google-Smtp-Source: AGHT+IFd+25kqOCl8Mtls+rK7tgp3JWT4MMWmusUEIHcNEh4/LJMig2BrxZ8UZh+twKEBDbH/cVbVA== X-Received: by 2002:a05:6a20:729b:b0:262:7f60:d757 with SMTP id adf61e73a8af0-27a8ca845d3mr7443149637.11.1758194155831; Thu, 18 Sep 2025 04:15:55 -0700 (PDT) Received: from fedora (dsl51B7D2F9.fixip.t-online.hu. [81.183.210.249]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3303ffe611csm4070220a91.9.2025.09.18.04.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Sep 2025 04:15:55 -0700 (PDT) From: =?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ==?= To: openembedded-devel@lists.openembedded.org Cc: Armin Kuster , Ankur Tyagi , =?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm0=?= =?utf-8?b?w6lueWk=?= Subject: [meta-oe][walnascar][PATCH 2/2] gutenprint: 5.3.5 Date: Thu, 18 Sep 2025 13:15:42 +0200 Message-ID: <20250918111542.717014-2-zboszor@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250918111542.717014-1-zboszor@gmail.com> References: <20250918111542.717014-1-zboszor@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 18 Sep 2025 11:16:02 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/119559 This fixes an installation error: | make[5]: Entering directory '.../tmp/work/corei7-64-oe-linux/gutenprint/5.3.4/build/src/cups' | chmod 700 .../tmp/work/corei7-64-oe-linux/gutenprint/5.3.4/image/usr/libexec/cups/backend/backend_gutenprint | chmod: cannot access '.../tmp/work/corei7-64-oe-linux/gutenprint/5.3.4/image/usr/libexec/cups/backend/backend_gutenprint': No such file or directory Signed-off-by: Zoltán Böszörményi --- .../gutenprint/{gutenprint_5.3.4.bb => gutenprint_5.3.5.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta-oe/recipes-printing/gutenprint/{gutenprint_5.3.4.bb => gutenprint_5.3.5.bb} (96%) diff --git a/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb b/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.5.bb similarity index 96% rename from meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb rename to meta-oe/recipes-printing/gutenprint/gutenprint_5.3.5.bb index f90a123293..82953b798c 100644 --- a/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.4.bb +++ b/meta-oe/recipes-printing/gutenprint/gutenprint_5.3.5.bb @@ -17,7 +17,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" SRC_URI = "https://downloads.sourceforge.net/gimp-print/${BP}.tar.xz \ file://0001-cups-fix-a-build-race-condition-around-empty-directo.patch \ " -SRC_URI[sha256sum] = "db44a701d2b8e6a8931c83cec06c91226be266d23e5c189d20a39dd175f2023b" +SRC_URI[sha256sum] = "f5a9f47de28530b1ae2069cfbc647a9a641baeeabe809bb0ef2b3ec5b9668d70" inherit autotools gettext pkgconfig