From patchwork Fri Sep 5 06:20:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3E2CA1010 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=iT6c51Sr; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YhJKfazTaVZ5akWdNuyMXfmTDNEUmAX8+rIXC3AXfRmDAGOh2JZe6av+rZEcAVGgMdxMtGAz5owbntvlrGtNqok2E5JwI/IRGIXDJntzrHSAgWqu/x58YTF91fYQu//fF6xgk1t7WAkMGsc8adb5nqJV0tCf98O6cXv2v8x0tSozZ6tdwJjXziiLTJwCRP/2fR1IKgShCIVFWxcbgbdNOPOsAatt3b+7i4ikyTrwvvzzCZXxJAa8HVpSYGlsllJrApBweHci1ubkFZnsUskYR0TtYl9izy2ZmpQ3iA0RnOJEcNlUcJqrH1+ctBNjtzLvgrOCKx3pOKqbttHg+xiy+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=klRo2YCYs8fid/Pde4qdC6lyMz4x3raNKqBO50lqmuI=; b=yuuC/F9YxrPzWiVj8ygLxsGF5Mup+wu5K4TTvTvmheVRy/7TkcbyrcrWa8uqUhlfk98fRfzVfvzEGxhzICzylsJKeO6it8PXY+GtyjVYpg27aVvTcF9cjh9V8kuWEvGzTdrDl8erpgzNENnlaaUaJVbMsKiWOx3P4e5SSVfDmKCFpHldr84hsQ1mk8N8zHMWXCHjJRt0SS1QJF1kaPSBN4NgoqZoRDKqeAcxEQqyBKVRVEyiK7ioSpXG5rGvPCBtNhdp3B6K4I33dyrNJjt81mG9Ea4zarNtmWXvHIRs7NAuRvEOPvQyUzQkpty3FwPqh5cEjvUeGovW81w7+lfdPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=klRo2YCYs8fid/Pde4qdC6lyMz4x3raNKqBO50lqmuI=; b=iT6c51SrwiZY1nS6Z39OxjUe+GFY79l+7O6iVcBseSLlgZC0FFjT5Pwpy6Y89NcR1W98vE8JWGqOBniyIIhBsOaveHpL0vlhOk1FC6YFiaV4itUjlUYPKgLiU5v0YZRSnfaV76woIRcC3vFmnjpLSS7H1kFjZqR2HW4EzCohhFBEVTorOGmvrxjsv5Jeh+30yg5OnBabwIr/KCMA58XAZTiI8ldzLFJuMTKy+WmvT4nFQe/qAyMGHa6lmhX2c2pmqsRTIKXjaZKd1sMArSUAQ0fFq7xE7KEL2y4KVTXsa47o6bQ5ONocDoZJkkltdsRc80LeEjOZdb1Z3E8bs6ZYAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:10 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:10 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 01/15] tests: fetch: add test case for local paths Date: Fri, 5 Sep 2025 08:20:44 +0200 Message-ID: <20250905062058.2563806-2-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f9b964b-3890-4f23-2f52-08ddec44679c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: f4b88xLkWBciob3ME1YoZeBpiGUrzAkSCEAf76R9/XnSd6XF0gj1kzwyB25zxicUmGOywyJNLzPLy3k4/KODXvkWeUaCseLzEyRCWQAeb5GIeuW3FVCHsY2NHygrbmp8CLh9HkfC8vLwJZM3O3zHC3xnD5Y+ktmeovHhEyKaHXJV+0O9f0+848Q0BckXdGZdGOHNGmuA/AuOy0nNleBCa6SGSt6MYSH7Sq4zcPfB//jacm/ZSCyTl6t3mFJqKFkVuIEpV1UoKrQ5qt7zKaDn2w5m9fvH6w4MHvZrCzqR5rysj3pkraVx8R3QkLMBVYKsFVM6E5bJeZCkKFk8NYaMcPC5+l5ztH7KetRqUvoaWGLo/oy6tl2BzXyrppo/4JFYi/qd5FadAMhWD3dEPNBzCLMmSYks8hUompqnBFU3eQiAIVO9Ni8wT25O8xxnnfxL+uO2/4IWJ3YCv1D4MRSNHYtx6/L+i0bJ12op6yx8dFjabcWcU2S1jAbdGKdNaYwdvY0PnU6T0dEYNTqaVEEa81Ym5B71Emeuk2UeWEMRjnIe75l171KIJ59x9AFZnGmMNWPUTrWic4slItqr3Ek5tsXyJcDXMgK23g6Em9eXJVQxk+XcHeRYmZRzXSWaiT/WZGv7S/HMfHKCHDk7R5Y/xYvIoedZJyXgAnpZDotqStVmbCb4oL2Jm7+VCjQjtYpsQz36jXD5tCQmJ9Kt2SyC0MkAa6/rDrhX/tW157lPJMkVUlP9Q9wYTRv9Zx/3LYzNFLO08GJO56m6fWsTvHcoYIOLdlqcYDLOjrwdmxs+jPOTQLSFZQVft2UwVooXDaOwKtogpm/RMKP2zS0fEoMcLoEgwaHaukEzCMAN9tqwyQB1pjlk8Nav8/VmhfPf5bgyedugaQUmmQ9F94ZAHNAo1YrotdbD2HRJd85ZUw0m2enlMPGHvbBbhkZVvb5zTk8/eyNHiw6dylxumRiXc69+pZ5eQuYVS2bnrRWhnplGuVH/QvEFzXUd3Eeo2CAEsnKbv+vwxJGd4xzJvOQz6w/ukx5lH5TCK+vBjimVtgB/L/9LkUCp0oxBQOqSXBlamS/elbSWFDIYnAu3wFlLdI6cFyvy9Wr+LQaDu0Dey5FS8ZD24rf1x4awO5QM0J1FY/8ji63NyDBq3BNNhmZEqf9NlB33K1siJ4NeoczoHa8E/2vniW23MfUmX074QVI6SNGGLCJQbFChgWQqCV8YZy2AIGaDEHOXbTF75cknTgcqquy2DbBAewb/iXwvDuA4CJg4VN4vHZ9MNQp+Lsn7cWOarLIC9voD+wBJukrxZvNjhjqODTMFsIwdXk90TYpeUpqKZEUHwv7OhnJj1GkmKhtTX+XdYlyPV9ULQ3qejjHAHePpBLLwycaNT1atHDsthBs0PAAPr/VZeZFg+iL2L8Y/wYWwJcfwiFSrwlzybU2LGd0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GUtPO9EsxzJEeaNCqouLqlXpVi5Dy7f2zMuNL8HbNKS6Ht39R7doLYjW90ZnjSduDiaN9x1NJcznPJFx5/TiflmudMlgwdoz0UAmNAsopP0lrDEpIbfjrkNo1BZh2OjY4QbwVb1Xwfl+s3eoj5+XVO94URpPPc++gOTQbE/tO3xC1lI811f6B08sN+tO4HAkhuUNaaXbdIshxLOX23geIzjjZZLozXGeq9UQO3og2b0YeSzGPSuiNRRi5v65878OAD2XydbcaCcCGoMQUwraKSclivjC39kmmW9ZQgw3SakPm0uspKsvpj22bCejZj7+UPoa3TKD2BXKlBOgd4Sx9ampUACSuCKLlB2fSdGLMkKarom6UGmWEDJIJbYNpRpVEXLTD9X0bRuCyrNVfxHcpnN6fdU56xH0I1wav0p20M+Wl/DK3kJcN+TLGt+U5KiDkgR6+wowxH0HyXLVXVR+TB44BWgHQPMfN8N7bEkR6KfpdAllFVRy+5Hkv/OWEXeK6uiDvLVVrq7Ty3bMr8vhOzKqOzM8/Um0gbF+p1xM24Di58qd2TrGgttIU3MWQf8O8IqyOaLiAe5jTwe01oGKHYU7yyhcGh/m1KsX+jkwOfMLFrsQiNritxOhivvYCgOeeIodjiQVaUbpJTp/6C+SEnsW58v7nJ0MhAwoS+U5FVV1ygOfdfcpN0JBOTrQ15FtVegbIFSRXb0AyMwo3JNW381asvoFhpWlFssYFpHAuulBzDPc2m/ad111YSCB0fozifglO3aB//ODlaEqSJKiWmx4I98KGpY8yZZpfklwUhDXHV/CSNiSJi8/A/ad4yH9E+VxzcDuZHsg/2jL2CmRqsmDHd35bvj1qfCH2GpiO6cQ//TmDhivu0qG43+xYe0YXRi3mnZuIHg0+IkvqLsOaVMIzsgaTIs1iAlJbz98LxWX92ZSXSBxqdVQRWOy/Ekx68UOqTyKGG1Dt275A6C8tqEvkp+ZK9KYVo/arwF66vW8hoUNrt9fy3XNIx7PQ4MiPJOwzkFqalpF/aTrBBre8UwXc7YVVuUUcIXJe4qTp39pYy7qZ0sn5QMB+aYJ93N8b0f9BNoyQkXIf4kxgCorwLnUokQimP/lF/UFHOQmarNGZhJL3C4l3BbEH+P7+YD5NmWxFY/TVUaNCUEciMIckyMpPlqPdvDtKrVonizDodf4fRnpEzuD6SkvYg/vsVgVv8/p+7HRr7bDxdapYO50pjQSpDjYXebjaUXuS/7Thw8hlkfHKpHtMAsoeM++r26Y26pXucdpHRBcyLhqxnYTwPiQnjH1ukEffjmtmvmk06wkjRWfKuEVn3Di+Jw238I/W2Xp0CSbGF1tkBCjEtk+V+GPxUnTOWRHi1C65WDFVyEFZX2Zt2frSNEdC3hTIZpTraAtTGMVOYDjGT1zSzVT1g2YqzA8AQm2QvFNzbc9TiUzbXdO8nfuR3Ni5Tve/LgclDq/X0d7FK+AFfYYIFauxzrUdH2U52hBJLw4zEO0Btu3/5cQYI2+HMCtVHD/b/EOVHdgGR86kFChbbuuR9rINx0YDS7SI+0YssJ/dMtOJBXJkLlQ194LVSRaOGnFF9iWi/VSrlv8WWQGrgk0w9ajZw== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f9b964b-3890-4f23-2f52-08ddec44679c X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:09.8673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dNnTZyTR4jkV3eKe9unP6hpPAc8V6WfKVFWpJ2h8aiwohzI3rFtWkxiVhWrtIkN0MMqzTc5ni9dQ3gV2qoU/xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17958 From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- Changes in v2: - Move test cases for local paths into FetcherLocalTest class lib/bb/tests/fetch.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/bb/tests/fetch.py b/lib/bb/tests/fetch.py index d216eac2a..dcbe60783 100644 --- a/lib/bb/tests/fetch.py +++ b/lib/bb/tests/fetch.py @@ -888,6 +888,18 @@ class FetcherLocalTest(FetcherTest): alt = os.path.join(self.unpackdir, 'git/.git/objects/info/alternates') self.assertFalse(os.path.exists(alt)) + def test_localpaths(self): + localpaths = { + "file://archive.tar.gz": + f"{self.localsrcdir}/archive.tar.gz", + "https://downloads.yoctoproject.org/releases/bitbake/bitbake-1.0.tar.gz": + f"{self.dldir}/bitbake-1.0.tar.gz", + "git://git.openembedded.org/bitbake;branch=master;protocol=https;rev=270a05b0b4ba0959fe0624d2a4885d7b70426da5": + f"{self.dldir}/git2/git.openembedded.org.bitbake", + } + fetcher = bb.fetch2.Fetch(localpaths.keys(), self.d) + self.assertEqual(fetcher.localpaths(), list(localpaths.values())) + class FetcherNoNetworkTest(FetcherTest): def setUp(self): super().setUp() From patchwork Fri Sep 5 06:20:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69717 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF02CAC582 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=FPjJBAsj; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ihainYY7dQqL03/3WvuT93kJvq3N22ckGR3HGYfWiKEe4QNhZCJBQpzioukSA93nJbyKTe3D4LNP4XZf+982Fh5SrNedpxq49c0ihDCJbdl82h8pofoAnXMJlO2rpAx4YBNLBF4U9TkGiiKBItRikvbu6S/T0waT+PATkNYNH8W4+6LCkGyioMnVoXtW3ULq8BneHlyKH10OywpiE8xNiWKOuyuGVAu/nSn98nZ3jkBRNg7sKeClRzQZFJxzTybTSaKD8av3vAux2SioTXfONBKrXwB1sicpJU2GS6oUjGfhFtzfSiSlqrao6Wu1387w8p1PQuMdPEMqt8KAmDivig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MMCkKcMBY03PuLziBFG3egOtD7u1Swlu9SwKD7ogNJ4=; b=hfgHXo0K76olOlpJk4z1KRwHwCYCA4JldaRsZs4ulYZqMGkWjWPSUVOKZeD4CiNjeiyc576XkZk8tjzcELjtOPzxyuNdQeKYhFmd0V4XXvQNREW+P6YnkoEtMS7nB/BSTS4uVOg/Dd07NVHahS48CadUYHRA0fIYTFXdJQMiPgwoKkKR3+OoeAhSnT7HZGiip2X1hKx7d7uqlv7GU2LBJiJuL0yG/i6XdjVDAq0FXR6AShCUoIVNNVaUH2LnRed3hIhmBtppQStlSCRm7GM2RUkVHN9C33pi4CdCsutkUTuNCVuJjgAHkL3Yc15wmJkqEh0DDRecAV2a1IMJ2AjjjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMCkKcMBY03PuLziBFG3egOtD7u1Swlu9SwKD7ogNJ4=; b=FPjJBAsjn2MJBW846rwOrLihS3sm1zVc/MhofmZA1i1M9LVvPNHnVBTozSq/TKrddkDX5xzEocd2JgImV1QKQUcgRuM4QO/0pCpJXvqzwki5FPwYw2CJFxIB0VbAAsBQW4WXU9Bmn9u2J+RIb0YYg/RDZq5vrZqZ9nLLrT2al+Tbz78uwy6V4rGt5UvL1394e2XZxFgHFxTVrbFztmiCnGplcyAoJfMbIkTDD4PEKz6SFRo71uAXrDmtwXBhTERQzd9JLRQq0q5hasxbkFKPlMYY+3pwMXGIMrnTIsOrEmQ5P32pIY8buGry5CKRy0/qXcHLi9W7SewMzeuPsuVQAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:10 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:10 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 02/15] fetch2: support URL rev paramter for named URLs together with default Date: Fri, 5 Sep 2025 08:20:45 +0200 Message-ID: <20250905062058.2563806-3-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 71381b30-1f5d-49d8-cd94-08ddec4467e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: FY4tG2ExjymswvTB1uMwyKgFNu6yCPivAnoaDlw94OWXQWfIBd5qbQIywPHtDf3xz1+zML33qxAvCaXrF5g2qHhIoLFX/L8g7qJPQklNrEyyr+FOj72QnxaKishRskHI6+bOlNTQnUMhQ20aiTJXVU1uwaXus6cHuxzfQeWkV/Nhrbiv0A1O2rEvu7JpJw7xUuhuHQgRh5NV6N9/u92otHJ9Jw46zXhxv0H7pBq703fFS+YvXOXEBJ4eH7S9ddr5Zpp4hqDBA4JbtkIXtzWhUO8dj5LPB4lEiZQw0pGXlbQ52eYJ0qInPNGhNsBw5VEMbokgVlpbR8NUVw3/DzHF4Fvt7KiDHz3EraFv++j6NHmjPchmpsY2fZizb8kdf8EWPtv+8rGfbM1TUZrNeUy+JoiAO1IL+W7CmgbyI9AfaPf2i5IB88eFu3PtIId9BwNBU3svYhHkzqqvuVi2QVtYiVov8x579aeOkBaNGju105XoitlwxiZ7nwAez4COqKuzoPr+If3NWyCcmjH7fXcRxxmNjLtQPBwLYTHBi9eqAtFPayiu2gW9fUF4SRV+7bk5k62Y8Yqlz7jfbWHB0DsTcD7W7oOgQzTVg42J5iJ0tDsFtw7+4x4rs9bMiEjey0z+FvDSgEfygvMlvfUtuiuNNztZ2rESZ+fm4fauozA29moT2qdnfFjKDCZ6jN8Qmcv8gqpaZ3pZjngvo0eMImKg0A2VxW9CseF3oMmoSIbbM9/D5vBo4mzCAY6PDYSFfuu6wkdw6y+0VVBs0G9rZEUiVS9o9H9UabDlfSOfCVw537oqE9C67u6vK644ZB8YlZAD9jpYXF9Ja81gKsYZVK3TjLakMuIoqtL215Q0BwG3IJCdIWvGOx7NmDgkt++R6C4HnzYiuqp6mG4c8LbdNvAo76ETSwBLpZn+rYM/j+S3L95U28f1XB9iS3Ckyu4knpyctvzcRw6mLCSSlu4wLuJdxNolwlEuEUkfnUU55aMB5NgbqGLnXNn4A4zy3tpj+nok21XY9iuqWaQEJhKiZsAjHEE3TN3xYjWC1S/2FSFHvxnrmuK4J5MbeRFD1bUyRGQpBd3UkC8mD1xSOAMBG6GBawXayhVd8EK0SGBy63K0ZE168zrQleaA5v47GwH2K95FB+rMlLOtSlZSQnzt5GsAQSig6tMmiZ7Uw+qTI35QZHVT5G5G5CNT88kJni5rlGUNtX5ZtrFvMnSQQBBcANO3T0lX8j1oWhdiCTdoOrZO9bt0zgQv9olF6ETZGtgoC6yhTT/YBFzSeeJEZtXXsT+/dhCQAUYtEKAsfF2w9Yn/9aa9t8A31m75LC3FZvE4jo37AoREv2EnrHO1ey+4LrRBcIggIK2WWMKbJiMYb+td1OuxGTkUGcIggTm2GaEKWVN6MPfQzH8zVnN7n3dxEcTZ7J5v4638rkYXAOHgQPYxF4S3fzuR96THtUaPKnrhsiWtbWnRh+gYcot73L/li9xKyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gp9f0elEshZZRRqPwZyG83cyoLFbRQIcEBJw79UCDC9YsnKnrgI+Z2vhUx9XgVZDzFEnWfeeJyy52D0q1MKbMxFyJs5X87rKsbS25Gib+0Dvb0/euV3sVwktLZexX/6PXtRtuzqDhripuXfKsF1UnAM+XJ4lNKTpFYvGbDa0RcyOaaAjClzEsMTOSEwWuz0HreAlNoILCeeYSAMwdUVu3NMT/lI9MfEIH0xW9sVc17meCWSspHHqyUhNzVJM/PYqPC7APsA9Z353OOaGawE06VI+zeRfnxP4ruFWuWh2wLi+LIU7xgNj6IzBF0waTVyidAYRp23CgJ+a09IARaNFTw+yvWmGCQ54jD+4/p0HEnyX5+3i+Q2jJCHZmGxSe4DNSTAPIj13sFXTA40QvGRDQ5wS87nTUX7LSFIHDhzu6Hck+JOAYG738Ej8+6KpfqjmIW29yx26ir51Dh68Om6ctwajDNv0V9xr0ZJRCxOJEZI8lQx0lscczZs5xJJ/YU58oz4zInOYphVhfiDt674ADRRT8TcUkcWEajf3qOvpI56DATV6oIWlEBBcb7UfWUAs0xIKmZ5UFs36UvZCTikJ0bsSfKJFNVeWf6VuEBbS/OJGfnRbqJb6oXaTO9z1sAHMX0j4etR24h5nT6QkQV4+RLgXsLsUpNoSV5R8wzvjqYRpk6rQWfsCGmnygpdUJVl/wLqRHq3dBA/nMX6gZsdp7PCBBtvi2IHBMgfhxzhLTL5APu/7JjNjbjEkv3OIaxyjqnCoipO7J2tiu1DsJ/zpvJpA9Yi/ST9NMdXUqrwd4ZAh/8NFxvyRKN3W4fo1TWQ6LuWfd130QfDnvtDa7H50NGG7NqQ5d9wtciiKRUivv0S9cohuNSqiwEa2HxT8Lo77S+9BX1VodAJXhMWJJ3jPHPIJBqlqvG6QEkqicQUg9cSw2f8Jo9Xl2i3+T775o8+Xb1Ewj5Ht9/4wupLeUY7C/EAO144/tL8mPzaITWt4mCZGf8W9GMHW5T63eq5+IZbDZ0CDlOn7Sfui5h91BFe6i342rP+AjUT14bdEszjHXWYH3n7U0yx1noHX1sBhXY2kCuAfeSb77uX7jGqjEz5zonJqopWq+SnidID+Ezbqi/aWWOoehraz5+ZWaaNtDRpiYToWQ52PmgXeC13OMqdpRAe8HFk3GgnRQSRkT6rTcrjnffZ8JKFU42xSIE4gKVCnVaix8e1upVWFZEbBGR/Li3jvkc1ZR9O83QZhIYB5b9gmHQp+fZn9nL78dseUmWBkYjysAnAmQ//A5TnkyScBeH++hRGU/mSnIbE1NuphXP7Um0CTwAuHtddE8R/TQk9dfN8wG8aJUpSp5TvcYb4WnDs3ol9bPW0qyl7/hdxG8fvIrVEUa1oQFsr/nj9DDHLNQvzFfy0CNMg0dLbt+hgHlrxg6KbAmMNWZ3/AkaTELx8qUVI9RIBYSbydAgmYA8N0vEGlF7Lasoca80ew6MEXXrD1U3suwQwrmVh8bf2MTqxa1wWL2+ZcpEZFlQb9TpYxPd0qT5cGjnLSnPLDxyonsd13vmAbErLFm5+W21DUXsIl7/+salFAtOU6+6SaR0z1B1w2BiFuuzdc5nn3IqpE1g== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71381b30-1f5d-49d8-cd94-08ddec4467e4 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:10.3251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IK5Z3a1Fi30LpkY+WRHgg+pkYhH3aW3AMMA+lEBkKIGJMtnqCPKgsqNZICoaBBcRvkA1ooX8W30KedDtfcCYKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17959 From: Stefan Herbrechtsmeier Support the rev parameter for named SRC_URIs together with SRCREV or SRCREV:pn-. Only raise conflicting revisions fetch error for rev parameter and SRCREV_ or SRCREV_:pn- Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/__init__.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py index 0ad987c59..de301543a 100644 --- a/lib/bb/fetch2/__init__.py +++ b/lib/bb/fetch2/__init__.py @@ -1226,9 +1226,10 @@ def srcrev_internal_helper(ud, d, name): attempts.append("SRCREV_%s:pn-%s" % (name, pn)) if name != '': attempts.append("SRCREV_%s" % name) - if pn: - attempts.append("SRCREV:pn-%s" % pn) - attempts.append("SRCREV") + if name == 'default' or 'rev' not in ud.parm: + if pn: + attempts.append("SRCREV:pn-%s" % pn) + attempts.append("SRCREV") for a in attempts: srcrev = d.getVar(a) From patchwork Fri Sep 5 06:20:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69719 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC64CAC586 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=m96DEGBc; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NuKs5pYPR0TwD+ZFadE9RetokotzPgaBZWEjHg9RkJDw7skB8HxoEVBAQM7D7gsMk53ICk8ms2HjBcWFRNVt6uSdDQgL7tiJpvTQdyOJCPoP7K6l4rePKlwQ8MLyFYfYjepZ88/2JU3EMCtT0/3D1WH4atBbMzoUfnqX1zIQhLdfKkiREVY+2wftgBY69Qy48gtnzDS84rTNpbxP78JkUEMZsP34mTBR32OHQhHDSy7m90/Y3wAE7HzFw2Tf1WczkwtrnqXY3mUARwDPv0uUUYSC4WW2VLqrSrtUgHkAE2ogTnYuSnP4BwZYNi1PIL5xGyI1qW2GOHPnd3mh3hkVcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k2/DaQgm8ceDMMNT6cw1z+Y4j1nLtSWvhhU2pOP+lmE=; b=OtTk0VomJZ0GYYfBXVR1K9IQHUdxWw/IHBiphSrChnCjKxVvifOLrttB+wT1Q+l//ND+BmumsI+dBUG6DXOw/Rt3QVZXPfbKH/9bhSPbbtjMUYag2CJbwHizbO46xYXNGEtnH2cGdlFnov1hunbHftMsAtxCIDTmTDunXypRToBFsYNQrht21KyqLf/iKu2AiG/NIEc29tlsmPpNqIGW548q4R2sW5vmGuT2CS90MiwvI55JgkD1K0edQ9FuhBYe2dfZYeAXpFDLBiDfHruC+8dInRs+lAE/sH47aJih36UKkyaF3e8n1nDuQ6OOubGlT6lK33pJGC+zDcnGF/r0oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k2/DaQgm8ceDMMNT6cw1z+Y4j1nLtSWvhhU2pOP+lmE=; b=m96DEGBcO+b0perIfA6jOSt1Bpo9NC194FnDfltK626T47OvgepJD9w828+tEwRWRI9jI3Jyy7rVDSGGYxEYS88TQ9kSaPoRS1PsZWnfJSICZF/SDsKZDalurwOTxKwhQCy7RnrDlWL4wHmjyXv+9sNlb8fTPSd9wTFc+Xv5/v94jeK2QrrHORHjAZXGNaE+IG9iU5vVJLk5eiwN1zs7Oo7hSTElyglykH/2BYdZo7F9v5McS1MBk2s2/uAz45bpdZ7l8BfJXsTHwfzkqvU64tJ/cvIQkgWMpjGxe+s/5ztmmgIujzAS4wA9222W6uq4khK+i6OnCaxitiZxy6yAqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:10 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:10 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 03/15] fetch2: git: replace destdir variable with function Date: Fri, 5 Sep 2025 08:20:46 +0200 Message-ID: <20250905062058.2563806-4-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: acd933b2-818f-413f-0365-08ddec44682c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: mqmeBlQNe10dFanSl3B8DFrUPr2mebnWF5kf1H5jlurTb0POvS8Q+pamPMfNMcltWBodpjdY7F8JpxRf2Qnw6r+BRegiXJKDJuIq9/oS6sqEGSvHpYR+u09tbHhShc6CYjnaBRmoXvujrikIiU8PbZqyGBuLPaBQhsXuuHDyINRhi2zARNOVaWspRU+1GP6iMjYHTOeHeNjB1zeVFIiaiDUAKvKJsMM0SnaiFMKKGfgcUD+5R7x7fSydkKBkiSAaJnPx6gcJlqqQMFGV5wlK8/KFXt57IQlmxpJ7RO/2R6AmhKN/qgd8D+dGPgX3m5r172P+f93cUVfP2MwF/tqFl9u6x+Odtbjx7SNvtwqrKEWJ1R9dVuE0pXBSf0HkC8JDQp6Uj4cJsoH+bv7KFpLlkWKFaR9MRzX9rAQDea95vBt6EnQGViWKksZLDgSToLb8bT9Dzb9md/IGGohA/pp7jc1DjTeVTg/BDh6Zofb2aGn30WxVBv1D3cRW2M2GwwctELUXvjHr9J+nZCcq6oHQe23U2KzdZ1c5JFCkEEuLKgNrNLpCCzfgvns6Vh3C66nASx77r6MIJHCEQ9QTD2lHx6DIWJkCuvlyBvzkpb2ORJ9J58USmulE/w2Y4PkxxITpUZNq0OWDZQ+zC40JOnvVsrdh6kvqTn+e2pIEqmIWCbwxeF0gzCo17JfTjZD+PLTVzqEGQOnL3w+EsA/HCxPAFZYIcmau7bJufYuurOYaAk6hlfIAWts5MemK1pqg6c2EuAtxkmC6lhF0yrxT+CFJTnglmQ2FzaVVgKk2x3gXkEJIUqgKTAxHU+uku32GJ325h8fe8l1+8NLo0A7HNf6U5LU7HQzfgL+RMTyqk8omwFH8vJyp670f3qbjB2DhCAH6wIOkivVd0gpCTXeYmwVao+XNTPdXT+t0g08R6t5hai3fJnRMboI4neCioHKe6S+baLQMn4wYeODp1JNIPUuBmHdTajZdMX5kQHJf4mh5FrscvC7BdR2a4BFrAi2Xpc7NIUlq+YNZSQLR9Bg0k+zFg3s59O1cznuWG4M1pZp/4m8qYcuP9+ncLEME2J9VbDFUVW01aAwp/M4oD5/P74MQy4JwrY08zTffWs+Z5z5UECbNeT20W5ukl4eUylNlW/RWHonFxY6HC1mJdF/UUdwcoI+Fw0H9jm+Lp2EavgLlV83VD0CDLCti2gPU1aWcybpvl+yXkGQv8ArpiMCUK4XqLOES8+w4e/TMrSU8D5+3/KNGBWPpzsBiErWWUM4Xu8tEx58CHvnh4wswzKjqea7FGgGAgpLZuLG54vpSO9glf/tDOS5ZB0ZFGBq4znk5aZ6Apzm8o5TGivSStwO/V9+lJ/mw9G5oELBxuJ+AZiP0qeIMtxZXowSvcY3a/HJAcUJng/MhXE29FLGAadlbmL/PFq5eF8IDZp6OsqDKhXzSB4D3kDCOC0wlHUgRbzJfuIm3dZcHqdzjs7ZN3B9cemC0IA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1OaEiZwcBoUwywjuVWehg13cV5g9iCOegA2/i7RtWaXUX/9m1kkZtWrQzKcl7o5KD0Rsk24Q/UZP2VNOclSZgwq4yhmsQGoLV6AGSlH08LhALjBOZj+AI1aoCx7BtkyIfzM4M9BQhfxUt/IRvJE5w9EAfPJzJ6OmX0jjfXBHmR3lau0e+tUIsQP2iRe8AL15FYkt9GXc64+Y4OeN/PkrD80d6bw7zKrinwMbfIUcHkgiHHGeuIxwe7OePSBdtovd//Ot5ZAf+2Nfwtl6/2HdV1PcrPFVd1ofmajRfZYw0qGl+QbcfNiZoPkR9Fr7LMI61BaVzvFoFujxgNcZgQinmShEAOT+Z0DIimfjzw4XdTyBvCbQjEHhdmqaGpaIvKfIzRBr4oa7auyhkaKxa7D62KH5rRK3W4e823UWL6zgUXqc2jhlAAWC4BtVDO0S8BA+QISDASHbYbsZ0+48sWaweN6RmG/6CUDkDQyXD4yo7jKLs/5n6Z3Xzh5EzAXoadt/DswpomvdX56vwN2HsC/HcPePJwAXyaisls2sgGHnMFXDDgEdtu6gS8/GwQKisiUz1q57pp29cJgLZ65RMz96i+nNZx6YtQ3RKJsnfcSvjJN5XnpAn+bHhfjTpr5fA3cV2mKDuRxHpmZdoXeTufkeBlAyU2brEBB7fQK4QzornvdpTBiMhORlOdHOlVoKuPPSEJ2xsEUmoGur3U/lieXCzH+MmcybGTEEBkVI/KTBi0NvifdW8WQdcAqOXdfbXaVpWfSRQKKVHj4juduPRmwR2zo3Kwz+FUtK7rWpdhj/BGkL4OX8PS7DWqqoY2V5qstMlFxu8Z3oS8Xkw5CJZ1pp2pZNLUJixi6wHRftrvNP1PRvURehD3jqzefIlG1iTgg8pRWp8kjZ6gSO/y2KHcmNTRe9v+k2tiEIz9axAcfC5wpyVKPDOBgcRNBrVS1wB+DqsEVBA3HgI6tAB6BnzzXZY1JjC/sW++XAwE1R9GSRIxS8lIcaAMwW/iIvXysdgU/wqJbDg0IM6WGZ7mITUvjGDo27OPN9hYittiD/70SEE34i3e0LgFNfmBUs9FjRcmUUoJQ2vHHCxLUiaygeM9janfVYhqNBmjHbb1E4+U8+ROpeUfeAqQsjtR+0SggjBGpwzVs6g9EihCGR33ffCp9DEjo3ihOx3gQBO61IA4SO0jvz/zAF8ukmKg5v2z0o+cBOazwPsPGC1qHy7AYRCAoYpcJN8O75p4EcYaP0o6t3BJPDW74ZA92mYk2qytTEO6tJiEEOw4MDzmeZzsDyOVTmmYveD0gQLBQJoITkBFS97/cNf7v6ZbuSaXe/9B2wjcTJqxxPri0trfGCBDFTIxUEZfWZqV37e6RPWsnj6hU9yAuZZORD7scBVqIV8IE4pp50nIy+T9f5pCK4DURW8YUzPJ4UdL7rj3fG4IVGQ6ycgWsuFrb3coGfm+lmi0oJ2GQV+RiMqrEkAczLsYyYVZ5khsaLHJDcxEQSvsp7IveXwaZuAK7riAt798zXh+YRRs3nxWXyaooL3G70hl1n9p0iTf9ZAMgADvRbldd3ReBrF/aIZVhRSF2V16samfto6wuxKZ+hI1Pl/V2RcAuvkuKAxg== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: acd933b2-818f-413f-0365-08ddec44682c X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:10.7726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /3zfSgmsslVJCRw4XsnFDXCsXV/osigGoQ6j+nAjfH9z2ltc+/TMSzGTRMr1Kz3JgvXecAaYkHrlQcFWKtU/zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17960 From: Stefan Herbrechtsmeier The destdir variable of FetchData contains the volatile value of the destdir parameter of the unpack function and is only valid after the first call of unpack. Replace the variable with a function to make it independent of the unpack function. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/git.py | 25 ++++++++++++++++--------- lib/bb/fetch2/gitannex.py | 10 ++++++---- lib/bb/fetch2/gitsm.py | 20 +++++++++++--------- 3 files changed, 33 insertions(+), 22 deletions(-) diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py index 52fffe21d..6d3bc3447 100644 --- a/lib/bb/fetch2/git.py +++ b/lib/bb/fetch2/git.py @@ -656,30 +656,37 @@ class Git(FetchMethod): # The url is local ud.clonedir, set it to upstream one runfetchcmd("%s remote set-url origin %s" % (ud.basecmd, shlex.quote(repourl)), d, workdir=dest) - def unpack(self, ud, destdir, d): - """ unpack the downloaded src to destdir""" - + def destdir(self, ud, destdir, d): subdir = ud.parm.get("subdir") subpath = ud.parm.get("subpath") - readpathspec = "" def_destsuffix = (d.getVar("BB_GIT_DEFAULT_DESTSUFFIX") or "git") + "/" if subpath: - readpathspec = ":%s" % subpath def_destsuffix = "%s/" % os.path.basename(subpath.rstrip('/')) if subdir: - # If 'subdir' param exists, create a dir and use it as destination for unpack cmd if os.path.isabs(subdir): - if not os.path.realpath(subdir).startswith(os.path.realpath(destdir)): - raise bb.fetch2.UnpackError("subdir argument isn't a subdirectory of unpack root %s" % destdir, ud.url) destdir = subdir else: destdir = os.path.join(destdir, subdir) def_destsuffix = "" destsuffix = ud.parm.get("destsuffix", def_destsuffix) - destdir = ud.destdir = os.path.join(destdir, destsuffix) + return os.path.join(destdir, destsuffix) + + def unpack(self, ud, destdir, d): + """ unpack the downloaded src to destdir""" + + subpath = ud.parm.get("subpath") + readpathspec = "" + if subpath: + readpathspec = ":%s" % subpath + + root = destdir + destdir = self.destdir(ud, root, d) + if not os.path.realpath(destdir).startswith(os.path.realpath(root)): + raise bb.fetch2.UnpackError("subdir argument isn't a subdirectory of unpack root %s" % root, ud.url) + if os.path.exists(destdir): bb.utils.prunedir(destdir) if not ud.bareclone: diff --git a/lib/bb/fetch2/gitannex.py b/lib/bb/fetch2/gitannex.py index 80a808d88..dbb74e35d 100644 --- a/lib/bb/fetch2/gitannex.py +++ b/lib/bb/fetch2/gitannex.py @@ -65,13 +65,15 @@ class GitANNEX(Git): def unpack(self, ud, destdir, d): Git.unpack(self, ud, destdir, d) + destdir = self.destdir(ud, destdir, d) + try: - runfetchcmd("%s annex init" % (ud.basecmd), d, workdir=ud.destdir) + runfetchcmd("%s annex init" % (ud.basecmd), d, workdir=destdir) except bb.fetch.FetchError: pass - annex = self.uses_annex(ud, d, ud.destdir) + annex = self.uses_annex(ud, d, destdir) if annex: - runfetchcmd("%s annex get" % (ud.basecmd), d, workdir=ud.destdir) - runfetchcmd("chmod u+w -R %s/.git/annex" % (ud.destdir), d, quiet=True, workdir=ud.destdir) + runfetchcmd("%s annex get" % (ud.basecmd), d, workdir=destdir) + runfetchcmd("chmod u+w -R %s/.git/annex" % (destdir), d, quiet=True, workdir=destdir) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 5869e1b99..d9ebe8d18 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -205,14 +205,16 @@ class GitSM(Git): self.call_process_submodules(ud, d, self.need_update(ud, d), download_submodule) def unpack(self, ud, destdir, d): + subdestdir = self.destdir(ud, destdir, d) + def unpack_submodules(ud, url, module, modpath, workdir, d): url += ";bareclone=1;nobranch=1" # Figure out where we clone over the bare submodules... if ud.bareclone: - repo_conf = ud.destdir + repo_conf = '' else: - repo_conf = os.path.join(ud.destdir, '.git') + repo_conf = '.git' try: newfetch = Fetch([url], d, cache=False) @@ -220,7 +222,7 @@ class GitSM(Git): # checkout dir new_ud = newfetch.ud[url] new_ud.modpath = modpath - newfetch.unpack(root=os.path.dirname(os.path.join(repo_conf, 'modules', module))) + newfetch.unpack(root=os.path.dirname(os.path.join(subdestdir, repo_conf, 'modules', module))) except Exception as e: logger.error('gitsm: submodule unpack failed: %s %s' % (type(e).__name__, str(e))) raise @@ -228,28 +230,28 @@ class GitSM(Git): local_path = newfetch.localpath(url) # Correct the submodule references to the local download version... - runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : local_path}, d, workdir=ud.destdir) + runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : local_path}, d, workdir=subdestdir) if ud.shallow: - runfetchcmd("%(basecmd)s config submodule.%(module)s.shallow true" % {'basecmd': ud.basecmd, 'module': module}, d, workdir=ud.destdir) + runfetchcmd("%(basecmd)s config submodule.%(module)s.shallow true" % {'basecmd': ud.basecmd, 'module': module}, d, workdir=subdestdir) # Ensure the submodule repository is NOT set to bare, since we're checking it out... try: - runfetchcmd("%s config core.bare false" % (ud.basecmd), d, quiet=True, workdir=os.path.join(repo_conf, 'modules', module)) + runfetchcmd("%s config core.bare false" % (ud.basecmd), d, quiet=True, workdir=os.path.join(subdestdir, repo_conf, 'modules', module)) except: - logger.error("Unable to set git config core.bare to false for %s" % os.path.join(repo_conf, 'modules', module)) + logger.error("Unable to set git config core.bare to false for %s" % os.path.join(subdestdir, repo_conf, 'modules', module)) raise Git.unpack(self, ud, destdir, d) - ret = self.process_submodules(ud, ud.destdir, unpack_submodules, d) + ret = self.process_submodules(ud, subdestdir, unpack_submodules, d) if not ud.bareclone and ret: cmdprefix = "" # Avoid LFS smudging (replacing the LFS pointers with the actual content) when LFS shouldn't be used but git-lfs is installed. if not self._need_lfs(ud): cmdprefix = "GIT_LFS_SKIP_SMUDGE=1 " - runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=ud.destdir) + runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=subdestdir) def clean(self, ud, d): def clean_submodule(ud, url, module, modpath, workdir, d): url += ";bareclone=1;nobranch=1" From patchwork Fri Sep 5 06:20:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69722 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B523CAC587 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=GgMm42Ki; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2GQ3aJMQrzjGboQ8lD3Nc9AvfM7Xj2Tdf6Lskq878iAG3FgDiny3B8rtGEGahEfg6PepNcfINN0v4gA40IMjug3V5N7SLjxR0X0HJbrlx0X0QQBn9yOeWeJuFPcs8TFaIFyOEXMZxLUxaAKB5BLl7oXZzWncSt9HN40i9ZqHdteJTNpmp0Zolxh2C7dzKv8Iflt7Q3A8ckvWqydfvLQp5orfkYyVFeoZIY2a5eLk1vLbNcy47DZCBgxK2YilDnIArczo+5XhBzl1rWQRSzFIXV9OHEH7Z58utiNmoz5idCnq8q1admLNqK2Kw1gtfcz2tAcX8xcMDqpvZKqlgzUtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vo4XWvgrRzCpPyAwi4GEy65BB2pw+iqgs3MqOME6kuQ=; b=CCwPlhhIaSo/qw5nG0Xl9JB96PUvjDCZfWWvk01RmVI3VppBED7IOuM6dvM6mlRTY/5P2NHKp392ApJtk3mmwGtBO5zduHFPK1Y5ehPWZzMO3Mzh+ue/IJWqbm3BR682KrBOizaUEcXzW4jlcFzPaTWztxGIAU0MgNy8dx0qCO7SPnh7q2ONfRWQBQUmiiSzcWeZeMCbVXTjU13V8gGN6TA50QyeDy8BTew61OHW8rld6ZWj5IQN9F11GggV22UOCndz4YClXIG9bPqoa/kQh1qn7QDYiiZnCfQGJo/tuCTsIFvoVdeKQoIVUMSJ3UEZwMws/k+gi6gqjevTcMV0+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vo4XWvgrRzCpPyAwi4GEy65BB2pw+iqgs3MqOME6kuQ=; b=GgMm42Kif59zMATKPIIqECVYql3oahNaGezow6CcZM7jVZdQj+jVhf/qKPlFmb5Fp/qBIDRNGzoE/4PknB66YzSLdcxgVlMkzvVAmmbvnMGDylJgSHp+kBymkMe+fmZEHbunkU4OKaxrsTAwnc7uIpQQ7+9UskG7at4btYL3PppZ5+0YJM/CDT+c32mHRuDw6/Z8fV/xXLe/9DWOioU2ZowdU4wBjGYKGSv4IHUTqWogYDLmbXf4NEDB4gz5XdOgiBWWxioyiw7zrsu4qhmM7FXeqjcB6lzcoqMcNSxjyz1Wimoe+MeHJWiIEUdhSACyZmXAJBkw53cQ7sKvYViV4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:11 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:11 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 04/15] fetch2: gitsm: remove dead code Date: Fri, 5 Sep 2025 08:20:47 +0200 Message-ID: <20250905062058.2563806-5-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: f50c6d8d-9c66-4475-e177-08ddec446870 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: AInOEYeEqZWCY/otI8CdjcAjBlmT4NkYOgJmC4MaZrt2MZ4uQ2EAE8BTlyBWp4RAGlvmb1MfRRAxGOkzsh2PaN9wYcDRdmr/hKFp8bPZrEdu6kVgQhTjISPqDiH6AHvHCJdVvaP8KwiSihYIy5EUQ+FsEQ8zCSNuPTIUoXUgQ1vMgJxeRwe2r5e36by08hQvM/uK5YFYFcyNOPabuUKmDnj5YOtrdDkZxcKj3wrroNR43wy9aoJBVcoGYV6DmUNTLJ3c+/vPUFVFaKkWTGcVMqYUqHcWv0pkXkcWcGIFZNuX03uvVBtDr926qn1UafyDnhxw7S2z43HB3HBSSkHUg0xiwCbL9/RpvA7k3DTLgGCZA5WKyzoFPo7QjB/0kDSUUbpmWZkFykN51CzAhaOg0ft60gXkW5Fw0LwjiCqvdbhF+1V8bqaamwAeOBBwT5d/xx+thMtgYg6hQTTGHK+9iZXxzMh/bwUkOg+/6JHXVW8bY9Soudq815bl6O3c+zGLIWNV90jLqFV5AuLunMuPkKkX/RcXTVOCxBBA3pvoyoctZSs2OVhHAjY00TvyXF7M9ALAm+7+Abhkz0hmxzGB3dglWKE6PV2vG9CRqtwrT7UacoT7w+e1rZRgdh+7HwxQbFpd935o7ERj2E6rEmt+T7WyVZGLLQ7ZWYyBndLsgu0d/By+kbx9FZHIGpWwJ4RyWxj4M44u6xQR28VDj0nei6uS/zN/BzZcBr+0ES2yuU2ggKE8TDRYNeOR/+TASP3k9i5nV7ssDv+syiSd3VNE2IOaQw97s7S/tpd+I/EUzs1Hnh/AiFzW/gQRfZXbA0RNZe3pOwWZPYkn//O8utZWcuULITE7eI8h5cr/TthMtJOO65ss+ZBOi2nyScEKGnQ3O++Eyk5UfTTP0wRYRY31QLbHtVstuBBFTsaTcW7ACwApr22yuNblbU0B8lnuAthP7E59CXtA+Vdv5v7g4hc3ye3z5tUb58mRCF+RVVhRENOum1wI7CjSh6I0CxOM25qri2kmaLB2d0nmXoIi+SgY/rRMdzPukq2BQ5IPKdsix6bd38pEO5wfDscOfyxez2mcWMxBZGewggZB3URkBrd94OUhcmvpSln/0dx/KCXkOiiXUO/YLfrs02RKyPSQtna4KwWoKwj+O0qAUItDDnvrTdYzdehJWok1/un5LzMvafn8SEgleH9QOvvKpgbSLk13IuKeNBSSm4SlMsQ/uKnFOMzAE3vuIUT/m+9ht7zQ4oeWHe3cpu+R8HxzQWMyxWJdYZZg23K9YYYFK/OC4xCpeor17j0xxGHyP75jm3QJcthY2WcdBv/hxSLrBmppzC3+phi7gQpApFrT5qL5e3uNPqru5q8ffL56XFcqPJ1OWXLULt5SktGWjvJiKunwlgESQWEVYFN4oE1r+esCOmLNfdLPMjCvZhcaRX6IQmfrMmXVWFL+TkttU5jVvr3dyOvavavnbprpDYRfHAakBJnydg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oG59CUWIBc7MgX5A0MnHFQ1UmWQE9jWljEzgeVSefJVJiPzjsG3IBNVKtkOPn43X5l6aHNR9z7BoQb9ulXFziZnf9/YZaNIu+L5KINHWAkEydxW0Gl23Du7Q/KL/82OF20qVh8a32EdibTrwnWSK6GL3MDjsZ8lvIwVJZKym9eC96mzPv/oLBH7TRwPEwwttapMAJKEG0R5caO5+fnbXeNISDRCANcqG/nPkrWIixiV+5xV8LQb4CcX3MpRinWV9lwhsDPa6dyeZL9lZJ0TFnbdXIcAgE5LTmobYtC7+HF/OGQY8mPT02EEu34wci/cJR8qes0pWPhjBB27a+AfmEuLzCgcpELRzX7DZ73veySmcJWafQHbQcWa3RKyVpB8MRSa5jOxZO9xblxcuI1Uz77BqDla+tMAcczmON0UrRhmYY5PsL/FYIsZaTxBbq2noSmAFsAYnK115UGMBhZoHCuXqgy2O3eo4pqNNae2ngz+/eDTgtZz1POmbx4Vx1i9v9JcH5tM0jVU5ofPqr7/NAb6g/8Rhqpmwg+x+5X8Wcrrdp2xzQOdlVKbYm+md8Okl9GAPEIwDXcxg5jIXW/gkko3HrJpFb/rKlueypJV98aGacUkg3n9fw7QixcbAgMVSwDE26AbJy3ImBdEhYoOAjAKAchmi9yXZR52QkNon14zM6EpkjBx6DXChff7b2JKrfKyCJy09f/rkOS263A5Wln61xrcy0ZGWjNEMjpdZ9PQZLeFhlB5k078jACqAsc4FbucLP1T26Q2bQ7kySzeuc252uBKjjmgjumcI2vMqJTclRFPACc0vmVTHG6jtI84sh3jpJlrgP1k55mAhjbDV7ygFgY9Dxy/jjQzRNPjNFsy7C74kL51c68VcJ2MtPktkhXqnn2Nk3wBPn2n6k0i5xDHalFmhD0I3KiMGgj7VUoCgo+YKuvuOAAGky1x7DmCWSVtV/IMrlVkNswpNmK82sQkkHdo3/h0v2pae64b+IdJzl4i0nxQCbfL0SVn5qZCZOfpDchKdT/tukYqyb7ki484PadxyQvF+SarrySI8dLsem2Vcojfg52nWiAiN30nk/YR5SpTRBY+eZZkFvjmq0mNitlCEAOMT7AzfS0XFlgMB2Bi08koqgvlc2mld/pXeHXy/xAfpO8NBajWnDqRTLgBwu70O5fG30HinC7u4drfqkSrhpUjuCt/knLkivYYQgz2p45wQECD5WyIqrDOwp9gHUzEmp7gB3v1xAlrGs6y7C9Q5PK1D5r2HznybG4nUiW645ZHU+VBNxxPA8uMv9blRCsKyeviBcWWTciBlwIDHgwFew4NQuQnaVutKtIxSyeruKOaEYUg150bLiCayjBzhUV3isgMnjsxJtQJqZ1PlPzr4/1JyMJhmp5RgVrW2Zf9MGJfVWztA/etr5KggS2ARHZST3suELBdH1cGdeVRD9dM2DDClzrsJ8pUtpzhfcREfiPHnpEFHh3XBav6DpdF+Zeph93yF2cSPYlbbkiPedEkw/hpndEE30R5S1svneuRRe39RUudK9im5VrJxBT3s8GLXOyz7QUaxJ2L8gS/s1ZULwDl31QincSR9NJ6th0r51W0MTmCZx4S/ubkERg== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: f50c6d8d-9c66-4475-e177-08ddec446870 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:11.2474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8dFFuzzP3kEt1nBCOiUeU66H2ePxBKRWrcrOpu+RmtHRz2W0NPObWlETP+oQ0pSTpRO4VE733y2eU1+UG7UvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17961 From: Stefan Herbrechtsmeier Remove code which isn’t used inside the project or the tests. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index d9ebe8d18..9baefb3e6 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -218,10 +218,6 @@ class GitSM(Git): try: newfetch = Fetch([url], d, cache=False) - # modpath is needed by unpack tracer to calculate submodule - # checkout dir - new_ud = newfetch.ud[url] - new_ud.modpath = modpath newfetch.unpack(root=os.path.dirname(os.path.join(subdestdir, repo_conf, 'modules', module))) except Exception as e: logger.error('gitsm: submodule unpack failed: %s %s' % (type(e).__name__, str(e))) From patchwork Fri Sep 5 06:20:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6D8CAC58A for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=RpSUDf8e; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nOpNH8PZJnXds1JBrl/yLCExBPMU9SEotgbqOVYfdxonBIUrTwwmUeizuvdxBfw1B7X5tBK6LNJcO9yZbvfq31q3LjNsSQUVH5aU7q2sWOGeEL/tclJ3fHBfg/ByqkNL9FllFbSfDn+OfH1wkFKslblVetExZGGKEWhReAhopNk8lx5IHNPk2cBV91syZSKJKrTBWkFjg2XF3Osv86l1dfc5AhDIYNXErpwfXp6u5CpOUIlvEBRyoPvmMNMju3HE6OM5CLFUpm2+txcVdpTVExginfNj2lFz5ZbSxZIy4s5hOTzCbviz0iKkj0cTeiBQo4KnrYm8yopn1kzMi1439Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g70lbox7wsqQOL2hmPiU+ST8aeXYcjpmdmAUvFbrMGw=; b=XthYtBSxLuorSjZZn1A/c8nRdCfBLkG+N67qMRJjTCjbkd+rvy8UMh25f+ngyLIbznTrsP/4zBkxp5yLcsedsVCTBRDewGv4TwSop0W0GfestrAV/1r5UAwGW7Z4ozpeOMYOAir7mHxYjIi1h+c8V/2ZjmU+5Vt0XMpaCw2zQG8LJ+V31IhHsfTiBN0aRZxsEaBfGfa+gTjtWtbN3Q93ZNPvfT7rYAKZ7WGaLtV6TX7e/vMu+fMF21ki4JEZP2ZXlD77F4EzuhPkXcCJeihMnKQBnIYdjSJIzIo37XT7110rBUC4mft5hPZoq28wnSXxipTSaDWxOm0+rGEHKiCZ9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g70lbox7wsqQOL2hmPiU+ST8aeXYcjpmdmAUvFbrMGw=; b=RpSUDf8eJjnxJehRXV3HvyvWizIVSR/EIQ15OsLXzoUv55Vd18V/TWgGsbdFh4o04dOhzr9RACNhYEpxRJZDdkH80iyYtSZXBPCIENecg8Sgp+r7fkGNmUUshs6fdRhHbfeMGnM4sc9jRaW5GrtRbZsx5h3mtrCyBjiaAW2iHm28ikdqVdRG/ZOzHGAhzviHdCMb2Y2g3rGDlPaAdoXq4hxQKCP0FbzttlS7PE3r1ghekM6nDIxINAry0QFsIpXPKa04KNUlJcZU9rdfWT0cZi69+PokHOc3jC2XqXzueA/wsK8hOu8pBL+hdu12WG+iVDUw0MS32SpdIGIs770img== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:13 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:11 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 05/15] fetch2: gitsm: remove redundant set value Date: Fri, 5 Sep 2025 08:20:48 +0200 Message-ID: <20250905062058.2563806-6-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: c017f8c2-0fdf-458f-9239-08ddec4468b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: ACNiYQceyDOxNGvAUgoANvKy7Y7dxBlSlW36usgcz01XFDm6M24UmUgAeckf2R/ZMlYCj1bV2oTxpzUTyhJOC1VcDYE2+vxLlQ5a9IO12WKdLEbkz+8hFO5FWEQSaHxBKpdEMjidMH7ScMpFddq13QObMO2byPDEoruApbq7oSCG7QnTWZfWfmmuTcFzfMKeqTkHllUW71iCib9QLCVrcEmdRUdh3Ntk8YFerHbrrOCZxHN/ywYXedfVrVdgJbixBJ+0vvCOjU5qjY/Dkb4fK0x57k0yaw4OIKMlpzuDfBsQYE2XV5v2frzps32Z3x6MJ3dhBpnF3GbX6DgaNfpQfDB69TJ2bK0eWSXcXE05/KvldJAuIM9aNr+DOA+x2DfuBkRYBWZWPr8ZMmL5rRoqh/ppB5y4bXdpRf7VOyySROV7fqJLj5qTDUWFGnt30zTrESUfOr1jxfQZxEzV87QKUDdmdD195IVpZTE4/gqtYyo0eO1S8WGkC8SXz5CNQBk3+cx15w2Tu/qDTI+LHEbEq5Z4T5Gqd/rcqjI91bHc8yveOcrplnPErYJgmBx2WnmI8FxLZhLk5RymFYZPsvd78TNty2ynJOtHlPOacAU8D8cX3R4yGwpirx0CJ6V5ojW/AbIQzKNyij9aAKuwmyPak6nxls8zXqPtMYGk8zFj0ywVR7H7uWnKeeEzaCJuK3gM5sGqHAoDQ/CE3PEk0un+f9JxE6IoTSD6YKZWiZZXwPJqNwG/eCywnOx5s3UXXdLrF/949kK0KqyQ0J28hS2vs3coDxX8Gr7DwT9Yq555+cJW8nQyhJIoAtyF4O2BIe3TSRMDb2QeaL7mbx8EpyyhUKg6x0/Zu0m8C1/bmtuw+Ogz0wTwiNCTQBmfhlsOhgtgYq6ot/VyiawJSjZHVsmK9w0LO3c8opBIdFCsRyViIOD5LHHloSk27elgacZSt6Q5zMkiW3vvmH49XwocJGrtXK+8TJtZPwxRAkaOBGxy+OZaZhEz+HruEjkgwFub/UEs3B+3Q+vWinlIZjWAi/BGzoYuaseaeq96PeBEEJj+1Cxy9w7PdpL/UZlFi345K4eOCYkyFQjA0UrgpFmAJY/67BOZmy+Wa9wKP3j48vSLGAfjiUZUL9wSZCSfq+Ju8R/LkWImIwNkyJymgxIW50q+6+uk0dZ1+opnbO+ukpLWCDstBBf6g0nrMLc822Fw1BrD9H4dLpR2Jn+OH1RRs5vRcj1/QuYivxEkL907mEhwhp8mXQAVmUE5y6iGowffVvY48v0i/JxW3AMoKjlmcpSwpjMh7Dy7bxOt28sdh5kFG6FntC9VAKxqSQfZ1Efp0UtoDfYG6xrMu/4U3mcvoNAzXlRRgMlFKc7wTNpcwmck1vxrVeG84jITtlyyRod2ouwb6FUnwqRixg0St1YXwc0UZmHFJD544lmsElgPlYGkNlwmftRHVz4v9IxaYYMCfFIWuUPQ373iYdsDcW34Qe8QhA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HBzPcm9XacIquU+4pLzxqvUDrbsBilwP4RUKXiBfHZ3ZnurO3nx2xkWV0djr2NUYvopVz2lS+sOLU0w2u2YsJ4HirotpugeY4UwGkQImph7Yg4nKWPE/UoQZqyEafd5CuQL+PM7mqtCE8DzAwHKTMSoqh8kH51Y+MpFanShheBfMPB/dFZQ74I7Ids4gCb12H7hXzsjjuVrnEE0H5Eyo5jFBTjMRcTcadZSL7tVNyAV56UKWug3BsNYr+TP+VmWTlPx4fjW56v49N/BWIrx6ESU/+reAVPASdFHIRjGWoIbpXJyyubwZsXIyd9QctR6Nw+890OzOagyqM0vzH7hrMi1DKCudOLLb4DxZagGrtqdMLmU5tJQAzMMlovxXoNG2/8aX47sPJjQn9i7EGAbrtuxIKvkHkWwhka7aEsI26FVGWqB/r5tXyfxPS8PAE0ATeP5wfy7ePBhux4AnI98TgduhkWY6o3+zSP24GgrndNrTir1opRmdJtYt57RvV3Cnbaniz2zVDrR5F2bbBkRbDLlxTmuNFzIWgpOlqzIQasSEpexDpVOwlGvdKn3PtHkXXb+BN7B12zPfeWIxcIdpYOGE+dmH8tvleVBqU5P1+Bw9dQ319uQI8/IRKKMn4H3D+2N98JTFvfBjvj1Ep3OL3p0P3f8O7MSb/7FEf/r2oOLQHPFzJq2E/BsKP+eiKbkEAv2inzR8MyGZgDqaKH4oUXJG2romWBeILxBC2XXhFtF/V57xNiL8aTyNN5DCPYRCjHKp86veWpRGNGFrjYZ18lQHdefNS6jU1OSDs7AK4aaWohGwWfkbfgQOKRD0R6JaxJizZgCHtL+KQ4V6Bglpvun3ddIGpcSKYg3H791W8msm9ddxHlDc70tZvGt51Tbd883H2KsLuHkwJVYSydhnWdrI+BDKjEd+p39bdkgX7yqR+N7EsDLwT9VBoO2EpaYpizUFixReVfVVvJZUIzImZDdpYyStFUZ26NKXEfnA3uxiy0blvavEw2IWAy65+xs6bYdH+XCFgOkGswKqFdZjm8aFjuDv3yO1YADVfQhE04alelzC82CYkby4LvXpAMLulIKsF6ipleL/kkhuPyecVhxpX8J3Z+HNmWSGvkXh+AD9kjs3ThDHb+DArRJddr2vO0m+8HqFHQe2jn/G53ShtOmYxGVaZZUybUEuRS5lIvmVAmJW5uUjX68/IWBAfbxoWmVPoCKK177hWcX7HVubFw6RzxzrviXrKitg13aEztemnh4F3lBWFiZPVcADYxXP9PuyOjcjMwMPtipIXLjS1/MBZjCTl7+DJJZNjpBMwRs9qoa3XkYTmqDBPc1nPUUlEXC2HlRGupJzihjKJ+zoWB5sfO3s9Uhvw21BbaLLLiQ5DP1gQ2KT6pgoS4Uu1e+T8lGxxmQpFFS8w2n1mFILAN2ycQCD9fOqlMz/X/tZ2FvzMGskUhp5ItcJOxmKp5DXe5xuwl4x6CE9re3w1qlOty/dmkxgTtvF7Qr+Vip44cCxrd1F72Qd1gdUdeJO55WY33hX+LjXkAKARMGO2pJEUvFhZzMA/058nmzv/twCcG9piNSiXrrrKq9qMW+tpWuq1e9KwiOVNfsltk6cvJ1qXA== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: c017f8c2-0fdf-458f-9239-08ddec4468b8 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:11.7172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VrtU+ynE63yq0y6aMnN0yPDErIM18nA7CUda7QaOV0/WQCnUDrK+P4hfTVBxgE//M8xpKXO6osBFnG+fWYtoLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17962 From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 9baefb3e6..15b9c3740 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -139,7 +139,6 @@ class GitSM(Git): # Workaround for issues with SRCPV/SRCREV_FORMAT errors # error refer to 'multiple' repositories. Only the repository # in the original SRC_URI actually matters... - ld.setVar('SRCPV', d.getVar('SRCPV')) ld.setVar('SRCREV_FORMAT', module) function(ud, url, module, paths[module], workdir, ld) From patchwork Fri Sep 5 06:20:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0FCCA101F for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from AM0PR02CU008.outbound.protection.outlook.com (AM0PR02CU008.outbound.protection.outlook.com [52.101.72.84]) by mx.groups.io with SMTP id smtpd.web10.14988.1757053280733913428 for ; Thu, 04 Sep 2025 23:21:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=aG0isQGz; spf=pass (domain: weidmueller.com, ip: 52.101.72.84, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m4ROy7WUulZfvQd6kwjGcJ+9qIxARkApILg3/hOIvw8FxXvA1bBcyPCGgxtYQpgKTyj6eYI+wHDOftqjTE+bJT0F4zxAjbJiROsdopooMqfdNjT/AWfqNIguxpzTMY0/6CwxOW2wnNEdHtURwBMaO+WZhdsmox9KpRGnr7P5FvFMgIiKDPPxvJpyooOkwGKVOLnkttPNLzA9h0qkCExZ2ffhbPZkRJF8xT1uTJBSWUJBQAVK+L0z9gMiosKIsMdMcz1r2OJwB1e0fC1Ic1WEVX3KE5keATPm2/ok2DNn5JZB00PYFQ51qH3WYcs7wExbNQH+sS1s5cfSAPBiEIQG1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iD3fh7d6OR6zVRSu9/npCp2oB11IYdLrmDPqQnjPijY=; b=PdItO53uNG7T2l3doNjLn1BtihRv7/AfMEkgPaDx9z5w4CdeHOnMNbY09ekj42DyQ9uWDZEv7tTUXifYatPGK90MLFP3PMxBbM7g5MScHkpVNW/5siAuwFJFcKiJHJxQWj4b5Hu34CSes76KqtFnTFoHk7QgbCJvC1/RBLA7WmHHa0ki/j97MftgPoemO1Haud12fRw6dFhDO07rU6QZy6bGkMbpoCNhaSkxOLPT6Lm/pbk4qyHi2wUmCeg+qWKAcE1QHIGSmkzwt2E1p7F/weOQqlDRNoKT20d3Y+t9i79kjHsJXJ/+ST0y5czIZFvrz6nUCjwDLXdzuhU4XzdLog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iD3fh7d6OR6zVRSu9/npCp2oB11IYdLrmDPqQnjPijY=; b=aG0isQGzRZBHRG+FjjNhE19CBf/KHySmOzpLWM1jzEiA/pmAOE/LTH4EJVjndYBRgJeOjn00DuSgG5GjVIh6tvGO4WTFOh5kig7CL0kCt7bnQ21q1oIWqlTNvce8q7ErD85uGA0wqqqiLX+GopjHocJgD/x4EEXT+3J2ygmuzcGcVC/Mxg7f3r+IGVhhv04runYzI3jSiQSqn37oSwV05XqZQsuJ61ugJCKIUum3OIqPuUC8n0t4kElnP87J63HedByediafqy/8BxvLR5masbmmBNfIzoRyPE3Y6M8qMCNVzlFCiozmZU3NIZvsdJadvfZpxPkPDRXJnzkJf4Z8jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:13 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:13 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 06/15] fetch2: gitsm: remove needless SRCREV_FORMAT override Date: Fri, 5 Sep 2025 08:20:49 +0200 Message-ID: <20250905062058.2563806-7-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 77dbbf9f-5b70-4e23-9463-08ddec4468ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: QkPeuC+S32hWKE9A5E0fotha8pcsic8RMPVl56FFJCYB0QXiMP7z8qlSZbIsYqp3La1hdfZEsDQ5yRJWo7SqlEW1P13anHQMVZOghi51y5g9NbTn76Gzny9QbIi0Z8rS5JvAKMRGDaIJwfmyD7/pQOan5/aJDPRuaouDWZklgFWxSpuelV7JTfyeF0RVG4wqHD5FxlBccm+GN1NVLOkyt05uuQnHJoxT6CCHJJEKWGhw1H2rzlGjfYvxuo8nO5w3fC8AGSgdoqTiGHzWLX3U/IC+avoRezpgTyK6jp4r/E4p9HMr2tRS7Xy6i08Sua34diSt03gEFbyq0S6yxUOCKw4NFCHIB7JFOkA5G3ENW+XZ6WKgYQVdcHjepq8UXaT8FMAJE3LOkX+vegJmM83McUoxI1l/k4KWYgUa+xN9mGB9xJ8GPTe82Bbc0GsSymNi7vn+GL52cndvOdzo7e+UQnTFqWy8kl1Nz4mlRa2Gnhecicp4HSYQN/fSPGDknuJaau8KCsniUevg41w+RCgejBcMVeIw2XfYgkIbUViAvVoWdH8+LH544750PXQ+0jsbHLGUSkHBNyJT1DF3WUSmvTO665e8v1CBlndNQlzkbxTlQD0AQNnvjAm9qFk4S5rsWb+I1ZtC+R7NUXKoFwojuHFgT4tInRKXqmaGWXRMo9CRZ/J9L3Zxr2JhYrOgJlcckQ+muPozB52ZMDyvQ1e1oXEJo8YIPKpVt1PPyuwjKXJpFonQz0xDc9LFV1uNA8oDZZG42wKMzyiyGQ9PlCaugtYDDAh/6Yq3GN0s4sq0PwodVgT7E/4xYE7i86p9i7JaE3WO1x3FVEH5WWGEl7MdiMQgHU7NK4f21p2KdpLI7xB+7F5vI2OSAzr/JeFT8qHUMYrLvyIH66ODIk74kBiv9Rvfrb6j9L0ooxh+YQ1AF2DgRhKIBURnFZMDxlTsYY1zssABCOQckudTyTYE8NS6wIbuB/KCxBr1FP9mK1wIiQfKvOcuV7rq0KfikB/BNqy3XW+dmA9eJvXw+YOy/9bDiLIdQqxP2yH/y1805FhnkHbIQes+hXXRSj7F0DrL/bpzbeI1DeJuAwrUmQ1EwYYR9EPS695RCD7lxps8PHq3i4zBsjdrwiWbH+FsusjlcYd+FgVvsYj1RLbETqSBZ2ENbrqfseNKBuHoeFdgtxT5CLZmcU/YKaufNJJVTsijBXkMOXJVPYTIcKSsOSMGkxTEBRXj1ourQJHcZARxqiGwtjqWShKFqAJxr+JsnRApkL4/iTpayjdCiUewS3MMunOhoRN4iASOkXoP/fdB0lBnx+jlbmKqHrJhWEANA4n5hGklVAV7CSpCS0XuriL1PORwUyQbevxoJcCncfxx0blx+qGUHQRHryD4q3dysFH4RGpEf16G74ZoRO2gUjsgabP6va10tXSWfRB7Klbveznf7mFS/9vd3b4PzRXWe5FVP9CwR07CYXVQq8+6m3zKalbqNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dn1JzoCW2GsyDPzIg5fn9fsUF553RW/c26FlHYg1xX50AIZY/1+l4KBaj5HY8MlyenaRUz5M79BNuO/Vka+dWcKe9X9FzxWDxEFqc79ITTCcL2o2B44ATjQcoQCnqEID6vp6GqvmRGQS3EiciHvrajL+L3W31C4TCUwOP75B0t4TVQuNSG4yAxokP2CbiFEqoKhJmutkazLTxaFIjk5XZzw7O+IlXphwsUQ5N/wIuSpl9JjWOZESU0PcrMbUM2bBwFhVbwThA7k8wKYSq13TT7mLTur51fanLqLpN1NMzvlwfH6KYfuFoiRpsMwn6alm2D2c0ooIL83WtFYSKh0okk+6boL3XNqmktSmNC9BmFGM76lDDJcFCF+1ZqEgw84Agc1CqUd+xhQaQJaUQTOjjfhC3Fz4SuzD2CPbO/W6Fw/8SPo0zpv8UvUuqcRo5em93JYVjZJiOmEs7Mwgq66w7cig2uFsRI09fI8hUr3AlGcrccMrCgp/mMW2sDWM7o86ZsVwopMlFiDv6fqAJdEvfxHiUo1w8nRJUBP1+frV6WMuIAbzSDL4xPP7DXycw5ORizZ7CNKZea/QdQ3N81E4Z21DY8kyeQN2KUb6pTr5E9+3I99NRRVNnXFg97bJPKDjHqqz7ZfaojghySGeEY82TWo/3zrk76rCzSyEgL1BSlKeKKorxk4DtCgbtadsMiCPcNaojDj5+clkAikGqURAiRdlqNofomWYseXDUYgAQLev0wg7a+GdIqzbiOWV5VqB45LZhBAYaYdoOpGgXAdwC2v/ClzOGeGfmbKYai8WAlx62Cl4hS05muHYoaXrfGYhByeAe4uASebjWfh0vIreDDHjKKBUjc5MIYTmnswg59wu+upRYFM/ZgkM6wsncaE4iOPkL0iNv6OtZoBwqfXukkd/aw7ks9Sv8is6nHLG4Do6U67MbNA9TCfXxjX/XXF/AwfI7lefKhKIc2j/mNLapjpf0tkcnR/aLazu2C9Y15QozJUsQOUifUsDX4/NCcVOrouGMaR/ujuyx+PprEmQ2h7qhY9bNi5vUqWIhfU/JWRYDEYVA4R3NubpVGL5BxDAkL5aVguuk73QvKWxRrnue0IPZpC74nN+/NtJ1TLR09IOwhjgO0C7KFKyK5/k/35B++Fngmrw227Fk3aOsWEnEsUQr5y94zSm3RXKVW5tOXCGjflE/4CIU01yhPR5ZV9WQ7KsSyxExN4M3CFDO4gJ/Plf8Vz4qhNqR8/CXFbGbY4RLBdvuSIhy66LTBLW/6Ls3VvOZlX4KjDDATIgmjXYryKYLe3hyOx+vw6xGB0iShbMwJ3xyNt43Mt2Qtai+HLZWnuvjqUAzqlrqP+VWzVbaGbDQ7nFGcJUqan/n02tlGMZ5dsWg2LbvtMw7Vwz5EzH6Jc/kqlV9oeE0fd1sSoNrHh5IoRmhd3EIMWQjsRX4nZoNsYztO27gIhBgD6b385GCr/27L1F0kKy4bxYp8Nz484HcbVKghkguso+/IMnsZcqVxSPYj2d3fAoCD0wPcGp7C4CA+GqNRdcsSFG/3E6ihTQKRaDs62VbjNwQ04C4F3RrllIFus1kyPiLCXNQU0TtzftPzEOaJUTrq/urjbwlw== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77dbbf9f-5b70-4e23-9463-08ddec4468ff X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:12.1985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TWhXqGS5X/r5asifJhUvfrnjAIFnLnFMg7xGyIapqyCWQDqZAqhFoYzoR4WJ6gAr0Cviw7QUwlmuToNqbTUQ5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17966 From: Stefan Herbrechtsmeier Remove the SRCREV_FORMAT because it is only used together with the SRC_URI and not implicit URLs. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 15b9c3740..bda9864ee 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -136,11 +136,6 @@ class GitSM(Git): #ld.setVar('SRC_URI', url) ld.setVar('SRCREV_%s' % module, subrevision[module]) - # Workaround for issues with SRCPV/SRCREV_FORMAT errors - # error refer to 'multiple' repositories. Only the repository - # in the original SRC_URI actually matters... - ld.setVar('SRCREV_FORMAT', module) - function(ud, url, module, paths[module], workdir, ld) return submodules != [] From patchwork Fri Sep 5 06:20:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69721 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E54ECAC589 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=YRh2XYbx; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g0ScFYrUafE7LHShhBrIidU1knBOyU+XljcBuPI1kyviy7sUfmKfFPxmH79cXaw0G+4yHppxn7/pZbtbIAXv8pqppXVH7RgPnkI1YFgmZ9STnp7gV4YJe6M1YwdwBq8RB+7UZewvm++JH7HeLXCvFFT0El52vhG8bKRsnAZy4YTIiVTXlej12+fZ63Q8JLATa0UeR2Nm80BpRzRlHZWy46xMKVb16EYlPpZ9QOxvC4GlbcmQeV2lrBUKgiTyjGrXX1mtNIaFndnDVxafYR1JLPMvkQ7mDdaerPp5naWR1rIrHuIoYukfEXYon1R7L9ICTFVIe+Ka1+Q6k+fui9Ja+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O1Bjd0MagqhDxEvw7qhM8TPa1qTyUlhoQl5M5E0Wj/I=; b=yo0tBBeP/vABUcGHpE8PlaJYm8+hqPoCMYeo/r3HglOaIbX7ubfPcqd/HtdeUL3zXVYL9u+8zOl+yAkxN1dbGbcJw7aIdek4rxhNSZ0K3MeexGdpo8Ct6A2pnrus+Xv1oQuicrea2goUVuKMFIRF/mdGQ8zkaZnIARU2W2MTAQ8NKE7ITInKHpjPQ86kfN71NgEUL0skIF1o+9NHsgaCSxj5nT4tQkp28kr0aT8wftbYWeS4BPBwzhLWq9WmpatHzM6mkUvv+0Fbzf2EyHDgiYBwQ8I015aW440uMA4Bs/mF3UlX1tKnpwiW4lWOWO1wzfxlbBkQg9J2FVgQ5Y21sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O1Bjd0MagqhDxEvw7qhM8TPa1qTyUlhoQl5M5E0Wj/I=; b=YRh2XYbxd5/eGVo4vd3vJ+mt1gEmJ6gWdgqTgm7x6ZmJLgyXMqaR9f1rYEvbHrU6hLS9Q8dioWnEfFww1Y5Tl1UBvh1Q+tat1I9SPgAIradi1yELlhrsmAwgCwiRXha7XG6gFTI2gWDcQhtY1h/2ETRJZCf3mrlD0mrom4wFSz6EzDw16oWy1ykzRMYAaQyy1x/N1HFjN3rl0uoS2k5f1EaY02mmVlXc8zMluwHsArMdjlPgNPM9Z02bz6SHqAVCAn4gB9aRfisPvRu2gs6vvUS+IZ3r+etab+41IL02gEebDHzJoH9B+um4DX1KnSYlBTKz/zsikrikt83SEQ0TxA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:13 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:13 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 07/15] fetch2: gitsm: use rev URL parameter instead of SRCREV variable Date: Fri, 5 Sep 2025 08:20:50 +0200 Message-ID: <20250905062058.2563806-8-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: ebb53fee-e05e-4957-961e-08ddec446948 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: cEYHW5qDiTJtfHuP/w2YDvNTY/MzhbbhBI3WrZ8iw+5UUjfGTr59rm6SLeO7/ZsQ7XpenJNBQgv0aI9r0q8mnQg+4z9iL4gv3dxf1KTGyzBblHw8y958DsYedoFTnXBtM4W4VS2hlCmIIjA9brCg76RHu+Aju2UeterIrPSphdedKUZrJv4N40cE2f4KHeJ14C5vCGzcYsgy8IMpcXp5fmA82HksVi31OxkxFxF3V61y5X1LFj288HVRUmtazRTH+SBCXV6c07B1rcujwTOZsd5apRDjzNsCZ3vZ7zYI8V8SMD4V8fa62nM30xr+VSSbPmVKuHWNvgiNJ2PPX5hiFL3xXkMNN6OpnhTb+0cRBOCAxQ9KuM0HjeQU2rOrf9h4GEFYmZHPGDpfsBYdvwJgePylgfAlSLN16Pc+SGxnVdxUGS7vKuT7/hjOtaqT4vk1e3NMUd69Yck4YNrhOnyLR8s9KbKLVn/7LLsI0ywzOo5O/zVxvBHtc7JAlqXpTsScRHImSMqnaEl8/OzI64pbzMBVeqVp26N/ka/rmfpDs/4KqvvOjOnmAz9N4EoQ3o3hRRqS8fWEVpeUQSaWzel3lgDM34+npIq5yq0PLxD5WQYWf64LLtKowKEe6YYzP2A/IXMzp5ipDVHgJXDvxIRZWkbm68p5sdkTVl9fPFB8vaVu+NBvWFpgJ7cV2bIoaCmrGQCSbYa2fl6KqJdyLDp9IyIaLhggs9gGUxHN5ldxccguLQahrIN4SEN8bPWnFo7YaM1QxgAxowiAJEFntSYL7dzHJZN0wFA3y8+nmGt9Pu6K9MLT2lcjHZbbImIMLcwTjgatMC8PT4exPO269B3GSl3pJ1+sL+c+YHreye6Ph+X4uiRy/SmqyyeQawJsIoPxRC67CiTjBF9HIqtPQN1W2A/v+avTSOAFF9HdqZsglWgp+rH8cqMLaqyH399mgoTI+3wr57voeZboybu+vTw1Z8GNnGyl61LF+Do0GsZzZ3a3Epjea2Nvo0Q0t6lyhqLmEnC5Vy9rEAmCt3LskIdqXZeBJhSWzeCQg3ss7rOk/KvXTK/p/Vly/y3qGuAwGEah7RKe78HYbVG6sJVJLy7qqU2+XHfVIAseb0sw707bFusKVBFu/Y90u3YbTjDkZTy7s4trjQ5byHpc1y2lX541J56pSUuVi+t9/ylQvmSyoyYB1nAvNuzHXb2ltvIuyHT7gqe5TlwD3w9zyvMyhlIHPsuucpkxGpCPnlo06lW6IvEdnHW1mpJOH2IkVkHbpwdc30fY+lFWc6zxHMQc46X9ht6n9Y0+/t4uwO6xLVlUcH5FtI2dg5IuCBAa7grDyDMdqG5K/FIgUWSk/WNnN67YL2jakrqe6MgbqCLami4v+WPQE3e2PgEilGgAmrKYOOJk3U79ZC+GXeABhZw947K/sclH69W8jyGm8nJ158eSXT7tKvt/5XoOqCK90kboP1KRfPathkDm48symG9R8RAYnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YeA8ShyNZbibU6XfY5dQjoZsO5snQJ5o1Mv1Rff5QKivGlyUnhE94tHrlfQKbr+J7tKrh4gYSwXerUG2EXh5607o+shfQlebRVvFwIo5cDiITXtLRfEJ3w5SYUNY6Aoax++wnb6SQJ0TDxKP8bwVmqYjx9pHnR0Jv0JuSNlMHVAkY7xJ0wmMtpwtHZI/QAde76ZusjKTrucw6jlvsYL1QFCKUWHxpqaUfHWdU3E3oQbxH1cs/yrPnw1oKj22Fn9CS+UO7syIm+4VBNaYziH30h/8Ksf7XE/EMh7jso4uU04EyWEf54vFsbxLlHzcYSHCwI0/dzaco4wLpCqmwSaPTylD9iYKbI8IR8v8NcM2WMq+eb6H3k/6HUximfCrSOtGrdj858/FB0yNbJVySnnX/o6sfaxutdn+ksCTfQ/3qslAxTpmeINBCx3R14RU8WgG0h7r0jUvNckQU+/9y7eE2McB3ghI5FrdQihgHV05zFYTeTqnFkbnUZkkpDGr86LgAuxNCnoMFe3+V8ShyIY2S9OqD82DoO802/MfCH/PltIJXJJbqLMyh4KVQeIpOLC6yGNpn4TGGme3DL1xCcSj2NZlB/QsOFodT70Q3FZAtpYjg2gxiq5e5A+IXIaSI/yCsjI+TZGEJx1bUPC5J14Sm6MRzsiN7W4jvXOaUFLW/jSS1VEf7Xbg90N/2RPoVyUuWXAj+7m+Y53YkxYbyXbQuwNakj+gULiPLRxYgoCL1Mrdfzc7ZpPbn4NiAmebjq+igt2Mla+KJVNbaaliIlgPV91t4UxMz4TDntMJDA1DHLo22QZ1NSMzO4RlvCY0n/4bj6OsP3r1DZ8p8OclDzUUqT5h28765VkQolzVuQfoJu+0+69GirnARRY4Rb+AQtYEbe5auwx/qOTJFvzYam1Dtrj24bGLIsQpc3gsWYSPcdnMZ0jjngPuV9euffHVr7T6e5uYYYkzNWqB6mtsT6Belcg8s5cdF+tmW9UUmMflgafeKT4HEr+693/sBT7dhvcOkSq7D5gtmmjGxgmUxf/21eqkLqNWd8+hPGBCC10u9Id2IwbzeEkSAM0S1DFzCP384gDTpu4kyrarIh/L/O+/I/HrSxk5OMIkXKqwl+PhkPvqTH8vmtO1U7/aHitWI+kCkvAmX5Ecd4+EqYr00CNjFiyxv8q9qgQxWeBET43fnNk3uo8p+io+yYE9p45oAKUyigxGrRA8cV5prTTQSyTM4UIlZOz+H2aJ6342bWlqtevZiHnq4F8+G8MkuZxCxVnj0CzSzUMGijvl201RekMaE07MMoGKNLUKrpgBjY0BgtA8eDn1bCZcLE6+8UgWydhqUp2BnGlTCsWdmpNITAgJgjTYISOKDL6QX33/jw8Qc0JSeFDG0TMFnrnvkddurIRdF7qot1KOqBtaig2neD1j+kGB83g6FfjzdDhX3DrUuxByuagR3FaL0PLerS7ddZUHfswA3zECmBehQ9lXGFY/vq+ybK+nSPcWY/SufbtrD2pkV7q4zCVVQ5iJzht7bUfGKmPbuXXkp6GeFbktv+FScKuh3fyYzv1Mr9hWkFMlq7+j4UyXJx4g0XzewDo5xJe6K8k1693259kydH61mS2dUQ== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebb53fee-e05e-4957-961e-08ddec446948 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:12.6427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GiKh5TvDS/foIrQAj1S9wCzUqEqkjcYplL3B1zDNnRMgERJMv+MG9BHWEolXKtP+l3aDO0VBbWYd7VcO95MM9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17963 From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index bda9864ee..497661bd6 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -123,6 +123,7 @@ class GitSM(Git): url += ";subpath=%s" % module url += ";nobranch=1" url += ";lfs=%s" % ("1" if self._need_lfs(ud) else "0") + url += ";rev=%s" % subrevision[module] # Note that adding "user=" here to give credentials to the # submodule is not supported. Since using SRC_URI to give git:// # URL a password is not supported, one have to use one of the @@ -130,13 +131,7 @@ class GitSM(Git): # the user (See comment in git.py). # So, we will not take patches adding "user=" support here. - ld = d.createCopy() - # Not necessary to set SRC_URI, since we're passing the URI to - # Fetch. - #ld.setVar('SRC_URI', url) - ld.setVar('SRCREV_%s' % module, subrevision[module]) - - function(ud, url, module, paths[module], workdir, ld) + function(ud, url, module, paths[module], workdir, d) return submodules != [] From patchwork Fri Sep 5 06:20:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3BDCAC58B for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=iB8z1lqz; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RZDz83sQnyh6P/8vy4L1YFncg8EXTui78e31TXSCQvM3Fwa3ehU+uJ8XtiA0F+S00sHn2vBsqg0A/kTHOf4IoZzH23hnYtEzaVxpoxYro3qzO5+wKP9LZYwko8JE5/tVsIjVPzY08/eZrpFX5AlsbnGnjVMCX+2loSbbJN3U5Sov9X5RYY0JTyGBPT321z3EX0g3ttZKFVavNXcwYjgY31LMXwrVc3C3oJkBYk4Xipd6pJO9YzUejH7vzjavt337gdXaMPOp91Wfg2BJnh3hR4Wuw5k45pdm4Lh0H8zNiEG6kS8aWHcBPF7YM6ljZ8DZoedakKFqlf5V5boOD5NCgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XYH/jhYeiv4qBR5R4uJ2d1L0GblGN2X0d68YZi8lakU=; b=Nj67NJXHlhUFB5FNb4TWiBzBgjVVKw7kabmpQHYlnJ7CeO+sE3iiK795hufxthdBHrX1Kza5wIOvUMoon3xunGU4NxobBCn7YJKc/htf0SOdqzy9xKonG8jBLPR18iIzN3qQmhIY8neIHi8nAKKYGpKoi9nuvFm6ZwbqiAxTMaRgaBaAqMWbrkl+ckn7JoE0EPnHdHV5wYk2l5bH4GrASb8d2nPHsaLviqQW/7w/r1Nb9eSqZscLKjKZo5g812A06Dgx9NLEa0nyQEdcNOR3bZ2JJTZ5u5kX5JFUE7BjCO4WPEsXEfvLV08YDFn8BQHXEi5K67F0w8iTGwTJkl8R2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYH/jhYeiv4qBR5R4uJ2d1L0GblGN2X0d68YZi8lakU=; b=iB8z1lqz1L2fYCNQJpofXEZ9k7pSIzlpl60suYThgTUemJ1ka/OKsr+io6Vi7fxdiHZZmBmUUU37xa21pOG7tdnaQI9/zBKjzGQpZrCR25CGWJPDeyudXTsavUhM/MbMQfRLKSHKU3fa7fIWSl1p0XvCznHGOdYUt3EEETfWMDSXIn9NsLyJIDgEkRhYMEQZwbx3d1wAtZ2s2VPkIbPxwda+hsiX4wbw4XvZrYx0heSBPNbrXQwEPVjHxP9sJ7IoOqLME0WDYGvaQUdpTr3sx3j9GQHbFiBQs9NmQQUrP3TxDBe/xN2XkzrJjKOdrtMH2b9HwNvpWsqwAY9LgcNNNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:13 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:13 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 08/15] fetch2: gitsm: remove duplicate code Date: Fri, 5 Sep 2025 08:20:51 +0200 Message-ID: <20250905062058.2563806-9-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: a9b7e85a-c325-43f1-75c5-08ddec44698c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: lOQLiGvc6v/lUwioHR5oMmuZnLugs94tDp9iN6dnVdj5KKvwU54LJj0ASENvKxlWDCBXZpcMnGZwn02/u2ZVUAgJ9YRjxVOJI0KccRczsECwgi/EsKzljb5IB7J78l3VTuacKWjV2zLfzeBXiqGSblVY41nz8Yig39rGPkbFXJPOs2je/KWJUPgMfMtxRjyhJi/ucMQJBB7hRz9G0/ml3N+9EHnbPMvOTZRGfHvK49I4qxk3TDBJ7CMpJKosUH8FsL3/2Zf4ont483RcRCN8uDjzgrXwggYmZZCI3Y5ONfi2Bvwr2/hQneGF0MhetelZIE3X910C+EQKKq9QCa+bVhnzD4GAa5Ql3ehiiomWh2gchZO/4Gwn1UO33o2vx0M56Oi/WmA1fPOobVFgCNxhhIPehwac4x8hhLYybSTUxePbpiPJEvczSA5s+mhVU7YtMVLevUB0G8wGwwB5ioIBv3OTCDuHaql93Uy74kULmDl6nx+cgVg+b6mjJ1PpjGt9oPKJMP3WXb0ic5HT34RN5LG6sEN6BqzOp3dHsQSv9HT3u68TUG4fwudnD7VhHXkzTEBoH2myt/vH/KW7XVtfUuxL6LsZ/ijG8EK2fYaa1jxt2sDIyS7PYcSaewGBXv2xMl/k2vngZZpZiX0DMHDFqVYAaiBa8Pii7/sfI0nfPoHEvc9sUcKt6/1FBUimVXr5Ck5JmGiqYdNqwmLHx97Z46dE6HtgY/p9paq6cRFeaouTYqZQh6W3ALf8C7/+oiJz5+lFFOFRscKvTsgPiRx0lBBSSnfoxS/AjBqS1nyV0J6/vcasSOzqb1ALxXvbQW+AZOGMuo6H5JFnXDS6MTygGInaoUThw3pLXDLUJpWkgE2BlpIuHO7PauoWI+IBp1TwIOG+sZl/dy9ySGLdIkC4KvGROGkvPExtw+VUkpzQDsyCT1uSDY5OFvSTRhhJclojmTpzC/htpu0iHb+83XJPoYiOVmIYJrk1XiJXIntxApGFfAv94M1R2fVBGlIudFD2OtAyPEyTl54vLqAeJVjGVXLYfxlTvsua2SHqbgO8AtouI1olvELPGYlGy0lcKKU4Gqgbupq/COG5/fBY2XUlE+QKSYnqQskI40HTfeTxg5/6sYmyHqCZ064cBiwX/iDgxa3rssmulh0g5OIuA9SdHYsAN++31Jo9PTCCdKS82+gvUHUiP76apSZhD8xUlDxMna1UK5zx9mR0eQ9dX0Cjw1Gh3aWZpWm0/v3uFz+Y/4wDeMyPmR25WS/zUECo799VD0nQfpowpLOoAZs8aYyG7NerK+Iqlkv4CHbgihHpQu7BVR8C9qM5qLEU9/u/+Ri5BdMtM38qsNJHl4Dha3yDpI6OiUzXSz5X8h2qctncD8RdaB1swoeLdywiNkyNDgmL7D/bGLe4CQAWF4IFvijLo7A2V+iH9W6Ftt4UKjNgLkAoBl6HWVVeYkiV2Q/ju0GgMaFreodvt9wBtjJDyGSY2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jpxi2hfZcAs2wP0mNeTPmT50BSBoLYk2ivMDIkp1qJiSETIH2i8PyY7/Pm7I4mFdfs166OAP6cx/Qq8e6PGBEDUH5FPOVoxqJA+m80j8a8SPJRiEIQ+Apo1UV1lb1xeWhWbJ9Lt306wUMiVCeuKCAZoFbE1cWllFaqpSl6/yq861b3DU4pwP9y1FqqlOCr2dG/6DUYTtOSZBf4kDa30UpJE6H/ZtauknRzMQRBuGtsFv+SQvNybqRx3QhbKvIps+1LHkZK9yfpf3ondCKNCJofBytyf66RuAsjs6G16tv5pw6sK04W8QBKv5Ysxddptje+37a4iqla5kx5hyIzanqqBFQRYZWj/hlTwLcg6bMfFRUiZ9nCmb5/mrrqYcGpt4Q8H1dqU/VA0v7+9k/3xg4yigU2wamQEfNlrSqVbyUE+Na/QM91m69uWCb1tkQoX4+YAjr4roKde/W8B9R361ggFKizbXx3LIF9z0a2S/8rqsgFeG6ozDK4ypnBFzJEoD6egxFRO/Agsyl923FsT7Qb8PRKl88tiTzM0kptYx1sOx5gpCjo0LhBAxX8cwyg2Psby7cYf2pvPSUqh7zmgS8KUSbuwLehBrUbo6JDLlub2PCZGkBVcBneS48of4rKZsqYc7W81utVFSpID5qr0NOzS6pfN9eR1zhH3z0pmqxaVdgc0K31UOzcQGAWnxhtJoD/Ap9ezY3N7TY99Agn2jHm5rHPygC5pexd4BOndOf91ufC+aSQjrhgAN01+vsvae6myim3GW2Z0cpSeP1hiMScpc0DSo6Ii5cVXloxaHh6e0tenZXog5I2rdUzhQGG0tgtPw9ldm+Tdi7g0jnObAjMONle0MZ8OTMEIhvNiH4dXiWINLzeJTS1SpCQCmK9TmALEL7RgBVkZ199VM8lwKd/KzHSo+FsYW7eUW8KZb44wc2IoecYsoZymR9DKfw15yeMQ6G25XyQBnMCtO1iPQQ2b6cRqr8lx0EoFnNvj2m8S8Pk1dWtVFvNgTAkB8TVejfIi4N6GAocMEuoOhqUiAvVoq2cHeW9v+OFbdhHGyyZQMZ/mxTVRPNfZdlvBAmmT5SPCDa/zQ0iKpDgP/kV+GOs/ITuyZeCImn/5cEP3DE9KL4eM6gWr36Kw65c2xEVXkhmnGcZD8rxmxKLHbB9DeY6yXLjFgcUIw3ZRkUDMms18D8ACFWzGuhCiqGifs0eKqMkd5/CXnKAmtMa7eaBwMn+GyNkfdhDIZZrQAZfFVpC/VWBWa6YH3rL913Qb8KAvIvpSXNXuuz13/KhwMU53a9A0p1d19lcAu3fWI6y74m6YYDPIQ4t9B2fslmeB6muGkHVuyg7isrwCMuw84GH7hYuYtZil59RIQ6oaQDhACwJaJfkjHvV/TWKrmE2gPH9rgceoUZLuca/q4VfWqlruK/2CuvU3sEKURPCkDhZP/Anp5qUHy1V3MIxRg1isck5h8AL8kjw4p3WwMKChU/Hgy+Jk3n9C1DwclDCzgmQiiCScP5+pWlSPk6JOjd4ppJpVSqCRAF8JBC6ZSMO0m1PClbyP6PF2SyDGUZmf/H1SMGFnYUgQVJF84xGR1fO8DOA2yXj8SoCe+U+Mhu3ydmcWkUg== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9b7e85a-c325-43f1-75c5-08ddec44698c X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:13.0450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pkXmLS5i5FYIIuUMd195U1ckrx8ZIIz6k0siIOGo2nd0G2mj5LiBWMMQ/gtdnJbzY/iO16CVICusvI6bHfw7hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17964 From: Stefan Herbrechtsmeier Remove the duplicate append of the nobranch parameter from the loops and move duplicate append of the bareclone parameter from the loops to the URL creation. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 497661bd6..953a1ca39 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -124,6 +124,7 @@ class GitSM(Git): url += ";nobranch=1" url += ";lfs=%s" % ("1" if self._need_lfs(ud) else "0") url += ";rev=%s" % subrevision[module] + url += ";bareclone=1" # Note that adding "user=" here to give credentials to the # submodule is not supported. Since using SRC_URI to give git:// # URL a password is not supported, one have to use one of the @@ -157,8 +158,6 @@ class GitSM(Git): need_update_list = [] def need_update_submodule(ud, url, module, modpath, workdir, d): - url += ";bareclone=1;nobranch=1" - try: newfetch = Fetch([url], d, cache=False) new_ud = newfetch.ud[url] @@ -178,8 +177,6 @@ class GitSM(Git): def download(self, ud, d): def download_submodule(ud, url, module, modpath, workdir, d): - url += ";bareclone=1;nobranch=1" - # Is the following still needed? #url += ";nocheckout=1" @@ -197,8 +194,6 @@ class GitSM(Git): subdestdir = self.destdir(ud, destdir, d) def unpack_submodules(ud, url, module, modpath, workdir, d): - url += ";bareclone=1;nobranch=1" - # Figure out where we clone over the bare submodules... if ud.bareclone: repo_conf = '' @@ -239,7 +234,6 @@ class GitSM(Git): runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=subdestdir) def clean(self, ud, d): def clean_submodule(ud, url, module, modpath, workdir, d): - url += ";bareclone=1;nobranch=1" try: newfetch = Fetch([url], d, cache=False) newfetch.clean() @@ -256,7 +250,6 @@ class GitSM(Git): urldata = [] def add_submodule(ud, url, module, modpath, workdir, d): - url += ";bareclone=1;nobranch=1" newfetch = Fetch([url], d, cache=False) urldata.extend(newfetch.expanded_urldata()) From patchwork Fri Sep 5 06:20:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69712 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65343CA101C for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=LwAV1Ige; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uuAsfwSicwGChG3RuZdJlzHDbro9xRcuJPxOhsnRzRGsrVTmVwqfFFpS5f7QVN4V6niah1P1T7LC94fw6AREe93OXAWLtI+VyXQPfrT1Y8jfxJ7S+FLleedTWljafYg8M8Z7sLqWp06D/R1oNjg+gNDrhfKh8ZK4eRXX+6zHdH3xGmuH26lVPFH1OKUhwuH/By9L7ux6DhYEruaOXxmseKrTDLW3xUNIKe4TJzxwoHbVmKRDMdQk4ZBc8ffQghN5Bdhdt/Zey8Xv0Av00a/rYS0hwGEAT/+CU85ylQ/h5v5IIfFfUE+qqaAbotsPfQG+L72Brpcyb3Llv3FXlCMcMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MLs7gS948dWFxyBWKyNJAmtLoDdOQeBs2LjoOGSX5vE=; b=Gvn6T+rG2y6SPWj2DEAwpfwJdZgvHq/y76VM3R/BsY0sN/o1TdXqWj/Ew8kfX2DkxHLHxu1YR9cd7XoRSgANv8BPc76rFHcCEORTJtoeJOkAK7V1os8st/+NM+OFuQqusZ02ARXI+sEYmPDgXZwATNPra3xkkNEUd5fFWyg/FSB0pPGnb7bJzyQ+M3EHfr9bv7V2WZ8sdcO7pQbv79umS52kCuCGUC297HGrPm1VpP+o3LfoAcxwWGf8il8M93vsclsBIvkbbfP1eqDyzTMkl7gMDoWoAb17u+gm6qpqOSaVJL/+Pv/vADF6jjvX6PUUp6wsWgW9ayiEYG2nwH4m4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MLs7gS948dWFxyBWKyNJAmtLoDdOQeBs2LjoOGSX5vE=; b=LwAV1IgeYQs92rKCSrkVhhZmSfk21LCS2+tCjpPeYWlEUDUGyBm7mRUSh104/TovENskMQVrv+7AV97MxhIBWBWinhyjegMWsLApm/KUlXI5vY+6JfBzgF7ylbOAgidPEBldWMMPDJ0x9iwc7DJah3/5DQHk5cj3RhoT6ddwqUvEHtQmt6CMN2c7a1SpZmXtmiIHsY5IBPvfm42tz5J5Ku5lIIqWXnxXuuHCoJdireVOjfXo+eWnL6Fh5y/8kuRgscpF0PuZhm61gyYR5VHqDB/sR9F5Dbv+KuZdfJVjE+YMdc1NdysS7Pn/ApqykAV+898gKKP4qOUhGi7kWVuHLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:14 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:14 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 09/15] fetch2: gitsm: use subdir parameter for submodule Date: Fri, 5 Sep 2025 08:20:52 +0200 Message-ID: <20250905062058.2563806-10-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 38c810ee-ca10-45c7-bd78-08ddec4469c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: ttsW6FPpneH6lgUn8rirjYuWgDuQHP4DUoKnk/wAQ8B5bFH2O0dIsO2y8EAJ51mf8JPsyKDz6zjuPq2vEs3ZTPeZkQIisdk9J2qsU+07VTsH0vnp6WHcbStxqdCER82K8ERA/zj+0kqKgPhdLHANlBeVfhrn4+NGAopBRYdpLB5qQYV6LGSjg73uqufD2by2T6IIGFie45bAQ+/MNHXuMmMMPW7clxN/BUJnReNx8RPP5w9kpetrMw9y+7bBlA/pGMHdRnCshpHVM04JW+wh2FDjTYpBMtWiBtnQy2kiqxSnD/Uy6D1yCdsHJ+LWNAuNmBKd5v2g4Gcp3tS4NIXWx0BYagqjQXILD8bBWUFMf/7iDG56PORS76ZlO02RwY4Crxtspa2kF5U9ARLGIIhzXQU5sSsUviEysBJSIAGKdscN0EdsWFcszMCt2ulLeF0Ra6BKLvdSiLRX3A24Sh4uNHNpAUHe0eGFvTi5jVXrslsAltiGg8TyEnU/Gtbn42SZ7zx7tIBhOXPnwFdwm+Jx7vMl/NUY5msA4Zg2Unp/nHZX+ooTsDuQbpI6yG5XqGcSBewBwbpWQi2iGOqXnvctAWYwhdfxKMIctJqk4gYgTC+9XtDdHKROWJ5zlOxcGyldRniz/641beUCX9A3TGUNEHNPkyDPov3DaWhNdxDigdCxlP0lxBkwaoUQZipnYRrFlegoUP0wzxqsHIUVKyzKyzaeIUMGQp4SBAi0giFFeAA67ELyTjJf2w7Wi1X6dXatUL/zRq4T25o3vajYpaKabJGO9Lv5Fr8u6hdBmk6bn9Zu1S0R/gGucNSa8lD6Bo5X68sG+EBFgk7m3iw9w/voCCHmxvb9m8DDo2KS73YWAZgFrozg7+0qGPx/PIv0b8fHiA2DWm4fRlTEumZJ4xjtf5C1rxsXrf3c5EczchRsmzEIGdPZEgcOWlWzlOT2zIUOYdLkaQQu+AHqXS532hOh5rLTzNaqX4eQ7rkOljZcuIqklVZEdpnxEZTCOeIF/vVthJ8UbIW7vgGhAopnC0p61yrsADxgJUVWnAo0e8nb3Og+K8gtzDhxCEEFrv0D2YhX9WvfNSng6wG5u8MCP7kyDxhbFt/+sDSIv22WLc+1bCBIdMcqVPPUu4SMLawAcCQxV99eNcNt1RDN2yJT917mcleR/d1HYqfTD4rbykTlQFFTaG5HjpHfU4HX3u102e0VaQL7nD8cw1RN67ZtcACaPtiVvtuFVraVkuvX30vMW64UaGKH35+wHLXL9hc+5fTSy1BYZtadiJX0rT3lZCZKa0pPaCHbA+nRVf0P+bJn7xoPBgBtha9/Abes+Y29utDyU3qKkpVJb+KuxR2yBY8Kp6gzV+4FEiUKlLhpdjHCrV7YXhoVJ0wWQLT1H2O6uatZ7uEph6aqoc07yJmwLE83EQxCZHfSPmLtSt0Lgk3NufXU1rUqTCT97c9q7EaBRzfWt4ojnv7sWGUAwV2pviEqcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: k/+PSE01de62fXpMHzxlj6wgi0rVkYaI0bSImI6Iv8U368aFC6fBO7zOmdBI7lRhFO69TuJMr+Rm5z6lQ/x/FINyLUQCN6xkAzX68Txuhj08BZyc/MOKWUtA/dbR/p6YE3D95BMv3+5SD1cp/+HuZrb5cJD1YP4wCgVYu/ZEDqHchA0AL3byzqSlQV7Q1vxu5WKo8kqg+kCKWMSUUD906rywTI0lGrw9IfcujqoE6AaLhhtXY3wkS7xN7IXZqW4acQdZTL6AOOUWQtwsrj2srbOcwtU7xvq2zXjbl9qxQ2bDIt6Q35/GnzdT1WJvAUGiPSwQzgy2RVxzLbtahgh+BIO7UnMvXZjI0lucLFmZrFQoFz2bzfJYgt8TAahZwNcJGbmlNV85pyWeXK1hrXI7e8ixXElyd86c/K+vYDNHZTx2rp03S83WXFDXqxEq2O6j7We+AJRssQsi6xmnGQTWAYYiEh6DfR197NM80Pa5Ioe+UsBqd11AmNemx9qrWuKqo5e7kylIPKoUEgb8zeq2dpEKoV1yoW/4V2zI+ZtHNfO58PxCFdWf4FAkn14eNujA+Wev+c90D1B8AxrsBfoimtTsys4Flxf9bSCUXBZhjWXqFj3tPkfdI6+8gao5AurrHBr910NCBpPXjRJ5uHIU/uiNTBr9Gy/g3glwYG+AapSEHQ+BlK2Zs91lf62o9ReWZiJv7os9UJLyiiAZPAy3VAo1uc9B0RZ9N217n/uE63HEcZjCqoNWRgHv7lZoGslA9RSAq85H2jirmzGWV8qKc6z1gYbXG0qL7WOsCiFzYgE4+92q73SnTZ7IjqxpBjPdNdC3JcPjcQ6DT0B5JILbl7VIO+dsiWDt3yl7Xg3+FJE+/52GzfjGdAF8juU2gN/fvB5BhwkGfzRSa6q6igcGaclLHrxXc78g0I03BTRu/3ZyFXL0HQYc1zxa4JV+6NfKGKId1RiMkEOarKbzPxMwgKfnWXPd/qxhhUTsp05b2EcoFvv5sIwZ8H65JwvwRnrWgJJHR8zbQsKP0Dh/NPJBFgZunyTAWFmINXu64C5iStQCnjUk31CM+nkpQa51ZZcawrD/nnbxiZUeqQwoPf+Jb8djCKcHDlXgVBQDpBdXveOUOBNIrwcwi4Q4ChJFTFT16i6qDaen/Gsz9YuHm3VhDkWFW7iEjhis3ycS9wqhzdCBmLEg8N56M65Pn5CBTVL57SYggzzi2n2ZBUfhunuwJHa6b9Utk0cNjzL8bxVCZy0VnXH/LuQHtAXdgZEay9br5lAUmzKUuc4MHUOpRCO9EPyIkv9moPUf0gyZ8lRK+QaZycZZIpTDCy9PuP8KgkjUJzukSYyA0deSL5aNhULH54kwkTol4dvVeo6loBQXFqGzqVWsWWwiGfJp/Tscgsok3NdIBnRK/ad4jAUvW9DwWI39Iug7PQS4Ppfxx3ZGX5S0jJEb19nL+VmbvfjQUFBoNOeZj6ijoFwXpemkB21lGukXFFKe+VSzj60IkR8WdyTzXm06QxLWGue3PlNBn1sRTyA+4823lz0fFk1NIwyP9+J4FPVbPRZH0vvmaHEN5S5CRo1gOprpUe75tx9YqU0KZ3ciiLc0yHhzE7hQn2mJAw== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38c810ee-ca10-45c7-bd78-08ddec4469c9 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:13.4219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AJhYo/pQY3f+/KmxCY2RGc5qnIlQdkP3VN8wRc3wkWexbpns17EBFAJc00D4Jcit17+OGeAQoHnBEhb7NCjpzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17965 From: Stefan Herbrechtsmeier Use the subdir parameter to pass the destination directory to the unpack function. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 953a1ca39..d013a09d6 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -125,6 +125,12 @@ class GitSM(Git): url += ";lfs=%s" % ("1" if self._need_lfs(ud) else "0") url += ";rev=%s" % subrevision[module] url += ";bareclone=1" + + parentdir = self.destdir(ud, '', d) + gitdir = '' if ud.bareclone else '.git' + subdir = os.path.join(parentdir, gitdir, 'modules', module) + url += ";subdir=%s" % subdir + # Note that adding "user=" here to give credentials to the # submodule is not supported. Since using SRC_URI to give git:// # URL a password is not supported, one have to use one of the @@ -194,15 +200,11 @@ class GitSM(Git): subdestdir = self.destdir(ud, destdir, d) def unpack_submodules(ud, url, module, modpath, workdir, d): - # Figure out where we clone over the bare submodules... - if ud.bareclone: - repo_conf = '' - else: - repo_conf = '.git' - try: newfetch = Fetch([url], d, cache=False) - newfetch.unpack(root=os.path.dirname(os.path.join(subdestdir, repo_conf, 'modules', module))) + new_ud = newfetch.ud[url] + fulldestdir = self.destdir(new_ud, destdir, d) + newfetch.unpack(root=destdir) except Exception as e: logger.error('gitsm: submodule unpack failed: %s %s' % (type(e).__name__, str(e))) raise @@ -217,9 +219,9 @@ class GitSM(Git): # Ensure the submodule repository is NOT set to bare, since we're checking it out... try: - runfetchcmd("%s config core.bare false" % (ud.basecmd), d, quiet=True, workdir=os.path.join(subdestdir, repo_conf, 'modules', module)) + runfetchcmd("%s config core.bare false" % (ud.basecmd), d, quiet=True, workdir=fulldestdir) except: - logger.error("Unable to set git config core.bare to false for %s" % os.path.join(subdestdir, repo_conf, 'modules', module)) + logger.error("Unable to set git config core.bare to false for %s" % fulldestdir) raise Git.unpack(self, ud, destdir, d) From patchwork Fri Sep 5 06:20:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69714 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E21CAC581 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=3Q2g7E1Y; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NxDZoTAyIH5sOliHv+2BoWdBsgMPLlniJ+Wa4xe/QkwHR2vnjpa/oCWM1VHzQSJu1lHaOdA9RBMbx+EBNQMhx7NMkZCIL2jAfNjld7F9MLtHvlC9/CrA8kIxKT+lZSnPM49cCORaiAi08PvMR8UxaCKTlVyo/bEC0jaB9itU+4+0Gzc2JpLehuZG4A38z98tYsWAjwnEuaCoQXw3yND2y83C2vLdVwRzl0XcCafbMFOc2vdZAMpFeqKTQbI+SXSQvm6d/dKIYAqXKwR9sv7kHMSyKJLPlryWziYNTHifypWTgUMpyEeuxzZ5N9gVMZOy+EAPVcnLrmPAIOKRVv5Vyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QQkcsUX9CPiPzNI1scA+4zaZE8DQCOBjsm9VdvvLz9M=; b=gS2VdI7afjplTAyiUIq+/TenjN60iOCVEpt8V22MBvaa7IHdwWuUuyQFD9RXN4l2BsIXcv/SUCME93lRI4/mp7JA4etpQidCGK4ulOqkO1Zr0hvHmB0pB/3fN8rQwEdbf86wV0f+pJGKPYHNdDC5PkRHWcFvHwCTxQ+eHU5rWti8LEjRkpz7CMc2kL5t+fRWgzBv71AIt8gvBfLWlR93AnqeDKAN74yjwtpMwJ/yigu3R5U4KTN/vCd24C9S8pA/oZit1/5nQhPG9OUNUayuNMtweGhhb3Oqn2w694LJ1Fv2gp4CsW3wPYdbG3pxwONGszWH3Ad+TWNjAfn3Jx9GYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQkcsUX9CPiPzNI1scA+4zaZE8DQCOBjsm9VdvvLz9M=; b=3Q2g7E1YnDto/qwCEiLxhHLc3zhNTGMWtlUwUFoY3MHTyh2IotUHNBV1jNjoVkTx9pyp1UHz+orO1Ae3qequacFy0SzAXcQY6WWBtqHXRRyH/dQFA49k+8PJVliKT3zyOcZGfKIpI75/GWFKt6/GKKkISoPXnsI6trk239AiJ9wiivwRBfKWgxloEFK7ViGxlLGKIeatT8KR1qzDYlFLadKezYK9jNND9kmp+qXvdY4Tnzt1dPYIcxT8TkH14NymWm0NnGh1AcnxYFeuhd8dj8mUC18AWIZTToBDOGlr08c5bSC4VSu7BjYtc7Ayi1kC4qReE+Yre2f2cKYuZ7lpQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:14 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:14 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 10/15] fetch2: gitsm: add parentdir parameter Date: Fri, 5 Sep 2025 08:20:53 +0200 Message-ID: <20250905062058.2563806-11-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 4176d1cb-97a1-4048-c9c5-08ddec446a02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: yZKOjKCudYTKD5TGMp4/a4iD30M955VMwFzjJVSFz2ipJmNLUxeRWSJNgER1YTux7Dm4d7FvhzqvipLoxhm5PLEFWlWaJCR5jCVFTi+A22cE92/r8klkjrJqnvWjIHG4Ha6U82MIvWNY+FZ1KDAPYvjtRokN12CSNaGq6Be4F+sRgmUMm7iR3GP03fOWOvcq0otPTJIQgd+MY0I+DAjvEP4k/ltZ4DRirFNFf679A6YTiXcs/7xVkwBtgM1hNrIVDdO/HCj26nOHzrSQV1uEOzgmx7CYbkAks4803cwE+38QvzGbGBYGf7Ung2XQhZNDtrukldbBuIUgKjfC446JGYeydTYFU3GMZ+OAPkdlBsikyeHE9F2zko0IkFiuSpPO7ZCDQdA7BBgqtheImCd8FsXaM6t0jOV9Lctq8qYXd08rT6t64MjLyfw8AN9B5x7AKGm3F/zdRkklZsYNpbAv4AxrC0ITUPvHlEVzoGwBzVWjqxxFlWmkc/Ndlyf14COVolU6f8aXZ0lYyB3fC5ciemMoGcnY/i5RNHBDD/x+bRX0OtX5smp402YuccVZe7R5yQ4b/ufgjlAR7KGAr73N7DUYOTOX8D+5MJX+fNQLXrAdxCPLRfJBEDCoYgMM0OrtMCALyS6/M4LRDePw8HgWcER7bkBcQ5atP4sS8eOigOyig6HOqMeyvMtJk6AqeCOpho0q325DL2QEH/roQUfFSkU4eTLb7Uukzvy1XrziCd1lqL/p329KpaXZq65N20lx8y0qEaNQWL8r2lNkMw6eYOtGsMnribpUqJG+SR9GW1oFuVauFLeMy4SD+gmiSNUMiWFri4YSSXeGbShOdxWKU59+Ohr3FnDi/9QZLy9OJ5uH1egxDABPg16Fce1oUFIj/Wup9oxzIZN3EF9hzbAQ1MNdrXRoLCuHul+LK4DknWQs2zZQofhiuM1a0sQ8PVMVpfeRySMPcpd0PbuyXg5KKPFJi4FjIzt5Bzs++yYuNGvD7KEW76PwC3MCGl1Eawti5aIX05umPjkMSlOfoi34KIuwXtBjiIPFz7T1SXzHFE9Xsw47uie7G+fP2cFr1vbOJQZQjjfkVAuAuHdF9J76Rj2VdF/vImpoVlTlWl4JTbsBryZtpxqBFetV6tyJzQ12geGaX0/fpsiaXVeyCb0m45U+ajexGLq/o+oVz6hmLwMMMZMDmx21eWqm9R1I+9eiv6uRwDWaA3R1c2lVO8lPCtVhPVXWVaYsSuJqYwuzF8yCF4ffislPxaNd7auQfLauMaOtV/OEKkPvHeZxb9vYo/5YEAzyw7//ME1wfb0YLO72lDyFU1Dw45ZW+eod1mxiZ+xSqIs2uno5xnTERkh30kOR6KU2gcaSQ8ahi3H1f/RCRT+IAmxu5WSP+sIPTNljf2oV9mRGV8VfHzPgJoJlm/YUoqtAX9xghnACDrYQjdYCm5qZeSBWfG3cip1fuKOWMuyIL/Vt1R81iF9/5msAig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zt27+o9+jBOetn4xZwnXHN0rRvhl3PJYJlzbGhZysAy2GlmPqFL6IKZGL+QMXDfff2ZISQU+Kr48i8f5kxV6fHLVw6itYbhfzzedaJBDPm8fciU4pTwR35XDftTPqyPOu6Om+f85qHJHLjKW9MbR1GZ2VkAlQLbkSMbrmhcfJeBBu+h+8BuQxHw9lWZYm2kMX8xefn8OuYNkGlP3GOcZoScQytaq7Upe8cmFp3ftxp1z2qx6uyvUdliP6tDNlf4G/O4dO2OWSlv/1fGcPG/rBOe62XB5YeXJ9gpNP9/5fx/Ajuz8QnQOgruLb4RszMMJMHueSMOKl2cPeTWH1Oikqqps85gjS3ilmoQX8zptKTI9Dbxtt/Of2l4GBG+y/gfmbN6RMJNAxGRo/ZA2+2pEZIPT5NtwATi4zF1rb1rQgV7DBMZhduSsu5L/nOQJOLoJIKDz9RHyS2vstsQnZQNCFxR1FwljAvuLJ17igDQgg5/QjkP2i+JueatOyL6K44WJGjHstoiVpLIz0p4N3qClQwrHviEui3WPFg4sv+ZOd7KPAVTDfXI2sstluCQfejpz8VLD7F71o/4hkTVL+Ii0gJ0SJOnh8ageyXdRBKe4/NdkV2ydKcywaSASaL6rzmb/f4qX7gvL0ujeShAlPk9ChHZi50t1DucVE9XZs7ZwWaClegms9b4OlHbfDtzuRc7Evlxwa8m+OySnxarNK5OxPG2GYJKFlr9dlq9mV6pIu9gJ4I51YdSTOw2mpDDX0+7oTxJc7mVQCbo5kT86G9HIsHA8e1f8M7ZzVvWt90Q2zVs4go3LdSTeCkabgeWx4QYpjipzN7stWnutcQEpW0Ve8+t+2TcXmBnNx7dXXqHfXby70SHkhnTLrMiUQnihOiu2JH8c7HLLQpd9hTtTUpbXvH53aAsvXmwSObKYnyc0MiQeAcAawkkErxMJxQHtV38r3vM8kvhDWlTam0DoNBxgwbBVFfUd55AVVMF/IkdMLOMIqT/0FlP2Be7ivkSwx1foB2WbhtfHCh5YQPJcfAMHybMzJrZ4f9zCNEA+XZ/d6Pjpb4cTNZgP0ElT9SXp4s5SEaesci/AVjSJEP6ijxcIQUnVb2L1xLx6UQq/eCcfz07hzpOT0KUw2/Rw6PQ5rJ4k8P/ukPip2GzqnUnhW3EzRV2tYlExalgCkgZhdyNAWWzHKJ12V8qBTfsYvFe6nPjVDuuGpJLkESB4UG4hU3Bf8XaeOWcuzL5c0tll/0YLDO+nrcLG2HHl2QBFJBNir0XCqNRrCCg0WvuHoNG+auZwCeFOsHkOKzj8++Ku03S4tVOeU8vOvacimhuzVb/Rkfso3rvgZHdgTd2r5IEQuKS7CnVQwO98uo9GK/L/pk0i6zko84yWQ2AxU9DbxpKE4aKN1eGn/EMK1d5K1P7YPrMeBJLjl3v6Gbr11QjsfjFGM49Rz84piR3yp87SXN+Sc8S7+KXWUQ6j1gsBZ0bQ0JH/uael66+OcPsvO2pGkNLnMmnSNGoLYdeUBjoqrhuX1ai2pce1174kclQVtJHodvKHh2QFknBtZbb5ga5MXWO44Pai+r7ayhI/yAW/z6GSpR8iwIqA6tb+jJcoq68hzjyPzg== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4176d1cb-97a1-4048-c9c5-08ddec446a02 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:13.8030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R5Je5BxpgEwsoUCMAEhGxHPCWL0XI2S0aw0RXorPHQkoMP6ClhnKmEti3iPG4iFFYClubFSoEZ7U7qBCgnHz8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17967 From: Stefan Herbrechtsmeier Add a parentdir parameter to pass the destination directory of the submodule parent to the submodule. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index d013a09d6..c3e7189a0 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -127,6 +127,7 @@ class GitSM(Git): url += ";bareclone=1" parentdir = self.destdir(ud, '', d) + url += ";parentdir=%s" % parentdir gitdir = '' if ud.bareclone else '.git' subdir = os.path.join(parentdir, gitdir, 'modules', module) url += ";subdir=%s" % subdir @@ -203,6 +204,9 @@ class GitSM(Git): try: newfetch = Fetch([url], d, cache=False) new_ud = newfetch.ud[url] + parentdir = new_ud.parm['parentdir'] + if not os.path.isabs(parentdir): + parentdir = os.path.join(destdir, parentdir) fulldestdir = self.destdir(new_ud, destdir, d) newfetch.unpack(root=destdir) except Exception as e: @@ -212,10 +216,10 @@ class GitSM(Git): local_path = newfetch.localpath(url) # Correct the submodule references to the local download version... - runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : local_path}, d, workdir=subdestdir) + runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : local_path}, d, workdir=parentdir) if ud.shallow: - runfetchcmd("%(basecmd)s config submodule.%(module)s.shallow true" % {'basecmd': ud.basecmd, 'module': module}, d, workdir=subdestdir) + runfetchcmd("%(basecmd)s config submodule.%(module)s.shallow true" % {'basecmd': ud.basecmd, 'module': module}, d, workdir=parentdir) # Ensure the submodule repository is NOT set to bare, since we're checking it out... try: From patchwork Fri Sep 5 06:20:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787FCCAC580 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from AM0PR02CU008.outbound.protection.outlook.com (AM0PR02CU008.outbound.protection.outlook.com [52.101.72.84]) by mx.groups.io with SMTP id smtpd.web10.14988.1757053280733913428 for ; Thu, 04 Sep 2025 23:21:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=xcAfzWar; spf=pass (domain: weidmueller.com, ip: 52.101.72.84, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=emmmDCgNjck8R7s6lMPlHI9MzIzmJstSlxTP8q/oOtARiLKJx1dg6hNQ5LW+NYuJecbVzClZ29R4odQ/K9I00vae5+4V4yp8pfxU3/KWC6HQ7OifRUAl2Q3vdtrpvTN1xqLp1QNeTblp4zTIPwUe3QjnHk1Xd/dUcEIEk8H7ZS7Qc/xo89ujpRD2xtQl+0rK0bz3hhiKeenMGAFUiflgdoe2DLAxkDk/I2k2MSNVagM5FhLVi4KRkuBk6dkTSpB18tDN/4RWUWUqJgoog/TNy7dxoTF1HM5fiFjljLhYRe8YGR7xLYvAqjjrHWJz1bWsgum47G9EufawaGYBkzHeKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zOUfiewAD+pidFkGZUe+0SvI+qtL0cNBs6yfNrlcMgU=; b=Rruakwj6b90MqNGDUv7S0ihrIxEfm3/geD9kxcTgPJ80hWixttGC7NTG85YOMpbdBbsBSOYwKOca8YjqvscE/Rd8JVgIMYET/pe8kQoIcsTa4gboacSvSsCe88ZU25m3XaFoH0UUSfpHUdHIJgeVrY1+/K50ChL8wDhbQaXhnoL2ZmuzzzEDSAL1eNGcQ2onw5XSXdLmTfUzTyk3EgW+ODVWU2DqHg0xdNID75NIn3RYJIpIdbGLdrAofWFSBzOvClFqZScmB1n8PF6NqLE0CgkfGgbt/tMzBRyIBeMhLBYWzzFbQci5vis/PfBDx2XN3lVqB4PMv4WO8YFRIjX1Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zOUfiewAD+pidFkGZUe+0SvI+qtL0cNBs6yfNrlcMgU=; b=xcAfzWarh4ZK14/2Qa6ZJJbNmwu0p8BnJ3T9adSjh0njEYU7xfDaWDAZGyrwyuAhhFrsF2hCI8LeOoy7oY9bxl6Kg5NSmP8hGIDWVA6lCRIjZcVSEtR21EGCC7XE+UPDDfzU63DB/o+IJ37iTL5/CAljpBVJ7PobkqBDWld2GJcgs9ENxR4H0lNv6avjeOIEiI2q2x07zcM7A2sItbxGGe1dDId6eNFgKQBMd30OvmYyni5PEZLqc1HGllk6EuGEzR4v5jZ+ceH0MJ37viverodl7QyiU2TJQZ9B5XA1O0G4/6zU50Za6at/br8zmr126/n7E1rTtap5OREDDNC0AQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:14 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:14 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 11/15] fetch2: gitsm: handle submodules inside submodule unpack Date: Fri, 5 Sep 2025 08:20:54 +0200 Message-ID: <20250905062058.2563806-12-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: a307240b-72da-4c68-db6b-08ddec446a3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: +DJnU7S91g9yUI3yuY8UKCkCPx3UPypQ6n2Aq4Lj0ETQQo1FXlFz+vtcKjgvx+o3Tc0qNAGNiE7HftXll3TatDp1yVKz3O8eaKdGe8ATJlw0mUL7H1ceV6SPS5q+V4cyvSlXxY6I1IfSG/A8VTxuCeJZaUT95bLnJXZaXO61BYz7XT6iL7zPgL9G6qS+VaQEU07n56y5N3nu8ah83i8flV9WSVm07Dtz8kBgn4oFNLw8MHOpDU4StrUHQol8yqEOvmUA3guxkyGnDDwXk3NceOfPjJTATHC79pl3IZQc3bziLegZ0J/AZOCB3dWcN9EnFYMTbVPDQeC3wEnb/uL0JOmX+/yJmO5xwcVgMLw1IKn68bVOiwuLXWz097MgofgiudB7a4K4osWUe1X+vB+H8NW8P4A4yIGn47krQtIlq/LJqzaXyF0VumR0F50rq7cReQ5awIJ5qkzZpsJk1mKtzlGt0gXWhSCmfLIf9g+hjUioWoRNvA1jBakD+9FfLSNFKj4FvLDFQjlq4GtKI9EmkElaFbCrf+GVK6FfyteMNH0N1QOFUF60K7h6NCeE0ykkiQm7VF7G2zgs/2xOjJ3q6WWDL3x8sAAVB459v5/O+E4z7neDLTKnZgw+Z4fmrDy5VbZ+g6kChfBoiWVGOFVTDjYzum4YpxAnbB7AUDys9a3tZkmnTXahbg2qQbsAMjYtLNn/H7XV47QoUmK6Hu2MGpWzpUF95iO/jqmM/bMECpxO3r4Sy6IEYbKy1EsNtB5qgr/P0FszfgW0/+osP3xN2nGLN9uORFPxscBMbDNztqU4vW9Px72G6v/LRBOdCvMJFf5YEctICsIvUoyLDcxavMYasjYRc4K9xrvApsT2ntJH9Xjvck4A0WN9bHUS/oJuGmapscTAMR6TgM5WfMuJJSENHD4d9s8exOUP0DflKYwtcFp0W8lbKmnVKPquPNaoiYsDv4BbyeiPHT1J6LFtBf0rbeAklfOxz/YDZUlM7x7rBccHi122LgnVt7xAoYDrDDX/ztJSJWhH/4uJ5w1OI0DjO+0aM6D9nE8SXv5GMGECGV+SjF7ySyBzw/cAkkNfzbmjUPUphGL4cK70waSnXSvdb9HixbFmFGQeWFe7cX7y21+0Ng8ZCHCxCi4vMrPmCw5v7AUTIyG5V0G6m0R5RCQW6MnyJbrWk3MEgkZbbZY8klJqT7UoJUDe5HzUsQdu1Tc0EtJ4ZChYVONXYRDdXQGWBSlu+nBOL07Snof7xIEM0a7lqysVtoJUqJvzMHSrje75jbyOZW3jAAfj5Dd23/TFTr3xPMs08xmGAdWhsZm7k4+Dtq+1tb3/LMR/79kjsxK6ZtZgyS7qiO1/Ua4GsNXPlDqKsg8nYZqkpvJ/qdB6fKCkrfSdledz9KPeEZWIk5Uutwcabr9txQa1WtxzV/qsKWa1+6xCwaB45NDh16amn7xZPiLaj479umahYndZveHii1CNUpAIjOFjBsMgsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ApC/l3FyhKAKSdgnE3ARZfnvL/YjbSQUo8bMYwx8mOuW3OmaR7NG7/hMYuzbSAG9GHDlBCKk/7XKCNSzsC6UB+f/aq1JfbinwQoz42mIvWNY8+hMyy0FdlHZCyRoNrJTSx65CeaE1UJcksV15TZ0x0DirPn7DF4De1iRys83rUOaCZMBc+Rb27em/YPQZe0Vcc1L19WSV5ZJE93krb3XTHBubxrfUvfzyG6henxXuaGca0hwLES8dwMT1SCqqKgspHCQ+xUrmUS4XmUZhtLRIqrvdNM9FBMG4Sz0ATROg7QxzJ4upOQ6v3DqKVv3IT2s3hs76j9lsBphYF7buuJsxbsmOEvXHgs5F94pNgfhVDyLDcIg9gs5OMPqCFzvZxlyqBRP30bGmnaMklzn5uefea1M2xbeSYcqgQ15/GZtKxHduhRjc2oM+Hs2213ZPVChBVmlAgBxF2FaABmXm21VMYraYNQ+qYM9Ezqe0j9FcUp7L3EFnlupMdOKmo3w5FhjdCtzXEd04HdLmxw02qb57Acz4GLyQXkISzvAcNgwLao42Dm96eAcysRRonxdGPoyefpnpYB4AI6pVm+N6o1IRbpZNrsCwtvmVg6hD86VQcZimFtKMIEKWHduSSVGljW6UlQmidFlrOOtcwm88peAZBCQY6dhfWVRoQLTW71LwszywcMMOf9isU/vQNW89bPgBAKmQg596N2auN4UZUiCRjkPszpr/SuSHoq4yjBCedVNn+1chDjLJQu8omro4hzZ67slowFvKpiy0ijyzcsksrlQ1n2PWAajYtIFOPYflWtgKiFzWq91RtRTLEzSLfeYetrXU1S2sxP8JJnXSMRN4DphDitVii47+qwdQoXifPQrJoymsV1M+/8fh3Xs0CR4P6m5If3Y1N6MMqO0zj7EHH2l0MkNyGTQbW5kYAd91+z12M4Iv3tUICod0+m+6pxxSJ+bCzZKBcYgaUJ4twM9nBZRi6lWTCy3vLAqyRP3DtT2yklnGPmwjUj/ssw8MCYI3joDKU2A1/c5fOeHjuGcFmgM4p0ous8cVMbQl4JrVwbQzEagkIb3BznSBPxcXGPhi4ihBXD2LbA7DWAkgDQEsNy5T84AqWZmuJNgSY6zq52EfwGRNErQjUdkuZPVfIKdd8R15RLsjO4AfkRQ+35wMpn9/I/pNfXInNRtsa8I+zOqVmMYunQGpQwOFgM7VkZqXnZKCKbxToylFKIoiJWYASee74EVqKJrwbL6x7RgYwnXYy9SERe2pnsEZRiA/VYo2DztPfLk9vIy4/fWb3ML9c0PNnKREFqUpIAGShcZeTyGDWYUgfpnsrVF+YxHdV8S2c6el6raAWZYLkVE60X2+xmX7LGPkCUY/WULLptDcMSVxeOga8wLyr1grsVec5n7MTsj5c+mTjkTO+56grZSMEOkEl8zukIRv7dfrOJfCosbCL045+3Oknkulruavs8P1QsuznOv3TPmJnCkC4Yn3kD3OEMTFAeTZRahA6qQf1xcsKUCE+h9E3Ao27X6aQev1VYCdI0ahNDFbElzPV5itcY8Go/dTcmrIH4Qj9/oaDjfL3piOt2pq7p6Eh7eMsLjPU+XkY7dClcPB7/jql+kyA== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: a307240b-72da-4c68-db6b-08ddec446a3d X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:14.2237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 25WlaKezwcVWqsZcP3dXOQ5VB/LhmD3/R20c6Efgv3sHkP+ZJYZwgb2oz6J6tDIeprkGG3Clb7kprs4hIssx4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17968 From: Stefan Herbrechtsmeier Handle the git submodule setup inside the unpack function of the submodule to simplify the loop. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index c3e7189a0..37f82cd37 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -198,25 +198,28 @@ class GitSM(Git): self.call_process_submodules(ud, d, self.need_update(ud, d), download_submodule) def unpack(self, ud, destdir, d): - subdestdir = self.destdir(ud, destdir, d) + fulldestdir = self.destdir(ud, destdir, d) def unpack_submodules(ud, url, module, modpath, workdir, d): try: newfetch = Fetch([url], d, cache=False) - new_ud = newfetch.ud[url] - parentdir = new_ud.parm['parentdir'] - if not os.path.isabs(parentdir): - parentdir = os.path.join(destdir, parentdir) - fulldestdir = self.destdir(new_ud, destdir, d) newfetch.unpack(root=destdir) except Exception as e: logger.error('gitsm: submodule unpack failed: %s %s' % (type(e).__name__, str(e))) raise - local_path = newfetch.localpath(url) + Git.unpack(self, ud, destdir, d) + + parentdir = ud.parm.get('parentdir') + if parentdir: + module = ud.parm['subpath'] + if not os.path.isabs(parentdir): + parentdir = os.path.join(destdir, parentdir) + + ud.setup_localpath(d) # Correct the submodule references to the local download version... - runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : local_path}, d, workdir=parentdir) + runfetchcmd("%(basecmd)s config submodule.%(module)s.url %(url)s" % {'basecmd': ud.basecmd, 'module': module, 'url' : ud.localpath}, d, workdir=parentdir) if ud.shallow: runfetchcmd("%(basecmd)s config submodule.%(module)s.shallow true" % {'basecmd': ud.basecmd, 'module': module}, d, workdir=parentdir) @@ -228,16 +231,14 @@ class GitSM(Git): logger.error("Unable to set git config core.bare to false for %s" % fulldestdir) raise - Git.unpack(self, ud, destdir, d) - - ret = self.process_submodules(ud, subdestdir, unpack_submodules, d) + ret = self.process_submodules(ud, fulldestdir, unpack_submodules, d) if not ud.bareclone and ret: cmdprefix = "" # Avoid LFS smudging (replacing the LFS pointers with the actual content) when LFS shouldn't be used but git-lfs is installed. if not self._need_lfs(ud): cmdprefix = "GIT_LFS_SKIP_SMUDGE=1 " - runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=subdestdir) + runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=fulldestdir) def clean(self, ud, d): def clean_submodule(ud, url, module, modpath, workdir, d): try: From patchwork Fri Sep 5 06:20:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CCACAC583 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=ND2aqua5; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QbB4McGAHm7ZjlKWn+ETomIucKv7V0c6Sy0G9E/qHUcjnojYVNLfSsFq3nTdyPYG8gKve8zgmYOye+1pbY6fKkKxAj4g4rCnoti7tWQUKddCx/nRyZ3nBl5oIV2uiGUFzKfSaHDPbSmc+4f8fLf2WpUqy1P3PYyB9mp34eKUDiDcIbxnTACsPrZKaom7eWoBK4l5e8TqR8SC8nd24z7gV7EpK0iDWZwOF3FiSGEpbKdFsoU7MFb10/9huoik96ni4nCxoC/XTbj5kGMdrID5ZnZ6ErK1a6D/1NlGsrTNo7edc55C8EmXOQxXesn7Ta5asPNNbk//XM/neruUfX+l9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JQdp+YGgCowzGkp093QgL5rYpiwzFykoLf3cxs4jELA=; b=yuWHLM9pwQ4q+wFOa9rOZjHsGxS4HKnucFQiOQoMPPOF4bFmqsb0StLp/1j6fp3wyIm8lHAc2ZbQyO8tH4xqw88Q2WMrJhcbA7B04VcqR2tgJz067Cae7/TLlF8bfiXHgxQLyeCYUjKfWgiz3D5fLSl4FzecbbqbTRPbSwBdQp4Wf56lMZIf2Ju7xcTrH440ElmezirLn1DW0hrfLXh+guidHjqGEfJVlplwTlc7iw2FQL+4BRptDzrLCHXSGpZXhPXIk9fXpf5wH7qgt9n4/YmsS2SmTRpWX+4ACzuNrb+cPQD+uFRvODxUhrXPWgBLb4LBPwmJtjvkwVm1Bh2RGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQdp+YGgCowzGkp093QgL5rYpiwzFykoLf3cxs4jELA=; b=ND2aqua5wY/yji6Q6agyXlok5fgOnzxwr6EJ13rRf9oIpBg+JdEJMgCS0vaIJq2DPOV7pp8q3sa+3OKfpNV77eCbHHT6korevNASOkf+JRyVaX4/Es0HU6gPvLXL8RqRaJJ+PCyEyuWUhkWtbtjZ58Nz7LBhaF1Tt10EVrHU8WK75YTrtaKWNDFmCGHamDVMU+oOJzSf4EOxoGkZBaEHuDzQ89uozRKI6ZyCTZXOUMGUGcJ8IN1MrIAx28bIHtd+ZHfIjTQ7v4WI5eLsVpaMuysfy9qF59RGZZiTIu+ydKgdGjAVBylHecpc4rb/bR5Y56URHOpq39spvsVPDCCyZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:15 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:14 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 12/15] fetch2: gitsm: remove redundant check Date: Fri, 5 Sep 2025 08:20:55 +0200 Message-ID: <20250905062058.2563806-13-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a775ca5-dc18-4777-fa6a-08ddec446a7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: tDpkGhbhAgkUfoKLovoLgyVT8dC9MWkAKsGlSSAaM6gM5OsG7oR9SVa2K5QP+hN+26Ywoc606yeKo069IoWhAQ+tataHqD0gGnjIpFEMbi8kISSkSTEJtZN6hI14ya6mHtUxCP+9meDRrDcwJxUAXmQ0AT//HkEhO/4RBh8IGGM4gLb62MOMcClsTwSDb42eOxr8G5FNW12lVXCT3gxr9s7MbRwh4A6SBFcf6oxkvcJXbRlRlw9RDCHAPvwoMeLZuecSpJqOaIcG8899N0TltSNZ/oA4QweNiRqXEaAXFZWg19Sm8KOztYnliXTWEtGNahGM4hjxXH5F/iCZlLlfSePIsV3NaQQkix0rV7g1so+VVVhBhU28jJ/QH5bjYumaNoxzqKcjBLZitGResKQfInv2cwiVyy/XT54mpJXHb12MRPelvfcXq0kc7lHKHDMqBsEGzAOPlfrBssv3JmpSBWKGZp4B+2BEByaRM4tnvCbyO9XF2faMXzvTSR8683ZfUnDbUFoGmW20V3sH1kQN4LgC3x27n7QDE+T2iA/0u43e+aaTvH6Xq/t49iPsJDjkzM9bA5+n66iDFDSHi3/4yo+n0IyVqpjl/7RoVAa7gJrIGlp3EvkaArLpe19rYMu/eVWjZwG56FLtJdrVZ01OVg0dXM4jQnCsaqAvC7patTRe7Ro6XywTaizcpcfK5S5rtxEEgBw6TcXGoSzOQsSz9ncHri2HchH8kjOSJcGE8YglyeaRrNQH//bqhVquI3wSQTB8DioPlVP6vYD9oQsyESambXkuBgexPxsZhjZ7sdSha4lESBB/YnA09qhIl5ZpbRHWAaKwxVn0zxNzhamp8Ar9HVEkV/fwf6eq+rUgq4/ARFUmS8tU9r3NbKqin9UnSrZ57zYzMC/sUdwJCAosDsE7mi/kszc0+1jUDqWYlHW8uuJd+T4ytjKijZ/ImvaGKo6Jo2nATOwc9bKFjpoOZHJ6XoaqjHbpUsJ1y4gn3unaQ/oOFvd56iIun7005YC1a1ACMT8r5a81KkoRXIBmaTTwjq8a9O+i9MqPTHco/ydDQxw381bnUW9ThlYh++to7v1TelreU8ArPTFo8JU0dMjK1Dkho0nzx7XX+A/ETi0p9tNxuSqNpl/9Ed8z5bVqRHU9PY4jErsVfKCUyyKZafWrutgngRMaxMly/wevqJgIKHT2KABVGtCc6ca9IT4hDKrAbZNKkvpWFSjkGjrW2YSwLqVP4n+CIGI/F7kUCGOxxpDyiui0L6H0OViT0PjFANnjThjH3Xs00q2ZaO+kOIEtQzYCWbB6G+2QmsyuslZ8XDX7k5BUFNrUPun2jB9vUWFr5qhWos3ghQL+0Ts3Q90pFFCR9tBKOgZZxVrB4Mmm+RhduStnS1TM3Z3S+v5FjYBe7UcNArrHSRW7RlLSCTmgLIthLbpoVrJSgdCsSqBOc+UPfiFNk8QGlfly3qHT+/wEXVaOruRGCJI0ykLhZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cYN+tUeM++ZZ3JCxbQhFpZ9TrUkK8to15cdEwZPI+h2OQDZw+2rgLgorZITVWa0e1AP7wCP+AIOM3EOrJshazp+SizzrZetMECnl4B8aSTLlbzsTofKIPQmCt7GJNqbb7usflp0rWJ1vl9OTSpV4++6Z7b04U0YKqGu2zHpkyrvu00OlnK/G3CxpeYDZLVD1Ors8zhDiWRBrIbZ1mIeTzpnIEEmfsaWTBUzZJFBSnUCulQy3aDLIKvy8NA6gVhSYeIo/tSWEZTjE4CMnhP/u//erlkVJXiozWavMuXqhts1JJ1wvnI26cUzWlS0/JwlU/oIqJAVJ8GubRNa3trr8CdhvtSyjo7rm2ZVo/wj7ibjrnxXB/woCLjXeD70SRsNlG6Vj2SRNcvxeu3NiatKc+fSSzPzzP/1X5RrREGYn8qZqPFLSJPgh2kVX1TRo0cIEJZq8O3LN7y9bgqQ0loy7J58mr8SLtHnXjnxHpDXkmcr+9Ou91GsezghBs1uQ5JY3mkJ4aZFtEdsAQNtk+EQXDshWXZytmmaytJKKeP6qvwnIOx/t1H2qU14rmjhnkDGJJH/NOJzs5AItiyWmdhSEWTndL6OsqYpcos7lJJ07DIwo91As+chpFGJyPf5845LLppYd/HF8kk48QMvb9qpBD/6mqH/lTVIu/jBolXNKRiJQllzxVrfVV7U/evO095v33ACs2bDiXZTqyA5ctehem5N0I4ia+ui1SqPZKw6mGD+tiNJPur2u74CBEShGul6SvoelP8YUkl+tXPh6OB0FaA7tNB1z+N9RC2jhHEUQMpjYX0tuqx0VdHGczaWaEaRP/5GeM75SdhrALR3tz95Oez7euPBIEQStUIlRmEAh8hfHvZEYNKuTlYDmrS8hRpKpvCUPhE3jXD9cK8UcEj3Cpom43luzony9ftHlV2bI73pVXrHRguJyzX9VhODQDPUIBWUumLx6mYpU7jh4KItAFf8Ww1PGMFeFIo1SGyDKMAc5WIETy4IEwt3glW0H5S9x+3Q/gAaHefnyGdWy1d+e21j1uxrSYkRc6zEy4zUeHSWJgQXVTGfWpCZN2A9Ydi948X+EexC3NO/Y+PJUNCyaeayg9Uo3CTr04KMFe0LwrIayRL78UztCODwRKI5Tp74aJg2eMPPp86mTki9WF0hScGHXzgaw17wwI8gpW7RLA1Tf/Brd0t9W8PoXjvBSkhxVzgKUg4lLcT0U2XZVd5aqvfPN6BXhhkWse6ENuJ1YFEQjXlXVOLLK3VLldVCYOEe6DA/a8rpyax8mYWbBqDDFDmoiBKLQDGqnPrr67qSWhVnLueGNO4fsySlOs4uNs+hKC0nzPROim8xiSodG3hvaco+Tt1s0zFYFLsIM+Am319dRR6L8WVKB6/a3HJegyowIUnJhWlQMwJkWHRKev8HZ4FJraK5sNMAWutxubosSZl0jOt7sNCu/4GK5C7cQdeI4YNLnnuBDTtLsVliL1DTEgkxLnhd1fuw9BTPrjibgodPmvtPZy5vc+qjbdjb27Ex2WKVn+nrS9B+PnvC4l2Fg7q6e6mI2cBi9VuBf5l8hcmL5TmggzIJHIpyDfRNgbty2DCdGIvwnY8JVKKecKXbpqw== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a775ca5-dc18-4777-fa6a-08ddec446a7d X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:14.7067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NzHBUO9KYrAf71+SorAOYe95J7vJ4qLyC1z8FvU5ybn5iR3CaiyyKyx5TlUyMrtq8VYM/tWXfFSmeGeCRoAeFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17969 From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 37f82cd37..9afdc8370 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -174,7 +174,7 @@ class GitSM(Git): logger.error('gitsm: submodule update check failed: %s %s' % (type(e).__name__, str(e))) need_update_result = True - self.call_process_submodules(ud, d, not os.path.exists(ud.clonedir), need_update_submodule) + self.call_process_submodules(ud, d, True, need_update_submodule) if need_update_list: logger.debug('gitsm: Submodules requiring update: %s' % (' '.join(need_update_list))) From patchwork Fri Sep 5 06:20:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69720 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC18CAC584 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from AM0PR02CU008.outbound.protection.outlook.com (AM0PR02CU008.outbound.protection.outlook.com [52.101.72.84]) by mx.groups.io with SMTP id smtpd.web10.14988.1757053280733913428 for ; Thu, 04 Sep 2025 23:21:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=u4oF/xkW; spf=pass (domain: weidmueller.com, ip: 52.101.72.84, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XUFF826d8snpvsjdYgt3iKs4wkB/rH5vkascer8ZIRNQsUAfDMa8ADlWgKheI2rnkS+g4EAvpCGKnCogQu1+Q6OCuPIYWTpuzaWwGr3+07+z7VDLEDY6QB25XyR9lk34ZoePqrmcy7K36cysORCd02Q0hWyxymC7Bpi5crZH3Bi04KYYQsv2HTxWvrJ+M27FNn8BVyuwO8KwBUDbwhPNPFzqVNnNhJWwvpXnxftpfrXC3sLV7H/7RiFZlxwSstKSCL0MBK2Q0d0cVbDsz59wyF2Xt1v/UzK8SZoiNixYTaI9+bwRSDtKlT9+AZde2t3BAU50njWVUPTebZywr9G50w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1aRqpEakDOUppHJG2UqbRXwPk+fOBmNyOOHP7eGaEOw=; b=MjM+UKYtki81tT744y5U1dkSxS5iucvXy5nHtxmLkEq7f/lgDk51MYeKvycpEXHOdrCGc/45jh6i6ltwDszN7zqaoe/LFLGegqVbJGp4qtGO2wZwNoFI0qgmSWJQDXdqvaXXJ8ClckjaRjWKx209GlRs5M6jL69SJkdEqvocHh0J5TPY1ewUlHWhv5Z+MIRPLoLvA3C6nGUsCYVpxSbj1y6YDZ0B/aFo3e/zTNjqGr26j55gReFY5KqvLjjsY6tPiOo++FeGc8QQGWlaeRC+PRPuiIuhVpo2eM7hrI8EuRz+56U4NVtgvrmrDvjbKv7n4UgqtFVNZUPjAxm1mRewTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1aRqpEakDOUppHJG2UqbRXwPk+fOBmNyOOHP7eGaEOw=; b=u4oF/xkW1isZ3RodU2SoPUuVDEBhPatYIZA95MKTZmkd5AF6uvTDDZYdp23QMNLAvRpBmOzPAvtQ2q7jodTx4CGIShQPVlwfD4XMZRCaJF5bPAAOEoq9b+hTFMJhA7R4+wDFCcRI5CldxHH9p4CJUHzhLhBlqcgrLDVoDZDDiO5aYV3nr0uGpcpJUEmtdnhiN5JhD7yrel51KDW/2oekfc0FSvTuNuVrspSozDfq3xN7VJCy4xhcUZbAKmTKQCXm8iHqkKi9g3PK2bjqtDPcwpzhqUJi/N/+rFA1kyy4PNFCIBrHCmNgndWRgN/w2H9IOm4mq3FeR9S4YkVQolvKeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:15 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:15 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 13/15] fetch2: gitsm: remove useless need_update check Date: Fri, 5 Sep 2025 08:20:56 +0200 Message-ID: <20250905062058.2563806-14-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: ff25cc81-6e82-47e0-82f4-08ddec446ac6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: nL8Ich3LtVOyCcR8ilXWgL+Jw5qAY8Z+TpkjEHJL/2TUBAybtumBGxqkSb1SVKMiGXv4UI1bCV4tEhQQ+ohwx0n3Z1xlwwH7Jbi47XdGiOAjoguolbJxBoF42DrIhrF42NfGBLzrzMfpZ1rHGitGxKDh4eYy+vV4ATYl00LCeOdRvIdPSFBPvwHZd94lm8uHIkzH8guAdWYhgbIGPuvlrYCyFfdkE0/KfrYbYQ24jqO4T9Kfd/Pr19BfmWlgvdDk3NmCh6RparUJCwpACEgNVLhz+kXzWFri+KH9PGWbBdzPmLfxjrThh9UoQmw4RY0Kk27d7J81pzZRV0eIYLbEXk7DhZgwot58s2a7+6ncu0Xy78DGfHWq6f30pNU+h7dyxPLMdn87cTmo0OZYDGDTSt5CXACJNvD+nmzVKpMJWbPj1MGDmRQasWqIC36mEoVh8n0yPNb9BasRb++aVafvYX7puvNb4Lei4tv/GjBX4YKe1LUKyR4CFuTb1cuezT1r4Z4pvn+0M0DHgKi3neGf1Mq02733FyiMsERDs1Ddc89Xe8LlTjJPRVmiEFd+Ze5ZKnoUHsAJAR4JLpL0gUgul67vBl18kicKw3U5y4B/2Xo+Yznbof8FO1CGffuazvo9fCamRoGCxFlfdwxDiQcZSEmkWyUZRWZ27YjuczzEIYHvpgIgswpbZXSlQRD7iT5eQc1k/8BdRQ4QVBIHhaAm0g3WWfMlpMwRxcl1FVnxVQKc1UZC4X8rj1QtXuCkr2kwokI9TQjXkTRrrXihctM9tLbKWpjEkdHs6FshmzYyT2EaJFfTByW+uC/1FadEd1byflP7ZxlCT4zv1mDDM0nfNj9SlU5wbcEjt9DQtPpzR937ET0gB7t3P4VOZP/hI1NADHnEqJ/xYr7urHqsjUben/6YyJBxsid3pZX/eftliKwPHjuxJy7QfMQcsn4KG4ieFuK5DnlJR6Roz09RN2M+fwqZJIYWEeec3VicbLuPHzjyzhZ4No7xNE0Bt3OX62GS1g3xWZEKNdXmjIs+3NRWrboyrnlwHbllBbLrvIgfp4AQ1uq5Kmr3e3JDP5m8PN3B+m4u9ZJhPcpvnPJHBG23Lg0PLJQmBgO+HwKPzVMydeQ/kOjyu3sfis4T7gZ9HxYOzd6ojZ3pwJuY4k23aBE/sSLRWlKxaWsJY2ia6ZtqRlePepX6zzk+TC08xCz69s01HqSFUiy6DrJ2vTsRwXEQuAwvXNS44yHosjUk/W1iDVDJvDm9WfWIiVvkP0HTpv/JyoprEjpnFbO2AiRG6HAj5DbNHaboL6BZ5FinegHF3lEUG4SoQeMpYx+BwLRVgATMFOo6oB+dklslI/J+ZVDM+epbescjLkzBCzT3CKhE/8acdxkHn/cRRQfnciZQZvAW9eqi/64NMJFl+QBnCN6hGhIsPz/i3nNWiAKaSPG0/E4nTIbiuXWNprV9vrx3FAyklggr8vVP78LRg4RzGMI5yQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5CO+IeUiDTnkMrcGlFiBt10GAvQ61MKiC1waWjppjSKDp201vKcnjGgyYWB7Nsi7ETh/pEGH8DgEp5W1XvuQbDgTUwSf48jmj7UN3LA5PAqdHwJJc/bo+Om0q7Ouw/ASinEw06jbe8w7T/aYr+11o6SbuLrhHhNx5FJjoWd7ijv6qe4lIWieFDVkxku7oCbrXsGglhFRfbwnmHean9ngQCVE54BLOAGrJgyx54PGU+/ecyfcw+FO9NCw4uN9NBdmamosH8AzuYNEW1aojjPys1arJRqLBKU/k435l/9vZigvMxEbv2xbT+UhGbKqmdgfm+0T36pBMAMbAozVkxydr545K2Ojwdm5FURmg6deLvhIgj6ZzYnrGuZre6tK+6phWmjVu/ZzEFe7IVueIF4LL4LDsPJgDOErGFWMGdaNuiCOw6rbDMjwpXnQrfCAqHNqxejTMI6SDFYoAxj/4qwqYmJX6eMjrIEX7gryNFZNgnNaJsD8Wr4ej2tdZHZ9xXXw4waipsEzyLb+t6bpvqPDTw1l+RtRPZmX1od0NFA1xHP9T80kfuR+CTrIcqtCgo6GR2XAnbUrOdxs+Y8vPOtj5366zCOhs+QZ57zUI8UgoDWVy6hD4l9fPvXvrGWi60Abc2MOOfyLh+9U5eV2SwM5hc96ys5/9ZKFvERzRpGFdgHzmfEEfLbdTQZpX6h9aSVFHGOrKSdRhEnDavdM/3qoUApVUEA+RrqKxC9E4qKYuRqiJXEcxWbWluntxQsazR+vkj5hbcdyu/27WayYmvW0C/avAgk+LIwkICK7PJbnMFUYwlIcEFXATpXWrpFUbTXfsoyql5DEQ2uaNWHpIu5QOdHA0cFGWEcJTCeUioNPtqdV/gQYyMVfEonVAOT7sgEKNSGS747qIklL3ozmvdyHRC6roA9CzHRGa0oiN40hr/qx8nBjCEhxRl2wBl92e2f9gygr/8BoA+DkmA/FaoTlsnQ+hrbD6+kNkcYojNXm2FziXsGIvQnoOFum6KG5e0N0BUO8Co+lkehWZ9FnliU3T0x0+ZYS21ru2mODRnuUcrcf4F69pcLhFZnxnMD7kDZuaIbKFjfTTJ6ZFZPppnnAW+QohPTc3BaT4aOTQxJd1QurbI9CuOXtCdPdLziTsfMwkyMFJmQME8tD70GudwxnA6cQ78z//88VDloc4j6E9uuFRd7VdcRUaPDiNGVib8Ew13NP4a8LSYP7tqrAycXheKWqc/MBRAPhbWQjNHsMIDjbNRcWJut/4lE6p7CdNAYA1yclU7Fot8M86SlLGvFMsotdOY57sOxIB0b1G5swVfEnhRP0mcWgN9McJL49DsAwrNbfwxTtVpVRJQNeAENglCByNYiqG48ZnNPfsAwTf6P+yKeh/LTEDqcoFQJ2XPBrspQEvkL83bNCpm/UycwYX+r2/t9QliaVvZhIUxVHYbe51SKwvILnyLpxHdQqziEd1ImZ3HPNXEQQvMsMqNasjppkO/savywOU5aNQrpPKEFSNvjwR2ArhEJg3knBI6WBp86JB0XsfGCV6ZktXf04TX3Z1UcdmDD35pT0JQPCwE6J44AUefG6r3hE8IOB8awp+MI5oXGEgzoYs5YT17mAaQ== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff25cc81-6e82-47e0-82f4-08ddec446ac6 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:15.0948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 58gj7uZOGwkAp12mvvN15yiabLNrRgeSd0zIXDpJfb0vl75Cupj90brbhHQVkHp/AIm3aN5ZrGBP5V3/qDVpaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17970 From: Stefan Herbrechtsmeier The need_update check is useless to decide if the clone directory or temporary directory should be used to parse the submodules. If the git repository needs an update, it does not help to unpack the git archive and use it instead of the clone directory. Furthermore, it is useless to call the function of the class itself because it bypasses the check itself. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 9afdc8370..31460b19e 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -143,13 +143,14 @@ class GitSM(Git): return submodules != [] - def call_process_submodules(self, ud, d, extra_check, subfunc): + def call_process_submodules(self, ud, d, subfunc): # If we're using a shallow mirror tarball it needs to be # unpacked temporarily so that we can examine the .gitmodules file # Unpack even when ud.clonedir is not available, # which may occur during a fast shallow clone - unpack = extra_check or not os.path.exists(ud.clonedir) - if ud.shallow and os.path.exists(ud.fullshallow) and unpack: + if os.path.exists(ud.clonedir): + self.process_submodules(ud, ud.clonedir, subfunc, d) + elif ud.shallow and os.path.exists(ud.fullshallow): tmpdir = tempfile.mkdtemp(dir=d.getVar("DL_DIR")) try: runfetchcmd("tar -xzf %s" % ud.fullshallow, d, workdir=tmpdir) @@ -157,7 +158,7 @@ class GitSM(Git): finally: shutil.rmtree(tmpdir) else: - self.process_submodules(ud, ud.clonedir, subfunc, d) + raise bb.fetch2.FetchError("Submodule source not available.") def need_update(self, ud, d): if Git.need_update(self, ud, d): @@ -174,7 +175,7 @@ class GitSM(Git): logger.error('gitsm: submodule update check failed: %s %s' % (type(e).__name__, str(e))) need_update_result = True - self.call_process_submodules(ud, d, True, need_update_submodule) + self.call_process_submodules(ud, d, need_update_submodule) if need_update_list: logger.debug('gitsm: Submodules requiring update: %s' % (' '.join(need_update_list))) @@ -195,7 +196,7 @@ class GitSM(Git): raise Git.download(self, ud, d) - self.call_process_submodules(ud, d, self.need_update(ud, d), download_submodule) + self.call_process_submodules(ud, d, download_submodule) def unpack(self, ud, destdir, d): fulldestdir = self.destdir(ud, destdir, d) @@ -247,7 +248,7 @@ class GitSM(Git): except Exception as e: logger.warning('gitsm: submodule clean failed: %s %s' % (type(e).__name__, str(e))) - self.call_process_submodules(ud, d, True, clean_submodule) + self.call_process_submodules(ud, d, clean_submodule) # Clean top git dir Git.clean(self, ud, d) @@ -260,6 +261,6 @@ class GitSM(Git): newfetch = Fetch([url], d, cache=False) urldata.extend(newfetch.expanded_urldata()) - self.call_process_submodules(ud, d, ud.method.need_update(ud, d), add_submodule) + self.call_process_submodules(ud, d, add_submodule) return urldata From patchwork Fri Sep 5 06:20:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69718 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92538CAC585 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from OSPPR02CU001.outbound.protection.outlook.com (OSPPR02CU001.outbound.protection.outlook.com [40.107.159.75]) by mx.groups.io with SMTP id smtpd.web11.14988.1757053273963266587 for ; Thu, 04 Sep 2025 23:21:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=VnublnBi; spf=pass (domain: weidmueller.com, ip: 40.107.159.75, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mynna1MNNoOYGZXXc9xMWODCpNc5gAPpNxG9fz/DOamTQ2c73ilnYUoE4PYVcLFyCILqRidB+NJd6Km1RfQBJDzxme+devR0fZPAkfyLF8gm80h7VoAONKdLjFKlbEFRcuWU/GqvjES2hk0mvD3qSG1Y7w0uVTKioz7+yJ8iAfOBRkSUpPBtIfqIU6uT05p5NNHj/m71rDRS9r7S85Dia+ugvAjFhFmqD8ounhHm906mxbZufzuzgI9brlF9hHBO58t1CXBmYxWbB+5p2ynG6jHgg3JtnK63RoE+ZblEgqYqFEC+jIV0Bwh/OHdwUlkyHcn4cvpEb2bNRPhALdUYaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KTFZjRz2Zi8ePd1sxhacyPK9eStitM9OedNmfyn1gTo=; b=Qbhjm+se613pwizG8vOI41kd7uA1hIU9Ap7UFAkBROHrfLMGIMquXB6PKZOggfN3956KGBS95wdKHur+kyDDRXyrx5i/Ciqo49ec5au3T+IEqabWcwXFqINp/V4ubq40p2f2ptKZV5+Ym0mH6vAg2afiW32j82wISICeDsD6bO8PVFEu0GQ05lJfsNnUlbbM0+D14/WUWEAKssQlBnF7enLXmW0NdSb1Z8Re72qrMfof8IUNNbpMENjwvoQ9G6ECN/ilSOEpJpLMy3GrmPLuNSQZfkqFMGM8KwL4RObpJkpcWsdOGV/hUEeJxC7OsJN+kV3mSvho8ebDF2xMnKojfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTFZjRz2Zi8ePd1sxhacyPK9eStitM9OedNmfyn1gTo=; b=VnublnBiDM3nhygYKiZYrCYGXwQprrzGDryqPx7u4JljRGgoFZp97P8JR2WPQ+pxTa54k2fJX/8JyHiVnurOjZXmoYYFhMaBZBa+5XLLlX7Q1Hb1qI1SOraFo2sj//Fstp/d1l9eUGtGoUEhvzKI27pl6IVP7gOCBcV0On+1/n0JyZf0p/6ICwjJEoKwqoTFaUtxgCxFJ+NcTkANvecV9KXBQFiSIylz/UvWX0muApC9Awdzhf/Na2Z31MN1jFRrQQjVUAu3LCf6cqo0UCuyVfsUhhRBw4rKcv/eFsVVTOiqfX44Y0o7G8eqLRQ8QRtttbEB1PWLoNUF+NyBMGYCkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:15 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:15 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 14/15] fetch2: gitsm: use TemporaryDirectory instead of mkdtemp Date: Fri, 5 Sep 2025 08:20:57 +0200 Message-ID: <20250905062058.2563806-15-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 431b8f6e-4812-4da3-688f-08ddec446b07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: VpIBP3OD5YjBpDIQ9lS8x1xWL06MjALRw87YCk+6vf0krrImw5jOHmmD750zsN+F3I4ALcFha6SvoLDsrPuG+7cXK4J5J6uEhDXva2a6u7Tk8rStVijgk5ZTxjn/H+YKkx1thBZm8CA+fNiCdOc0jHeWW6OCU+obzHQJzwNasIyp0v7WHz3wv39psIE82ZqFTW9xZ39NQspByzpVc/tmNTZQvACj2rJWyKn8BqHmLrkPQ7jeDPYr8RtTGsy5fX4ymT5BiivRYEZ5mKvYn2oJL98UnXZ7GLthq2LbYV/Sxt7KnFmBC2IScxdOlRDCe9kPFqxSolFtFQiCn64JRhSBlwTAyZvS1am4CvRJd6PcEAb9I+8fVLlcCApqKZJ82AZlKcoAuKPV6VrfN1QD8aSToT+q93u3HyjwQZyefwUSG0/FSpiHTJ6nPAKZrqV8G2AZUUeKf2OPahsXSL1rZI2oImovZ8JTb/Uyn0P8PvSrrQqEhT8gRLaJYbiTiL8VMU7svmdLjoYb6qEnkZ0esnHM0VoLv7F8ftg8F18OV27iT7O7i2fYDLp+hDphgT3PPclG9ws5XCk2gCCj1Eva6CN+VnWYBBQpykJxJL5Pi4hAGJx23JmCtdm1x123O+mM3UvNLuyI4hp4zhvduexdlm9AuDdDFeZgk4yTmLnqOeX2dFBzWN2FYa1XBC6CD6Y0jD/xmNFhs9MUcDKpap/bM3237lVG7GKNhzDM4SUpJgdPCOmsdq76iPymSgmpHugxQ7cELbqXGQvHnoopgCJDaLbH6NhGLNb66XEABHEj0erqb8baFpPFoU9yMZErLDRpsoAI9PUMgkuW8of6dKPNDtQR7BkuTniCenfPXaHpF568j9FzLKbMqDrnWhwD7hvwO1853j9e+0zd0H0USE28HfTUqERi6tOQPFOw1mw8XOQdiJoEc4NMW+xt8gwQy7jidwWP7u3jFqtLneR7JOb3/uWtMkt4+lSh48DBLeVR3oQKSTZqVtHgmC15O0PVWTiCQqFSkQ1wqY+kmwuMf1JKqTKCTwZ0OMVFB8N06fxRYoBX+R3rrEHv8E7+JSEhac3tM6u+8MWL2t6HcrPp66vNWnxR+x43DNxr7/0kVsYk3cc/bBLfA0l6em2rRorHZ/iW/eHAjGp/YODTOwequOY1Co02Pgu3/TjRGk6HnPsG/y8UwCPAwjJttB8D/IidLXOtWIz14ay9Ks6Vi6SKguu+25dOyhMUxwAm12eoOcud1VC4kPBVp5Q/mbMcMW9/QIUFmx00/xpm+y8remn05Eq36mD6EXfAX5783EIbP7uOt4B2zylU3LSklHVYuSs6FVp+/f5fCWsrRto/9RT8uQdTfNzKPrjkP2biJIiwibKshztc56bGQdMaFEPhsb4ovKwpQWpAFVPZIXTBUcaN8a8Bk+OX+oZFj9alnyyjXlIfrZ/7nyWOPnvgm6fLAJ01AOmTEKIspLsSiK9I5pi7EV+kO7Qikg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KrS9lYm9tkkaRkMwiSfc22msLVnpSuCabP17WoC4kKwnyOBnRSK8KpJQVPsvQ8bVTdRoJ0sc6/l782Zmprk6b63JOBAkvBC/IDuG/lmbh+/rmG0aT2BtcddzMsnt4WtjVltLr22vUfK62ufu07Au7TQIgtUCwU+pZJ8UrYRxr/xWBIFHhkIR/FCeTBN+dsJss1rE41JsaAUvWCWdS5l0pvd4+0DpwHrHaxmkX7FjUyufPsimZwBVfEhDvlL4ExEevIJAeGzUilvasiNUBPjezvoKKr/aadZ3UPUnWAATbwdW5KQVfdTgdTwA5FwgZotUuaQvHaiWEz7ukX+qLakTw3ELrPOK7y7uV3mDK5BlMGntCIYF/gNAJDKXkSmHDAU25bxlVxVLq0/ylWegwe5+LPEDJnWuHWcnsti9zwYNjMSxwhfT89XgBHnKj5sthJTOSLaXLom1IPmH7hrhgUu0940KeUW04kiHMw1222T8b5V3Ildg4wCGUePwqECtQRn7ZXgUXd33DNs8twDRw9cLyit1MWdjFVrIztNxAkzcaYaz38VNKqsLDvujbztK14GtzU4lkmL6/H6V2U51nR8EeR2NtwT1KJXoZJeCassau8Rn0kjpIcp3Ya4edbnDb38FFfs6IkvvuAyFsPsN8bYhIju5Jz65yfuBPtAQr2CxTSSIeIw/EHnSU9jYkITiZBpuRQCEMYN/HdqMK2pUW0iZRF1EJWP6YK6Q0FXbUIpXYyTXVtfGNyeYmxD6j55AIib/JBJxMAUxl0h5TKKEtQaxkj76/y+OmtDe1KZ3XfJWmJDjNRDqS9zA0C3p7elckYALATLWoTlkZcjlJboBk4+Jjoxh5B7oiDJPLpyTRwWtV9iouUe2ug2HPQUr0DAKiiGAIr/Y2F6XziI2iCBJUkfCRaHw34vU55BokH0djY8V4Er6+/xu6iXHiYxp3CnkSVdy2FcoiyWzc5iIUUZN2loLM0RoZRRoW6igoOeWmR5mzbzz6AEgCTcV/K6b9Xn6vFxQsTw52CA3h1KUimchG7yNkUwMrG6XFPAXUCxLLtZHZ+4U3ZxBOFJrxOaMbNtKi/TB/tPu2wLhJZp9mWrJ3plPG38kzF6FJ5qOQr1EVCzX0vUsNr7FF0lFG7XgNZb7bSGrzXH7zFUEdIFWUurMV1Z/YahoF54VEZjEH4Oq/ULz/5yXRvIy/QL+xQMiOjopMYr5m6FDIhx4CjKY0MJwzYn3DW3qSVo6B7a58KZCzhBalrxVfmFRjmYahIsiJZTvuuERF1HWqUZNkjjLshblZrBkmuRiivLfVqSvCfyPWaVMGqLjArGJxZEau3UAybS1SXK98SI1633I7b+cYg9TMjFZcJCLcFPmqR/qbGbphiopPP6v1QgWMUtHzyrHnKHQayHGx9jFhOBfp8n4WzuiWeBmDlLVi3eXl0uAGn3zIXOZibiXW0jkto9UXf2LToAA6LH0q8CbtcPkj2flcoz7EkG3+PR0Lwp98i9mLkpqqdtmUaZlmmmi2h9qbWH7RenXYndwBRaghLi++mAYClrkciRdzi243VKCYJrJt0KU0Ie7M/3o25Hf8bgGFDESygbvIfIyO+W8Ak9GGoDObaUqHneJSA== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 431b8f6e-4812-4da3-688f-08ddec446b07 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:15.5822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yodhoF/u2qWqPOOWzckJBMeN02pUjcwzyK6F3G9wvPYlPZAXnCi+9uTvSJmmlxln4Sz9Tj4goGo1gHHavxIkyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17971 From: Stefan Herbrechtsmeier Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 31460b19e..4b6c88baa 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -20,7 +20,6 @@ NOTE: Switching a SRC_URI from "git://" to "gitsm://" requires a clean of your r import os import bb import copy -import shutil import tempfile from bb.fetch2.git import Git from bb.fetch2 import runfetchcmd @@ -151,12 +150,9 @@ class GitSM(Git): if os.path.exists(ud.clonedir): self.process_submodules(ud, ud.clonedir, subfunc, d) elif ud.shallow and os.path.exists(ud.fullshallow): - tmpdir = tempfile.mkdtemp(dir=d.getVar("DL_DIR")) - try: + with tempfile.TemporaryDirectory(dir=d.getVar("DL_DIR")) as tmpdir: runfetchcmd("tar -xzf %s" % ud.fullshallow, d, workdir=tmpdir) self.process_submodules(ud, tmpdir, subfunc, d) - finally: - shutil.rmtree(tmpdir) else: raise bb.fetch2.FetchError("Submodule source not available.") From patchwork Fri Sep 5 06:20:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B162CA1015 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from AM0PR02CU008.outbound.protection.outlook.com (AM0PR02CU008.outbound.protection.outlook.com [52.101.72.84]) by mx.groups.io with SMTP id smtpd.web10.14988.1757053280733913428 for ; Thu, 04 Sep 2025 23:21:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=1UvhUee4; spf=pass (domain: weidmueller.com, ip: 52.101.72.84, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g84yOtDmtl0xpjb/CHSepV4Ws2A4Fd94dYNaw6mGazorD3vcAffkysPYLmGekGrB3M7xek8MMVemmfuCTgakbcMvWo95h6SGinzrwpdo3VJFW0kuEpcI1bocQ/6i6ec5UYmS+bgz9P1bPO2UO95h7OKErJN9mvQP+AoU1tOqS7Tu57Eke73vOPMAH3Cf/E0XLVvzi89/sxWFIbb0YKnz4kvAVHrcTkRVG7hlN1rLW0VYZykDI/GikxBdV7tcuZ91wYSIHZN19ZpV1UiQWPWeOxtzZ6kVnhNu9+rGqTRcIbzup9Z3MhVMQd/Kov8tj/on1q/xxETZFX0HtPJ52rw5Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6BYOfzCZEnDeicVH5gylifvft4s0qoNVgkS+Ec8hDrs=; b=q1DSd1vZPWrkLQaeGPPPWlyAE5ketkEkgz0EL1yW1LjHUmiPYrof13DwP//HABPUCzrGJkGY0o0T6HyG65SQOVn1wJwxKGKna8k9WP6X9D2a7w208KB0X1igReCShq5FoHlSd96TKHa8PbqdXvjCOCoKGwnmBSY4aWmQhgVZSd9TnwnN5M33MONvVFMjy25lHbGgVJH8XDIn2Z3GanFg+rD6UCL9z61F7OpJaqxr2u/vkAN89J0lB1CzXHqURWrGuUCfXGC2g/3aI9njHnTH/iOB48W/IzamxWhxNn80Qnvrsgy/Vi7FddBOtgAdYdyQODsyl/Mii4DHAJLR52EkbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6BYOfzCZEnDeicVH5gylifvft4s0qoNVgkS+Ec8hDrs=; b=1UvhUee4oBAC5XYimRROy4g6rO8nId/0DKaCTdZoz+reL3UdEYA2KWurxJHHLXgjtY6q2jyGSrM8jwgYWe3y/kbzBRcAFjiUqppzyPJkMG5MTLntHbVdbDOD/tJCmA9VmGDvcxpN+xVT814uZR16GHOqnKgBqLFHGS17b7zVe31MMnyvaq67ai9ZShlttNujVzqLgihfIK8IpIdV9jf6+kaBamS7qCpzR6HerZLgt0BBuvNKA6D3v72p4yOfO4BegTrVHB+xQR2sMKJCalVi2p0pfSy3RI4fD1qPmH3lDZj+WaiyCOid9mBrmP1WmpkjwkeuaR+5ISIfR9aiD8MzCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:16 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:16 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 15/15] fetch2: gitsm: remove indirection and nesting Date: Fri, 5 Sep 2025 08:20:58 +0200 Message-ID: <20250905062058.2563806-16-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ea73753-869f-453c-a7b3-08ddec446b4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: TovQo07o2MahrExpuKUWRkPIw47565b3OTo4jDOupsXmMoB5dC8TphPZ9qNLwXabCS8pSNWVVgAQ/HTGUseK3jN/TxqEooDm+GStesbziVHAxRtp4v8KuCekNS1TsI/ItS0ZR17/tNG2oxAkdct+9Ns4SCIPRYT0IA9D15g2wkNA/0bZVyOCl+hOtZElpNl+apEHjPPZeLiFJsfJfLjSEC69x1/bAqI+OARpDYb4d8Y63DEsvmMbzGvQZwQ6iTwYrQDND6FTz0prsHjxIBdldGRP880KgBuTBEOj0AJ0nBUsFDKqThtuq5QPRnLQMeRh0KAmuwW7kIBKVy1cxkwBmgflYBFnyjdlQUGFxvntNNisvZCyu0EGi/BL8aZt4+WSzMiTHGn5yqBanO+VUedQXMGOQi89stu6hjvBLMg0HIwR722LR96UDqTRZuqFi8hs7ztD7epHLfKsibJ3GxRIpLqQP3xOaNjR+4xmPwMOvKCCzjJtFiHGyxYKb7k10dM7/+LU4yzxyhgpnmxURnRS9ahO8LQ7if74bEH3YzGPXUDV+j5jSKF4OV9Zpdy9SSF7bsPlwReBTCTpJ0a94YiXHQ+NHvAfJUjNsQJDpxDONPlabH5ZsDtkX8LT44reTbmGrrLFu9bHyL4FGO/WxKK/eqN9Qje8UBr8D1qvDDoZZhMgW7XOZ1IfJ41sPayMJjCnswhDVjPQAI9+4LNY/Ghm1VpBOFCfBjZRyhWKopiSNOTt2fDJHsUf2LFmQbpWpNBV6lQXZZ53FjFYUvlpnUknYoVPqwHIBwdenQfMtoRzCVlXZsz4UZF7AOleiSuOCgfdqEMh5Z2R/YBK9PBmHVTMujpFODGYLGm2Ftys6WCBTbduCIUwIR8GFN/xolqvGKrJrrOq6oP0FMkLVQ44CdDEErHd8CDqd5ilhMAG6gSgkz6R5Hp6PObkS9UbotfC47khpMe90hX9qUhxYFjhjVnx7PaFsk78ocompendB0YCYAzlm3hF6dAPwOMAbSxqo9eRyEa3DIgyGV1Adh+ekKbh/3ngawBQ4cjY012Hu7V+27eeHw8EB+ajLvjy2q+UCL44TKVIxGIFjKVO6F7HQTNGzJQj8eJxfbDsCnHYEnPsV8vSBRHUgeXn8wEJkxm5F9X2imc9sTBaL3BqCzPYTWYgBCL4qSYsSRUh4kY81oa65G8G1wHS+Vo1aJba8Psi8PJt4wNySO96hxeMwkvj3rJCnPURU8qjzLN4AZad/G1uEDiQr5bgOLYI/uv/ANqiqK+4JCcSViXJuTbV9kHP5iNiTSaF8Wxf/oLUJ3/T48fSZ6wzOPzSkkNCFKm/MItrqyxuHBtZa48SO049EQQt1f4xvYkAisslgU5zwrmFFK2qtc0Igsw0PkxbLklbCJygQzYhp5eKm+DbyocGV2emypNBNtg39yw38N3mlBU09F4awM6AK+OXujo/qyclUaFOqsC9nyW7iGgKN9/puXby2fmYhA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2d1tfC1XX7EEriN85elKWeUAy6tjc65qV95m2D09jeXSTm6wglnEV0uqYhSi80XhjflYgp23Htq+OyOnJSQzCWo5saD7zbdOSpRFFwe3Pb10aDxjibXiypOStB61marAe3TpaUd42qCJWK4/OAFshc027HIWFvUPMnaXKl+QBfYvsF1QfpO1xUh/0czpTWUDMrofHiQAfkyqohsyic1Ja4R4cjs1kyyscDBWGYEuWwIj+EthhBc4uWLzbibMetNGLx5eFamSPod2XX2LG3aUoVGdhG7G9LIXz0UL+mivROdLZGvuFd3GaCAJMWn1t7MR5zpA0kMddyFtXL/YImMkVjfQahTyn2LaQxNesUkT4FFCkPqAzO0BCotrL09HIouVC4FEd4J+AlxLN2NvnR8Ks5oKCIRVAPB0NvE6CzknVlVK6PRKrQ8mtXJwE6+r6RZkuXRgFRE3cgrAFmCfytz0GYqvZcY5hQh9hQVGrsyqX2drnsiHHRTniR09S2HSCYoZttMy1lquvjQNJjHknCUUMAib7kqUInbk3LUj2LlWxICCWuJqthAJ/hS/ltTkYUTtnbZBBlk0m4EaMG5nEoEgXZ+0f4Gg0ZkybWc5RPlpMFy70iWkyyZILak1OCKvH+vxWIJR59ZSXDU91f4KM6Pot+SUCUgPzJq7RQ6NfhHh0QQtLiQDQxEh6iQTrhrFA37jjgzwvd6gWou2s0XA+6GhEfsUG9PA1CA4K8XLMEjHv3ZO0d+oaAykpjwHdHfHT2H5l5IE1/GhtMTczJwhdLk09SMFAH2CZbJDCDoUboPO0t/GhnrPNjfaoczQgOhh4elQJBqi84uazL50gdgZI9maSD3sedA/Akg98TxWMaSG3c9fBf6GmN4/ZqfoRgQdamHyhg7EK06k1GBs2J3BlzyPeeVH29hjw7ZHnT7FJpnFvaAr4r/2G6lnIcmiSIvEBOs9WYSxiW+l39MapFesFf8m+PEBlZG0A2ge/zg5ICfAY/z8YBvDXjWILBCd1w5tDOGIt3PnEbfmJ4F768BCAnE5fbJEMdUuBgClOEvlu3uiZv8C9YvR21ETTyPVZ1TtcocqQAy358FODhU1OD2cSTBXBJz3iO5C7cq4234ljl1fB+dUqaro/gowuVD8n7Fxjx0r0qetNOL+0eV5USul4k69YU9CAh9WVy2iDOk/efB9gCMlsWYiYEfIy75R4RuOliVVQOgkYATYNcW19KjV/K63bPdm8y0cwn0ESWrdi/1+m7TT05WC2jgFT423OQ8PZK5dRAg7SL/jBUqY8J1JeG3oIqDDnfLa6GLsSltn+iXm+86BPu1c85F6XchqEeUo2hbHdkoWmc0LFlVaKjLC/9+Vvu231HkZY9Ye9lS0nMsiIjps0TYlQlAmvOD8aFAZ8tqZeMZ4LT7Mox4HOI4vRa3zOGQ1XWLQ5Jed4YCQ4YJz/KWbaH7ors0koIJxwxV/4zeqHF88YKtjXiANYm4nlPKbd9sU+HrBB2tsgMFHHXd+k4BCZjgHjluIA5rN+zcn/C0FQ12EpTv8bkAy6ViEI1/vxcDnKzNHGjaeaknXmuGmB4nkNL5cP8euXK0195Bb+AsPepV42qg/YCywGJgkaoptwA== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ea73753-869f-453c-a7b3-08ddec446b4c X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:16.0272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 67giG2g+EKjPmvARn+6TNF45LFyBCcOPVeAXXlN5UJsbhas3Aool0V2xerxQociqk0f5cbl4sC5vKwooH3u5xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17972 From: Stefan Herbrechtsmeier Use a single fetch object to reuse the fetch functionality. Remove indirection, nesting and duplicate code. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 98 ++++++++++++++---------------------------- 1 file changed, 32 insertions(+), 66 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 4b6c88baa..5ddc81f86 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -33,10 +33,10 @@ class GitSM(Git): """ return ud.type in ['gitsm'] - def process_submodules(self, ud, workdir, function, d): + def process_submodules(self, ud, workdir, d): """ - Iterate over all of the submodules in this repository and execute - the 'function' for each of them. + Iterate over all of the submodules in this repository and generate a + fetch object for all of them. """ submodules = [] @@ -91,6 +91,7 @@ class GitSM(Git): newud.path = os.path.normpath(os.path.join(newud.path, uris[m])) uris[m] = Git._get_repo_url(self, newud) + urls = [] for module in submodules: # Translate the module url into a SRC_URI @@ -138,21 +139,21 @@ class GitSM(Git): # the user (See comment in git.py). # So, we will not take patches adding "user=" support here. - function(ud, url, module, paths[module], workdir, d) + urls.append(url) - return submodules != [] + return Fetch(urls, d, cache=False) if urls else None - def call_process_submodules(self, ud, d, subfunc): + def call_process_submodules(self, ud, d): # If we're using a shallow mirror tarball it needs to be # unpacked temporarily so that we can examine the .gitmodules file # Unpack even when ud.clonedir is not available, # which may occur during a fast shallow clone if os.path.exists(ud.clonedir): - self.process_submodules(ud, ud.clonedir, subfunc, d) + return self.process_submodules(ud, ud.clonedir, d) elif ud.shallow and os.path.exists(ud.fullshallow): with tempfile.TemporaryDirectory(dir=d.getVar("DL_DIR")) as tmpdir: runfetchcmd("tar -xzf %s" % ud.fullshallow, d, workdir=tmpdir) - self.process_submodules(ud, tmpdir, subfunc, d) + return self.process_submodules(ud, tmpdir, d) else: raise bb.fetch2.FetchError("Submodule source not available.") @@ -160,51 +161,26 @@ class GitSM(Git): if Git.need_update(self, ud, d): return True - need_update_list = [] - def need_update_submodule(ud, url, module, modpath, workdir, d): - try: - newfetch = Fetch([url], d, cache=False) - new_ud = newfetch.ud[url] - if new_ud.method.need_update(new_ud, d): - need_update_list.append(modpath) - except Exception as e: - logger.error('gitsm: submodule update check failed: %s %s' % (type(e).__name__, str(e))) - need_update_result = True - - self.call_process_submodules(ud, d, need_update_submodule) - - if need_update_list: - logger.debug('gitsm: Submodules requiring update: %s' % (' '.join(need_update_list))) - return True + need_update = False + fetch = self.call_process_submodules(ud, d) + if fetch: + for url in fetch.urls: + urldata = fetch.ud[url] + if urldata.method.need_update(urldata, d): + need_update = True - return False + return need_update def download(self, ud, d): - def download_submodule(ud, url, module, modpath, workdir, d): - # Is the following still needed? - #url += ";nocheckout=1" - - try: - newfetch = Fetch([url], d, cache=False) - newfetch.download() - except Exception as e: - logger.error('gitsm: submodule download failed: %s %s' % (type(e).__name__, str(e))) - raise - Git.download(self, ud, d) - self.call_process_submodules(ud, d, download_submodule) + + fetch = self.call_process_submodules(ud, d) + if fetch: + fetch.download() def unpack(self, ud, destdir, d): fulldestdir = self.destdir(ud, destdir, d) - def unpack_submodules(ud, url, module, modpath, workdir, d): - try: - newfetch = Fetch([url], d, cache=False) - newfetch.unpack(root=destdir) - except Exception as e: - logger.error('gitsm: submodule unpack failed: %s %s' % (type(e).__name__, str(e))) - raise - Git.unpack(self, ud, destdir, d) parentdir = ud.parm.get('parentdir') @@ -228,35 +204,25 @@ class GitSM(Git): logger.error("Unable to set git config core.bare to false for %s" % fulldestdir) raise - ret = self.process_submodules(ud, fulldestdir, unpack_submodules, d) + fetch = self.process_submodules(ud, fulldestdir, d) + if fetch: + fetch.unpack(destdir) - if not ud.bareclone and ret: + if not ud.bareclone and fetch: cmdprefix = "" # Avoid LFS smudging (replacing the LFS pointers with the actual content) when LFS shouldn't be used but git-lfs is installed. if not self._need_lfs(ud): cmdprefix = "GIT_LFS_SKIP_SMUDGE=1 " runfetchcmd("%s%s submodule update --recursive --no-fetch" % (cmdprefix, ud.basecmd), d, quiet=True, workdir=fulldestdir) def clean(self, ud, d): - def clean_submodule(ud, url, module, modpath, workdir, d): - try: - newfetch = Fetch([url], d, cache=False) - newfetch.clean() - except Exception as e: - logger.warning('gitsm: submodule clean failed: %s %s' % (type(e).__name__, str(e))) - - self.call_process_submodules(ud, d, clean_submodule) - - # Clean top git dir + fetch = self.call_process_submodules(ud, d) + if fetch: + fetch.clean() Git.clean(self, ud, d) def implicit_urldata(self, ud, d): - import subprocess - - urldata = [] - def add_submodule(ud, url, module, modpath, workdir, d): - newfetch = Fetch([url], d, cache=False) - urldata.extend(newfetch.expanded_urldata()) - - self.call_process_submodules(ud, d, add_submodule) + fetch = self.call_process_submodules(ud, d) + if fetch: + return fetch.expanded_urldata() - return urldata + return []