From patchwork Wed Aug 27 09:53:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yiding Liu (Fujitsu)" X-Patchwork-Id: 69207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3B4CA0FED for ; Wed, 27 Aug 2025 09:54:01 +0000 (UTC) Received: from esa6.hc1455-7.c3s2.iphmx.com (esa6.hc1455-7.c3s2.iphmx.com [68.232.139.139]) by mx.groups.io with SMTP id smtpd.web10.11395.1756288432098211760 for ; Wed, 27 Aug 2025 02:53:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@fujitsu.com header.s=fj2 header.b=Mq1ngmTD; spf=pass (domain: fujitsu.com, ip: 68.232.139.139, mailfrom: liuyd.fnst@fujitsu.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1756288432; x=1787824432; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IdPA3cYisuEis1XNiuBYtrzLsWvC5IEGDXJoj0P+eCM=; b=Mq1ngmTDfaklateRqp+eUgg3mWW8xszeVSfIXvaODabYVsquMR/P/QJR ocoXH55owV5ecw75UzNHD+yAQLCJf4dbG395Erq3XKh/SNgUVQLnGGcTE 0usnml6MUiVvoQ3pVDH0ZckzST8ADEBi/+aLkjnBagLguM4E/n2O43UhD vc0egi9v0t57MLLwVaiGpJDoeyOkKsncAhbmv+EYHBgSMHLKpYDUC6Hut IgK+x9mrn9EJa6VYJ+8ry052O/tJmUoy5wO/IDxI7VQCehiS+MCOxR0PM mfBCp8EWFDlhEPGxWJVR4Kajwy9GRTxiIoTThTlMs9JXaM77B6Va1XAXm w==; X-CSE-ConnectionGUID: FnZfWDRoRki+dHqWXgmUvg== X-CSE-MsgGUID: +f7IBfzMRru0xqqJysNzHQ== X-IronPort-AV: E=McAfee;i="6800,10657,11534"; a="214160782" X-IronPort-AV: E=Sophos;i="6.18,214,1751209200"; d="scan'208";a="214160782" Received: from unknown (HELO az2nlsmgr3.o.css.fujitsu.com) ([20.61.8.234]) by esa6.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 18:53:51 +0900 Received: from az2nlsmgm3.fujitsu.com (unknown [10.150.26.205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2nlsmgr3.o.css.fujitsu.com (Postfix) with ESMTPS id 8848B1000351 for ; Wed, 27 Aug 2025 09:53:50 +0000 (UTC) Received: from az2uksmom3.o.css.fujitsu.com (az2uksmom3.o.css.fujitsu.com [10.151.22.205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2nlsmgm3.fujitsu.com (Postfix) with ESMTPS id 3F3411800080 for ; Wed, 27 Aug 2025 09:53:50 +0000 (UTC) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2uksmom3.o.css.fujitsu.com (Postfix) with ESMTPS id 01EA51001CDC; Wed, 27 Aug 2025 09:53:48 +0000 (UTC) Received: from G08FNSTD190088.g08.fujitsu.local (unknown [10.193.129.116]) by edo.cn.fujitsu.com (Postfix) with ESMTP id E02CD1A000B; Wed, 27 Aug 2025 17:53:43 +0800 (CST) From: Liu Yiding To: Alexander Kanavin Cc: openembedded-core@lists.openembedded.org, Liu Yiding Subject: [OE-core] [PATCH v3] readline: backport a patch to fix issue that readline can't work with samba Date: Wed, 27 Aug 2025 17:53:13 +0800 Message-ID: <20250827095313.1915-1-liuyd.fnst@fujitsu.com> X-Mailer: git-send-email 2.49.0.windows.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 27 Aug 2025 09:54:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/222502 smbclient can't accept input after readline upgrade to 8.3 | root # smbclient //192.168.2.16/test -N | Try "help" to get a list of possible commands. | smb: \> similar issue has been reported: https://lists.gnu.org/archive/html/bug-readline/2025-07/msg00011.html Signed-off-by: Liu Yiding --- .../fix-for-readline-event-hook.patch | 55 +++++++++++++++++++ meta/recipes-core/readline/readline_8.3.bb | 1 + 2 files changed, 56 insertions(+) create mode 100644 meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch diff --git a/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch b/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch new file mode 100644 index 0000000000..f2ec506f5c --- /dev/null +++ b/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch @@ -0,0 +1,55 @@ +From 15970c431517a046099d8294c91d778b1da9b29d Mon Sep 17 00:00:00 2001 +From: Chet Ramey +Date: Fri, 11 Jul 2025 11:51:15 -0400 +Subject: Readline-8.3 patch 1: fix for readline event hook + + +Upstream-Status: Backport [https://cgit.git.savannah.gnu.org/cgit/readline.git/commit/?id=15970c431517a046099d8294c91d778b1da9b29d] +Signed-off-by: Liu Yiding +--- + input.c | 6 +++++- + patchlevel | 2 +- + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/input.c b/input.c +index e6a39e2..3383edb 100644 +--- a/input.c ++++ b/input.c +@@ -261,13 +261,16 @@ rl_gather_tyi (void) + input = 0; + tty = fileno (rl_instream); + +- /* Move this up here to give it first shot, but it can't set chars_avail */ ++ /* Move this up here to give it first shot, but it can't set chars_avail, ++ so we assume a single character is available. */ + /* XXX - need rl_chars_available_hook? */ + if (rl_input_available_hook) + { + result = (*rl_input_available_hook) (); + if (result == 0) + result = -1; ++ else ++ chars_avail = 1; + } + + #if defined (HAVE_PSELECT) || defined (HAVE_SELECT) +@@ -285,6 +288,7 @@ rl_gather_tyi (void) + #endif + if (result <= 0) + return 0; /* Nothing to read. */ ++ result = -1; /* there is something, so check how many chars below */ + } + #endif + +diff --git a/patchlevel b/patchlevel +index d8c9df7..fdf4740 100644 +--- a/patchlevel ++++ b/patchlevel +@@ -1,3 +1,3 @@ + # Do not edit -- exists only for use by patch + +-0 ++1 +-- +cgit v1.2.3 + diff --git a/meta/recipes-core/readline/readline_8.3.bb b/meta/recipes-core/readline/readline_8.3.bb index ff5dec6c0a..a2f23eb353 100644 --- a/meta/recipes-core/readline/readline_8.3.bb +++ b/meta/recipes-core/readline/readline_8.3.bb @@ -1,6 +1,7 @@ require readline.inc SRC_URI += "file://norpath.patch \ + file://fix-for-readline-event-hook.patch \ " SRC_URI[archive.sha256sum] = "fe5383204467828cd495ee8d1d3c037a7eba1389c22bc6a041f627976f9061cc"