From patchwork Wed Aug 27 03:05:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yiding Liu (Fujitsu)" X-Patchwork-Id: 69197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C29CA0FF0 for ; Wed, 27 Aug 2025 03:05:39 +0000 (UTC) Received: from esa1.hc1455-7.c3s2.iphmx.com (esa1.hc1455-7.c3s2.iphmx.com [207.54.90.47]) by mx.groups.io with SMTP id smtpd.web10.6478.1756263929164513463 for ; Tue, 26 Aug 2025 20:05:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@fujitsu.com header.s=fj2 header.b=Hbz/+oP/; spf=pass (domain: fujitsu.com, ip: 207.54.90.47, mailfrom: liuyd.fnst@fujitsu.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj2; t=1756263930; x=1787799930; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=FKDh1Cm5nwVpi4KSq3aYOAnZPQzNLKe0gcqBqz9jqW0=; b=Hbz/+oP/rU4NAbNf7hM7nfk4/M7M25qXIwzHBC69RcycQigxVLjX5xcP gInWWDzPZkmk+Da8QSqdLYbjP11JzXkTgRNlgxDo5DgGikCws2rMkDAFZ c1IQZ7FGv7QtenQJv+7D3D378BIgcMHb/h6SJRET4aYIWSOuoR3y9aB8j 3g3bgQTo9CPCH/vId9J58Rw5PmQ1lvd5S8rEH1M78cUbk4GkXM4Np4Oxu hYsDcXucZl8TxD0IB0UzugcVTqW3PIy0FHVl438aqTUkgYV/WxwUUKJu9 I6WX1MjcK+OIQGLFECrQ/ssPlGAYqeJcB/EyRbtMwnZl/nKlQwY27Pdub Q==; X-CSE-ConnectionGUID: AglRVreBQWqt+s28e8g54g== X-CSE-MsgGUID: zPCb4j4ARH+p0PSHFzOWwA== X-IronPort-AV: E=McAfee;i="6800,10657,11534"; a="210775013" X-IronPort-AV: E=Sophos;i="6.18,214,1751209200"; d="scan'208";a="210775013" Received: from unknown (HELO az2uksmgr3.o.css.fujitsu.com) ([52.151.125.128]) by esa1.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 12:05:28 +0900 Received: from az2uksmgm2.o.css.fujitsu.com (unknown [10.151.22.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2uksmgr3.o.css.fujitsu.com (Postfix) with ESMTPS id 871C81002B9D for ; Wed, 27 Aug 2025 03:05:27 +0000 (UTC) Received: from az2uksmom2.o.css.fujitsu.com (az2uksmom2.o.css.fujitsu.com [10.151.22.203]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2uksmgm2.o.css.fujitsu.com (Postfix) with ESMTPS id 43816180025C for ; Wed, 27 Aug 2025 03:05:27 +0000 (UTC) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by az2uksmom2.o.css.fujitsu.com (Postfix) with ESMTPS id 3638014000A5; Wed, 27 Aug 2025 03:05:25 +0000 (UTC) Received: from G08FNSTD190088.g08.fujitsu.local (unknown [10.193.129.116]) by edo.cn.fujitsu.com (Postfix) with ESMTP id C1ABF1A0096; Wed, 27 Aug 2025 11:05:21 +0800 (CST) From: Liu Yiding To: Gyorgy Sarvari , openembedded-core@lists.openembedded.org Cc: Liu Yiding Subject: [OE-core] [PATCH v2] readline: backport a patch to fix issue that readline can't work with samba Date: Wed, 27 Aug 2025 11:05:16 +0800 Message-ID: <20250827030517.1402-1-liuyd.fnst@fujitsu.com> X-Mailer: git-send-email 2.49.0.windows.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 27 Aug 2025 03:05:39 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/222486 smbclient can't accept input after readline upgrade to 8.3 | root # smbclient //192.168.2.16/test -N | Try "help" to get a list of possible commands. | smb: \> similar issue has been reported: https://lists.gnu.org/archive/html/bug-readline/2025-07/msg00011.html Signed-off-by: Liu Yiding --- .../fix-for-readline-event-hook.patch | 55 +++++++++++++++++++ meta/recipes-core/readline/readline_8.3.bb | 1 + 2 files changed, 56 insertions(+) create mode 100644 meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch diff --git a/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch b/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch new file mode 100644 index 0000000000..f2ec506f5c --- /dev/null +++ b/meta/recipes-core/readline/readline/fix-for-readline-event-hook.patch @@ -0,0 +1,55 @@ +From 15970c431517a046099d8294c91d778b1da9b29d Mon Sep 17 00:00:00 2001 +From: Chet Ramey +Date: Fri, 11 Jul 2025 11:51:15 -0400 +Subject: Readline-8.3 patch 1: fix for readline event hook + + +Upstream-Status: Backport [https://cgit.git.savannah.gnu.org/cgit/readline.git/commit/?id=15970c431517a046099d8294c91d778b1da9b29d] +Signed-off-by: Chet Ramey +--- + input.c | 6 +++++- + patchlevel | 2 +- + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/input.c b/input.c +index e6a39e2..3383edb 100644 +--- a/input.c ++++ b/input.c +@@ -261,13 +261,16 @@ rl_gather_tyi (void) + input = 0; + tty = fileno (rl_instream); + +- /* Move this up here to give it first shot, but it can't set chars_avail */ ++ /* Move this up here to give it first shot, but it can't set chars_avail, ++ so we assume a single character is available. */ + /* XXX - need rl_chars_available_hook? */ + if (rl_input_available_hook) + { + result = (*rl_input_available_hook) (); + if (result == 0) + result = -1; ++ else ++ chars_avail = 1; + } + + #if defined (HAVE_PSELECT) || defined (HAVE_SELECT) +@@ -285,6 +288,7 @@ rl_gather_tyi (void) + #endif + if (result <= 0) + return 0; /* Nothing to read. */ ++ result = -1; /* there is something, so check how many chars below */ + } + #endif + +diff --git a/patchlevel b/patchlevel +index d8c9df7..fdf4740 100644 +--- a/patchlevel ++++ b/patchlevel +@@ -1,3 +1,3 @@ + # Do not edit -- exists only for use by patch + +-0 ++1 +-- +cgit v1.2.3 + diff --git a/meta/recipes-core/readline/readline_8.3.bb b/meta/recipes-core/readline/readline_8.3.bb index ff5dec6c0a..a2f23eb353 100644 --- a/meta/recipes-core/readline/readline_8.3.bb +++ b/meta/recipes-core/readline/readline_8.3.bb @@ -1,6 +1,7 @@ require readline.inc SRC_URI += "file://norpath.patch \ + file://fix-for-readline-event-hook.patch \ " SRC_URI[archive.sha256sum] = "fe5383204467828cd495ee8d1d3c037a7eba1389c22bc6a041f627976f9061cc"