From patchwork Tue Jun 17 05:25:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Kamensky X-Patchwork-Id: 65101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EB3C71157 for ; Tue, 17 Jun 2025 05:26:38 +0000 (UTC) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mx.groups.io with SMTP id smtpd.web10.11495.1750137995091516811 for ; Mon, 16 Jun 2025 22:26:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nNyJ0cNA; spf=pass (domain: gmail.com, ip: 209.85.214.174, mailfrom: victor.kamensky7@gmail.com) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-235d6de331fso64075785ad.3 for ; Mon, 16 Jun 2025 22:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750137994; x=1750742794; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NRGss+cny7I0oI+O3AfsSlQL9oRSpTzWSMKHfJbk7ro=; b=nNyJ0cNAmA6EAE8WRwGYlUhiVcKHLbW3Wem93zCAl7/ML6r7X64t0xoD+CGHWb0EfJ BRxPG86joJ7YNXobjUi/88BXMo1qgrApRdFPv/GiEHLP28gq4xrrznnEL4ROLIkuNmVM 20q0FoeqF1RbTTmhqdDH3pVEZs738zwOqqpzz0vbFRF5vZs+a9Hw4evsLwB25yHiB3va 1XswCLLu+07EncA52bjVrLpuidyezw89eEja+KNWGEWdlQU0attqddRT7D28/5bcNb8l 5rT3Ro/x2xDl8ho0opMPm9/HHu7IgrYvIODPzh3dGDtNaliuWQLWH7R0EGzsNOJiBifE AJXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750137994; x=1750742794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NRGss+cny7I0oI+O3AfsSlQL9oRSpTzWSMKHfJbk7ro=; b=mzGLYGS31xXw4ivF2IU8zFJ0KNN9eKi0omFi6Amf3fNiRCh37VPNWPmhYfDOTB96mX Bur30byeb6+gPzsVoIkX6vRqcAvWlpbZny0VkYNm4f6lSaLpT30hUOP4Fh+NCNwQsook 76zp/8EjJQOszqd+RUBbRgwodgJDpgKRVGj2MVzsGrs31cPTtUiIwLtTz9pCKYjn2ePQ XX7zQ7ln+eeQxAfTUornKxw/tHlrj6DGnRRSSYiVK/2v5ki6BZwXqSDPAwIehwNpXXt7 6qEc9lTVPVsFg3sOQ/w5Mmwndhpj4V+y+Zg9EGL9dbYyztaYZVF8+/GgsI5eG82qb0G7 QXOg== X-Gm-Message-State: AOJu0YyvV4OWEwnhap5EESLIY4seqB8mhb+c+Z15vlmkDozApDkp/4dm SXRXrtBdwyDjwTdnNTviOPtR/La2EQxmD/QOkLBjAuwloHf+Mr+HTYwBvEguzg== X-Gm-Gg: ASbGncuYxrDYGmhrYLtVdSxMg1Dei3dz2tPu0KdrtEAkT/cM69VBuNQx1SPvkxZUvVN ohyawW6jK+bABcDfNlJrEYs7EHeNeNJyP6R5hXCUwipxqOglR3lBAUJYFAy21amMsEhSD9gIuP8 cDTi+GKSgzmiqDAb8/6qaW/rsJ+lkxf6g70LZfYOGuQRpCKHLxEzrx6e4mnLMLBs3GJyzzmZG8i y1KmohBC425rdDgET2+mmyuthKwLtdpQU27g7KXQlmGT75egcFErBRQRLM90IOHHXp2UaRFh0sf zNoPJ50KMG2CzDmH0/cZ+BjiWsqD5ofDw7Pm8LXgQG2A9CDFaVa1kDjeRrEPwq6wNuLeCb4= X-Google-Smtp-Source: AGHT+IFndV0/pvLmAzwFfK0EsKqgtPkEaWZcjxu6GzJBmwvnXX6P9UjcGCpve0UyOm/xzsd2QXMrFg== X-Received: by 2002:a17:903:18f:b0:235:eb8b:9968 with SMTP id d9443c01a7336-2366b149d13mr183562295ad.36.1750137993814; Mon, 16 Jun 2025 22:26:33 -0700 (PDT) Received: from kamensky-p15s.cisco.com ([2601:646:9d86:8270::6b7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d8a19b0sm71125555ad.61.2025.06.16.22.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 22:26:33 -0700 (PDT) From: Victor Kamensky To: openembedded-core@lists.openembedded.org Cc: Richard Purdie , Ross Burton , Victor Kamensky Subject: [PATCH 1/3] systemtap: upgrade 5.2 -> 5.3 Date: Mon, 16 Jun 2025 22:25:38 -0700 Message-Id: <20250617052540.8256-1-victor.kamensky7@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 17 Jun 2025 05:26:38 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/218851 * fixed patch fuzz issue Signed-off-by: Victor Kamensky --- ...mtap-native_5.2.bb => systemtap-native_5.3.bb} | 0 ...-improve-reproducibility-for-c-compiling.patch | 15 ++++++--------- .../{systemtap_5.2.bb => systemtap_5.3.bb} | 0 meta/recipes-kernel/systemtap/systemtap_git.inc | 2 +- 4 files changed, 7 insertions(+), 10 deletions(-) rename meta/recipes-kernel/systemtap/{systemtap-native_5.2.bb => systemtap-native_5.3.bb} (100%) rename meta/recipes-kernel/systemtap/{systemtap_5.2.bb => systemtap_5.3.bb} (100%) diff --git a/meta/recipes-kernel/systemtap/systemtap-native_5.2.bb b/meta/recipes-kernel/systemtap/systemtap-native_5.3.bb similarity index 100% rename from meta/recipes-kernel/systemtap/systemtap-native_5.2.bb rename to meta/recipes-kernel/systemtap/systemtap-native_5.3.bb diff --git a/meta/recipes-kernel/systemtap/systemtap/0001-improve-reproducibility-for-c-compiling.patch b/meta/recipes-kernel/systemtap/systemtap/0001-improve-reproducibility-for-c-compiling.patch index 15a6f2a9a5..7d35f76b29 100644 --- a/meta/recipes-kernel/systemtap/systemtap/0001-improve-reproducibility-for-c-compiling.patch +++ b/meta/recipes-kernel/systemtap/systemtap/0001-improve-reproducibility-for-c-compiling.patch @@ -13,19 +13,16 @@ Signed-off-by: Hongxu Jia stringtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/stringtable.h b/stringtable.h -index 5fc42e7..6fd8a1e 100644 ---- a/stringtable.h -+++ b/stringtable.h -@@ -19,7 +19,7 @@ +Index: git/stringtable.h +=================================================================== +--- git.orig/stringtable.h ++++ git/stringtable.h +@@ -23,7 +23,7 @@ - #if defined(HAVE_BOOST_UTILITY_STRING_REF_HPP) + #if 0 && defined(HAVE_BOOST_UTILITY_STRING_REF_HPP) #include -#include //header with string_ref +#include "@RELATIVE_STAGING_INCDIR@/boost/utility/string_ref.hpp" //header with string_ref // XXX: experimental tunables #define INTERNED_STRING_FIND_MEMMEM 1 /* perf stat indicates a very slight benefit */ --- -2.7.4 - diff --git a/meta/recipes-kernel/systemtap/systemtap_5.2.bb b/meta/recipes-kernel/systemtap/systemtap_5.3.bb similarity index 100% rename from meta/recipes-kernel/systemtap/systemtap_5.2.bb rename to meta/recipes-kernel/systemtap/systemtap_5.3.bb diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc index a6688f2604..ed806d2cdb 100644 --- a/meta/recipes-kernel/systemtap/systemtap_git.inc +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc @@ -7,7 +7,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git;protocol=https;branch=master \ file://0001-staprun-stapbpf-don-t-support-installing-a-non-root.patch \ " -SRCREV = "3a92ffe673c1621309a0b60892114495b651c9de" +SRCREV = "c4fc655170b534478a6b131292b987630c7c0865" COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel|mips|riscv64).*-linux' COMPATIBLE_HOST:libc-musl = 'null' From patchwork Tue Jun 17 05:25:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Kamensky X-Patchwork-Id: 65100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7097C7114A for ; Tue, 17 Jun 2025 05:26:38 +0000 (UTC) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mx.groups.io with SMTP id smtpd.web10.11496.1750137996326567036 for ; Mon, 16 Jun 2025 22:26:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=D8Hbie9Q; spf=pass (domain: gmail.com, ip: 209.85.216.45, mailfrom: victor.kamensky7@gmail.com) Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3122368d7c4so4664010a91.1 for ; Mon, 16 Jun 2025 22:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750137995; x=1750742795; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AtBvHdtjmAvyUcsssT3Ycs972xwIeITTwib+w7hRdJI=; b=D8Hbie9Qjoqei+98pX/17s7I1jG7NaY0dfDwRDHSxidQTf4/jwbPYFr+iIzMvUZ5MD uuCXRaM24xzNvYrbG6rmIGAuLs8mLNKy7+ndyh4F8fdNSZjCTb9MnkCgN9oP6QAaFeH5 WM5pRlD/2xG2eF+rgnAq9d2bqwY65wL8SsYRplbuykdnsbYLNxJDHyHOJdMofnG5+QVA HxQN05DfcFluJ69upkcKVvBklJflBkR9nKImF+QAoKCmQReOITY9v9VOEqcIYhIN4/cN zKli45pVv4jsQf+2iDeYgF/0CcvnbcbEVOg/lLpDz6HPJQJu8i5xI8UosKPiMZKl4vAt g48w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750137995; x=1750742795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AtBvHdtjmAvyUcsssT3Ycs972xwIeITTwib+w7hRdJI=; b=wtmlt6rfCwWCjeAlbwCemjVbB+QMFkLqjgz62H0ANFgLH8HM3/y8cHW+ZjNdT48PrB V2HTk5llOW96JiCm+0mMCT21FmbEqi+AE/0caqUCTli2H4h6UvYiTXDDdhaiZnYhrui6 GaGR+lKLRoZM6PCi4XOdZztHL3GqTH9nMu0ddnjF0y0j3ydUVnpNM3Wl+sADMzYfDUHc Ryz9rf83SDoghocb72YTMEHm5wFZQ6VSNjlHwdGAz5LB/wnTGP4VJdpzd2KJMDwrmAs6 cW0LvTXCofnTjp1T9/LpsUPdatxXzg3/m2lMgk/NeF/ceKXCE2EWL9PiAuAtohSO6vEy kJ8Q== X-Gm-Message-State: AOJu0YzmR9TTtJ46bicX+4sBVRThWzF/uQMPll6kSrG416vYp1ajQuVD +ViaufnX4x+1nqlWfESMhBGwtY2cIeNR4eG4G/e4lppmJ0dv2CZqZtlv+hRdpA== X-Gm-Gg: ASbGnctTlWAGnFx3CWU6+YXoTBPA3wCW/gLWB4DHQBtvb+kbEi3Dl4jyPrHEavZcG+p 9on2IHjqf/Ji1UKV1IYgMjMgVxI5+S/5UGAULCES7X6Pi18IIOi9gJHBqti2QGnCZVB2iNnzvik u2cWBJhIvyj9iiE2j8OVy5mM4d1TZ01o3JUvRlTZdMF6KNiHmeZ+FSQWcluYWZG7IxS00Qb9CpB owDIfWXm3gXv8rqIIHvtXG/P2WeuV5I4nXVayt0gcsOImkBmAssLrSTmmkWSIDAkkio+9SzW3hP lZ3R5VDRpjd6sJFAaDSYMHw4ZnmaDxlmlzPhkePAVICxwmxaaLnH2ngMEw0PYElS1Gj45wA= X-Google-Smtp-Source: AGHT+IFA3ADmjg30xvifaPoL7qqOxwXsoYmWfUxe53ii/4Jc0A+xcfPK4+8g7DRbjp5jXhGQ0v8JBA== X-Received: by 2002:a17:90b:2dd2:b0:312:f88d:25f9 with SMTP id 98e67ed59e1d1-313f1c7dacfmr20098557a91.7.1750137995123; Mon, 16 Jun 2025 22:26:35 -0700 (PDT) Received: from kamensky-p15s.cisco.com ([2601:646:9d86:8270::6b7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d8a19b0sm71125555ad.61.2025.06.16.22.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 22:26:34 -0700 (PDT) From: Victor Kamensky To: openembedded-core@lists.openembedded.org Cc: Richard Purdie , Ross Burton , Victor Kamensky Subject: [PATCH 2/3] oeqa/runtime/stap: fix module name: stap-hello -> stap_hello Date: Mon, 16 Jun 2025 22:25:39 -0700 Message-Id: <20250617052540.8256-2-victor.kamensky7@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250617052540.8256-1-victor.kamensky7@gmail.com> References: <20250617052540.8256-1-victor.kamensky7@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 17 Jun 2025 05:26:38 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/218852 Systemtap refuses modules names like stap-hello, it says: > ERROR: Safety pattern mismatch for -m parameter ('stap-hello' vs. '^[a-z0-9_]+$') rc=1 'stap-hello' was introduced by: 6cf4d23a2d26c2767edd93f2eb317ff759b5a992 (oeqa/runtime/stap: improve systemtap test) and '-m parameter' regexp check was in SystemTap from 2010, not sure how this test case ever passed after mentioned change. Signed-off-by: Victor Kamensky --- meta/lib/oeqa/runtime/cases/stap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/lib/oeqa/runtime/cases/stap.py b/meta/lib/oeqa/runtime/cases/stap.py index 3be4162108..23eace7e9d 100644 --- a/meta/lib/oeqa/runtime/cases/stap.py +++ b/meta/lib/oeqa/runtime/cases/stap.py @@ -21,11 +21,11 @@ class StapTest(OERuntimeTestCase): status, output = self.target.run(cmd, 900) self.assertEqual(status, 0, msg='\n'.join([cmd, output])) - cmd = 'stap -v -p4 -m stap-hello --disable-cache -DSTP_NO_VERREL_CHECK -e \'probe oneshot { print("Hello, "); println("SystemTap!") }\'' + cmd = 'stap -v -p4 -m stap_hello --disable-cache -DSTP_NO_VERREL_CHECK -e \'probe oneshot { print("Hello, "); println("SystemTap!") }\'' status, output = self.target.run(cmd, 900) self.assertEqual(status, 0, msg='\n'.join([cmd, output])) - cmd = 'staprun -v -R -b1 stap-hello.ko' + cmd = 'staprun -v -R -b1 stap_hello.ko' self.assertEqual(status, 0, msg='\n'.join([cmd, output])) self.assertIn('Hello, SystemTap!', output, msg='\n'.join([cmd, output])) except: From patchwork Tue Jun 17 05:25:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Kamensky X-Patchwork-Id: 65102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 907FBC71155 for ; Tue, 17 Jun 2025 05:26:48 +0000 (UTC) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web10.11498.1750137998447939201 for ; Mon, 16 Jun 2025 22:26:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fLMvX7M+; spf=pass (domain: gmail.com, ip: 209.85.214.180, mailfrom: victor.kamensky7@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-234f17910d8so48405175ad.3 for ; Mon, 16 Jun 2025 22:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750137997; x=1750742797; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AszOnjPbXv2oqE5YdZF5MIm/v8B3q+mMLxuFOPWkzyY=; b=fLMvX7M+i9xLQCkvkCliHvz6vcopp8UavRVI1GHpQQjj+jGUjIJ03TH1HFm/GJIgEt qlwBAa7BNPpYx8tPkYIJ7dMKZjK4CYSRo/b12/Gz+FYL9BaITFNay9tVMI7HnvtyMjc4 krYbhe6zmuq0ivWIGDuAvIvFSir0n9G5X100Dd+9FJDPlt0xLK5K6m9t1WOiJltKw3aH Af6vdyNWpLX5zKAH2OBwKL6bQqF640XWWwfvutrXqb/TYs5W55sN8AWApT3yE5+UXaZo HF4ByCY14/lst7xVZzXdkX4w5dbD4h8kp0leQocqgSMu+fwYr1Y2yIvTUyaZ8EMBqXQZ 7lWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750137997; x=1750742797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AszOnjPbXv2oqE5YdZF5MIm/v8B3q+mMLxuFOPWkzyY=; b=f/YNaAYjV+ulcaHcc0lz+rPmp/3v4vEDRSkyV8naLq8t9LelAeBmBgeNxzEpyXc6Ff Nwio1P+7nJy/qgl4AUYkg0qZS11vPc2sD+g8uxlroezOEaQhNRd/EzCqK04ie86jbqOP hTcvB+WgqWx4srOQXChgMSkg+JZ8+lVy4N+ZRvngrP/qYhpmo4W6prS5RGS945xwgaYr J8FnYp460g5bYvynWB5wThOF7eePitJxFnnv4DwETYkS/+X5xJiB9LoNe58G7QOagI+G 5U48IVNaLMrgPkDxMqYUj5e1qUJKWGOnHwi9+YcgalLsLkDxb6gczOm1XaS05+0Wi9ig vmfw== X-Gm-Message-State: AOJu0Yxu6DWktpl2ppz357kTS0v+BZuzbN9KXdeU+u0jSN+cgQNZqoaa /hDyv6GOG8ekU1oPVawqwM4ftgD/JP+jA8QjiR8wRbVFvD1v9ZF+wzHYAEzloA== X-Gm-Gg: ASbGncsePhVBj9cb5OhI5dCoOpuy8XqoClhITtWcg+7GPPHVtNbKrAiE1OX3Sb8y+h7 6ofzXCqldOkCIIcQ2bJYUXMHyEfSp0J+hymGvnq+syhEr9h7MbwBZNmcW5DS+9DxxFQzabm4JKQ yPfDX3Sc+arU8opXwi3imr0ALTBYmsaKl25ztGtsf2jA1HS0fh9SwMApSH7bIh0/NBbPcbevPPh dA7iYS/5aO+23dhWehix9UwIIsSnTdbJ/znQHwunezoyQNm07qAJVQMs6fmsHnHBlTkrlwXVcNU MmSbhJUiK3ILCU0hmDjA1EIVzlgJO6uXDLuBslNXLLIevDxAoue3eDGDjWPKYnyftZ+gANY= X-Google-Smtp-Source: AGHT+IGfRyrzLqouIuguhJX1EvIAT4WrGhshk5TOnZdYQWt9JL8vDRTr2ytWnBaeiPHmg0FmdsMp7Q== X-Received: by 2002:a17:903:acb:b0:234:c549:d9dd with SMTP id d9443c01a7336-2366b19da09mr190252855ad.48.1750137997271; Mon, 16 Jun 2025 22:26:37 -0700 (PDT) Received: from kamensky-p15s.cisco.com ([2601:646:9d86:8270::6b7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d8a19b0sm71125555ad.61.2025.06.16.22.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 22:26:36 -0700 (PDT) From: Victor Kamensky To: openembedded-core@lists.openembedded.org Cc: Richard Purdie , Ross Burton , Victor Kamensky Subject: [PATCH 3/3] oeqa/runtime/stap: fix script logic problem Date: Mon, 16 Jun 2025 22:25:40 -0700 Message-Id: <20250617052540.8256-3-victor.kamensky7@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20250617052540.8256-1-victor.kamensky7@gmail.com> References: <20250617052540.8256-1-victor.kamensky7@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 17 Jun 2025 05:26:48 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/218853 Looks as a typo introduced by "6cf4d23a2d26c2767edd93f2eb317ff759b5a992 (oeqa/runtime/stap: improve systemtap test)" - when original command was split into two parts 'self.target.run' was missed for the second part. Note this and previos commit issues were masked because mentioned commit has try/except around tests, so failures that normally are reported when test assertEqual throw an exception never reached oeqa infra. Effectively, this test was broken for the last 3 years. I will leave blanket try/except around test for now, so this test will pass all the time as long as dmesg is working. But at least with the fixes one can inspect log.do_testimage output and check that all steps are successful or not. Signed-off-by: Victor Kamensky --- meta/lib/oeqa/runtime/cases/stap.py | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/lib/oeqa/runtime/cases/stap.py b/meta/lib/oeqa/runtime/cases/stap.py index 23eace7e9d..6b55e7de50 100644 --- a/meta/lib/oeqa/runtime/cases/stap.py +++ b/meta/lib/oeqa/runtime/cases/stap.py @@ -26,6 +26,7 @@ class StapTest(OERuntimeTestCase): self.assertEqual(status, 0, msg='\n'.join([cmd, output])) cmd = 'staprun -v -R -b1 stap_hello.ko' + status, output = self.target.run(cmd, 60) self.assertEqual(status, 0, msg='\n'.join([cmd, output])) self.assertIn('Hello, SystemTap!', output, msg='\n'.join([cmd, output])) except: