From patchwork Sun May 4 11:07:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeroen Hofstee X-Patchwork-Id: 62409 X-Patchwork-Delegate: steve@sakoman.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97528C3ABAC for ; Sun, 4 May 2025 13:54:59 +0000 (UTC) Received: from outbound3.mail.transip.nl (outbound3.mail.transip.nl [136.144.136.12]) by mx.groups.io with SMTP id smtpd.web11.26887.1746356852484961701 for ; Sun, 04 May 2025 04:07:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@myspectrum.nl header.s=transip-a header.b=JbDi/2NK; spf=pass (domain: myspectrum.nl, ip: 136.144.136.12, mailfrom: jeroen@myspectrum.nl) Received: from submission2.mail.transip.nl (unknown [10.100.4.71]) by outbound3.mail.transip.nl (Postfix) with ESMTP id 4Zr21Y1SkSznB2h; Sun, 4 May 2025 13:07:29 +0200 (CEST) Received: from yellow.myspectrum.nl (unknown [IPv6:2a01:7c8:bb0c:45:5054:ff:fe01:854]) by submission2.mail.transip.nl (Postfix) with ESMTPSA id 4Zr21W62l4z2rJ5nm; Sun, 4 May 2025 13:07:27 +0200 (CEST) Received: from yellow.myspectrum.nl (84-27-20-154.cable.dynamic.v4.ziggo.nl [84.27.20.154]) (Authenticated sender: sendmail@myspectrum.nl) by yellow.myspectrum.nl (Postfix) with ESMTPSA id C821F200DB; Sun, 4 May 2025 11:07:25 +0000 (UTC) Authentication-Results: yellow.myspectrum.nl; auth=pass smtp.auth=sendmail@myspectrum.nl smtp.mailfrom=jeroen@myspectrum.nl Received: by yellow.myspectrum.nl (sSMTP sendmail emulation); Sun, 04 May 2025 13:07:25 +0200 From: jeroen@myspectrum.nl To: openembedded-core@lists.openembedded.org Cc: Jeroen Hofstee Subject: [OE-core][scarthgap][PATCH 1/2] bluez5: make media control a PACKAGECONFIG option Date: Sun, 4 May 2025 13:07:21 +0200 Message-ID: <20250504110722.2549513-1-jeroen@myspectrum.nl> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Scanned-By: ClueGetter at submission2.mail.transip.nl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=transip-a; d=myspectrum.nl; t=1746356847; h=from:subject:to:cc:date: mime-version; bh=cliYmG/ma3t9jBNBjR2bGMn3sCQ4XThN94Os+QFuhWM=; b=JbDi/2NKWOJhTMQgagYYyVqFadxyoiQUVLGKoKgLfPK+ApLfeRwvtGYeBhRHNAYhmWcB1s jqkEYfYJMIzB2yae4RQYdaixKIAOocNgfPIPeYdoC0/2YRzZjXVO1myKeZ9U0m+Wu/FqWy y9xAUhewSqfOG1aJtkgimtiqsCQ7AfwxEv2BZXt3N+HQHLVW0JFfYxuLPVaf9tpvGI4Jj2 qzw8Gdo0K4fqeN1xBZp+Ltj31QpqdNOTm16YykR0hmEi1KCS2ziC5XZhzxYqCUbOU00hsP Q+6h3m85y3xnh76ZSiYUL4g9y6vZFsjTDOQWHNU71h5h8rsI2aXoqis8FkLHyg== X-Report-Abuse-To: abuse@transip.nl List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 04 May 2025 13:54:59 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/215968 From: Jeroen Hofstee When not building with the default PACKAGECONFIG options, the build can fail with: undefined reference to `media_player_controller_create' undefined reference to `media_player_set_status' Otherwise. So disable it when not set and enable it by default. The packageconfig option is the same as in Styhead. https://github.com/openembedded/openembedded-core/commit/ebbdb7cf5c0a3f0e6773704d4c4cc570358ec611#diff-9d9284f6f27a81c75dffffd6d601b40c8266ae12e678d0a49c46bdb8356a0e91R52 --- meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index 39e1bf389c..731bfa0e40 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -18,6 +18,7 @@ PACKAGECONFIG ??= "obex-profiles \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ a2dp-profiles \ avrcp-profiles \ + mcp-profiles \ network-profiles \ hid-profiles \ hog-profiles \ @@ -35,6 +36,7 @@ PACKAGECONFIG[nfc] = "--enable-nfc,--disable-nfc" PACKAGECONFIG[sap-profiles] = "--enable-sap,--disable-sap" PACKAGECONFIG[a2dp-profiles] = "--enable-a2dp,--disable-a2dp" PACKAGECONFIG[avrcp-profiles] = "--enable-avrcp,--disable-avrcp" +PACKAGECONFIG[mcp-profiles] = "--enable-mcp,--disable-mcp" PACKAGECONFIG[network-profiles] = "--enable-network,--disable-network" PACKAGECONFIG[hid-profiles] = "--enable-hid,--disable-hid" PACKAGECONFIG[hog-profiles] = "--enable-hog,--disable-hog" From patchwork Sun May 4 11:07:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeroen Hofstee X-Patchwork-Id: 62408 X-Patchwork-Delegate: steve@sakoman.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96597C369DC for ; Sun, 4 May 2025 13:54:59 +0000 (UTC) Received: from outbound4.mail.transip.nl (outbound4.mail.transip.nl [136.144.136.2]) by mx.groups.io with SMTP id smtpd.web10.26799.1746356853365764422 for ; Sun, 04 May 2025 04:07:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@myspectrum.nl header.s=transip-a header.b=LrpqlsTY; spf=pass (domain: myspectrum.nl, ip: 136.144.136.2, mailfrom: jeroen@myspectrum.nl) Received: from submission2.mail.transip.nl (unknown [10.100.4.71]) by outbound4.mail.transip.nl (Postfix) with ESMTP id 4Zr21b02Vtz7w7M; Sun, 4 May 2025 13:07:31 +0200 (CEST) Received: from yellow.myspectrum.nl (unknown [IPv6:2a01:7c8:bb0c:45:5054:ff:fe01:854]) by submission2.mail.transip.nl (Postfix) with ESMTPSA id 4Zr21Z1MjKz2rJ5nr; Sun, 4 May 2025 13:07:30 +0200 (CEST) Received: from yellow.myspectrum.nl (84-27-20-154.cable.dynamic.v4.ziggo.nl [84.27.20.154]) (Authenticated sender: sendmail@myspectrum.nl) by yellow.myspectrum.nl (Postfix) with ESMTPSA id 0372C20296; Sun, 4 May 2025 11:07:28 +0000 (UTC) Authentication-Results: yellow.myspectrum.nl; auth=pass smtp.auth=sendmail@myspectrum.nl smtp.mailfrom=jeroen@myspectrum.nl Received: by yellow.myspectrum.nl (sSMTP sendmail emulation); Sun, 04 May 2025 13:07:28 +0200 From: jeroen@myspectrum.nl To: openembedded-core@lists.openembedded.org Cc: Jeroen Hofstee Subject: [OE-core][scarthgap][PATCH 2/2] bluez5: backport a patch to fix btmgmt -i Date: Sun, 4 May 2025 13:07:22 +0200 Message-ID: <20250504110722.2549513-2-jeroen@myspectrum.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504110722.2549513-1-jeroen@myspectrum.nl> References: <20250504110722.2549513-1-jeroen@myspectrum.nl> MIME-Version: 1.0 X-Scanned-By: ClueGetter at submission2.mail.transip.nl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=transip-a; d=myspectrum.nl; t=1746356850; h=from:subject:to:cc: references:in-reply-to:date:mime-version; bh=pOBvYNUV9OFhu4D5d28eRKVZn79fnUZZJrLl1TcyUfI=; b=LrpqlsTYOeIQ47J+7Cl7oLlPBZtyNQtJwX3OrAECvO6xjyDCVaEArL9Q3CC8TQ4cJfVDE0 LJnqMyNUkI0Pg4VbQLDLJosynd+r4nsTHAhKPsnjl1QcqP+//XIzXzD7eapIQK9/A+aXlK CTP8cQK2nsJ1u486Mfs7xRuGgS/jzRc+h2taOmBGTp7IGDM4UrsdIxidgsG0YZgFUGAstb Grh/BaMrG/h0/IvFULtqBfGnmCOLvg7G1IO3O7TZQVgdKvWoOcNWYM1itN4NX/tbtsKiSi jMRW8UcPVk9gXYWvOjaIoCSsoJIsAcDWXwPbBB6NU0w4vU4NbkFXuJWmxhczTA== X-Report-Abuse-To: abuse@transip.nl List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 04 May 2025 13:54:59 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/215969 From: Jeroen Hofstee Without this patch btmgmt will always use hci0 in non interactive mode. Signed-off-by: Jeroen Hofstee --- meta/recipes-connectivity/bluez5/bluez5.inc | 1 + ...ndex-option-for-non-interactive-mode.patch | 29 +++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index 731bfa0e40..53d8644159 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -57,6 +57,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \ file://0001-tests-add-a-target-for-building-tests-without-runnin.patch \ file://0001-test-gatt-Fix-hung-issue.patch \ file://0001-adapter-Fix-up-address-type-when-loading-keys.patch \ + file://toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch \ " S = "${WORKDIR}/bluez-${PV}" diff --git a/meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch b/meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch new file mode 100644 index 0000000000..f4e14be146 --- /dev/null +++ b/meta/recipes-connectivity/bluez5/bluez5/toolsbtmgmt-fix-index-option-for-non-interactive-mode.patch @@ -0,0 +1,29 @@ +From f00d5546c9e989dd68ce0de0190cd0e043b0f1f5 Mon Sep 17 00:00:00 2001 +From: Arjan Opmeer +Date: Tue, 9 Jul 2024 13:55:41 +0200 +Subject: [PATCH] tools/btmgmt: Fix --index option for non-interactive mode + +In non-interactive mode the --index option does not work because the +call to mgmt_set_index() is made after bt_shell_attach(). + +Fixes: https://github.com/bluez/bluez/issues/893 + +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/f00d5546c9e989dd68ce0de0190cd0e043b0f1f5] +--- + tools/btmgmt.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/btmgmt.c b/tools/btmgmt.c +index 9b7f851bd8..436c2bb21f 100644 +--- a/tools/btmgmt.c ++++ b/tools/btmgmt.c +@@ -51,8 +51,8 @@ int main(int argc, char *argv[]) + return EXIT_FAILURE; + } + +- bt_shell_attach(fileno(stdin)); + mgmt_set_index(index_option); ++ bt_shell_attach(fileno(stdin)); + status = bt_shell_run(); + + mgmt_remove_submenu();