From patchwork Fri Feb 21 11:08:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 57696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F71C021B3 for ; Fri, 21 Feb 2025 11:09:13 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by mx.groups.io with SMTP id smtpd.web11.20792.1740136145337150188 for ; Fri, 21 Feb 2025 03:09:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=n1BVAPqu; spf=pass (domain: bootlin.com, ip: 217.70.183.200, mailfrom: mathieu.dubois-briand@bootlin.com) Received: by mail.gandi.net (Postfix) with ESMTPSA id AB52E43221; Fri, 21 Feb 2025 11:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740136143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=grf+FmYS8i9OpncE+DsyaJ0vpSMvLWU9HI/6tpxOnhM=; b=n1BVAPqurrHvoYl3t1jKMOUFpgA3+vtm7Q3BFyz3vZ7qldmq4nFz6da6NAa2t2M+Bq6MR4 fkwA1cv8wN4Zfj1OfOXe9Wr0xYsWcZ7eTpk5dL0QaK06rNR0W6mcrDPSbhhGEvyIdbwf3K Fpgig1RsxmSIAXN3nQLPCXngVHYr8JYAFfZwKzqKo7JLgQ5ULNthRLmdALthKbHDrkkfbm QYlhnrQyHH3CGqT8WuPX+5QypxOcGbR68SLBp7wNLXNph41AlafXoV98uiWuJ2rxTHW46e ZEY/sURu4eFYqH+U+p7kYrX+RQEF7ICCt4+5+7zWHrwPoWS/jJKfxtFkbuUeIQ== From: Mathieu Dubois-Briand Date: Fri, 21 Feb 2025 12:08:34 +0100 Subject: [PATCH yocto-autobuilder2 1/3] yocto_console_view: Fix release selector use with keyboard MIME-Version: 1.0 Message-Id: <20250221-mbria-release_selector_bugs-v1-1-13d166ff0ca1@bootlin.com> References: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> In-Reply-To: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> To: yocto-patches@lists.yoctoproject.org Cc: Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740136143; l=4780; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=YYOVES4hr53V2I83fm4+qrH/3wEA2gKl42ymsfvMyY4=; b=ao20jb2H5E9yRdn8S1YkGxZ/aDvMRL2RvAX6DlrHpra6ABcXdhaPmIxxV9dBWHKnT4IsuISRk CZ7PQjplUT/AcZaLUthIbzcEJnic4SUPeKvSOMB1iErEf0r1gn1GkH5 X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeileekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforghthhhivghuucffuhgsohhishdquehrihgrnhguuceomhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnheptdfhgeetvddvheejieehheehueetjeelkedtfeehhefgfeeglefhteegtddthfetnecukfhppedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejiedphhgvlhhopegluddvjedrtddruddrudgnpdhmrghilhhfrhhomhepmhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhopeihohgtthhoqdhprghttghhvghssehlihhsthhsrdihohgtthhophhrohhjvggtt hdrohhrghdprhgtphhtthhopehmrghthhhivghurdguuhgsohhishdqsghrihgrnhgusegsohhothhlihhnrdgtohhm X-GND-Sasl: mathieu.dubois-briand@bootlin.com List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 21 Feb 2025 11:09:13 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto-patches/message/1114 Signed-off-by: Mathieu Dubois-Briand --- yocto_console_view/src/releaseselectorfield.ts | 70 +++++++++++++++++--------- 1 file changed, 45 insertions(+), 25 deletions(-) diff --git a/yocto_console_view/src/releaseselectorfield.ts b/yocto_console_view/src/releaseselectorfield.ts index a11816b21829..b330c4cb2ad7 100644 --- a/yocto_console_view/src/releaseselectorfield.ts +++ b/yocto_console_view/src/releaseselectorfield.ts @@ -1,8 +1,8 @@ import {buildbotSetupPlugin} from "buildbot-plugin-support"; buildbotSetupPlugin((reg) => { + let selectInputName = null; let selectListName = null; let inputRefs = null; - let selectors = null; const onTransitionEndEvent = (event) => { /* @@ -44,59 +44,79 @@ buildbotSetupPlugin((reg) => { const releaseSelector = inputRefs.get('force-field-branchselector'); const releaseSelectorLabel = releaseSelector.parentNode.previousSibling; const sepIdx = releaseSelectorLabel.textContent.indexOf(':'); - releaseSelectorLabel.textContent = releaseSelectorLabel.textContent.substring(0, sepIdx); + if (sepIdx >= 0) { + releaseSelectorLabel.textContent = releaseSelectorLabel.textContent.substring(0, sepIdx); + } /* * Get the name of the ReleaseSelector field div. */ - const branchInputId = releaseSelector.attributes.getNamedItem('id').value; - const selectName = branchInputId.substring(0, branchInputId.lastIndexOf('-')); + selectInputName = releaseSelector.attributes.getNamedItem('id').value; + const selectName = selectInputName.substring(0, selectInputName.lastIndexOf('-')); selectListName = selectName + '-listbox'; } window.addEventListener('transitionend', onTransitionEndEvent); - const onClick = (event) => { + function updateSelectors() { if (selectListName) { const listDiv = document.getElementById(selectListName); if (listDiv) { /* - * The ReleaseSelector menu is shown: save - * associated selectors for later and clean menu items. + * The ReleaseSelector menu is shown: clean menu items. */ - selectors = new Map(); + listDiv.childNodes.forEach(div => { const sepIdx = div.textContent.indexOf(':'); - const propName = div.textContent.substring(0, sepIdx); - const content = div.textContent.substring(sepIdx + 1); - div.textContent = propName - selectors.set(propName, JSON.parse(content)); + if (sepIdx >= 0) { + div.textContent = div.textContent.substring(0, sepIdx); + } }); } } + } + + function findApplySelector() { + /* + * One entry was clicked in the ReleaseSelector + * menu: update all fields described by the + * selector configuration. + */ + const branchInput = document.getElementById(selectInputName); + const inputText = branchInput.parentElement.previousElementSibling.textContent; + const sepIdx = inputText.indexOf(':'); + const selectorName = inputText.substring(0, sepIdx); + const selector = inputText.substring(sepIdx + 1); + + new Promise((resolve, reject) => { + return applySelector(JSON.parse(selector), selectorName).then(resolve); + }); + } + + const onClick = (event) => { + updateSelectors(); if (event.target.parentElement) { const parentId = event.target.parentElement.attributes.getNamedItem('id'); if (parentId && parentId.value == selectListName) { - /* - * One entry was clicked in the ReleaseSelector - * menu: update all fields described by the - * selector configuration. - */ - const selector = selectors.get(event.target.textContent); - if (selector) { - new Promise((resolve, reject) => { - return applySelector(selector, event.target).then(resolve); - }); - } + findApplySelector(); } } } window.addEventListener('click', onClick); + const onKeyDown = (event) => { + if (event.key == "Enter") { + findApplySelector(); + } else { + updateSelectors(); + } + } + window.addEventListener('keydown', onKeyDown); + /* * Apply values from the selected field selector */ - async function applySelector(selector, selectList) { + async function applySelector(selector, selectorName) { for (let [field, value] of Object.entries(selector)) { const input = inputRefs.get('force-field-' + field); if (input && input.value != value) { @@ -110,7 +130,7 @@ buildbotSetupPlugin((reg) => { } const releaseSelector = inputRefs.get('force-field-branchselector'); - releaseSelector.parentNode.previousSibling.textContent = selectList.textContent; + releaseSelector.parentNode.previousSibling.textContent = selectorName; releaseSelector.focus(); } From patchwork Fri Feb 21 11:08:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 57697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BF0C021B6 for ; Fri, 21 Feb 2025 11:09:13 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by mx.groups.io with SMTP id smtpd.web11.20794.1740136145852944225 for ; Fri, 21 Feb 2025 03:09:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=YmHoe40Q; spf=pass (domain: bootlin.com, ip: 217.70.183.200, mailfrom: mathieu.dubois-briand@bootlin.com) Received: by mail.gandi.net (Postfix) with ESMTPSA id DC6C44321C; Fri, 21 Feb 2025 11:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740136144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+ggWkYe32CiC/YyVDVincZiq588vxDlgxizuN6DH60=; b=YmHoe40QePM2r1czuk+lhA68VwfmedXbXN/UWzVcEii20z2FafvNmtJF0LxSHUOo06zuZu iqmI9tDLBmSZKtoxsWg4ZbLKGfRsVWBFHt9a49DfiYZu5nHFUVviWitY9wU7JLFxbzz+Gb PrSXkZ51Zmim9peI5UQTyGDqpugIc1WAwtg/n9PZoHSjfHD6QH1cju0njJtLKt/lxzi0iV OeGvSc1VTgQctv3Vm7mhF0xJrJ4TievpJmCignqr0iP4Bi2by2oTV96HfZEC2qSrY9hMoK D66T2PlDZp9ujh0jJbNMOuQXCQObUakPLFp+4s0e/dlC6gAeYP3BlIbyx1u5pQ== From: Mathieu Dubois-Briand Date: Fri, 21 Feb 2025 12:08:35 +0100 Subject: [PATCH yocto-autobuilder2 2/3] yocto_console_view: Override Force Build form CSS MIME-Version: 1.0 Message-Id: <20250221-mbria-release_selector_bugs-v1-2-13d166ff0ca1@bootlin.com> References: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> In-Reply-To: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> To: yocto-patches@lists.yoctoproject.org Cc: Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740136143; l=1314; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=U9T7Sjao5DA18nf9tkSXncdYViit7BK3KC+j2/Z5sbQ=; b=iWepUSE4sm8WIpDrw4+GNw/le+KJddccAa09W/MgeEmzS6umF2dt0/E6TzPzaL90ofnisyEia EM6KTyW4lcVDhg6njzLuZr9RtL5eWeCcjZ+1nIzPR6GBtBgVm04wZuN X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeileekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforghthhhivghuucffuhgsohhishdquehrihgrnhguuceomhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnheptdfhgeetvddvheejieehheehueetjeelkedtfeehhefgfeeglefhteegtddthfetnecukfhppedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejiedphhgvlhhopegluddvjedrtddruddrudgnpdhmrghilhhfrhhomhepmhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhopeihohgtthhoqdhprghttghhvghssehlihhsthhsrdihohgtthhophhrohhjvggtt hdrohhrghdprhgtphhtthhopehmrghthhhivghurdguuhgsohhishdqsghrihgrnhgusegsohhothhlihhnrdgtohhm X-GND-Sasl: mathieu.dubois-briand@bootlin.com List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 21 Feb 2025 11:09:13 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto-patches/message/1117 Compact a bit the force build window, to look like what we had on buildbot 3.8. Signed-off-by: Mathieu Dubois-Briand --- .../src/views/ConsoleView/ConsoleView.scss | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/yocto_console_view/src/views/ConsoleView/ConsoleView.scss b/yocto_console_view/src/views/ConsoleView/ConsoleView.scss index 7969b229706c..15dd3a61bcbd 100644 --- a/yocto_console_view/src/views/ConsoleView/ConsoleView.scss +++ b/yocto_console_view/src/views/ConsoleView/ConsoleView.scss @@ -47,3 +47,40 @@ tr.bb-console-table-first-row { padding: .2em; } } + +/* Modify the Force Build form to compact a bit everything. */ +div.form-group { + margin: 0; + + div.col-sm-10 { + display: inline-block; + width: 80%; + }; + + label { + display: inline-block; + width: 20%; + font-weight: bold; + margin-bottom: 0; + top: .5em; + } + + .control-label { + text-align: right; + float: left; + } + + div.col-sm-10.col-sm-offset-2 { + width: 100%; + max-width: 100%; + label { + width: 80%; + float: right; + padding-left: 8px; + } + }; + + .row > div.col-sm-6 { + margin-bottom: 5px; + } +}; From patchwork Fri Feb 21 11:08:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Dubois-Briand X-Patchwork-Id: 57695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52139C021AA for ; Fri, 21 Feb 2025 11:09:13 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by mx.groups.io with SMTP id smtpd.web11.20793.1740136145529383924 for ; Fri, 21 Feb 2025 03:09:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=T1aJdcUV; spf=pass (domain: bootlin.com, ip: 217.70.183.200, mailfrom: mathieu.dubois-briand@bootlin.com) Received: by mail.gandi.net (Postfix) with ESMTPSA id 155F843224; Fri, 21 Feb 2025 11:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740136144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9gaD4CJTKo1q3DRUVchn41qcMKVFZ9mca0eV5iq5maI=; b=T1aJdcUV/4+dv2JDcs83a9qfvvi2w3IKW/7X07BctfIHDDCdtbvwWZQO8cwHRQwYEhShsR 6QhoefWagdfPoFkEaKB7tIuJf/o8uiRKXQVKTrK0z7QHU/wpNx8LgXHd58u2o147n0NMHo s7yPt2C7KfCPrS3nZ/FpewIS/C/x3CTaTY2BoXjbEkmBxSirBsRheamzOuYSEgldwShmmJ 7mY8JbxvyjQo3w8FwhCqWtXyn/Tr6wFd5RDuooF2LCL1KLJSeG6b6sQMQMxITlmfspgulF HYoFryu+RTeTQy2An0TMyhIjk6WN7eyIbMCIm0c6LxyyxiSetux+BIkZW6xZ+Q== From: Mathieu Dubois-Briand Date: Fri, 21 Feb 2025 12:08:36 +0100 Subject: [PATCH yocto-autobuilder2 3/3] releaseselector: Fix selector not applied in some conditions MIME-Version: 1.0 Message-Id: <20250221-mbria-release_selector_bugs-v1-3-13d166ff0ca1@bootlin.com> References: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> In-Reply-To: <20250221-mbria-release_selector_bugs-v1-0-13d166ff0ca1@bootlin.com> To: yocto-patches@lists.yoctoproject.org Cc: Thomas Petazzoni , Mathieu Dubois-Briand X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1740136143; l=925; i=mathieu.dubois-briand@bootlin.com; s=20241219; h=from:subject:message-id; bh=iOc9zdICGQNJZqsQMYH5rHZV/iX/KXrOmsOCMVVRaVs=; b=r2tcvRXelTGwVy3NzVksCJN8mlCfNyBzSfHwhK6ftYr3UPE+Vp5MSG80RLpBBvbvnzX237iEy nm/NP1wg758B4qwqWPdttngIJDZQybiQpfV4axevwz7gyPqGeXcxBbW X-Developer-Key: i=mathieu.dubois-briand@bootlin.com; a=ed25519; pk=1PVTmzPXfKvDwcPUzG0aqdGoKZJA3b9s+3DqRlm0Lww= X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeileekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforghthhhivghuucffuhgsohhishdquehrihgrnhguuceomhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnheptdfhgeetvddvheejieehheehueetjeelkedtfeehhefgfeeglefhteegtddthfetnecukfhppedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejiedphhgvlhhopegluddvjedrtddruddrudgnpdhmrghilhhfrhhomhepmhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedprhgtphhtthhopehthhhomhgrshdrphgvthgriiiiohhnihessghoohhtlhhinhdrtghomhdprhgtphhtthhopeihohgtthhoqdhprghttghhvghssehlihhsthhsrdihohgtthhophhrohhjvggtt hdrohhrghdprhgtphhtthhopehmrghthhhivghurdguuhgsohhishdqsghrihgrnhgusegsohhothhlihhnrdgtohhm X-GND-Sasl: mathieu.dubois-briand@bootlin.com List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 21 Feb 2025 11:09:13 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto-patches/message/1115 Signed-off-by: Mathieu Dubois-Briand --- yocto_console_view/src/releaseselectorfield.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yocto_console_view/src/releaseselectorfield.ts b/yocto_console_view/src/releaseselectorfield.ts index b330c4cb2ad7..93ce46382f95 100644 --- a/yocto_console_view/src/releaseselectorfield.ts +++ b/yocto_console_view/src/releaseselectorfield.ts @@ -144,7 +144,7 @@ buildbotSetupPlugin((reg) => { const prototypeDescriptor = Object.getOwnPropertyDescriptor(element.constructor.prototype, 'value'); const objectDescriptor = Object.getOwnPropertyDescriptor(element, 'value'); Object.defineProperty(element, 'value', { - objectDescriptor, + ...(objectDescriptor ?? prototypeDescriptor), ['set']: function(v) { const realFunc = prototypeDescriptor['set']; realFunc.call(this, v);