From patchwork Tue Feb 18 10:47:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 57526 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF1CC02198 for ; Tue, 18 Feb 2025 10:47:20 +0000 (UTC) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.groups.io with SMTP id smtpd.web11.16646.1739875636124128412 for ; Tue, 18 Feb 2025 02:47:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=C+A8MZGE; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.46, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-439714a799aso27685465e9.2 for ; Tue, 18 Feb 2025 02:47:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1739875634; x=1740480434; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=34QkeJNGNVbl5DurtGWUqHp+RhdJlllAmQIjN7v/WtU=; b=C+A8MZGEK44YbuThiM4pUNXppkUCMn8s/AfNVBUg9u4uWG/lVqdu9Jv0ktNBI7M0eR xQ6hOXPSIWgpyManNziPy/jCTxC6NmwWSW38rKRFzfSs8I0T8fowYbZvG6CraS2K+eIr BKC8ronyHM7OckiXjldRiEKHcUCye4KWoahzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739875634; x=1740480434; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=34QkeJNGNVbl5DurtGWUqHp+RhdJlllAmQIjN7v/WtU=; b=GcMmHJ0rUJsvf4owirQF2+GkS1hqDBxUn4i7mlyjvcJEM9r6lGELqPaA6pBhWNPw9+ Tl3eZ37TnEFHjAbkTgHrEE5WM05wWQWxVrl6xiSipLSmZ6rM0yngfs37xd6yOppBxVAm esvPVDC1qRSieO6KQzNycwtX7zr1BHcPckThXfLej4CA8AI/Xj5PluKlNIl0IuSgQdT4 xErFCpymTDjkexvi2bEZwYWMcN4z5GFRUIDTnNUPZep7YrhE62IE+o4T5JHoqFY4cGM/ VZXGFFA9cPKrCb7mnRH/NDAYgM1o/1whTwlzp00WeUHSvxBRi6BG/CUZzF3souNt2glv B14A== X-Gm-Message-State: AOJu0Yybvyb9LAorrIiKmlXhGvGP5mqVL7an2F8bn7u/h/VVUhdi7H/t dkvj3yXPsCxTuucUnhp/QZTxfnI5mjp1TJ/BqsXd1+fQOPXvvTE6NenbHjO2gEyTRzzYuViqA83 m X-Gm-Gg: ASbGnctqRw4MC1u5nZMNcl/7b2d4xDdCpAortY55B769ojsaSYaghArakGLK2CEJ+wn STHJ/yWyaKSHBjeiwm+7RXTBS1tSIam6ZFu6H+xuPuyDcelgMy6x95Mo4NL8Y52XJBB+Gcl4Ukd VY82GaQG+TsW32WmVyWEFyteLobetcFm4C82uuEiYTO+c7RYJSPldZ8j3HdmslCfKhVNOW29YPg QqJgh4r3Kqe75f5c2pKN1MeASNq9x5t5xEILxPssCQAgvp0Bsw8bJXoIo3VzT9LfR4E6R46sDry 33MfFmDmEP996M0S8qPSMk2GacWKZeklfWr/9rAGzA== X-Google-Smtp-Source: AGHT+IG9EDaEtaKLkT1a97xRsw2yT70/Y2Eon0z/hQtbuHIVifkL7cUpEO7SJLuKI2fACT/9jQyAUQ== X-Received: by 2002:a05:600c:1d95:b0:439:88bb:d02f with SMTP id 5b1f17b1804b1-43988bbd25amr59595155e9.5.1739875633954; Tue, 18 Feb 2025 02:47:13 -0800 (PST) Received: from max.int.rpsys.net ([2001:8b0:aba:5f3c:a6c8:42:fd4f:69d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b432asm14364490f8f.6.2025.02.18.02.47.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 02:47:13 -0800 (PST) From: Richard Purdie To: openembedded-core@lists.openembedded.org Subject: [PATCH 1/4] gdb: Include xz support by default and clean up PACKAGECONFIG Date: Tue, 18 Feb 2025 10:47:09 +0000 Message-ID: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 18 Feb 2025 10:47:20 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/211600 Firstly, just include xz support in all gdb configurations to simplify config. Most systems would already have the shared library so this isn't a big problem for a larger debugging tool. The PACKAGECONFIG duplication is also confusing. The only PACKAGECONFIG which needs special handking is the python one due to the differing modules needed in the nativesdk case. Remove all the other duplicate entries which should work through our usual class extension code. Signed-off-by: Richard Purdie --- meta/recipes-devtools/gdb/gdb-common.inc | 4 +--- meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 6 +----- meta/recipes-devtools/gdb/gdb-cross.inc | 6 ------ 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc index ea1fc27a61b..c0312f0f05c 100644 --- a/meta/recipes-devtools/gdb/gdb-common.inc +++ b/meta/recipes-devtools/gdb/gdb-common.inc @@ -30,9 +30,7 @@ EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-libgmp-prefix=${STAGING_EXECPREFIXDIR} \ " -PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python \ - ${@bb.utils.contains('DISTRO_FEATURES', 'minidebuginfo', 'xz', '', d)} \ - " +PACKAGECONFIG ??= "readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)} python xz" # Use --without-system-readline to compile with readline 5. PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline" PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python3,python3-codecs" diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc index 9150c196a85..7b4a7719e44 100644 --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc @@ -12,13 +12,9 @@ DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-gmp nat GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'" # Overrides PACKAGECONFIG variables in gdb-common.inc -PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}" PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,nativesdk-python3, \ nativesdk-python3-core \ - nativesdk-python3-codecs nativesdk-python3-netclient \ - " -PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,nativesdk-readline" -PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, nativesdk-elfutils" + nativesdk-python3-codecs nativesdk-python3-netclient" SSTATE_ALLOW_OVERLAP_FILES += "${STAGING_DATADIR}/gdb" diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc index 399f4bba97a..acdb7317c17 100644 --- a/meta/recipes-devtools/gdb/gdb-cross.inc +++ b/meta/recipes-devtools/gdb/gdb-cross.inc @@ -4,12 +4,6 @@ DEPENDS = "expat-native gmp-native mpfr-native ncurses-native flex-native bison- inherit python3native pkgconfig -# Overrides PACKAGECONFIG variables in gdb-common.inc -PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}" -PACKAGECONFIG[python] = "--with-python=${PYTHON},--without-python,python3-native" -PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline-native" -PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils-native" - do_compile:prepend() { export STAGING_LIBDIR="${STAGING_LIBDIR_NATIVE}" export STAGING_INCDIR="${STAGING_INCDIR_NATIVE}" From patchwork Tue Feb 18 10:47:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 57528 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8A6C021AE for ; Tue, 18 Feb 2025 10:47:20 +0000 (UTC) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.groups.io with SMTP id smtpd.web11.16647.1739875637109929923 for ; Tue, 18 Feb 2025 02:47:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=gXkbQTLH; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.43, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43964e79314so48622545e9.3 for ; Tue, 18 Feb 2025 02:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1739875635; x=1740480435; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=z7fqVsp0+npXpHEWW6VAoAYQpfDG8wEUeUeG4PI6SX8=; b=gXkbQTLHPkIz5GuWazJluyMohjfVPftI712pQ8/Oqr/NIuf90avkyyMGeZrBQTeD2e SB5UKNNmAQd8cz8EDvrzphdlRN8Y12NNd5GIkz5qRUeOAtCoW4HC1ItMpo+wK/0Z7LMG 3S/QAxm+Ils/Z81uMar0hVxPxxQVxryEw9fXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739875635; x=1740480435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z7fqVsp0+npXpHEWW6VAoAYQpfDG8wEUeUeG4PI6SX8=; b=IDA4zOea3YCZuSX8nlqW/CyXAQX6XA0PNobBjadE+tNTyjf6XltX5axvzfTPwvDbu5 fWCWC2+Qj2Hq6N9pohmt7//TeaSqwmTn7itO5oQ8CAhBNdsr8mKhHfDzLz6zcBYVMiSR 1Vp0xgYiLsFTk8pEcVQGEGm8ofsLDiUclf2C+A6dMSnHZ4zfxV69uHNYG816EEVCaBm0 rgNTlqScDKLRlkXrrXv1aQZPmtTIjz+2DIjEhA4INI82vG+mZQF7SumCqQ6uvvbTe0EZ D5BxKcrVtjKRLqvD7MPmmxX+oUk29DxABoDRoz+IxzJZcjQzmeD9O1G9Cz8UbaekeXBx Yflw== X-Gm-Message-State: AOJu0YyaN8O9CKIXsmRYWe7hAI4hCcyRDq3eBtlA5p6ZdQejeRKjiHCm SmL3KE7B3tw6aiszIHR8t7etLjAWoPajuTO7gxitV80rcwsHU5Dx13Efp4c9wxK95qpaWCis9qX G X-Gm-Gg: ASbGnctBdV5+ZtMd5C+oD0/OsmkD7rq1iog3fKMOMA+phr+X2xjT8yoPLpmCOuMBkad FYul8BbNAyYAqZJGlIYUVPIYzieZELbY3ExzNSPLjXKPvi0/lDxDBObdmGbFr7Nyzcd9cwGBSKR KgaUSTZYJUio//T2p1dKHk9GjxpzCoMnbI2RKYabm/jSN9wNT/cbtlko+U/eYtfseiQH2iTgG3U 1aDnu3BQdTaLW0gcYVzCJ72NBFRgKQIMTivFR3ElzPY/a/Rhq8wP1P1NZoJaxwUuY12sMJrXPoK xiB3VHvFwqjzsX7xEAgC5n6X9hD/cEOB5EBBfHVx1Q== X-Google-Smtp-Source: AGHT+IHp0c7L30iKlEnid92QTbSX2rBRtEdlXItNOxRWjiLoVIkFj88/ZajLz2BezNDA6VZQ0LiE4A== X-Received: by 2002:a05:600c:1c9e:b0:439:88bb:d013 with SMTP id 5b1f17b1804b1-43988bbd395mr55709695e9.7.1739875635184; Tue, 18 Feb 2025 02:47:15 -0800 (PST) Received: from max.int.rpsys.net ([2001:8b0:aba:5f3c:a6c8:42:fd4f:69d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b432asm14364490f8f.6.2025.02.18.02.47.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 02:47:14 -0800 (PST) From: Richard Purdie To: openembedded-core@lists.openembedded.org Subject: [PATCH 2/4] udev-extraconf: Switch from ifconfig to ip Date: Tue, 18 Feb 2025 10:47:10 +0000 Message-ID: <20250218104712.1362661-2-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> References: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 18 Feb 2025 10:47:20 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/211601 ifconfig is obsolete, drop the call and replace with ip instead. Signed-off-by: Richard Purdie --- meta/recipes-core/udev/udev-extraconf/network.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/udev/udev-extraconf/network.sh b/meta/recipes-core/udev/udev-extraconf/network.sh index ace38808cd5..500e60ae61c 100644 --- a/meta/recipes-core/udev/udev-extraconf/network.sh +++ b/meta/recipes-core/udev/udev-extraconf/network.sh @@ -11,7 +11,7 @@ export PATH if grep -q "iface \+$INTERFACE" /etc/network/interfaces; then case $ACTION in add) - ifconfig | grep -q "^$INTERFACE" || ifup $INTERFACE + ip addr show dev "$INTERFACE" up | grep -q "$INTERFACE" || ifup $INTERFACE ;; remove) ifdown $INTERFACE From patchwork Tue Feb 18 10:47:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 57525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1B1C021AA for ; Tue, 18 Feb 2025 10:47:20 +0000 (UTC) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web11.16648.1739875638552035753 for ; Tue, 18 Feb 2025 02:47:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=HkvzEChI; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.53, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-38f3913569fso1508397f8f.1 for ; Tue, 18 Feb 2025 02:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1739875636; x=1740480436; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9oLFIlihGsEfAXqofKtNLe1HYcgF1MoeZeWSfjZ7klY=; b=HkvzEChIj1UWNv6ejUls6uSu+PfG7ALciw9HKXoh0dURozjwKAvOdYhkqQqNQ1ddbf q8HNcInvHn51Hvt9sm+rk2EYdOdyYgeAPegnxKMLkDgGU0KFBID2VtIZuSBxqsQEMkrz GkOscuNGCHKkfBJBg0Gm5nF7ilPRAcU+FQ1iw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739875636; x=1740480436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9oLFIlihGsEfAXqofKtNLe1HYcgF1MoeZeWSfjZ7klY=; b=KG7g2+fHAhQfbY+scMVGHreq6UtkSaMB9qy+k+4Mk1dtBdwi7rqPZ3MjlVCSZPTaBA p/o/ge2QzmEewHfF6CNSN4DsbEhLonJxXzIWeq1R+VYXfVn2iDMbiO98fPnuvXLK1N0D bP8YjXnGNjNc/9Xr+mUVrF4Lj4U7yUmTBBTvhhpe5KdKEL/Rw/WRc95iEb3vPh0ZHHwL odAvltjoHbl/exVLUJxfQ20kv56Aj/BNj9+upGDpefufFNcKZ2cTy/mqfT0iKO++Ad1P fNyLXbRNOi7jJWDh9a/6wjzebn2q4Gjf8wegsPsfqeQuXfmbf13ElWCNxCbU6HxjANT0 PWEA== X-Gm-Message-State: AOJu0Yy1l459Xd9X1HpXDEayA2N/YwU4DwUREhNLyIkBOU11+3Vthpll CEV3qFJLyNTNjNU4pvijLJ0hetjkLDv3U9R+9pgabahj3CyW/YzSlBuCxfnTHTIqXbp8wvA5iTy X X-Gm-Gg: ASbGncuFEvvpXwq+cnokObzUH1tKEyzmF8ViEE5+nI+1sZlKiM1wbLxzMNl4jSguqp+ I88Uk3NJyL7egTDzVrv6xrMy07pGjRUSjB+qI7GpAW5Xhz1ebTNqjWwSdPeRrC0ZRMGL3NVsrvJ dNujwNttUmRDe/Nxy3N8wUE4Ss4B+vZvRNiaO/yml6AT9pdg0XxZtb44bT7EowRDMe4TKrddGd0 dXxOUtrT0u/XohBnlu1TrG6VnpeH3bPWhdhx6f+LukQ5/KEWKQWCE/vCLWBRY3me6OEdlkVj63a PXy/mrJR0HrdKmoIrPX9CIUPyYrq+P/2MaSOoZpwLA== X-Google-Smtp-Source: AGHT+IFDg6lNyD4KfkOxMDdFYBqXiyJ1zn2l9nifo1A4W9SOFKjYGUDSsugCMjGIRe8jtFmPGncpFw== X-Received: by 2002:a05:6000:4024:b0:38d:afc8:954e with SMTP id ffacd0b85a97d-38f24cfa3dbmr24274178f8f.11.1739875636236; Tue, 18 Feb 2025 02:47:16 -0800 (PST) Received: from max.int.rpsys.net ([2001:8b0:aba:5f3c:a6c8:42:fd4f:69d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b432asm14364490f8f.6.2025.02.18.02.47.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 02:47:15 -0800 (PST) From: Richard Purdie To: openembedded-core@lists.openembedded.org Subject: [PATCH 3/4] oeqa/qemurunner: Convert from ifconfig to use ip Date: Tue, 18 Feb 2025 10:47:11 +0000 Message-ID: <20250218104712.1362661-3-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> References: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 18 Feb 2025 10:47:20 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/211602 ifconfig is obsolete and being removed, convert to use ip instead. Signed-off-by: Richard Purdie --- meta/lib/oeqa/utils/qemurunner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py index 6cab9aa6b20..04e03349140 100644 --- a/meta/lib/oeqa/utils/qemurunner.py +++ b/meta/lib/oeqa/utils/qemurunner.py @@ -534,7 +534,7 @@ class QemuRunner: self.logger.debug("Logged in as %s in serial console" % self.boot_patterns['send_login_user'].replace("\n", "")) if netconf: # configure guest networking - cmd = "ifconfig eth0 %s netmask %s up\n" % (self.ip, self.netmask) + cmd = "ip addr add %s/%s dev eth0\nip link set dev eth0 up\n" % (self.ip, self.netmask) output = self.run_serial(cmd, raw=True)[1] if re.search(r"root@[a-zA-Z0-9\-]+:~#", output): self.logger.debug("configured ip address %s", self.ip) From patchwork Tue Feb 18 10:47:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 57527 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABB8C021AD for ; Tue, 18 Feb 2025 10:47:20 +0000 (UTC) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.16698.1739875639640656818 for ; Tue, 18 Feb 2025 02:47:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=NsKLAPaM; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.49, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4396f579634so17021725e9.1 for ; Tue, 18 Feb 2025 02:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1739875638; x=1740480438; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nOAgGSfb7wW3ebCltQThTqjW86n8WPcMK+5+A7ex8aA=; b=NsKLAPaMbV2ar5XySUvQ6fku++Qj0lQUeR/RF7gPwMlCU5p1KOtnOiu5WXCnB/3U2f 4NQN7kvuczr0ukCYaM1G9/ZYlLLKrlfaEuXmrOlsO49ytvznuPHiVZBmH+OFGxiV2T2m blxsJW0NDJqGN8Evzp7MsWPnwBMsSiqUEx/I4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739875638; x=1740480438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOAgGSfb7wW3ebCltQThTqjW86n8WPcMK+5+A7ex8aA=; b=o+GJleDJWnoA0RbENrD1jD8cakLh4pDBb2YZBlslOwhXKvvfw96FroDh3pdJFgkgPA JWEeaIs1y67DYOyAg77gDr9lMA2Bz0V6Xxi4yGGE29gmdJ91/Ux4qUGATTERQ95Y2gam +1qZoUOqzZKLrOo3BC+es+fJFPjyAIZcw+FOhrwqrC1kEZCEMF3n//eLuV1HIflJ6qQS ZMyuKne0kaRVDuuqI+4b+u3u6TVANHSOu9eKjBZnfm952gBw5PrrPy9MQvVgupcabAsJ 9GixcKpObBoqIqtcc7i5PnK8zV1EWDpXn/WwF/yf7B4xw5AZzuuyj66RPR4KGwhJonKd eebQ== X-Gm-Message-State: AOJu0YyvanEd+PYFfhG77PH/xQOzBxbZiKghu5IEq3Fg+GdUgoxe6oBw zBRafUHqcxLnEpCG8/oIknZ/V/0AwSxXJm2cArtv0GsZ8WW6pELX0jw5zliYKJ89pkNjjVY78du + X-Gm-Gg: ASbGnctOScFd7+sYlnrJCwT6XcldsliVP8xSJEh0aktQCv+d7+IqLFkcX8sJMqG6YSt Qdz3yTpEf4iormgFVnmOauI+0vLV3kldG/CT1ClBHohGIj9UhyGkE5iEx+LOGpXGsOogwswfRn2 0ZUfZS2r5xO8mIMS1v1dDdtXTi7dAEYSfNKOdgUGw8Lp14G0wUji3KOSY154DQvdN1qdq3KuDpR S0j3/msA1vbRtKPqcziUqvPo00eZDBuDAQ3SwD2OwyO09TD1yqPWdUA3ITP/msG7QspY5QzkvWu M+tXiLeCe7YgafFkhXBW/8HA4uYJunTWpb93wGu/ug== X-Google-Smtp-Source: AGHT+IFkwNKNa1HUDBFvUDGZpBPd1t+gFupdAB6ltmG9L0j84U3075n8rpNVnVZBbMkJbDsUMJukJg== X-Received: by 2002:a05:600c:4e45:b0:439:8346:505f with SMTP id 5b1f17b1804b1-4398346524amr61111105e9.20.1739875637621; Tue, 18 Feb 2025 02:47:17 -0800 (PST) Received: from max.int.rpsys.net ([2001:8b0:aba:5f3c:a6c8:42:fd4f:69d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b432asm14364490f8f.6.2025.02.18.02.47.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 02:47:16 -0800 (PST) From: Richard Purdie To: openembedded-core@lists.openembedded.org Subject: [PATCH 4/4] oeqa/runtime/connman: Drop unused test Date: Tue, 18 Feb 2025 10:47:12 +0000 Message-ID: <20250218104712.1362661-4-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> References: <20250218104712.1362661-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 18 Feb 2025 10:47:20 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/211603 This test checks for an IP address and then tests if interface aliases work. We don't run it on any of our automated testing as it only applies for non-qemu. The connectivity test is unrealted to connman and pretty pointless as it depends on ssh being working, so networking is probably ok. The alias interface test is unrelated to commman and a general networking test but seems out of place. The code uses obsolete ifconfig calls and overall, the value of the test we're never using seems low. Delete it. Signed-off-by: Richard Purdie --- .../oeqa/runtime/cases/ethernet_ip_connman.py | 20 +------------------ 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py b/meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py index eac8f2d082b..4e671ec0ccd 100644 --- a/meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py +++ b/meta/lib/oeqa/runtime/cases/ethernet_ip_connman.py @@ -9,24 +9,6 @@ from oeqa.core.decorator.data import skipIfQemu class Ethernet_Test(OERuntimeTestCase): - def set_ip(self, x): - x = x.split(".") - sample_host_address = '150' - x[3] = sample_host_address - x = '.'.join(x) - return x - - @skipIfQemu() - @OETestDepends(['ssh.SSHTest.test_ssh']) - def test_set_virtual_ip(self): - (status, output) = self.target.run("ifconfig eth0 | grep 'inet ' | awk '{print $2}'") - self.assertEqual(status, 0, msg='Failed to get ip address. Make sure you have an ethernet connection on your device, output: %s' % output) - original_ip = output - virtual_ip = self.set_ip(original_ip) - - (status, output) = self.target.run("ifconfig eth0:1 %s netmask 255.255.255.0 && sleep 2 && ping -c 5 %s && ifconfig eth0:1 down" % (virtual_ip,virtual_ip)) - self.assertEqual(status, 0, msg='Failed to create virtual ip address, output: %s' % output) - @skipIfQemu() @OETestDepends(['ethernet_ip_connman.Ethernet_Test.test_set_virtual_ip']) def test_get_ip_from_dhcp(self): @@ -39,4 +21,4 @@ class Ethernet_Test(OERuntimeTestCase): default_gateway = output (status, output) = self.target.run("connmanctl config %s --ipv4 dhcp && sleep 2 && ping -c 5 %s" % (wired_interfaces,default_gateway)) - self.assertEqual(status, 0, msg='Failed to get dynamic IP address via DHCP in connmand, output: %s' % output) \ No newline at end of file + self.assertEqual(status, 0, msg='Failed to get dynamic IP address via DHCP in connmand, output: %s' % output)