From patchwork Tue Mar 21 19:21:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 21500 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D41C6FD20 for ; Tue, 21 Mar 2023 19:21:38 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web11.23270.1679426496250042112 for ; Tue, 21 Mar 2023 12:21:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=BsnM/m4G; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=24442424f2=ovidiu.panait@windriver.com) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32LBUGmZ015052; Tue, 21 Mar 2023 12:21:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=EjuAgKz0wKIYN1yDCnoEJl83vYdVBW9Lnd9eGxFc8as=; b=BsnM/m4GZei5u0KDo73eo0uBY4WWdruMcV7+Cpw7mF84+fG2O86h4HVG1LiR0DetXdW/ /5P3hXh3QE8O8stZYYX1X91Yyfb/sxLOzEJrRmV+dxCrJqqwmg3ZWr9TOXcYhLFMu8ZY BExdPCsurCRp9aMaZGglf7KSlSzE0m2e7u9lTu7e2Y6BbK1hyH+PFFGu4XEGiwp2cTgk HL1KDulr83GsuG18wGfpsaAHPHr2Q6gV/WiYwut3ah35uIIFXSerTGN/X0l7KwLC4Owy bs+Prc0JVU0Ho3xgMlLk1r0fpFyVkQrLa7p0NcimcIL9gqejF/4+DSYuxz4mcZw0oOwl dg== Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2042.outbound.protection.outlook.com [104.47.74.42]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3pdctmk4u0-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Mar 2023 12:21:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8X83EizNFWzU18ysqO5hJ9MfK8ZYUgBQpTKC7m+PPerMpwMRA/LcQSrvni8iSwKp4b/SbdfErThLG07b7IldBqWesO+n0Pc9/SiOOUdRDyL8Hy2yO+FX5VuzxHmM6dM73aTslu2A5bMX3DPl0vTguYiWn6kcRIpr41HGW2Dpih1+wV56Mf+XzS4AwDGsA9gJa7YPg+8DMnU28RMyNjUjl0xhJfgSKaGF+DADgOwJdkm3XYGdEQqYInEDQoA4HLzTLRkpLTq4z96dgihrIBdkcZYG47WXL5bFGs2KE8YQ8q8F/rygZogsmaUSMHaPAy0izFr6qB3HVXXRRlJQ+WpBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjuAgKz0wKIYN1yDCnoEJl83vYdVBW9Lnd9eGxFc8as=; b=LubzJsRP2Jz8AoUFmzGaIOC0B6DxNAzBC8dS5jYff5ZLU9HGDpxugAaPX/AQgx7sUWXbjtZjlW72GAV1LpMo0dGFfWmXUDdler+O8XoUiFiUtwvUVfrbKl6RHK4YsSQ380C81rXs1BIanIYIHCJvTvc8UlEi+MYMOFFsVa0fRXRvQDSbnu7rRUthFN2ahTv8YAgPVTaCJGwaNFtpXk5nDkDdLrZiThZu7RKrUvOBvyLvCjCthJBns+MW6RUz/fumK9a7lWuCRR4itsJApqfNCF19bhLC11Qcwqw0ztD5noNdPFnAP0uz6K4xVQ74QDuA7zs4l4afaxfsPt9sX4hdJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) by CH0PR11MB5297.namprd11.prod.outlook.com (2603:10b6:610:bc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 19:21:31 +0000 Received: from DM4PR11MB5327.namprd11.prod.outlook.com ([fe80::9f42:14ae:2b0a:d1fb]) by DM4PR11MB5327.namprd11.prod.outlook.com ([fe80::9f42:14ae:2b0a:d1fb%3]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 19:21:31 +0000 From: Ovidiu Panait To: yocto@lists.yoctoproject.org Cc: anibal.limon@linaro.org Subject: [ptest-runner][PATCH 1/2] utils.c: rework pty setup Date: Tue, 21 Mar 2023 21:21:10 +0200 Message-Id: <20230321192111.197351-1-ovidiu.panait@windriver.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: VI1PR0102CA0091.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::32) To DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB5327:EE_|CH0PR11MB5297:EE_ X-MS-Office365-Filtering-Correlation-Id: 2824780b-86de-4304-f25c-08db2a417a07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DJWdsDvMZ5PGQ7lGQZBkSVV1CAOIJT3jgqJpyJ1KEujzo+JxLJT8ogQ3Ge7CboHL/Rt5AFx8MHAXSJyHvFSJLs7KvhDNYE0ed9WJv7L5wik9u7Dk5atn0a0QsvJgPVFrRO9epBHw65bBZBaveI6ep3ntv7x2ZGrikKDaP+IJFx+qNNg382dO2cpEQe6Q3oe94q09Ip2jB7rvESjvAjK8Pgc9IdRd3S46JSjsCkQ3LiqEWoSUQZV7Rn64gYkoHHjNItri7Bu3hXENZ7JMe5YTfQtnYkYIRjA3pZWK29W96t+IYc4F8PzmbBSw6IykVqk5MVgVwW7gYETIAVhRQjU371zWUvM+cGoR7ntWveG+zynzPIvpUOVQckcKAjPBLzOIm6vHyZGOOhGTJbhS6ztW/4bFlPvmwJ16l05qL3bVq/YUUPgzJfgP1vrC4rge6sBRZ0JjoYTKyJ0MKrhtfukxskzH5OhopgbNSarTmqG6YDz8vYzEZEXVgMRX0w7NemJaPXG1o7zLS0gdRZ246UFpQcFtOErgLRX1YDmnvbHtaTk56/Aw5MHmiQmmInaIEZp0HagHlRKKLAKfBBzJrvC4qN6eELKc7NjklusilWz54XHIHvlf/xBRQcO5JBqCq4c0AVh4BjVTLEBQZn7EXq2M0ewufy6BLa7IJ/5M9rbUJmxgAkBNNW4nwI08KBl13ErK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5327.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39850400004)(396003)(366004)(346002)(451199018)(52116002)(2616005)(186003)(6486002)(4326008)(83380400001)(6666004)(478600001)(1076003)(66476007)(316002)(6916009)(8676002)(66946007)(66556008)(6512007)(6506007)(26005)(41300700001)(8936002)(5660300002)(44832011)(38350700002)(38100700002)(2906002)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zk8Nz+Whkibigf1CHoB7roFjxZBEO0AecsY2N/Rckid+dJPDE+us/fCD9vO5T62iftK9W3qk49K0l08GGhvNFHZsc0Bw8Eu1C9FllPznaHncH/LWiv2QEdmT3BFSCGJdltOP4L5CbBsudDd2zF2CNf/AIH0h3vrNEpnNtTq2XxC1difAj6JD4HGsVikPhmw8U3m4Vkq3889IpoeHomytGji4cJIfIQFtRysa9lKhlvtHbWYBgO28/QOLYzdqMLFTZR9wWWwP7qsMMMQ8KgPY2rrzCFxG2gR7nqT8OxRUsqL3Q3ulncmUVueAuxrBrMj0w6IEgTRWNI9+3vf02DfvA2UP3XGd4CBPmsT/5Omgjfwa4VLk/0/U5GptzUDdl+lr2U+XEbGL7CQ7SDkgdu3eH2stdpiAv0xLVB+wmWJJXxgCBcPyuY8nHDoFGbYHe2MUAKOrmaR5rW/sJBo6a+heZSrTD9XlySplfyUvwZibYa9/hJUIVbZ9G2YYaRKpBbK1lB/ZgO6YTWeClYbCKCBIcSQ2y7zvpcyN2hDxeCoAPfX+M3TWvNWfjbOLj3UFF/QLgAOglU6cuEeHhngRZwtvQbyEtUPZztEq4yW8/+B0BC4mDFWTmn7yV97xhBFc00Tel5InK+z4oGzdlmz0r8JCm1k/Mhm7FURK47PbHJ3mcBSg5N4AFKO8cz5rKSz1vZlsmQed6zfIIX6GpKWUnA19Q8ZYrYG+LeQYNpbPzaLQ1d0EamLdrejlIL1HaDkLK9P33v8sF2eB06HHbeX84ms9BfAZRaJS+d9dT8GLw5U5P4698LkDiXngp9IGxTg5WPjzlzxLxC53A7d4UcjXyHq1VJ7HhnKNxbujM3r+UwLA3xv+q57zV1cbTrRA83mP4rfh6WbISSYhjS4F5dU9hJ2uirxBtNGmdVojFxmgAfRipzk6L74slt2mDBdCsfM9mDt896ByMGspRY9gjECPT15QxT8wqQlDwQgj6rSFn6BGuNjgUfEPIfQN2WS+Cf9gPYndcIi/pB8IF6vLV01KqhYWoh+D3lvG8DZe/O66hXrTLQuf/fCXNUMfJiTJqBh9akH6HJvPv4HHzmpCHN+ZWz1eJwVuzsmK7i3Kgdyevu78Ztsa0rbFn+QTy9QbUXbRgO1nvuveo/D4N5vCdXuD9VmNKEBGixlQeonRbPBSI09uZZ+fDp3I/Bh0apcCu0KYiEWRkWi9wT0n77fMf50jnTNk2I+qhyfLg8nbeifIKx0t08NxwUCNZectzH/tfBPvFaKO1u59ot1zPjYlbEqdouwjhlvk9TvqbS5KREzxOkB3yh1Y8PgSq9KbPuSRb/9Q/lPxELRyeLruB1zblOiQSVPTKI6OTrNjncQ0xw0s5DzkrMsLH+yKdOJ/JwpRW2SLadW0LIb3EKWPoXrAFMMN5aWfLXYs7tyWIkNv2qQf3Q7ax3jNhrxg2qPGM0lt5yYEPlml/Jw9F8hN+e80fwgc9GSB/LRqJmzcpNhjYXLEbsTBVGyHleUhAY4+hKgUz00Wqa0tqsngKi4VLmWDkJxVbDydiPpJpYrCUvntWWo6Eh0VIq5+VRHHE+0BOrwyTcAq5jlYwROVzlTsr74HYDAEJHvT7A== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2824780b-86de-4304-f25c-08db2a417a07 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5327.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 19:21:31.3961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /T2E0TMA8EiEOeUx5cLVzw6pEfWWeEj4XgHftqBD6niwwCTuaW7CA7mxpfcl+zyo9c/FNljQLXNq+PCeqEMcLz++zCPfjhdEJD45MBl+ujk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5297 X-Proofpoint-GUID: V6FMLRaa5iQdPhaAqIJkCNkmmc2fFE7A X-Proofpoint-ORIG-GUID: V6FMLRaa5iQdPhaAqIJkCNkmmc2fFE7A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-21_11,2023-03-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303210153 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Mar 2023 19:21:38 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto/message/59485 The run-read bash ptest fails when it's being run by ptest-runner, but it is successful when run manually: 0 0 0 0 0 -0 +1 timeout 1: ok unset or null 1 -1 +timeout 2: ok unset or null 2 timeout 3: ok unset or null 3 FAIL: run-read The actual testcase that is failing is: tests/read6.sub: read -t 0 echo $? This failure seems to be related to how the pty setup is handled: openpty() is called in the child process and the master/slave file descriptors are left dangling. To fix this: - move the openpty() call in the parent process, before fork()-ing - assign the slave end of the pty as the stdin for the child process - adjust the TIOCSCTTY ioctl call to use the file descriptor of the pty file Fixes: 59381a643e1f ("utils: ensure child can be session leader") Signed-off-by: Ovidiu Panait --- utils.c | 45 +++++++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/utils.c b/utils.c index a67ac11..87ac20e 100644 --- a/utils.c +++ b/utils.c @@ -385,18 +385,9 @@ wait_child(pid_t pid) * fp should be writable, likely stdout/err. */ static int -setup_slave_pty(FILE *fp) { - int pty_master = -1; - int pty_slave = -1; - char pty_name[256]; +setup_slave_pty(FILE *fp, char *pty_name) { struct group *gptr; gid_t gid; - int slave = -1; - - if (openpty(&pty_master, &pty_slave, pty_name, NULL, NULL) < 0) { - fprintf(fp, "ERROR: openpty() failed with: %s.\n", strerror(errno)); - return -1; - } if ((gptr = getgrnam(pty_name)) != 0) { gid = gptr->gr_gid; @@ -419,10 +410,7 @@ setup_slave_pty(FILE *fp) { fprintf(fp, "ERROR: chmod() failed with: %s.\n", strerror(errno)); } - if ((slave = open(pty_name, O_RDWR)) == -1) { - fprintf(fp, "ERROR: open() failed with: %s.\n", strerror(errno)); - } - return (slave); + return 0; } @@ -441,10 +429,14 @@ run_ptests(struct ptest_list *head, const struct ptest_options opts, int pipefd_stderr[2]; time_t sttime, entime; time_t duration; - int slave; int pgid = -1; pthread_t tid; + int pty_master = -1; + int pty_slave = -1; + char pty_name[256]; + int fd = -1; + if (opts.xml_filename) { xh = xml_create(ptest_list_length(head), opts.xml_filename); if (!xh) @@ -493,15 +485,22 @@ run_ptests(struct ptest_list *head, const struct ptest_options opts, fprintf(fp, "ERROR: getpgid() failed, %s\n", strerror(errno)); } + if (openpty(&pty_master, &pty_slave, pty_name, NULL, NULL) < 0) { + fprintf(fp, "ERROR: openpty() failed with: %s.\n", strerror(errno)); + return -1; + } + child = fork(); if (child == -1) { fprintf(fp, "ERROR: Fork %s\n", strerror(errno)); rc = -1; break; } else if (child == 0) { - close(0); - if ((slave = setup_slave_pty(fp)) < 0) { - fprintf(fp, "ERROR: could not setup pty (%d).", slave); + close(pty_master); + dup2(pty_slave, STDIN_FILENO); + + if ((rc = setup_slave_pty(fp, pty_name)) < 0) { + fprintf(fp, "ERROR: could not setup pty (%d).", rc); } if (setpgid(0,pgid) == -1) { fprintf(fp, "ERROR: setpgid() failed, %s\n", strerror(errno)); @@ -511,8 +510,12 @@ run_ptests(struct ptest_list *head, const struct ptest_options opts, fprintf(fp, "ERROR: setsid() failed, %s\n", strerror(errno)); } - if (ioctl(0, TIOCSCTTY, NULL) == -1) { - fprintf(fp, "ERROR: Unable to attach to controlling tty, %s\n", strerror(errno)); + if ((fd = open(pty_name, O_RDWR)) >= 0) { + if (ioctl(fd, TIOCSCTTY, NULL) == -1) { + fprintf(fp, "ERROR: Unable to attach to controlling tty, %s\n", strerror(errno)); + } + + close(fd); } run_child(p->run_ptest, pipefd_stdout[1], pipefd_stderr[1]); @@ -549,6 +552,8 @@ run_ptests(struct ptest_list *head, const struct ptest_options opts, fprintf(fp, "END: %s\n", ptest_dir); fprintf(fp, "%s\n", get_stime(stime, GET_STIME_BUF_SIZE, entime)); } + close(pty_master); + close(pty_slave); free(ptest_dir); PTEST_LIST_ITERATE_END fprintf(fp, "STOP: %s\n", progname); From patchwork Tue Mar 21 19:21:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 21499 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8932C761A6 for ; Tue, 21 Mar 2023 19:21:38 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web11.23269.1679426495831316737 for ; Tue, 21 Mar 2023 12:21:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=S/Ywm0fF; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=24442424f2=ovidiu.panait@windriver.com) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32LBUGmY015052; Tue, 21 Mar 2023 12:21:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=+tgMpFDj/wH19D6Z/cQmTzGsDwcPrF3UH6NoBBWhGUk=; b=S/Ywm0fFEqglMxNI/Swfl4CgtaRzbDZkIyubxMS5kpMnzjtS7nw6R6xie95dtnpE+V6C Ar4ceEMjeYzE9svj6JMvY2MbEauOEZAzm7jK9e0PHw8Y3ASNrD0VRB3T80IJ/08sEO72 ClS4n1zGWUYHNVKa6S6L9sKFAStVO0Nm/XorgLI6Nn7umbzZizK2Cxjd8qngZWN8FkAX x9ObYT6zGNbBmXELcJIFsv6BDC8Yl0f2tJwNGGcZ0ULYIYs9ttYiwJcgxhiBchj8W4uB u+ENxYYpUh7BGmKg9xXh+WBKY8EQtI2DO22RWkI0sXc6z04UmkI1f3pPsIGaV9w2JI3s zg== Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2042.outbound.protection.outlook.com [104.47.74.42]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3pdctmk4u0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Mar 2023 12:21:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SKNn64i4dIxzTQarET/IcYBsvCQF6itgizQhzABh5FjlUd0U0DcLVC+xUrd7CEY5hnED6lDfWYmA7UdWcZ0Dv18EwmSnQ0x0RT+T77WG3TmKsZn8ugjIPrd7A+VWm3gm7dYPvC17cI5mdA0DcESaCKTDpbFsV3xlqB1Fgg6T97wrRbuH8/SS7RNASyyoCLV1bULgrnkrcd9Pr2FBM5qI4xZZoCrALdoKp5lNYpwswT1RboGX0q75MgUnvgvnO4B2khD3rKycnpQVQDMtwwqONcWlfI/mNmyDz++YadBN1p12ULdsxASAciH2ahOQnWvV+rO7QIdQLb/OuAzKHxPAUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+tgMpFDj/wH19D6Z/cQmTzGsDwcPrF3UH6NoBBWhGUk=; b=WR0C4rB4ky2ZlCrznpxocTSe3dGC2r/vEL/Ky7WbOzBtmIjf+LTYCyiIDlvYxZfLR7pPdL5jp+zFNvO0AAh598/UUWW+CLr072R2gIwT6Ay37d5l31GcH+v80bkJhurLAVwbtRlbOjGSxnVPTkFDQOY5boPSwFowXISJxPQFiptLm2vEUOYlGnT0KWx+Yidl0wFUR7Rbs6UAmmvypNknNmrugjgQ4GqhCHQbj3hPT/YpfsHON6bvoBLruJacU0E0e3Kv0zv/sfOV8ikU8O+DIXnjcjUrltqVBSj31p/JFhk6q6/D5+HYLwIsOM02O1QWepNKEuckd/ujHfjSoO1V9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) by CH0PR11MB5297.namprd11.prod.outlook.com (2603:10b6:610:bc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 19:21:32 +0000 Received: from DM4PR11MB5327.namprd11.prod.outlook.com ([fe80::9f42:14ae:2b0a:d1fb]) by DM4PR11MB5327.namprd11.prod.outlook.com ([fe80::9f42:14ae:2b0a:d1fb%3]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 19:21:32 +0000 From: Ovidiu Panait To: yocto@lists.yoctoproject.org Cc: anibal.limon@linaro.org Subject: [ptest-runner][PATCH 2/2] utils.c: make the pty file readable by all users Date: Tue, 21 Mar 2023 21:21:11 +0200 Message-Id: <20230321192111.197351-2-ovidiu.panait@windriver.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230321192111.197351-1-ovidiu.panait@windriver.com> References: <20230321192111.197351-1-ovidiu.panait@windriver.com> X-ClientProxiedBy: VI1PR0102CA0091.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::32) To DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB5327:EE_|CH0PR11MB5297:EE_ X-MS-Office365-Filtering-Correlation-Id: 20a807a8-c09a-4b67-9909-08db2a417aba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BM57AGI6bIWVBs+E6M2bk1xm3qiduzBhSChVglcOBd0EhlBBrRSx2NGkkRa3OYg+Y5bLoNcINtH/cm3mnJo2ZaJdCeskSmYsVTAmiOp39hRXwrHGbylKaCBzE7cxPDvxD3+3k0p+QNa2n9kval2UXMcVUbBiKnfRvhn+p/yY09Yb3xRBxJ4pHEE9lex2vrHBwRrYhwCKDDxf/eOODZw8yz1Qu05DSXL8NlnD79jdI+RqCqcmKhR723KKc1dQzYUkBWuXldho/GcFb6aYuPahPNxBHJ+06gFviNl8eEkkP+zDogztdVi2PaaNNanvBgtRuwy3LM/6NdKS27C5Hh9eTQfah+wB9hacfSpzcF20UiDwxtXR7bUFUGsGF9QKOEVKOBx0k6I4+oqcF1x/DUZNb9gtMvIFb+7SjE7VEyJziZQHRI6b5kS/7qNR5Wa+yZlM4W12/uko7otzbrcIK9u05oxnWGdT6kCAaAfU7Yx9XyYVGFvS4fnYNPhYWUqZV7KrYRh57Yp4csrSGG1zQ9SX+jvoJYfaXdSnv8jaOI5gcal7e3MHQM1ijGWtDQ8JfgiuEB2DCNafqPUD3dviJ4lrG0M6fx3IP69MXpkX1xTfPFhUoYZJ6uoNENov+/EU2kxLArWyrj3FCrgnHxrUwV3Y7DVvSRVSDFwO5eEOuAeE8e5TE4Qs5Pk+rTFyKNGnBKN2kzHInVXNTNTjc3BJgQIjQjx+T/0y47rj0IuLHAYNMQ7qV6o1mTrYbJM84Y/3Q/mS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5327.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39850400004)(396003)(366004)(346002)(451199018)(52116002)(2616005)(186003)(6486002)(4326008)(83380400001)(6666004)(478600001)(1076003)(66476007)(316002)(6916009)(8676002)(66946007)(66556008)(6512007)(6506007)(26005)(41300700001)(8936002)(5660300002)(4744005)(44832011)(38350700002)(38100700002)(2906002)(86362001)(36756003)(26730200005)(19860200003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: J/o8PoPU8yXtFi75yYteSyPqrhcKyPxTyzB9yKLXQ+mlyS8oeYoVMQZGjYZi4yVLg5rR+IrBIaK1Okj2VvPGUiRxP0mBXeYMx+Mb0RiE4yjCCNzRM9b0aSL01h3gLDJxMgZ3TrPFvcCUljYmCyrCV00kdlqOz85sucCZFvD/SSNURLxiPKp56/TEy293N1QQYcXU7c/tGxk0tjXVo5ATOJGhmR2/BuYL9qN3CgMMsIWqVFxRqlYKS2K7UVN6OV5uZ8Q6EUAI3PHkMEQrymf7KOKVR1mFGzinVhIbOHaAVnMcDIUMOVlfysTnS6baVcxWh978Rr14oiAEZo6p9Cu7TgMuh/0SEbRNPgcEmES30dABr6OFVthbI3046dB1hL2dXdWHHgPcEUKlpgSkYNIg8ahnVICYBGZ07ztkUKHIYaIhmG8dCOc2riP7vKx1iqWjUUFLys4ekaqlImVviP8pySPZjp9dxnLP9u++QrIQXuK0abrBrG/zB/pK0XV6hZFJZyJUp/RwC8a+ssRNCEb5U+swPy/11frcIKtG78YMEWLAPqc5cL+TfLRV1hejQVExhQB+gGfNcgsMZm8C5d2vwUgJDDcWIsQM31xkj42pL3FHnD+T6Qg/rrMn+C/QVnVJSZSGDOWAfTLo+0WEzjlWu4hvYNrwXAFhs/wGZK8KXM9x4z70TYXZBGZRFIUnr1fa3+9G+QoZhQ88yzHFQtHrRQ+S8j11goldnifnhjWjpC/7ZMTJOEGD1wjjf55TDyG3gcWTMETAysKSpjijAJLCj3w2cyepEmUZFyMXOv2qPxDtUg7rI4V0NQBlQ2fnH8RGsivzl7cH6Hvq6Ja21GG9OzNft5QjYmb4q5+IPNi8Ee6FZgJUjPUlfOwsvlj9Dcf2DCh9j4XtrGwy/w+qNWjktiFZiaKlQeKGggixNVKoBXFAcvexeF3uG9jATKxXnn6ILBQlAwcP2/4snOOJLo3Cjnsuibe4Ch6YdwKAzmpoaUIaWtH1mx+1VzzjhyeGuqmw2p+O9ZJRbTYnrSUI+bA10k8vdP/eVLXccVnK119XE59KpLxxwOKQKGjV+ss39m0gfLJNu87+gsWfL05OzsSqm1B0FxsY7/D5QPXygZv3SMefjUdXWvzGIr9owo0Lm6BkxR7lvtuhvFS1ZRV1XTOFYGkLH0nvnGUl65wP1CSgibNx/j9jK2EDw8jE7blue1VOPbyT/F/tQ90N3VF7tLTwjm8DKjuhIS1Ka6ZwWEIqHGGOweNB9suyJ7coUBndkc0JxGJ4lh3kmlo0J/NmfP/lDye0MEfoscrYOVwNSb5vWH6ZiEQbiqravIr8a/ph7UuoS5sC7E1TgVpE1Y/0m8nm62Qw2iprGNun+jWCpIHNluWv5xyxVHdflz3YVJuID55tOw50aGz5i+5p9wflKz96qvRz9L6UGzRqYUA9R+opE17vih4VhYfCYUysGrU82SNk0vFOtJ2HYWls6Io0G33aagEZqu8UPdVsPcoqFzXw1scDF4g+MKn6PBQ/pQ7QJ4iZsNaIk+qm1geoPTS6rVGcu2Az7OAhVX2m+YJOH1SZgbqnsN0atVhXbUCY2T4XbUaXK4NforOGT64vKXXqY1XKAw== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20a807a8-c09a-4b67-9909-08db2a417aba X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5327.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 19:21:32.6940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8zDZqU+cpAPxff3dfPojt7SG6f+Iy9uJwrHU8NfM1K849UlWil5bALkNOr/Ezf0d3GnGFvV+tMnGFOKZmowzUFZWAoALb8GOR21kXS4iWaY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5297 X-Proofpoint-GUID: AQ40nY1kaOoJTiEQckYqZGlkCJox2r_o X-Proofpoint-ORIG-GUID: AQ40nY1kaOoJTiEQckYqZGlkCJox2r_o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-21_11,2023-03-21_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1011 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303210153 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Mar 2023 19:21:38 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto/message/59484 The "run-test" bash ptest expects read permissions for /dev/stdin: test -r /dev/fd/0 test -r /dev/stdin The test currently fails because: - bash-ptest is run as a regular user - the underlying device for /dev/stdin is a pty, which is owned by root Make the pty file readable by all users to fix this ptest. Signed-off-by: Ovidiu Panait --- utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils.c b/utils.c index 87ac20e..643693a 100644 --- a/utils.c +++ b/utils.c @@ -406,7 +406,7 @@ setup_slave_pty(FILE *fp, char *pty_name) { } /* Makes the slave read/writeable for the user. */ - if (chmod(pty_name, S_IRUSR|S_IWUSR) != 0) { + if (chmod(pty_name, S_IRUSR|S_IWUSR|S_IROTH) != 0) { fprintf(fp, "ERROR: chmod() failed with: %s.\n", strerror(errno)); }