From patchwork Sat Oct 10 07:50:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Volk X-Patchwork-Id: 100281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A61CCA9EC5 for ; Sat, 10 Oct 2026 07:50:44 +0000 (UTC) Received: from mailout03.t-online.de (mailout03.t-online.de [194.25.134.81]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.5367.1791618634115937379 for ; Sat, 10 Oct 2026 00:50:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=f_l_k@t-online.de header.s=20260216 header.b=s5N8hbI6; spf=pass (domain: t-online.de, ip: 194.25.134.81, mailfrom: f_l_k@t-online.de) Received: from fwd91.aul.t-online.de (fwd91.aul.t-online.de [10.223.144.117]) by mailout03.t-online.de (Postfix) with SMTP id EA044E295 for ; Sat, 10 Oct 2026 09:50:31 +0200 (CEST) Received: from intel-corei7-64.fritz.box ([79.219.229.158]) by fwd91.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1xFRqg-4UT2hO0; Sat, 10 Oct 2026 09:50:30 +0200 From: Markus Volk To: openembedded-devel@lists.openembedded.org Subject: [blacksail][meta-gnome][PATCH 3/4] Revert "gnome-shell: upgrade 50.4 -> 51.0" Date: Sat, 10 Oct 2026 09:50:21 +0200 Message-ID: <20261010075022.1738748-3-f_l_k@t-online.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261010075022.1738748-1-f_l_k@t-online.de> References: <20261010075022.1738748-1-f_l_k@t-online.de> MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1791618630-D77FC47D-5F0E3BB5/0/0 CLEAN NORMAL X-TOI-MSGID: acd2a3ee-790f-466d-a8f2-699a6029d0c1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t-online.de; s=20260216; t=1791618631; i=f_l_k@t-online.de; bh=dQASgwRV3Qaf7VGbxd+qcWKJ21TRO1tjL/ILHmbb+bo=; h=From:To:Subject:Date:In-Reply-To:References; b=s5N8hbI6QGLbDPx0XTDmKnhsDhuEvYc8eryf84SyB07NX98w03uvXTTrHbd6LvNua kLUaZgE/6qrbbNOKcVf+HP2RvAc0qO5QTz9YBublpTtf3J1vfkc2jvzmAh8v3x8Lzw ME7VXPXffVbTltqKZ29V4T4kDXpgot6A6qT0th4t97vFAYsjd7UMIvfvw+smhYCJR5 dOBqjb3OisNsFh4vpFVkb56Scxvs3m98phInqY29Z0Jz0hh5TDVACMOkUZ1Hq6VioK wY2jzv9ZquCza7Omb+I5vo7AHeSYhsyxqlGYIoVsHzmdWZBT213u7tDRmM3gITTrt3 6TumfRS06MsvA== List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sat, 10 Oct 2026 07:50:44 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/130718 This reverts commit d22efe5c4c2252226b8644ee805863d3c3b5e446. gnome-shell 51.0 needs mutter >= 51.0, which goes back to 50.4 on blacksail. AI-Generated: Uses Claude Code (Claude Opus 5.5) --- ...ver-Fix-build-failure-with-libical-4.patch | 44 +++++++++++++++++++ ...nome-shell_51.0.bb => gnome-shell_50.4.bb} | 7 ++- 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 meta-gnome/recipes-gnome/gnome-shell/gnome-shell/0002-calendar-server-Fix-build-failure-with-libical-4.patch rename meta-gnome/recipes-gnome/gnome-shell/{gnome-shell_51.0.bb => gnome-shell_50.4.bb} (86%) diff --git a/meta-gnome/recipes-gnome/gnome-shell/gnome-shell/0002-calendar-server-Fix-build-failure-with-libical-4.patch b/meta-gnome/recipes-gnome/gnome-shell/gnome-shell/0002-calendar-server-Fix-build-failure-with-libical-4.patch new file mode 100644 index 0000000000..d64cf38ccc --- /dev/null +++ b/meta-gnome/recipes-gnome/gnome-shell/gnome-shell/0002-calendar-server-Fix-build-failure-with-libical-4.patch @@ -0,0 +1,44 @@ +From 91eaa9221b45b506d7a5d84a9ec8c204b5c8c34f Mon Sep 17 00:00:00 2001 +From: Xi Ruoyao +Date: Fri, 8 May 2026 13:13:37 +0800 +Subject: [PATCH] calendar-server: Fix build failure with libical 4 + +Fix the following build error with libical 4 due to function signature changes: + + error: passing argument 4 of 'get_time_from_property' from incompatible pointer type [-Wincompatible-pointer-types] + note: expected 'ICalTime * (*)(ICalProperty *)' but argument is of type 'ICalTime * (*)(const ICalProperty *)' + +Link: https://github.com/libical/libical/blob/4.0/docs/MigrationGuide_to_4.md +Part-of: + +Only the gnome-shell-calendar-server.c hunk of the upstream commit is taken; +src/calendar-server/reminder-watcher.c does not exist in the 50.x series. + +Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/b34766f3992c7616b7816a47249fb463c053e5fa] +--- + src/calendar-server/gnome-shell-calendar-server.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/src/calendar-server/gnome-shell-calendar-server.c b/src/calendar-server/gnome-shell-calendar-server.c +index 0b2f88eb7..622c16181 100644 +--- a/src/calendar-server/gnome-shell-calendar-server.c ++++ b/src/calendar-server/gnome-shell-calendar-server.c +@@ -112,11 +112,17 @@ typedef struct + time_t end_time; + } CalendarAppointment; + ++#if ICAL_CHECK_VERSION(4, 0, 0) ++typedef ICalTime * (* GetICalPropFunc) (const ICalProperty *prop); ++#else ++typedef ICalTime * (* GetICalPropFunc) (ICalProperty *prop); ++#endif ++ + static gboolean + get_time_from_property (ECalClient *cal, + ICalComponent *icomp, + ICalPropertyKind prop_kind, +- ICalTime * (* get_prop_func) (ICalProperty *prop), ++ GetICalPropFunc get_prop_func, + ICalTimezone *default_zone, + ICalTime **out_itt, + ICalTimezone **out_timezone) diff --git a/meta-gnome/recipes-gnome/gnome-shell/gnome-shell_51.0.bb b/meta-gnome/recipes-gnome/gnome-shell/gnome-shell_50.4.bb similarity index 86% rename from meta-gnome/recipes-gnome/gnome-shell/gnome-shell_51.0.bb rename to meta-gnome/recipes-gnome/gnome-shell/gnome-shell_50.4.bb index 549a3d5971..f39d72532e 100644 --- a/meta-gnome/recipes-gnome/gnome-shell/gnome-shell_51.0.bb +++ b/meta-gnome/recipes-gnome/gnome-shell/gnome-shell_50.4.bb @@ -31,7 +31,8 @@ GIR_MESON_OPTION = "" REQUIRED_DISTRO_FEATURES += "gobject-introspection-data" SRC_URI += "file://0001-shell-app-usage.c-only-include-x11-headers-if-HAVE_X.patch" -SRC_URI[archive.sha256sum] = "2179bab13af353427065096af8bf3d30da7b86e0c516e5ba86a14998af9575f6" +SRC_URI += "file://0002-calendar-server-Fix-build-failure-with-libical-4.patch" +SRC_URI[archive.sha256sum] = "c531939539db316a41aef23670370abd1330d3254f84bcb0f9f4dae5d6e362cf" PACKAGECONFIG ??= " \ camera-monitor \ @@ -43,6 +44,7 @@ PACKAGECONFIG ??= " \ " PACKAGECONFIG[bluetooth] = ",,gnome-bluetooth" PACKAGECONFIG[camera-monitor] = "-Dcamera_monitor=true, -Dcamera_monitor=false, pipewire" +PACKAGECONFIG[extensions-app] = "-Dextensions_app=true, -Dextensions_app=false" PACKAGECONFIG[extensions-tool] = "-Dextensions_tool=true, -Dextensions_tool=false, gnome-autoar json-glib libsoup-3.0" PACKAGECONFIG[nm] = "-Dnetworkmanager=true, -Dnetworkmanager=false, networkmanager libsecret, networkmanager" PACKAGECONFIG[portal-helper] = "-Dportal_helper=true, -Dportal_helper=false" @@ -96,6 +98,9 @@ RDEPENDS:${PN} += " \ librsvg-gtk \ " +# The extensions app is a GJS application and pulls libadwaita at runtime only. +RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'extensions-app', 'libadwaita', '', d)}" + PACKAGES =+ "${PN}-tools ${PN}-gsettings" FILES:${PN}-tools = "${bindir}/*-tool" RDEPENDS:${PN}-tools = "python3-core"