From patchwork Thu Feb 12 12:53:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyorgy Sarvari X-Patchwork-Id: 80975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69306EB491F for ; Thu, 12 Feb 2026 12:54:04 +0000 (UTC) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.44321.1770900835938063185 for ; Thu, 12 Feb 2026 04:53:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RUlcCV2C; spf=pass (domain: gmail.com, ip: 209.85.128.45, mailfrom: skandigraun@gmail.com) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4836f363d0dso1066065e9.3 for ; Thu, 12 Feb 2026 04:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770900834; x=1771505634; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=mbCGZ7MJAoN/E8qTiuGihqidf2MkdbRqtkJMZCGZhG8=; b=RUlcCV2CT50icHi/TKjN6j+dzyIX8Dj0aQvbyXtsC2681Tqnts2a+Oyf6xFZtY0m3/ 5hEh7Oi+BB9j7b8CUH50caR4gIXQQEK0wmg2DtLIopdkzUVxwkwzWRXd6zNzHiLelj0H Vbg3AYWQGkt2hEkWa2B+fNIGkza7p9MH9RkqySczhXt8lb/W3aV6IDnzwUAMzXa4LTM9 9n1Oml1C8e0MEZg1xwMbrvPr+HKCNEVa/bC1ESDfrKewBL1gq3xewdY0fasc+Yh3kx8m bKhFdsWXEZbtShUrKpr8SoQeL9k4Uz5oRGK0h8b/AHY8932qqIQutqSLxIF5B2Fsgx4U LZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770900834; x=1771505634; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mbCGZ7MJAoN/E8qTiuGihqidf2MkdbRqtkJMZCGZhG8=; b=W77o7M9vZTtmwt9yj8Y+KjqGROH4oMQN913oawKdbQJzdA6a6JYVrVS0Qfbq4z/60C LCTcO5fmvPdjWd2uDZwxwiQUjkCyZqo0S3MxnhJ00jcutQAz7THU73SkuxP/3w5YR1YE SE1t165pebLMdXvlcQX6IrQ21Oi7ybAvgl3nPRfaP31qs+UWsOYqaZFtRtyekYBepDtg HFlQ5P+4Ze8BJEgpM1ZIeMJkh8zfTCcZv5qCBp8ROLoX7tcjpQZl/5pLkVaf8S12te9P c4XDOAAAU6ZH08Yvh9X1kErTkBEX8eNxklXO0DEaoTiAINSIcEOUUx8AO4GN5yQQhLWr CwXA== X-Gm-Message-State: AOJu0YxDDxJ20gOgtjJpMoSdDv3V9odM3SHA7FwlcixgKmx7xSpGQjph MiwliJfOpwhBmToNca0wL9C3Bbkb5DUv+UYvVjVx2BSaZFuGO6xPUv2hrY0K6w== X-Gm-Gg: AZuq6aID8uWLus1zALgX1a0cc4G76t+IS/dpLE2KoNis1gUeBrOh9V6YTa6558hjkxb BCjmTwHmNmOfz7sXFIBoX1tQuKv8yLrXKvdhDQFaHp1O22o/cNe3awG1scCSDaYuweZFwBKclh6 g2eskCz0rmkeWp05pAbBWA3XEiyT85n8PdBt8y6wkb4ieaQIZSFkYr7YblMm5RVf0jRRPkwmwIl NdPFgcnCCRWN3r+1/HsMW99Q/SgK2scZ4pP41GYHI/ifWpvp+wk8JhqUE4qkEYOw8M1gliLVTQ7 8QuNXzvRIhUs9nXSFOiXLeIg1AiEnPXE1Hdd02wdxy3CP41YVAlZ+tAnn9R6GG5G9idpCqz69Cr T1B2Mh3kD+819PT9uqOuixIb6Xv0Kvpj48vY09oQw2LdWelcGw6XYZLJ5YriPhscIuDz3oq/17i dGjSrQ7q8wZv+0Su2geEJC X-Received: by 2002:a05:600c:8b76:b0:477:a978:3a7b with SMTP id 5b1f17b1804b1-4836570ed01mr35229925e9.22.1770900833892; Thu, 12 Feb 2026 04:53:53 -0800 (PST) Received: from desktop ([51.154.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835a5bf1efsm89236015e9.0.2026.02.12.04.53.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 04:53:53 -0800 (PST) From: Gyorgy Sarvari To: openembedded-devel@lists.openembedded.org Subject: [meta-oe][PATCH 1/2] nodejs: patch incorrect NEON intrinsics Date: Thu, 12 Feb 2026 13:53:50 +0100 Message-ID: <20260212125351.962556-1-skandigraun@gmail.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 12 Feb 2026 12:54:04 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/124353 The llhttp dependency of nodejs uses NEON intrinsics when they are available, however some of these calls are incorrect: they the call they use don't match the parameters passed, and so the compilation fail (unless the error is suppressed): | ../deps/llhttp/src/llhttp.c: In function 'llhttp__internal__run': | ../deps/llhttp/src/llhttp.c:2645:9: note: use '-flax-vector-conversions' to permit conversions between vectors with differing element types or numbers of subparts | 2645 | ); | | ^ | ../deps/llhttp/src/llhttp.c:2643:11: error: incompatible type for argument 1 of 'vandq_u16' | 2643 | vcgeq_u8(input, vdupq_n_u8(' ')), There is a patch upstream that fixes it (though it is not merged yet). This patch is a port of that fix. This allows us to remove the extra CFLAGS also from the recipe that suppressed this error. Signed-off-by: Gyorgy Sarvari --- .../0001-fix-arm-Neon-intrinsics-types.patch | 59 +++++++++++++++++++ .../recipes-devtools/nodejs/nodejs_22.22.0.bb | 5 +- 2 files changed, 60 insertions(+), 4 deletions(-) create mode 100644 meta-oe/recipes-devtools/nodejs/nodejs/0001-fix-arm-Neon-intrinsics-types.patch diff --git a/meta-oe/recipes-devtools/nodejs/nodejs/0001-fix-arm-Neon-intrinsics-types.patch b/meta-oe/recipes-devtools/nodejs/nodejs/0001-fix-arm-Neon-intrinsics-types.patch new file mode 100644 index 0000000000..ddbad575f0 --- /dev/null +++ b/meta-oe/recipes-devtools/nodejs/nodejs/0001-fix-arm-Neon-intrinsics-types.patch @@ -0,0 +1,59 @@ +From 3f4283dac7d88a89b42f1f2966a862cee5afe486 Mon Sep 17 00:00:00 2001 +From: Gyorgy Sarvari +Date: Thu, 12 Feb 2026 11:03:53 +0100 +Subject: [PATCH 1/2] fix arm Neon intrinsics types + +The current code calls these intrinsics with incorrect datatypes +(it uses a vector of uint16 instead of uint8), causing compilation +to fail with the following error: + +| ../deps/llhttp/src/llhttp.c: In function 'llhttp__internal__run': +| ../deps/llhttp/src/llhttp.c:2645:9: note: use '-flax-vector-conversions' to permit conversions between vectors with differing element types or numbers of subparts +| 2645 | ); +| | ^ +| ../deps/llhttp/src/llhttp.c:2643:11: error: incompatible type for argument 1 of 'vandq_u16' +| 2643 | vcgeq_u8(input, vdupq_n_u8(' ')), + +To avoid this, set the correct intrinsics call that matches the +actual arguments. + +The code that this patch modifies is generated code, so in itself +this change isn't appropriate for upstream. The actual problem +is in the code generator itself, for which a PR is already pending +for merging[1]. This patch is a port of that PR. + +[1]: https://github.com/nodejs/llparse/pull/79 + +Upstream-Status: Inappropriate [see above] +Signed-off-by: Gyorgy Sarvari +--- + deps/llhttp/src/llhttp.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/deps/llhttp/src/llhttp.c b/deps/llhttp/src/llhttp.c +index aa4c4682..887603fd 100644 +--- a/deps/llhttp/src/llhttp.c ++++ b/deps/llhttp/src/llhttp.c +@@ -2639,17 +2639,17 @@ static llparse_state_t llhttp__internal__run( + /* Find first character that does not match `ranges` */ + single = vceqq_u8(input, vdupq_n_u8(0x9)); + mask = single; +- single = vandq_u16( ++ single = vandq_u8( + vcgeq_u8(input, vdupq_n_u8(' ')), + vcleq_u8(input, vdupq_n_u8('~')) + ); +- mask = vorrq_u16(mask, single); +- single = vandq_u16( ++ mask = vorrq_u8(mask, single); ++ single = vandq_u8( + vcgeq_u8(input, vdupq_n_u8(0x80)), + vcleq_u8(input, vdupq_n_u8(0xff)) + ); +- mask = vorrq_u16(mask, single); +- narrow = vshrn_n_u16(mask, 4); ++ mask = vorrq_u8(mask, single); ++ narrow = vshrn_n_u16(vreinterpretq_u16_u8(mask), 4); + match_mask = ~vget_lane_u64(vreinterpret_u64_u8(narrow), 0); + match_len = __builtin_ctzll(match_mask) >> 2; + if (match_len != 16) { diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_22.22.0.bb b/meta-oe/recipes-devtools/nodejs/nodejs_22.22.0.bb index 92556b062e..ea547f6fd2 100644 --- a/meta-oe/recipes-devtools/nodejs/nodejs_22.22.0.bb +++ b/meta-oe/recipes-devtools/nodejs/nodejs_22.22.0.bb @@ -31,6 +31,7 @@ SRC_URI = "https://nodejs.org/dist/v${PV}/node-v${PV}.tar.xz \ file://0001-positional-args.patch \ file://0001-custom-env.patch \ file://0001-build-remove-redundant-mXX-flags-for-V8.patch \ + file://0001-fix-arm-Neon-intrinsics-types.patch \ file://run-ptest \ " SRC_URI:append:class-target = " \ @@ -46,10 +47,6 @@ S = "${UNPACKDIR}/node-v${PV}" # v8 errors out if you have set CCACHE CCACHE = "" -# Use '-flax-vector-conversions' to permit conversions between vectors -# with differing element types or numbers of subparts -CFLAGS:append:toolchain-gcc:arm = " -flax-vector-conversions" - def map_nodejs_arch(a, d): import re