From patchwork Sun Jun 16 19:23:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Marko X-Patchwork-Id: 45222 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8840FC27C6E for ; Sun, 16 Jun 2024 19:24:19 +0000 (UTC) Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net [185.136.65.226]) by mx.groups.io with SMTP id smtpd.web11.40407.1718565853373143363 for ; Sun, 16 Jun 2024 12:24:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=peter.marko@siemens.com header.s=fm2 header.b=OeOsNZz3; spf=pass (domain: rts-flowmailer.siemens.com, ip: 185.136.65.226, mailfrom: fm-256628-202406161924111008d41d3404479d54-1guhee@rts-flowmailer.siemens.com) Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 202406161924111008d41d3404479d54 for ; Sun, 16 Jun 2024 21:24:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=peter.marko@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=XoezKboXvu9cxnfeel/lbuEQKoMeWv9agZMekaw7Yu8=; b=OeOsNZz3rIz3KsuL7/+lrF9sLr0BURo1jlikK8213ixrOawnURag+uL7WPvp0pNoEAQ2Nj SAG++z+gWsYWvFdJyVzieM7H8b7gm23vh1GpqpsYwsK/CNCfADZWwh+RjkL/m9wXVW3h2/Q2 rtnkK42zEGDb/RGPLu4r+/ve6DzY8=; From: Peter Marko To: openembedded-devel@lists.openembedded.org Cc: Peter Marko , Khem Raj Subject: [meta-oe][scarthgap][PATCH 5/6] re2: remove dev dependencies from main package Date: Sun, 16 Jun 2024 21:23:09 +0200 Message-Id: <20240616192310.856262-6-peter.marko@siemens.com> In-Reply-To: <20240616192310.856262-1-peter.marko@siemens.com> References: <20240616192310.856262-1-peter.marko@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-256628:519-21489:flowmailer List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 16 Jun 2024 19:24:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/110923 From: Peter Marko It's a bad idea to add dev dependencies to main package. It's pulling build dependencies including toolchain items. The dependencies "were needed" because main package contains packageconfig file. This can be fixed by correct packaging. Signed-off-by: Peter Marko Signed-off-by: Khem Raj Signed-off-by: Peter Marko --- meta-oe/recipes-support/re2/re2_2024.03.01.bb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/meta-oe/recipes-support/re2/re2_2024.03.01.bb b/meta-oe/recipes-support/re2/re2_2024.03.01.bb index 192fe265f1..6e5b32a945 100644 --- a/meta-oe/recipes-support/re2/re2_2024.03.01.bb +++ b/meta-oe/recipes-support/re2/re2_2024.03.01.bb @@ -16,9 +16,6 @@ DEPENDS = "abseil-cpp ${@bb.utils.contains('PTEST_ENABLED', '1', 'gtest googlebe inherit cmake ptest RDEPENDS:${PN}-ptest += "cmake sed" -RDEPENDS:${PN} += "abseil-cpp-dev" - -INSANE_SKIP:${PN} += "dev-deps" EXTRA_OECMAKE += " \ -DBUILD_SHARED_LIBS=ON \ @@ -39,6 +36,6 @@ FILES:${PN} = "${libdir}" INSANE_SKIP:${PN} += "dev-so" # Don't include so files in dev package -FILES:${PN}-dev = "${includedir} ${libdir}/cmake" +FILES:${PN}-dev = "${includedir} ${libdir}/cmake ${libdir}/pkgconfig" BBCLASSEXTEND = "native nativesdk"