From patchwork Fri Mar 17 22:42:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21171 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248B6C6FD1D for ; Fri, 17 Mar 2023 22:43:19 +0000 (UTC) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web10.457.1679092997215324331 for ; Fri, 17 Mar 2023 15:43:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=rzcRbV78; spf=softfail (domain: sakoman.com, ip: 209.85.216.50, mailfrom: steve@sakoman.com) Received: by mail-pj1-f50.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso9027349pjc.1 for ; Fri, 17 Mar 2023 15:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679092996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NHoh3L6ahCiMtBdgE7dNHosEp4qAEDkO+zZIqzeAxUY=; b=rzcRbV78YKXekFZkvhnsnv3/dwuLkKmEVvx9/6d0Xr3y3SseQM7jDJ9Qg1QcIYlMnL jm4V9o2bF6iCI/UjAmVblLeamDcAqVcc7W9JDNxAZSP6fCADKjzi28UupHcS3V1BwTfy bo5L4QGaRnLe0q+iavxWQ2IA1BNOzNoOyej0AKgyUGrIr4FVnaZQdZXfdSquWn6m4k6N X/cqKILJ4U/rO0puSwSQEOs371HX5X5zZFGOHW4R+LVSjzMsB6bq1EH//B/w5OgcKlJO NJBGtib+m6g2KAdCSGNlhVyDaRYgoZobZJQciCSK+Qq2+5xa9jS6Kwxyi3LC2tfzE8NR ec6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679092996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NHoh3L6ahCiMtBdgE7dNHosEp4qAEDkO+zZIqzeAxUY=; b=pK+iL79l07cX0ryKo+Z9hEpIfWhDAaukcuX00Gzo1EzdqT5FIWiqur94MM5Rt4Y0oF L2peUHJFCtCGfPquXGwKJoe+Gphs2UDzsfdj4lFXHAeey0/uxTgs+XW7WEbfp0ALEL0S QF2Ywe/+kvOne27kD3BONtVshQo2fmM9IF2ZgZBqc0VPbX2ozGA6mrH5i5ygP73n/luK VU21T1CnMA7Wb4ShIECIiJZpe0liaN03qD3BPhJLUKriWb3LVU6bEzeOC1j/rgOw0Zla 21livhlrcGCIRHXlg97bdCYfpOX+acJbhNTuCkHbcsy2pZl2oonWjW79M20dZ03f6I5n +gyA== X-Gm-Message-State: AO0yUKXVd/gZoBU/hfWH9TmMVVKnPwtRrEhnl5oppBbvC3X/d8Tvq+II a/5nQsE2ISjSIctr3+yc2C7yqdCchFvKIFfqJis= X-Google-Smtp-Source: AK7set8ePD/2yDwHhKgfpqkVPRAEdhiv0ph4mmGu4SnaACCLNR0szT+Y1kMkNtqML14bRtpEO4vWhg== X-Received: by 2002:a17:903:74d:b0:1a1:a7b6:e31e with SMTP id kl13-20020a170903074d00b001a1a7b6e31emr3220507plb.7.1679092996391; Fri, 17 Mar 2023 15:43:16 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id jb13-20020a170903258d00b001a19040435bsm2027152plb.100.2023.03.17.15.43.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 15:43:16 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][kirkstone 19/21] populate_sdk_ext: Handle spaces within user $PATH Date: Fri, 17 Mar 2023 12:42:33 -1000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 17 Mar 2023 22:43:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178780 From: Kenfe-Mickael Laventure The script generated by the sdk_ext_postinst function was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 00e96bf250eaaded839caf465dbc0af5b604aed7) Signed-off-by: Steve Sakoman --- meta/classes/populate_sdk_ext.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass index 0fd30478dc..a673af7e7b 100644 --- a/meta/classes/populate_sdk_ext.bbclass +++ b/meta/classes/populate_sdk_ext.bbclass @@ -714,7 +714,7 @@ sdk_ext_postinst() { # A bit of another hack, but we need this in the path only for devtool # so put it at the end of $PATH. - echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $env_setup_script + echo "export PATH=\"$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH\"" >> $env_setup_script echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script