From patchwork Tue Mar 21 14:20:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C37C761A6 for ; Tue, 21 Mar 2023 14:20:57 +0000 (UTC) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mx.groups.io with SMTP id smtpd.web11.14404.1679408453287192571 for ; Tue, 21 Mar 2023 07:20:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=4XBacrpL; spf=softfail (domain: sakoman.com, ip: 209.85.210.169, mailfrom: steve@sakoman.com) Received: by mail-pf1-f169.google.com with SMTP id dw14so3678447pfb.6 for ; Tue, 21 Mar 2023 07:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679408452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rO6dXH7WvrK5PAZw6VZ7awDQP1+D5Nt9mMeTUQ98tA4=; b=4XBacrpLM7Xh1h+X1/eWxjibCC9ALTt0xSFqs2Q5GGYQxZhuq1XYGSsBmy1w1uV3xb 3Nc/j4Z6oSwOASvWt2pAJ7z1qRoEbfa1zGRuxHCWRbrC9yXy6pPBxIwLZ3OIemW5MaF3 MnB8AgrpQVb42pxb3Yc2NdOv2e0pH4O8VrQnSo+9WvLFHbYYemcKlrblSHNL2ok3Xn8/ NPTXWiFneJSpZUYmiVsiHxJ5vAIJCXdzyA4c9lPYTy96Jzm3dCukVEgQxcWHNkbA/Iwh 7vtTZOXuIZ14Po6ZqlLyL97iLVmSdmNSRHvoR7iezQ7eLjpZekxWorkpa3sGhiBzoXec FloA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679408452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rO6dXH7WvrK5PAZw6VZ7awDQP1+D5Nt9mMeTUQ98tA4=; b=KtSW3mpkEyP7oXHu7KbqcQPwb6dunDocXi8kXWLzw4tqiF5N0TE+DfAF1cUMoMMttc Qdpsq3URqASam0WTdNGMHowX9+j8451WmgPkA7peBqceZw93YUburD3a43nfK54RA92e g8IqGuMUlwIlXMZGQ7I/YPzwzHfmfqEperr7zMdGquwK//iy9y78WeTLNY25DMYg1Osp /IOIivdma8LhbSIK8nw8W3zCkGueNiRsKFkOH3jltCiDKbKt8db8iqE9jp6WMspw1BAR vbNYAgcoWpQFvAtXuSOqOS5z5BBZ7UGZu1Mor0gCjCPPML31+zyzbDFzfNx7PyPMXWGr qVCQ== X-Gm-Message-State: AO0yUKWXJ5kmUjA3aM4/5rmx3s3fGiM6CXwOId3YyKzlCD8zQvvmXNoK LtaRf2+JaBQARt2q6r3e9IMRsRbKBaqNRn4nVt4= X-Google-Smtp-Source: AK7set+FL3rSDdQe1K24ySxAVdtCneXNtXTSz3GHDSIVPCXGtTa4r1wmzeulLup4wndR0y6/71uGGw== X-Received: by 2002:aa7:93dc:0:b0:625:caa5:67ee with SMTP id y28-20020aa793dc000000b00625caa567eemr2201118pff.19.1679408452364; Tue, 21 Mar 2023 07:20:52 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id g11-20020aa7818b000000b005892ea4f092sm8551291pfi.95.2023.03.21.07.20.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:20:52 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][dunfell 12/14] toolchain-scripts: Handle spaces within user $PATH Date: Tue, 21 Mar 2023 04:20:17 -1000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Mar 2023 14:20:57 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178883 From: Kenfe-Mickael Laventure The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 42177ff2d45ee70ad00917bb6fbabca49dae4f59) Signed-off-by: Steve Sakoman --- meta/classes/toolchain-scripts.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass index 9aa31dc6cd..21762b803b 100644 --- a/meta/classes/toolchain-scripts.bbclass +++ b/meta/classes/toolchain-scripts.bbclass @@ -44,7 +44,7 @@ toolchain_create_sdk_env_script () { for i in ${CANADIANEXTRAOS}; do EXTRAPATH="$EXTRAPATH:$sdkpathnative$bindir/${TARGET_ARCH}${TARGET_VENDOR}-$i" done - echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':$PATH' >> $script + echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':"$PATH"' >> $script echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script echo 'export PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig:$SDKTARGETSYSROOT'"$prefix"'/share/pkgconfig' >> $script echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script