From patchwork Mon Jul 14 07:55:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Jonas Mark (BT-FS/ENG1-Mue)" X-Patchwork-Id: 66726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E97C83F17 for ; Mon, 14 Jul 2025 07:55:19 +0000 (UTC) Received: from DU2PR03CU002.outbound.protection.outlook.com (DU2PR03CU002.outbound.protection.outlook.com [52.101.65.22]) by mx.groups.io with SMTP id smtpd.web10.73288.1752479715144930417 for ; Mon, 14 Jul 2025 00:55:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@de.bosch.com header.s=selector2 header.b=V/KxRVVc; spf=pass (domain: de.bosch.com, ip: 52.101.65.22, mailfrom: mark.jonas@de.bosch.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kApAu9nL/TcLAuabA25UCvjV11HH6fpfUiNOy8LPUzWOMZyXdDQAMeUXwQPsWrHG2taA2uoeP1Eh8B9dvePpTQZJDFZHAscsZu6FYx7+uvfS14ZLi3UqRYdlpvQGKk7BrPV2i8Id9ktBloKtHW9jFqLIPTMo5hJ8R0VwdRTJO4NluLmjW+REQxwDBaKoP5RvaVihczjxXsjNj/Cphb0e5u2iXOPWITsud3bHr7Fkn76XNh4V9w2XPJFMVQWD+yoHkxT5iJxX7YYLclWP+2AGsY6yNSltIgDsObfVk5SE7L7R5QjMFA8NuLJCVDKL+QkTe9Uo9lFGp+RnuiEhZpitaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7DGrZYeGRmt3iUQ+w3aDDCz02TOR1rgXo4VOEsJhNZU=; b=iU1RshRsiKTVJPN44sYR3G/2/6R5Ni3mV2qjew9ZqbiqNwHy+lo42S8F9wSKgsi+W79YtTKrzyZQYl5DWBK1nQRdWho4qCjRmVvt98Nfl3Gwplb8545SadT8Iy73ZUwaCb99XxLJz0q8UldDguzBL5HexqbPP4EPfSYeDb5z73Ak5tA9FMZPqEpS4af0Q0U515fBjYRatoaYCe6OIlKtlhrup4NLYZaNHs0WVa1h7rvrMjr8t8OgC9+OXGoygZDSHYCn7ksGclYmsZLYiX0ASWkiHbCPpPP4pJuspgl1LJwROyZoZj/mDyTHwwnZe8PUT/B/Ys/ASnMA0dlfxjlrsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=de.bosch.com; dmarc=pass action=none header.from=de.bosch.com; dkim=pass header.d=de.bosch.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=de.bosch.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7DGrZYeGRmt3iUQ+w3aDDCz02TOR1rgXo4VOEsJhNZU=; b=V/KxRVVc9NZHnjPWPxtvfdoKzfQdtZ5VCU/WvsLHLZ9J5EvxH1ptYXXG7s/FVhC4omH52vBriD81toxXdXm5MGY8m6CwOMpVAd4zC4vjKp/zCPP6IiliYdV0l3/MuCZXphPSo/nLZ1psXjGnu0P/y0jhpNCO6A8zvZNZv7ipL9Bp8BmGvDdIzYsrPrz26JpzkVA39J1uZuce9vw/T/zJ4qUHCMz+shkvQ/+NmaIlnNJkTU1jKDyl6beTMutTN6HfOLnrDAu9kweWlK3hAfCWJFRID83AGCgCBsAfeD6wWJmnLvmGnX44n7Sk/sGH1ZW/DQLaYVAP2RHIC7QTmBAKcw== Received: from DU0PR10MB7076.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:423::12) by DB8PR10MB3259.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:11e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Mon, 14 Jul 2025 07:55:11 +0000 Received: from DU0PR10MB7076.EURPRD10.PROD.OUTLOOK.COM ([fe80::104a:4c1c:9bb3:3036]) by DU0PR10MB7076.EURPRD10.PROD.OUTLOOK.COM ([fe80::104a:4c1c:9bb3:3036%6]) with mapi id 15.20.8922.028; Mon, 14 Jul 2025 07:55:11 +0000 From: "Jonas Mark (BT-FS/ENG1-Mue)" To: Khem Raj CC: "openembedded-core@lists.openembedded.org" , "jpewhacker@gmail.com" , "mathieu.dubois-briand@bootlin.com" , "Simoes Ricardo (BT-FS/ENG1.1-2)" , "Jonas Mark (BT-FS/ENG1-Mue)" Subject: AW: [PATCH v2] dosfstools: Add ptests Thread-Topic: [PATCH v2] dosfstools: Add ptests Thread-Index: AQHb8oR7AuoQa1Dgfk2ARPC62uURlbQtJrOAgAQbxHA= Date: Mon, 14 Jul 2025 07:55:11 +0000 Message-ID: References: <20250711165344.15438-1-mark.jonas@de.bosch.com> In-Reply-To: Accept-Language: en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=de.bosch.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DU0PR10MB7076:EE_|DB8PR10MB3259:EE_ x-ms-office365-filtering-correlation-id: c9a11b76-888e-4cdc-b645-08ddc2abc2a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|13003099007|7053199007|8096899003|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?bDDMgYtEXKY/Eyz6Dt9lUtBbWvmzNr4?= =?utf-8?q?XjxK8Gm0xzf22ijh6zdW+r/+Inh/kw3NRJJtRN+YKPGdqrocOo5luyvslUimDyUOc?= =?utf-8?q?mi55q9I3qbcZejL31EtAjDioTP+rkdqUMCjxxB4kESDVRfPFSgeF98wVdxKUob9kt?= =?utf-8?q?1S6JUnCOTlWIy48X7T9Phm+VwNpAWXk2tWr/lZgeXDXvtUa5dp9e8tixlCkWA4XIG?= =?utf-8?q?SvDCSqfC+SIYUd69sTjqGKtAM7wfRJ12FsyqQRu6YUXll9EXQoiigroDwua9Tb6ss?= =?utf-8?q?HzCepcuatRTQLUGsbLwIxRJD/5qlC+Cehk+7xwSZG/1UjeydlQrJKpsc/PRfBo7sh?= =?utf-8?q?MqdF4hzpIyqGJzWwrUbgOUywfVGdZci8YChqCUGZmaYsnGoJuIRyUYFtWYHQnOzS0?= =?utf-8?q?yzBp++XIsV9JfQyqu5zB2R2LniwK9d+zllQs2L+K2xL+rQIVqgRWiV65oSrMmatVb?= =?utf-8?q?W21JN9ohT+/LN/5HEzw9QbFJ3RWxKZrfKCbibvrz9Uj8bmFFsR3iQgfxVaXHLAGzY?= =?utf-8?q?uCf5nnPfU1mz23qeUHnIXPy95ahr1K/+cuofTl8oGJ1HUCHzhHh+GYAG27o2rQd5Z?= =?utf-8?q?yieG00lqHf+55jrWhl3EZ6RTUxjacFG0FvFuFvYhyqgy9+MyFUEH/7F/ecOapdALp?= =?utf-8?q?lrIh211TCj4OTKjzj87gkARw8HYYwb9xNkrVGktbfU7L+O+9TKJlWibEMwyz+eZb2?= =?utf-8?q?WKGLnKuOGYS6t++BQHU8rFImjFihlYjVgcHKLtUNIKVrIRlStvpAmr2bXBqJWH/1F?= =?utf-8?q?uistah3fDq1eULJHGDfnWmjKo9dbveyQpvMU3GXOV2lOPa0k9/IXDob/4qhIHXvcP?= =?utf-8?q?eW7KwMu1L5NnwsYqhP340ca/fTUVB+0HsznQ4IpysDsTAlipQxFuME0GsG3bu3WdU?= =?utf-8?q?RNRYCekVJHHY3OtMYB8ztu9NPt71Hg5NuDRvTk28Lsc5hMrbdKz84a2PfFwJ1uUn6?= =?utf-8?q?D1GJFyKMmeknrmK8hz39wtZ+Gz1VyUTLnD7QP4oO0l6BKCe2gTZvUSKqSLeXJyMM9?= =?utf-8?q?lL2rd8lje8afNsPYz6y/CMrKrFR5oTo6HjNBiUTKCzpaokLvD7A9komAhF/EYZ9R2?= =?utf-8?q?Vo28A6xKJMxUrh2SG11kaIgl8mcaXAxl2tBaoz0rZef7aCQfpxDNcCqkBLU+x8DPj?= =?utf-8?q?dnq+7w2CJJLHI5oYdLg/DluYSvC8fMcV5/c6nSEagyJ30AsEUe35nv+LB7j1FGY+/?= =?utf-8?q?Wl7Jd5M0aQOa4CDEIa1slcHy5lPFxtwW+FfMUIGuD/6mAL2/lFfU65IjjL0ArSY8z?= =?utf-8?q?YMFuVv5xo7RHo7e4JcJZyvqPd9WIF7KDWFsUwB/JNJ2QbEd/FbxxpsKwFZpHmOT+P?= =?utf-8?q?kXq8Xp8E8UlzjotgH3/EFkmd8rgKY9eRCwKpQeI6cBxOBf96pnblMB0=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR10MB7076.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(13003099007)(7053199007)(8096899003)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?iExPkjdYGA61XPND/6gyfUIEtdFp?= =?utf-8?q?UBqbzSK3lsX+KxttR4cLbnmmRt/UKwOJR0+HrjCKmnY0YhHVCICksiurABpnfR9IW?= =?utf-8?q?u9JBEA59fy6JxBOvyGgln86e2kXcS5E1XF/t0BKea3J9qvh4c0IkSF4tw1qll6n/G?= =?utf-8?q?ALwJfcXaSfHSvtublIvnradR1PkxJFrFyaAOox8G7vwje78Ag/6ebfmA4+ogXYjHN?= =?utf-8?q?7Yiux2rk+gE3B5Smj/TSOV7hS+e6voyWa+KvaQi0LCrJuMCe/adm34f6VpJZy0i7/?= =?utf-8?q?J48nmaYthjTTu8o/DrWOT0x9Y8++omGaKharjacfwRJyE8i1OkWYk7CZb5XkwvS1h?= =?utf-8?q?YnpEgzvDB7Q3Kz9aktWA7dY4fTFG4LBStipz0rObwdQXcR2jFcpOH6AMlSJoEu0KL?= =?utf-8?q?NuLsZ/bPGdahIMZULVOcMTnCt+xZN2En7BVz0XGX6hm61omM60UDRGJWN9oV3w+Rj?= =?utf-8?q?tAABROKtLJUdwqm84ak61eJSgjIwQAornu5aObyrr21wqdSl8p3kW3qfm/0kV31WI?= =?utf-8?q?u+829L0YrGq81moiOYlV3pECQ8a3Vgs9/CAHMupwO4uxpmmE/brog69/GpOMJUZQf?= =?utf-8?q?tg9LDA3YCWcyWcxi659y8EpObIbRMjL3hOerZj11vNxDuHN2hm660+v4gNy0CyOT8?= =?utf-8?q?VcpRfWxbw6ZRbEznWfri5ic/T/4caHcwHq8Ss5eT4zFsp3dAbd7hJ4Fj5VT2HtbhG?= =?utf-8?q?7OUS435Hj/bD8jyp4zBu+tm+djcj3OalHlseUb+GyO2bBR0eRXa4BF+DpFpsuvba7?= =?utf-8?q?RnGf+Sq6+H7dWxBMHjLSc21KNDVFAqyu8DytKDJYYzWbhzpw/EFHppwkqDJZzNvuO?= =?utf-8?q?gLazbcaHZyH6gRWK88trYYyvm+gZdm52U03EI1ZuITjy7jQiWaTtoePFF1wK+1OlD?= =?utf-8?q?CP7Vrj1nwGU8ELXuJtIlSxtELx3sRKcQ3SbLfoOiLQnBZukPAVXNb5HgsOae4EOvm?= =?utf-8?q?AUrID7SJjXJDWewjoiFrpB050bWsccsPEOhYqOrVucWsuaVyGX7H9p+HVPlVUYi0V?= =?utf-8?q?Vyf3rNTeomDPuVJl77JCsZL2Lpum6M4Q29smzccpMFfwti0SuwTD9YW4gIBJtIKJv?= =?utf-8?q?IQcOI3r50eIe2kkHPTT5mawy3iVI4ZwrxalGX4qTxAtpWdaMK2GpbsIuADhb4EAhF?= =?utf-8?q?HsCtQ9l9k5cdwqsO7370U3QTt/jzUryrfMJ0tbIV6KYRexedFMJf4ddsGV5HdeHGH?= =?utf-8?q?MskNShpWeTI3yD51udglJDDdHNY3Gw5xEwdn1ZGagAWfjYWwjUps1TQl9CSuQ7vFK?= =?utf-8?q?2J4uoAmuJymcNCcV7CWJG5Hi7UGzvK3SIVwb++qJEKce+gMqCjh8hQhY+6T+t/0KL?= =?utf-8?q?rywJmZylg66zP140DpeKR57gTU6pyBPwHNFJdtZtxshuH6mh10j15bFv+Gg/Wa6jo?= =?utf-8?q?vSPApgiKhWQjeIGJFdC3sbUuX8etMwthTKONozk+jY+I5poO0n82kM48m9uha9bbn?= =?utf-8?q?PkrA8bRObDDPjnAuhn6BKujwmO5ko+kbDDAJ25CeQ6HxXetiCHgGERAA=3D?= MIME-Version: 1.0 X-OriginatorOrg: de.bosch.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB7076.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: c9a11b76-888e-4cdc-b645-08ddc2abc2a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2025 07:55:11.7168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0ae51e19-07c8-4e4b-bb6d-648ee58410f4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mmnS5y8yAaj4ivDRxI8blW/WouGN+L6Iv/iPbvNz4kieh+xPZdfcalNqMfjIvoARPawk1P8aYaupxNcb5tFzHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3259 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 14 Jul 2025 07:55:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/220215 Hi Khem, We really tried but were not able to find any tabs at all in neither dosfstools_4.2.bb, run-ptest, nor ptest-packagelists.inc. Also oelint-adv did not find anything. Can you give us a concrete hint what to look out for? Later today we will anyhow send a v3 of the patch. We’ll replace the verbatim /usr/sbin with $sbindir and use install instead of mkdir. Thanks for the review, Mark Von: Khem Raj Gesendet: Freitag, 11. Juli 2025 19:05 An: Jonas Mark (BT-FS/ENG1-Mue) Cc: openembedded-core@lists.openembedded.org; jpewhacker@gmail.com; mathieu.dubois-briand@bootlin.com; Simoes Ricardo (BT-FS/ENG1.1-2) Betreff: Re: [PATCH v2] dosfstools: Add ptests A small nit There are some tabs vs spaces discrepancies On Fri, Jul 11, 2025 at 9:54 AM > wrote: From: Ricardo Simoes > Signed-off-by: Ricardo Simoes > Signed-off-by: Mark Jonas > --- v1 -> v2: - Add missing RDEPENDS of ptest - Link tools to /usr/sbin instead of /sbin .../distro/include/ptest-packagelists.inc | 1 + .../dosfstools/dosfstools_4.2.bb | 30 ++++++++++++++++++- .../dosfstools/files/run-ptest | 5 ++++ 3 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-devtools/dosfstools/files/run-ptest -- 2.34.1 diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc index 4253c7b062..46c8945eb4 100644 --- a/meta/conf/distro/include/ptest-packagelists.inc +++ b/meta/conf/distro/include/ptest-packagelists.inc @@ -99,6 +99,7 @@ PTESTS_SLOW = "\ coreutils \ curl \ dbus \ + dosfstools \ e2fsprogs \ elfutils \ gettext \ diff --git a/meta/recipes-devtools/dosfstools/dosfstools_4.2.bb b/meta/recipes-devtools/dosfstools/dosfstools_4.2.bb index 86fb68f664..0772f39381 100644 --- a/meta/recipes-devtools/dosfstools/dosfstools_4.2.bb +++ b/meta/recipes-devtools/dosfstools/dosfstools_4.2.bb @@ -10,18 +10,46 @@ LICENSE = "GPL-3.0-only" LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504" SRC_URI = "${GITHUB_BASE_URI}/download/v${PV}/${BP}.tar.gz \ + file://run-ptest \ file://source-date-epoch.patch \ file://0001-fsck.fat-Adhere-to-the-fsck-exit-codes.patch \ file://0002-manpages-Document-fsck.fat-new-exit-codes.patch \ " SRC_URI[sha256sum] = "64926eebf90092dca21b14259a5301b7b98e7b1943e8a201c7d726084809b527" -inherit autotools gettext pkgconfig update-alternatives github-releases +inherit autotools gettext pkgconfig ptest update-alternatives github-releases EXTRA_OECONF = "--enable-compat-symlinks --without-iconv" CFLAGS += "-D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64" +do_install_ptest () { + mkdir -p ${D}${PTEST_PATH}/tests + install -m 0744 ${S}/tests/* ${D}${PTEST_PATH}/tests/ + install -m 0744 ${S}/test-driver ${D}${PTEST_PATH}/tests/ + + mkdir -p ${D}${PTEST_PATH}/src + ln -sf /usr/sbin/mkfs.fat ${D}${PTEST_PATH}/src/mkfs.fat + ln -sf /usr/sbin/fsck.fat ${D}${PTEST_PATH}/src/fsck.fat + ln -sf /usr/sbin/fatlabel ${D}${PTEST_PATH}/src/fatlabel + + # dosfstools tests depends on variables defined in the tests/Makefile. + # To run the tests, we need to modify the following: + # - srcdir: used to find the test scripts for each dosfstools tools + # - top_srcdir: used to find the test-driver script + # - Makefile: originally used to recreate build rules when needed. They're not needed here + # because we only want to run the tests. + # - XXD_FOUND: Always satisfied by RDEPENDS of ptest package + sed \ + -e 's/^srcdir = ..*/srcdir = \./' \ + -e 's/^top_srcdir = ..*/top_srcdir = \./' \ + -e 's/^Makefile: ..*/Makefile: /' \ + -e 's/XXD_FOUND=/XXD_FOUND=yes/' \ + ${B}/tests/Makefile > ${D}${PTEST_PATH}/tests/Makefile +} + +RDEPENDS:${PN}-ptest += "bash diffutils gawk make xxd" + BBCLASSEXTEND = "native nativesdk" ALTERNATIVE_PRIORITY = "100" diff --git a/meta/recipes-devtools/dosfstools/files/run-ptest b/meta/recipes-devtools/dosfstools/files/run-ptest new file mode 100644 index 0000000000..4f6e349a23 --- /dev/null +++ b/meta/recipes-devtools/dosfstools/files/run-ptest @@ -0,0 +1,5 @@ +#!/bin/sh + +cd tests + +make check