From patchwork Thu May 9 17:49:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Kovacsics X-Patchwork-Id: 43433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83FCC10F1A for ; Thu, 9 May 2024 17:49:18 +0000 (UTC) Received: from GBR01-CWX-obe.outbound.protection.outlook.com (GBR01-CWX-obe.outbound.protection.outlook.com [40.107.121.111]) by mx.groups.io with SMTP id smtpd.web11.2139.1715276951800019249 for ; Thu, 09 May 2024 10:49:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@carallon.onmicrosoft.com header.s=selector2-carallon-onmicrosoft-com header.b=LIcHH+2c; spf=pass (domain: carallon.com, ip: 40.107.121.111, mailfrom: robert.kovacsics@carallon.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mR+0xsmecsY6K2lmhd6zed+l3yYpM/F0r30OSijb0e1SRJDO4QsbmwqUOgZbU0UR47RrTXtX3vdAzPVI/lnx7XTZ9V+CQO2OsD2bl3OxRG8lfrkYq0b7bKNsiALTICHV4UIxbkJKdhxBgcCQeUFmKGl6Pm+U2t1MhpBn6P3luyvlyDhkvxURxSfipTY8BuS9HynMuuxShgUKAMAFfaJMJ7kRsMREKNsaO+4Uqd5P2we0k6UoDHF3ZZRFgwfVS3qUTMD2rKB6+cZjL19v1ZpcY6pJyJga0V5PjmllixiowBTsZANYlRJJunUwnnyIXH5Xs4a/GxAO5c9sjqamb1T7bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v1BsRACWiL26bJVQlPWHJclBwagXk50xqreThHqrhmU=; b=ZMdctkYeY3U4hoahP0Gc7zv/owb0UCHmnfP2U1Aryu9IbNg+QsJtxwREWIB9amKc1YWHVPyqHc1uUWMpnFh9SLSDMGgmWI03jH4DFYLb3cdpCqBi9UiYdCr4kPpYeRqajp4jDymeYQKh8bG59vMVeMqRocJb0UHxQ1zssyjZ+7c+cGMkmAABq4uRx+NZP1qzt7OgOJMfhtHWnDcjeZmgLIFVrlnbo6IOpuFPndgVNZYbKEIDO5dedIJ6Bkb+p2oe9eeaf03SQJnjTVihwAoex1D51YGVjupnRfOU9TW7GG1VeOEDLwFmb+dVDqQN+9HlpVdjXYRQnW5Y5emsaSYZcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=carallon.com; dmarc=pass action=none header.from=carallon.com; dkim=pass header.d=carallon.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carallon.onmicrosoft.com; s=selector2-carallon-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v1BsRACWiL26bJVQlPWHJclBwagXk50xqreThHqrhmU=; b=LIcHH+2c0ufl7rl0fy2wSnhBVL3MBjzoRpYcD0IkKMCPzjqs6pTRwB7aqt0733SAltlbvPsK2rJbbEsMGtkKcJgFk8EO5Fgnx0TtVyyTp8PxP58kECipxtmOKXR5RUf8nqwj/TLIU9tcLdhM8Jx18p+4e3l9iJhc5rgORPd3hxU= Received: from CWXP265MB2693.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:ad::13) by LO3P265MB2188.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:106::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.47; Thu, 9 May 2024 17:49:08 +0000 Received: from CWXP265MB2693.GBRP265.PROD.OUTLOOK.COM ([fe80::4711:7677:a3f:b1eb]) by CWXP265MB2693.GBRP265.PROD.OUTLOOK.COM ([fe80::4711:7677:a3f:b1eb%4]) with mapi id 15.20.7544.046; Thu, 9 May 2024 17:49:07 +0000 From: Robert Kovacsics To: "openembedded-core@lists.openembedded.org" Subject: [OE-core][PATCH 1/1] sdk: Fix path length limit to match reserved size Thread-Topic: [OE-core][PATCH 1/1] sdk: Fix path length limit to match reserved size Thread-Index: AQHaojXicnPw/RNvOUOpmtqp8HzFGQ== Date: Thu, 9 May 2024 17:49:07 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=carallon.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CWXP265MB2693:EE_|LO3P265MB2188:EE_ x-ms-office365-filtering-correlation-id: 1c1830e7-192f-47c0-0462-08dc7050534e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|1800799015|376005|366007|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?q?xTapZkO2RD/2Dft/qNjuU4W/Wy?= =?iso-8859-1?q?CawrCwI3kpSNIZArD3IFC2rWlfAugnTBouejwvV3wxJO27VxIjIBfR5EggaS?= =?iso-8859-1?q?uqHy7f5JTvDJQYE5fjtIVvYtipbW5F+WdWTnOxvEpEy6Er8VQ1NFpOULAFqk?= =?iso-8859-1?q?HaBN13MiwubOKljBw131BL08ePXpvG+0xkgRAf/9GRDQBVzipwOqSpVlrIne?= =?iso-8859-1?q?LLVOEnhZkO2iuj3eznuHw7q+D+skRlrVHUIQru2nMhfC7SxmDXvmavWK90sa?= =?iso-8859-1?q?QYLwhtAZcbb2HXlka+2hL0gBDGNF84ERBQFVmhjepntQahka02nvx9yGY3GF?= =?iso-8859-1?q?2B3V8Umgg5mytNFnAwXRUF2B25lJg66WT+5cYlQfHh3BNBZgT6toLYF2bHYv?= =?iso-8859-1?q?9l/thMcKDJBKa5rHUBxHbBXx4PIz9If62Ujpy4tCFIkpmgoW6a5zHTBLjsW2?= =?iso-8859-1?q?gJ4LPF0CJFqMv98SUMABQqQBGaNhQawVW+4U0psIeGrEYg2vLAIh/ZLkyXYr?= =?iso-8859-1?q?+fLHt5cNDxpEkAkiaITH2llcN4xgktYqGHXibACidcJHFJ8Rdawid0sVhT2O?= =?iso-8859-1?q?5XI7cU2laGy6BlacM4zvRu7hDM4A6ZPJUzi+H0kknJQH4XQpIfFdWjFLo3L+?= =?iso-8859-1?q?P0iODYEhc6V+loGPbGGBRs2YKmMwkWz6Ti9uFVlS7nQkhTgvzWXBa7dNB9C2?= =?iso-8859-1?q?ErCtjRUGrt1sL2uVCt41m5RgFN/XX37cPKUFvZg+ncCa3OC9dLGHZdoUUAqP?= =?iso-8859-1?q?E/ALHg0NSnPvKGiQPAndHlweIF2zkJMIGsYMhJqP4wZvaOxQyxr/tUdSq7ow?= =?iso-8859-1?q?/RCzhyVN1Mf454BYiTcS17CvJGvF4Wv0qgchGo+nKPINNbRwh7dYOQ88wPWL?= =?iso-8859-1?q?MACY2M/aCdQMbTROwrn+d5cfM15Hj+bCfs0T8iXSTNtSe3YQwhSGwQoHtj1L?= =?iso-8859-1?q?ANWPLDLKRJ+7namt7/XmYO4BRXmI6GaXgDxUGjH05sx7+SV60v20I1CGcv21?= =?iso-8859-1?q?X8YkVwVu+vdr64y0kADCkdkeWk43Ju9W8J7Ny5jjjarnF2ze49tIC6b9JUUe?= =?iso-8859-1?q?GHf1eEqsHx9Or5pV54BYGJQF+z7vL3AU3iX7Dw88dsOjiHJ3qy+uvg2kAeIq?= =?iso-8859-1?q?IRK234YjeT7byrzQnNG74ZPe0C7ujqveTWB04tfgg9+ubduUmkvn8i846Hsq?= =?iso-8859-1?q?lcg/l/rvaS0Cub8hvaTUNvphw/F1TinRboW+GHOO/PUoqzBNKVEoUiN7TKpC?= =?iso-8859-1?q?+GFR/dMs1ljcgNjyiqaxzbJEfvWazet+5qGUb9N6bmflf1bT8JJS6QkHBRc3?= =?iso-8859-1?q?hdmiLYafTZmdAQugRsfQ1jBR+dPuNb5Re02QemaCk8zmnJvBn8SKbp+1ki3d?= =?iso-8859-1?q?r0BBidm0qBkdrjcrEtEQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWXP265MB2693.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?I3F1rAg1TfccfdghdHItHgU?= =?iso-8859-1?q?DPiMpa+3O0IkdJWLZl0/NCGHUX1by5jgbfOu6PPg7bpOs1zE9uZpdXwC9/BS?= =?iso-8859-1?q?BeNmUB4SpOB9GFCgV2XGqCGHgRaaKrweBQZ9bxRpTW1Rd4E7MetYli2ipv/8?= =?iso-8859-1?q?eM/gk1uxRJdF7Xg+jK/blH+z8mVNrhFHfqpZGB7GIBu0Dd1d7KYrB/3kAuNu?= =?iso-8859-1?q?pKyvnem1Xe/vZzX1kjgM2PpQyoFkhKz8WkNAYY9XoPbf1htRutvU/NGR0tcy?= =?iso-8859-1?q?l4LJiMiww4CG9rjEDjs/Q1NM91E7nNm7E/Lx3GzTsBJJMqAjg1/jxE1suyn2?= =?iso-8859-1?q?nXhPp+lKPCR9oseitPFHvs9EbCjGSOjWFy8Xd0XO03G+5u8QG60dD9sc/X3r?= =?iso-8859-1?q?m2EpzhPfNbES2aBgoHvjrNNNcq70l98bcxkfQqN/mtD7ykO8wAnwH2epJmdw?= =?iso-8859-1?q?1bnIRm9nk/5QQYYGETyfH22boyS2G7hw31gCbkl4Popk8ggAc2UBLnwSJ4sP?= =?iso-8859-1?q?INk3wpVYCah44eqKbHFYnEKjYG+o6gJAPSXLxs7hX7iDVcJSjNdF2fH67XMB?= =?iso-8859-1?q?hn24cdRFAv02Yr5AQh9m2XGtEuY5oaNTdFeUZWD1kC883dLBs+vtDlL0lvvz?= =?iso-8859-1?q?PopEvoTVCPytcJYG+xbnsBeWQwvsiFJ6JzOp45i7ehzWd3mEP1HBYB/UjVwp?= =?iso-8859-1?q?NBlRfq83bnC+ZwK0U5r4UgS0Bbq7UaTYLr3Vz/66N6g0wURWG1cF84yJB8te?= =?iso-8859-1?q?zw0GAZuF3kYPSliBGvRwdSZzjvAJ80uRiRg1pbaSa/ix3w1+VvNEaH4v05oY?= =?iso-8859-1?q?+XliwIOaMZMCglaVaW/HDk3kpCX+ePCAG41AIvOLDTabZpouYPNS9iuHw8LO?= =?iso-8859-1?q?wI9MYdqy46yQccKFBKZ/3pLt1xKMP4TUBh3aCFNPlOD4D2R1lFLra26Ljd7g?= =?iso-8859-1?q?2OGqKsNpn7PQjoCpkXyGIWuaWiREI2D8vsum7AeMfvQ8EFbUH+ji0hwCPn2h?= =?iso-8859-1?q?fbrTlt4G++oMkmtrEZUwwaTNIJk9ODdM8RJuELzzyBiGRiyYxFTUQgAeIfvA?= =?iso-8859-1?q?h4O5CCzElgyLbS5EBkScKIm4X4UNDvZSmzf9+gfryc6nZV1/dTBywyx2xr1V?= =?iso-8859-1?q?X/lYck7M+JcbTH1IPqmlRL1/mo14s6HLS1vJvzb7vaonuzLpJ10xYSfsyEJQ?= =?iso-8859-1?q?6pe6pH962oknl3SQABIdYF84YiMrLV6weBcw6I71Du2mv+UpCSBv5f2EXOQv?= =?iso-8859-1?q?yMuLiwJnDBEzuCKJSJ+dmdXnlgP+oXqESlmfrqR1gq1Vi5diaKx82cH3bj48?= =?iso-8859-1?q?/SaQ7L/XBuwfp6jFbwLJb/cR0ZF2JwLxaHv3PCmm8ADrmDgh8OJvK3/xzzCD?= =?iso-8859-1?q?V4zwRxzXQ1ORCc+hqRG5MVdm27DZEWUGAkJsotPvyyMYOi72Vnxp0y7evLTA?= =?iso-8859-1?q?qcH2XQ1JA8eMh8CrYoLKKSffiGZxRAorwXfppxbcflagWALNM9qog3mwg/EK?= =?iso-8859-1?q?UqL2XBSZj01ClcATx8Ce4O2e8PQ6vFq2NsCdq+VKMUXFy1GcxPkTqb+YCnLr?= =?iso-8859-1?q?qBfbAeGPiXChHMPw4nch7L+wi1E8CgrFxZmz6gr32VsH70t7V+9zDMF33vcO?= =?iso-8859-1?q?RT49rdEMUOVKkyb/k?= MIME-Version: 1.0 X-OriginatorOrg: carallon.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CWXP265MB2693.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 1c1830e7-192f-47c0-0462-08dc7050534e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 17:49:07.6759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5677293e-6dd8-433d-8f8c-03a0fd233eed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0ilWnFD40DAA/3Fv8ucNSovNYnaLhlhRLT+0hSbyNWHhX7Pew+9VAGjgcjtaGej3UD7f8hzy3BP6XRFqRsv21TQNTpmmy/jmE4WVHHhHYkY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2188 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 09 May 2024 17:49:18 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/199181 Hi, I was just reading over the code, trying to figure out how the SDK/eSDK installer works, and the following stood out to me as a potential bug: meta/recipes-core/meta/uninative-tarball.bb uses `patchelf` to reserve 1024 bytes in the ELF interpreter section, but the check in meta/files/toolchain-shar-extract.sh is against paths 2048 bytes long. If I understand correctly, this is because the ELF patching is actually done by the python script scripts/relocate_sdk.py -- presumably because patchelf itself is compiled as a dynamically linked executable, so will refer to `/usr/local/oe-sdk/hardcoded-buildpath/lib/ld-linux*.so`. (I did quickly check, it seems possible to build patchelf statically but that then requires musl I believe.) Anyway, this just stood out to me as being wrong, but as it wasn't a bug I experienced, perhaps I misunderstood something. Robert Kovacsics (1):   sdk: Fix path length limit to match reserved size  meta/files/toolchain-shar-extract.sh        | 4 +++-  meta/recipes-core/meta/uninative-tarball.bb | 2 ++  2 files changed, 5 insertions(+), 1 deletion(-) From 395a3bc51bf0520a838d38ac31012106f19b134d Mon Sep 17 00:00:00 2001 From: Robert Kovacsics Date: Thu, 9 May 2024 14:28:17 +0100 Subject: [OE-core][PATCH 1/1] sdk: Fix path length limit to match reserved size --- meta/files/toolchain-shar-extract.sh | 4 +++- meta/recipes-core/meta/uninative-tarball.bb | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/meta/files/toolchain-shar-extract.sh b/meta/files/toolchain-shar-extract.sh index 4386b985bb..89d30005fd 100644 --- a/meta/files/toolchain-shar-extract.sh +++ b/meta/files/toolchain-shar-extract.sh @@ -164,7 +164,9 @@ else fi # limit the length for target_sdk_dir, ensure the relocation behaviour in relocate_sdk.py has right result. -if [ ${#target_sdk_dir} -gt 2048 ]; then +# This is due to ELF interpreter being set to 'a'*1024 in +# meta/recipes-core/meta/uninative-tarball.bb +if [ ${#target_sdk_dir} -gt 1024 ]; then echo "Error: The target directory path is too long!!!" exit 1 fi diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb index 7eebcaf11a..0fd01fdb64 100644 --- a/meta/recipes-core/meta/uninative-tarball.bb +++ b/meta/recipes-core/meta/uninative-tarball.bb @@ -58,6 +58,8 @@ fakeroot archive_sdk() { DEST="./${SDK_ARCH}-${SDK_OS}" mv sysroots/${SDK_SYS} $DEST rm sysroots -rf + # There is a check in meta/files/toolchain-shar-extract.sh -- make sure to + # keep that check up to date if changing the `1024` patchelf --set-interpreter ${@''.join('a' for n in range(1024))} $DEST/usr/bin/patchelf mv $DEST/usr/bin/patchelf $DEST/usr/bin/patchelf-uninative ${SDK_ARCHIVE_CMD} -- 2.44.0