From patchwork Fri Jun 27 07:51:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: falk bauer X-Patchwork-Id: 65713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553FDC7EE31 for ; Fri, 27 Jun 2025 07:51:55 +0000 (UTC) Subject: [PATCH] psplash: Do not mount PSPLASH_FIFO_DIR if the env variable is empty To: openembedded-core@lists.openembedded.org From: "falk bauer" X-Originating-Location: =?utf-8?q?D=C3=BCsseldorf=2C_North_Rhine-Westphalia?= =?utf-8?q?=2C_DE?= (80.152.229.14) X-Originating-Platform: Windows Firefox 140 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 27 Jun 2025 00:51:48 -0700 Message-ID: <9iJV.1751010708138628343.0XBD@lists.openembedded.org> List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 27 Jun 2025 07:51:55 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/219390 The script file psplash.sh tries to mount the PSPLASH_FIFO_DIR variable. If the variable is empty, the mountpoint command returns a usage text (busybox mountpoint here, util-linux mountpoint behaves the same): BusyBox v1.37.0 () multi-call binary. Usage: mountpoint [-q] { [-dn] DIR | -x DEVICE } :~# BusyBox v1.37.0 () multi-call binary The return code with this console output is 0 and the mount command in the if statement is executed. Then this mount also fails with an empty mountpoint argument. The source code of psplash respects an empty PSPLASH_FIFO_DIR variable (see psplash.c) and makes a fallback to "/run". So the psplash.sh script should also respect the empty var. Try to mount the PSPLASH_FIFO_DIR only if the variable is not empty. Signed-off-by: Falk Bauer --- meta/recipes-core/psplash/files/psplash-init | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/meta/recipes-core/psplash/files/psplash-init b/meta/recipes-core/psplash/files/psplash-init index e0f80bcdc03..6b7f38e3efe 100644 --- a/meta/recipes-core/psplash/files/psplash-init +++ b/meta/recipes-core/psplash/files/psplash-init @@ -26,9 +26,11 @@ for x in $CMDLINE; do esac done -[ -d $PSPLASH_FIFO_DIR ] || mkdir -p $PSPLASH_FIFO_DIR -if ! mountpoint -q $PSPLASH_FIFO_DIR; then -    mount tmpfs -t tmpfs $PSPLASH_FIFO_DIR -o,size=40k +if [ - n "${PSPLASH_FIFO_DIR}" ]; then +        [ -d $PSPLASH_FIFO_DIR ] || mkdir -p $PSPLASH_FIFO_DIR +        if ! mountpoint -q $PSPLASH_FIFO_DIR ; then +                mount tmpfs -t tmpfs $PSPLASH_FIFO_DIR -o,size=40k +        fi fi rotation=0