From patchwork Tue Mar 21 14:20:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21476 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BE3C761AF for ; Tue, 21 Mar 2023 14:20:57 +0000 (UTC) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mx.groups.io with SMTP id smtpd.web11.14403.1679408451442342813 for ; Tue, 21 Mar 2023 07:20:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=Lgv/n+Ss; spf=softfail (domain: sakoman.com, ip: 209.85.216.50, mailfrom: steve@sakoman.com) Received: by mail-pj1-f50.google.com with SMTP id mp3-20020a17090b190300b0023fcc8ce113so5428313pjb.4 for ; Tue, 21 Mar 2023 07:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679408450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=irsJSZN84HJ/+SSiS2yNY7zSr7GAT5mVknrN069NC4o=; b=Lgv/n+SsFTAVX2vYDxYaA0QyprcvA9yrcqBFMLRFJs+m4XvEctf2c1dAzNpYsiWutC k2+vu5/GYkC8VqBEyvOXJyrkjYVDSS0WNMd+AEA6mEyq4CbYgp5bqxqIZfvi0WPIU+N+ mpNgZAL5ivpduEKAeeOhyvH7YsBY6U9uT2MW0o84RQlc7UOO5MVS1QO8an/xXVwM3oZG ak6J/em2HvN+c8U4dkQhQszduTorTECrvQDf6bTf42jmJdDDoNRafNectOVb7JdW6/5l tTnoMJ3phEdkrA10CoV54rcodWB8qzJ/qmzO5kVakUO/HHUAqFJP7mWTz4F0DCugVVah 3W7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679408450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=irsJSZN84HJ/+SSiS2yNY7zSr7GAT5mVknrN069NC4o=; b=xwwpccUV1TBO3v531yZzOk22NQsG+GZmrYIbk/u5lArZMZBURseXzDhl4rKckJr2ku B3D5ADoZQJ7G14EzNauVeibhLILV/2jATAy85zqak4hnlxe/g3Rjsa8VbeXvosXg5xhe 2uUBix0FNlailkhShwQ+T9RG7zOz3ZxKdf2TAMFiputuHeUY57vAab3341jrnMDMGc4p mk36YjMNmBtRo8+Jvymiq1ibi0zXa63j65i1Y0fVUfBwdzQQ2slwuKNhD8nQi/AezIXv lrBU4tecpx4bb3xXVm32uQCK3loDrqxPbvA5fV1F+i9nHU1zDmExT/CNQUjD/XFgXw1Z Ulkg== X-Gm-Message-State: AO0yUKXtpSiy2mKgz8sZ2v50BHRnvLzlHQAjT842e4sUiOxC6QjLKaxh sylzFbAJ/40rOdfRF/rMGlAcRo+GHWXZYWlWoyU= X-Google-Smtp-Source: AK7set/lwn4bsXmGNYpk8tJQWO3OecGJK9FJn9wjQYMFU4Szus4ZATOBDCt9KyyU9p+vgsY836h3PA== X-Received: by 2002:a05:6a20:dc9e:b0:d9:e367:edd1 with SMTP id ky30-20020a056a20dc9e00b000d9e367edd1mr3423371pzb.15.1679408450558; Tue, 21 Mar 2023 07:20:50 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id g11-20020aa7818b000000b005892ea4f092sm8551291pfi.95.2023.03.21.07.20.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:20:50 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][dunfell 11/14] buildtools-tarball: Handle spaces within user $PATH Date: Tue, 21 Mar 2023 04:20:16 -1000 Message-Id: <9ececa2c36eff7c954d92e9d13a2fe8c1fae9bd2.1679408291.git.steve@sakoman.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Mar 2023 14:20:57 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178882 From: Kenfe-Mickael Laventure The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 2d4c032bf3187aaa953a0c33a999074e695f54bb) Signed-off-by: Steve Sakoman --- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb index faf7108a86..24f5f28589 100644 --- a/meta/recipes-core/meta/buildtools-tarball.bb +++ b/meta/recipes-core/meta/buildtools-tarball.bb @@ -66,7 +66,7 @@ create_sdk_files_append () { # Generate new (mini) sdk-environment-setup file script=${1:-${SDK_OUTPUT}/${SDKPATH}/environment-setup-${SDK_SYS}} touch $script - echo 'export PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH' >> $script + echo 'export PATH="${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH"' >> $script echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script echo 'export SSL_CERT_FILE="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script