From patchwork Thu Mar 16 21:45:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49ACFC7618A for ; Thu, 16 Mar 2023 21:46:14 +0000 (UTC) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx.groups.io with SMTP id smtpd.web10.5150.1679003151092139877 for ; Thu, 16 Mar 2023 14:46:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=l7jgT+Gg; spf=softfail (domain: sakoman.com, ip: 209.85.216.54, mailfrom: steve@sakoman.com) Received: by mail-pj1-f54.google.com with SMTP id o6-20020a17090a9f8600b0023f32869993so2965653pjp.1 for ; Thu, 16 Mar 2023 14:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679003165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wV9nsdqv4vF78cAsAi0v5FJ6gUYs74nL3pSE4EThi4k=; b=l7jgT+GgGgJ9tmFjkrezpInx6ccBnpx7mWcUJ9rmvbb6uprG0N1h8Chfc6T/pCcUq8 JEB5Kae48BnDXJ9XfiQZpwLCr24j/k5IKTYKvSnGblvQb/is1bLT5IyFNzMqxEJFY0tY 3gkS7OMkiqkueZP+u2wFOTGfkI/Qd4KfYhBCpuHd8mk3z1O/S4EmnZbK43sRaB14FtLV 3tsXdFrzW5c/TZrv9LZRMXSl8Y/d0BJ9G6HQo2e3J7n4vUtfGRmZw1GV7lxgqexTt4Jf W7+/bSfWbLtSt95y4Nd54hpyV10UPOe7jve1Ghcem/wbXMAKLHSUuEX/VPn+8iA6PmjN RdDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679003165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wV9nsdqv4vF78cAsAi0v5FJ6gUYs74nL3pSE4EThi4k=; b=HeHJ7Vk9guWq6EUMqpvyE4rlXoiV+4IWrxPUSf9niuaPUUAHKLUKcMpkdKogT5ptt+ louOJ7YpEEvycZ0XhUhE6RGGjCnQxO+pXF/Z6NNpcncdH+nxaViIdZVUDg5Jrq/n+Vi7 B+p6FwX9v29zK258Dw6fDodqKS5bPEhv1AFv+ukGBW0pS8UBJ4V7YmAoJvOIzv/leVoB 0cPgD4lUyxjM3F5KPj/HQOeMPFCySw8K3ZBbfGfnJbH4ekl4MFpbeZTib09k7e5jx73W RJ+wGFvwavXH2Nyhe2ylm6W/bSbVzUDj0HdsSNEB4GCMeS4wYyXSgnipyDau/s9hs3n0 XP9w== X-Gm-Message-State: AO0yUKXlMkk6nIsF52ziZqhqGKuMzFx7ibmR7lE0bWFsC1U20ERfjjDj BXu3lVPUBLTcbLenK94TQ45eCq8NH5tgrrhtuOQ= X-Google-Smtp-Source: AK7set/bdVAGJFpRE+ZAO965DFfD9bX6CO36iWFZgc+KuQFeGlxbWIAf9wDalopUMxQHS4mlxSgJ9Q== X-Received: by 2002:a05:6a20:12cd:b0:d4:d0f5:d403 with SMTP id v13-20020a056a2012cd00b000d4d0f5d403mr6439774pzg.29.1679003164721; Thu, 16 Mar 2023 14:46:04 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id bn10-20020a056a00324a00b005a84ef49c63sm137746pfb.214.2023.03.16.14.46.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 14:46:04 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][langdale 21/23] populate_sdk_ext: Handle spaces within user $PATH Date: Thu, 16 Mar 2023 11:45:18 -1000 Message-Id: <679835b6f692d7e344c115da72ddf4553657ac54.1679003014.git.steve@sakoman.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 16 Mar 2023 21:46:14 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178732 From: Kenfe-Mickael Laventure The script generated by the sdk_ext_postinst function was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 00e96bf250eaaded839caf465dbc0af5b604aed7) Signed-off-by: Steve Sakoman --- meta/classes-recipe/populate_sdk_ext.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-recipe/populate_sdk_ext.bbclass b/meta/classes-recipe/populate_sdk_ext.bbclass index 80f4f0be05..1b47fbe770 100644 --- a/meta/classes-recipe/populate_sdk_ext.bbclass +++ b/meta/classes-recipe/populate_sdk_ext.bbclass @@ -720,7 +720,7 @@ sdk_ext_postinst() { # A bit of another hack, but we need this in the path only for devtool # so put it at the end of $PATH. - echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $env_setup_script + echo "export PATH=\"$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH\"" >> $env_setup_script echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script